isolator 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1c367300194152c4e2d8adb2c9ff4ab37cc66f9e1eab3e5a1d1576b98fb4970b
-  data.tar.gz: c132274cc0936d897f2ecfda8d4c1523db73d5a803f5516ed8eb655fda9f9586
+  metadata.gz: 05b72beb85efc1ddfeb64209365e3b2326e346cce686a614349088a05406b2b7
+  data.tar.gz: 8679de3ba5f24b833054ee47a0515a8ce340fbb57880d6bf00dfa9d47ad57718
 SHA512:
-  metadata.gz: 8eb94aeb576bb42fe9b267403cde9d6418964db34c111ca23e5a8f415fc85aa936eab2da5647eec2878526e0d5998a6b40e09c68fd55afa5ef5648bb8f66ba12
-  data.tar.gz: 6285571a44a18c0d21816d48c7580f1a9a0167fedae5db5d5ff757f1485561bef15798f6781e7b7347fe0d87105931a0fd42560abb6b52f1e3fdb223d58785be
+  metadata.gz: 20351d43476587b537082c2e0f83a01813ec9f8f57971eedd5251bc27723b276cfe8b6c5e4c930169e309fe0144f117684393b1faabae29a890af6f482cd2224
+  data.tar.gz: 8f6ed452926f6f5e955537a5de95b2a67569153ab54a79ccb20b98fb37a775e0398f7e8be285dd39ab31750548271921047b4afd417b254a8bbfa0f600be84a4

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## master
 
+## 1.2.1 (2026-07-16)
+
+- Fix handling "finish" events for untracked (lazy) transactions. ([@sawirricardo][])
+
 ## 1.2.0 (2025-11-07)
 
 - Use `ActiveRecord::Base.lease_connection` instead of `ActiveRecord::Base.connection`, if available. ([@viralpraxis][])
@@ -170,3 +174,4 @@ This, for example, makes Isolator compatible with Rails multi-database apps.
 [@arthurWD]: https://github.com/arthurWD
 [@joshuay03]: https://github.com/joshuay03
 [@viralpraxis]: https://github.com/viralpraxis
+[@sawirricardo]: https://github.com/sawirricardo

data/README.md

@@ -335,6 +335,22 @@ The reason is that Rails started using a [separate connection pool for advisory
 
 To fix this disable migrations advisory locks by adding `advisory_locks: false` to your database configuration in `(spec|test)/internal/config/database.yml`.
 
+## ActionMailer jobs
+
+Rails 7.2 added support for the `enqueue_after_transaction_commit` configuration option, which ensures that jobs are enqueued only after all transactions have been committed. One gotcha that may lead to Isolator offenses is that `ActionMailer::MailDeliveryJob` inherits directly from `ActiveJob::Base`, rather than from your application’s top-level `ApplicationJob`.
+
+To fix this, make sure `enqueue_after_transaction_commit` is set to true on `ActiveJob::Base`, or use the global `config.active_job.enqueue_after_transaction_commit setting` if your Rails version supports it.
+
+See https://github.com/palkan/isolator/issues/93 for details.
+
+## Occasional test failures related to connection reaping
+
+In some cases, connections may be reaped and replaced mid-test, which will most likely lead to test failures because Isolator currently does not track this situation.
+
+One way to mitigate this issue is to disable ActiveRecord's connection pool reaping by setting `reaping_frequency` to `nil`.
+
+See https://github.com/palkan/isolator/issues/83 for details.
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/palkan/isolator.

data/lib/isolator/orm_adapters/active_support_transaction_subscriber.rb

@@ -13,16 +13,17 @@ module Isolator
       def start(event, id, payload)
         if event.start_with?("transaction.")
           connection_id = extract_transaction_connection_id(payload)
+          stack = stacks[connection_id]
 
           # transaction.active_record can be issued without a query (when we restart the transaction),
           # so we should add a new one on the stack.
           # Example: https://github.com/rails/rails/blob/ce49fa9b31cd4a21d43db39d0cea364bce28b51d/activerecord/lib/active_record/connection_adapters/abstract/transaction.rb#L337
-          if stacks[connection_id].last == :raw
+          if stack.last == :raw
             # Update the type of the last transaction event
-            stacks[connection_id].pop
-            stacks[connection_id] << :transaction
+            stack.pop
+            stack << :transaction
           else
-            stacks[connection_id] << :transaction
+            stack << :transaction
             Isolator.incr_transactions!(connection_id)
           end
         end
@@ -32,19 +33,23 @@ module Isolator
         if event.start_with?("sql.")
           if start_event?(payload[:sql])
             connection_id = extract_connection_id(payload)
+            stack = stacks[connection_id]
 
-            stacks[connection_id] << :raw
+            stack << :raw
 
             Isolator.incr_transactions!(connection_id)
           end
 
           if finish_event?(payload[:sql])
             connection_id = extract_connection_id(payload)
+            stack = stacks[connection_id]
 
             # Decrement only if the transaction was started in the raw mode,
             # otherwise we should wait for the "transaction" event
-            if stacks[connection_id].last == :raw
-              stacks[connection_id].pop
+            if stack.last == :raw
+              stack.pop
+              stacks.delete(connection_id) if stack.empty?
+
               Isolator.decr_transactions!(connection_id)
             end
           end
@@ -52,9 +57,14 @@ module Isolator
 
         if event.start_with?("transaction.")
           connection_id = extract_transaction_connection_id(payload)
-          stacks[connection_id].pop
+          stack = stacks[connection_id]
+
+          if stack.last == :transaction
+            stack.pop
+            stacks.delete(connection_id) if stack.empty?
 
-          Isolator.decr_transactions!(connection_id)
+            Isolator.decr_transactions!(connection_id)
+          end
         end
       end
 

data/lib/isolator/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Isolator
-  VERSION = "1.2.0"
+  VERSION = "1.2.1"
 end

data/lib/isolator.rb

@@ -120,7 +120,7 @@ module Isolator
 
     def decr_thresholds!
       self.default_threshold -= 1
-      debug!("Thresholds were incremented")
+      debug!("Thresholds were decremented")
 
       return unless state[:thresholds]
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: isolator
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Vladimir Dementyev
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-11-07 00:00:00.000000000 Z
+date: 2026-07-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sniffer