isolator 0.7.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 00d85d8a62a5a34bd39ef9295e1e8ad9c13599fc17648bbda7a5012f9a89ddfa
-  data.tar.gz: cf7a441154f63bc40258b4a78e57e3d3f46158b915167c1631d717530571dcd2
+  metadata.gz: 5c40700b0b2f7e5025ed7cbfb80580ac9ee1516a1295146bf0fa9db1de6e2a7f
+  data.tar.gz: 7d605d3790733c0b1bcd44e6188c30050900879042ef604950cc38b36d6214d0
 SHA512:
-  metadata.gz: a088b0f2e24c8afd8a2ec3fd65df4ef5e2d550f55c8376132955db8f870f68a28f021b8079024b413ef2692a474136f3d7da56c098a89d2e3b3aa52deb0ce334
-  data.tar.gz: d3667e26d54697e09eaefd7cdee7e9c5586e307c371ce41215d8eca88dc514c652079088bba2af3aeb654b9bfbdad3a3ab6080c5f20b47867291cf4734f16cda
+  metadata.gz: d3a05d4ccad1f80171a67f0f124cb2d37548803a5451338cb9d821c16042dc94c407f9a4a155597742268cbf8ee939594a166c49835f35f5f4d2ec4d1d9a0567
+  data.tar.gz: a287d291ca6465f3c8acfc8cb8c1c5ba898315c6aae80156855153d13a3c7c763864d97127ef38b04331bb7c99b23b417783eada86afdf8c26282c694dfe22bd

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## master
 
+## 0.8.0 (2021-12-29)
+
+- Drop Ruby 2.5 support.
+
+- Add .isolator_ignore.yml configuration file for Rails application.
+
 ## 0.7.0 (2020-09-25)
 
 - Add debug mode. ([@palkan][])

data/README.md

@@ -104,7 +104,7 @@ Isolator.configure do |config|
 end
 ```
 
-Isolator relys on [uniform_notifier][] to send custom notifications.
+Isolator relies on [uniform_notifier][] to send custom notifications.
 
 **NOTE:** `uniform_notifier` should be installed separately (i.e., added to Gemfile).
 
@@ -115,13 +115,13 @@ Isolator relys on [uniform_notifier][] to send custom notifications.
 
 ### Supported ORMs
 
-- `ActiveRecord` >= 4.1
+- `ActiveRecord` >= 5.1 (4.2 likely till works, but we do not test against it anymore)
 - `ROM::SQL` (only if Active Support instrumentation extension is loaded)
 
 ### Adapters
 
 Isolator has a bunch of built-in adapters:
-- `:http` – built on top of [Sniffer][]
+- `:http` – built on top of [Sniffer][]
 - `:active_job`
 - `:sidekiq`
 - `:resque`
@@ -161,7 +161,7 @@ You can add as many _ignores_ as you want, the offense is registered iff all of
 
 ### Using with legacy Rails codebases
 
-If you already have a huge Rails project it can be a tricky to turn Isolator on because you'll immediately get a lot of failed specs. If you want to fix detected issues one by one, you can list all of them in the special file `.isolator_todo.yml` in a following way:
+If you already have a huge Rails project it can be tricky to turn Isolator on because you'll immediately get a lot of failed specs. If you want to fix detected issues one by one, you can list all of them in the special files `.isolator_todo.yml` and `.isolator_ignore.yml` in the following way:
 
 ```
 sidekiq:
@@ -171,6 +171,8 @@ sidekiq:
 
 All the exceptions raised in the listed lines will be ignored.
 
+The `.isolator_todo.yml` file is intended to point to the code that should be fixed later, and `.isolator_ignore.yml` points to the code that for some reasons is not expected to be fixed. (See https://github.com/palkan/isolator/issues/40)
+
 ### Using with legacy Ruby codebases
 
 If you are not using Rails, you'll have to load ignores from file manually, using `Isolator::Ignorer.prepare(path:)`, for instance `Isolator::Ignorer.prepare(path: "./config/.isolator_todo.yml")`
@@ -196,7 +198,7 @@ Isolator.isolate :danger, Danger.singleton_class, :explode, options
 Possible `options` are:
 - `exception_class` – an exception class to raise in case of offense
 - `exception_message` – custom exception message (could be specified without a class)
-- `details_message` – a block to generate additional exceptin message information:
+- `details_message` – a block to generate additional exception message information:
 
 ```ruby
 Isolator.isolate :active_job,

data/lib/isolator/configuration.rb

@@ -28,8 +28,8 @@ module Isolator
       @ignorer = Isolator::Ignorer
     end
 
-    alias raise_exceptions? raise_exceptions
-    alias send_notifications? send_notifications
+    alias_method :raise_exceptions?, :raise_exceptions
+    alias_method :send_notifications?, :send_notifications
 
     def test_env?
       ENV["RACK_ENV"] == "test" || ENV["RAILS_ENV"] == "test"

data/lib/isolator/railtie.rb

@@ -16,6 +16,7 @@ module Isolator
       load File.join(__dir__, "adapters.rb")
 
       Isolator.config.ignorer&.prepare
+      Isolator.config.ignorer&.prepare(path: ".isolator_ignore.yml")
 
       next unless Rails.env.test?
 

data/lib/isolator/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Isolator
-  VERSION = "0.7.0"
+  VERSION = "0.8.0"
 end

data/lib/isolator.rb

@@ -135,6 +135,13 @@ module Isolator
     end
 
     def decr_transactions!(connection_id = default_connection_id.call)
+      current = state[:transactions]&.[](connection_id) || 0
+
+      if current <= 0
+        warn "Trying to finalize an untracked transaction"
+        return
+      end
+
       state[:transactions][connection_id] -= 1
 
       finish! if current_transactions(connection_id) == (connection_threshold(connection_id) - 1)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: isolator
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Vladimir Dementyev
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-09-25 00:00:00.000000000 Z
+date: 2021-12-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sniffer
@@ -248,6 +248,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: webrick
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: net-smtp
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Detect non-atomic interactions within DB transactions
 email:
 - dementiev.vm@gmail.com
@@ -298,7 +326,7 @@ metadata:
   documentation_uri: http://github.com/palkan/isolator
   homepage_uri: http://github.com/palkan/isolator
   source_code_uri: http://github.com/palkan/isolator
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -306,15 +334,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.5.0
+      version: 2.6.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
-signing_key: 
+rubygems_version: 3.2.22
+signing_key:
 specification_version: 4
 summary: Detect non-atomic interactions within DB transactions
 test_files: []