iso8583 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 0881d56e13a87bfba361adb50daa0a22b61f2e02
-  data.tar.gz: 8334f84528ecbad4c5481068706326f6fa7489ed
+SHA256:
+  metadata.gz: 4c551d563390f55d323d8aea190eb31b20dcc98f786a9f872faa5df24fd229d1
+  data.tar.gz: c448bfe8446285da07c61ac8b5cfbb908477cf98a9e1bf703cfdae47d17cb2c9
 SHA512:
-  metadata.gz: 8d259cbf42c0f4abde3af3622aa8792bbe89c6926628cc4adb091c8baf89023e2d1782f386ef1f001288743e60a29ac37db323b692ca58d1fd2bda2a6106da03
-  data.tar.gz: e242b86a519584d7f9a0e6252b0691cb05f6bd2de8606564ad037615b8ba88906da8e23309bfd4b6696fad0fc13f6d41157cbb1698b69b47095387cf69896594
+  metadata.gz: 1fe629ddc4d985d96b63d20e6bacfb7e9c7d7cbe429232a9dcb8f5e972f9be5e0263bb675e11d78e272de4a3c58d0ced9a7a8b2646e2f94d64d0aea8b632f66c
+  data.tar.gz: 05bb98f645a560bf44bc2b64884a301b0869f7df1b7694291c82d991abe21538df5b8a08d57ab716e8e30482770e9db8dc6f49146de2ba36aa9640e355265329

data/AUTHORS

@@ -5,3 +5,5 @@ Lasse Skindstad Ebert (https://github.com/lasseebert)
 Joel Ibaceta (https://github.com/joelibaceta)
 Jackson Harper <jackson@juvo.com>
 absrd (https://github.com/absrd)
+Nicolas Leger (https://github.com/nicolasleger)
+Jérémie Bonal (https://github.com/Aquaj)

data/CHANGELOG

@@ -1,3 +1,8 @@
+0.2.4
+=========
+  better errors for missing bitmap
+  cleanup warnings
+
 0.2.3
 =========
   Change Fixnum to Integer as Fixnum is deprecated

data/Rakefile

@@ -84,7 +84,6 @@ spec = Gem::Specification.new do |s|
   s.requirements << "none"
   s.require_path = "lib"
   s.description = LONG_DESC
-  s.has_rdoc = true
   s.authors = ["Tim Becker", "Slava Kravchenko"]
   s.email = ["tim.becker@kuriositaet.de","cordawyn@gmail.com"]
   s.homepage = "http://github.com/a2800276/8583/"
@@ -125,7 +124,7 @@ end
 Rake::TestTask.new do |t|
   t.libs << "test"
   t.libs << "."
-  t.ruby_opts = ["-rubygems"]
+  t.ruby_opts = ["-rrubygems"]
   t.test_files = FileList["test/*.rb"]
   t.verbose = true
 end

data/lib/iso8583/berlin.rb

@@ -72,7 +72,7 @@ if __FILE__==$0
   mes[2] = 474747474747
   mes["Processing Code"] = "123456"
 
-  pan = mes["Primary Account Number (PAN)"]
+  #pan = mes["Primary Account Number (PAN)"]
   #mes.pan = 47474747474747
 
   #puts mes.pan

data/lib/iso8583/codec.rb

@@ -113,7 +113,7 @@ module ISO8583
     [val].pack("H*")
   }
   Packed_Number.decoder = lambda{|encoded|
-    d = encoded.unpack("H*")[0].to_i
+    encoded.unpack("H*")[0].to_i
   }
 
   A_Codec = Codec.new

data/lib/iso8583/fields.rb

@@ -57,63 +57,75 @@ module ISO8583
   }
 
   LL_BCD        = BCDField.new
+  LL_BCD.name   = "LL_BCD"
   LL_BCD.length = 2
   LL_BCD.codec  = Packed_Number
 
   # Two byte variable length ASCII numeral, payload ASCII numerals
   LLVAR_N        = Field.new
+  LLVAR_N.name   = "LLVAR_N"
   LLVAR_N.length = LL
   LLVAR_N.codec  = ASCII_Number
 
   # Three byte variable length ASCII numeral, payload ASCII numerals
   LLLVAR_N        = Field.new
+  LLLVAR_N.name   = "LLLVAR_N"
   LLLVAR_N.length = LLL
   LLLVAR_N.codec  = ASCII_Number
 
   # Two byte variable length ASCII numeral, payload Track2 data
   LLVAR_Z         = Field.new
+  LLVAR_Z.name    = "LLVAR_Z"
   LLVAR_Z.length  = LL
   LLVAR_Z.codec   = Track2
 
   # Two byte variable length ASCII numeral, payload ASCII, fixed length, zeropadded (right)
   LLVAR_AN        = Field.new
+  LLVAR_AN.name   = "LLVAR_AN"
   LLVAR_AN.length = LL
   LLVAR_AN.codec  = AN_Codec
 
   # Two byte variable length ASCII numeral, payload ASCII+special
   LLVAR_ANS        = Field.new
+  LLVAR_ANS.name   = "LLVAR_ANS"
   LLVAR_ANS.length = LL
   LLVAR_ANS.codec  = ANS_Codec
 
   # Three byte variable length ASCII numeral, payload ASCII, fixed length, zeropadded (right)
   LLLVAR_AN        = Field.new
+  LLLVAR_AN.name   = "LLLVAR_AN"
   LLLVAR_AN.length = LLL
   LLLVAR_AN.codec  = AN_Codec
 
   # Three byte variable length ASCII numeral, payload ASCII+special
   LLLVAR_ANS        = Field.new
+  LLLVAR_ANS.name   = "LLLVAR_ANS"
   LLLVAR_ANS.length = LLL
   LLLVAR_ANS.codec  = ANS_Codec
 
   # Two byte variable length binary payload
   LLVAR_B        = Field.new
+  LLVAR_B.name   = "LLVAR_B"
   LLVAR_B.length = LL
   LLVAR_B.codec  = Null_Codec
 
 
   # Three byte variable length binary payload
   LLLVAR_B        = Field.new
+  LLLVAR_B.name   = "LLLVAR_B"
   LLLVAR_B.length = LLL
   LLLVAR_B.codec  = Null_Codec
 
   # Fixed lengh numerals, repesented in ASCII, padding right justified using zeros
   N = Field.new
+  N.name  = "N"
   N.codec = ASCII_Number
   N.padding = lambda {|val, len|
     sprintf("%0#{len}d", val)
   }
 
   N_BCD = BCDField.new
+  N_BCD.name  = "N_BCD"
   N_BCD.codec = Packed_Number
 
   PADDING_LEFT_JUSTIFIED_SPACES = lambda {|val, len|
@@ -122,25 +134,30 @@ module ISO8583
 
   # Fixed length ASCII letters [A-Za-z]
   A = Field.new
+  A.name  = "A"
   A.codec = A_Codec
 
   # Fixed lengh ASCII [A-Za-z0-9], padding left justified using spaces.
   AN = Field.new
+  AN.name  = "AN"
   AN.codec = AN_Codec
   AN.padding = PADDING_LEFT_JUSTIFIED_SPACES
 
   # Fixed lengh ASCII [A-Za-z0-9] and space, padding left, spaces
   ANP = Field.new
+  ANP.name  = "ANP"
   ANP.codec = ANP_Codec
   ANP.padding = PADDING_LEFT_JUSTIFIED_SPACES
 
   # Fixed length ASCII  [\x20-\x7E], padding left, spaces
   ANS = Field.new
+  ANS.name = ANS
   ANS.codec = ANS_Codec
   ANS.padding = PADDING_LEFT_JUSTIFIED_SPACES
 
   # Binary data, padding left using nulls (0x00)
   B = Field.new
+  B.name  = "B"
   B.codec = Null_Codec
   B.padding = lambda {|val, len|
     while val.length < len
@@ -151,24 +168,29 @@ module ISO8583
 
   # Date, formatted as described in ASCII numerals
   MMDDhhmmss        = Field.new
+  MMDDhhmmss.name   = "MMDDhhmmss"
   MMDDhhmmss.codec  = MMDDhhmmssCodec
   MMDDhhmmss.length = 10
 
   #Date, formatted as described in ASCII numerals
   YYMMDDhhmmss        = Field.new
+  YYMMDDhhmmss.name   = "YYMMDDhhmmss"
   YYMMDDhhmmss.codec  = YYMMDDhhmmssCodec
   YYMMDDhhmmss.length = 12
 
   #Date, formatted as described in ASCII numerals
   YYMM        = Field.new
+  YYMM.name   = "YYMM"
   YYMM.codec  = YYMMCodec
   YYMM.length = 4
   
   MMDD        = Field.new
+  MMDD.name   = "MMDD"
   MMDD.codec  = MMDDCodec
   MMDD.length = 4
 
   Hhmmss        = Field.new
+  Hhmmss.name   = "Hhmmss"
   Hhmmss.codec  = HhmmssCodec
   Hhmmss.length = 6
 

data/lib/iso8583/message.rb

@@ -135,7 +135,7 @@ module ISO8583
     #    mes = MyMessage.new
     #    mes.mti = 1100 # or mes.mti = "Authorization Request Acquirer Gateway"
     def mti=(value)
-      num, name = _get_mti_definition(value)
+      num, _ = _get_mti_definition(value)
       @mti = num
     end
     
@@ -343,15 +343,19 @@ module ISO8583
           # @values[bmp] = bmp_def
         }
       end
-      
+
       # Parse the bytes `str` returning a message of the defined type.
+      #
+      # returns an instance of Message
+      #
+      # will raise an ISO8583Exception if the bitmap definition can't be found
       def parse(str)
         str = str.force_encoding('ASCII-8BIT')
         message = self.new
         message.mti, rest = _mti_format.parse(str)
         bmp,rest = Bitmap.parse(rest)
         bmp.each {|bit|
-          bmp_def      = _definitions[bit]
+          bmp_def      = message._get_definition(bit)
           value, rest  = bmp_def.field.parse(rest)
           message[bit] = value
         }

data/lib/iso8583/version.rb

@@ -1,4 +1,4 @@
 # -*- mode: ruby; encoding: utf-8; tab-width: 2; indent-tabs-mode: nil -*-
 module ISO8583
-  VERSION = "0.2.3"
+  VERSION = "0.2.4"
 end

data/test/BitmapTests.rb

@@ -22,14 +22,14 @@ class BitmapTests < Test::Unit::TestCase
 
     assert_raises(ISO8583Exception) {b.set 1000 }
     assert_raises(ISO8583Exception) {	b.set 1 }
-    assert_raises(ISO8583Exception) {	b.set -1 }
+    assert_raises(ISO8583Exception) {	b.set(-1) }
   end
 
   def test_out_of_bounds_errors
     b = Bitmap.new
     assert_raises(ISO8583Exception) {b.set 1000 }
     assert_raises(ISO8583Exception) {	b.set 1 }
-    assert_raises(ISO8583Exception) {	b.set -1 }
+    assert_raises(ISO8583Exception) {	b.set(-1) }
   end
 
   def test_parse_bmp
@@ -82,7 +82,7 @@ class BitmapTests < Test::Unit::TestCase
     tst = "\x80\x00\x10\x20\x40\x81\x02\x04\x08\x10\x20\x40\x81\x02\x04\x08"
     bmp = Bitmap.new tst
     arr = []
-    first = bmp.each{|bit|
+    bmp.each{|bit|
       arr.push bit
     }
     assert_equal 20, arr.first

data/test/message_test.rb

@@ -38,18 +38,25 @@ class MessageTest < Test::Unit::TestCase
     pan = 474747474747
 
     assert_raises(ISO8583Exception) {
-      mes = BerlinMessage.parse "@\000\000\000\000\000\000\00012474747474747"
+      BerlinMessage.parse "@\000\000\000\000\000\000\00012474747474747"
     }
     mes = BerlinMessage.parse "1430@\000\000\000\000\000\000\00012474747474747"
     assert_equal pan, mes.pan
     assert_equal 1430, mes.mti
   end
 
+  def test_unknown_field
+    assert_raises(ISO8583Exception.new("no definition for field: 8")) {
+      mes = BerlinMessage.parse "1430A\000\000\000\000\000\000\00012474747474747"
+    }
+  end
+
   def test_rescue_standard_error
     rescued = false
     begin
       BerlinMessage.parse("bogus")
     rescue => error
+      assert_instance_of ISO8583Exception, error
       rescued = true
     end
 
@@ -168,8 +175,8 @@ END
     mes[64] = "\xF0\xF0\xF0\xF0"
 
     bytes = mes.to_b
-    mes2 = BerlinMessage.parse(mes.to_b)
-    assert_equal(mes.to_b, mes2.to_b)
+    mes2 = BerlinMessage.parse(bytes)
+    assert_equal(bytes, mes2.to_b)
   end
 
   def test_remove_field

data/test/test_codec.rb

@@ -101,7 +101,7 @@ class FieldTest < Test::Unit::TestCase
   end
   def test_A_Codec
     assert_raise(ISO8583Exception) {
-      dt = A_Codec.encode "!!!"
+      A_Codec.encode "!!!"
     }
     assert_equal "bla", AN_Codec.encode("bla")
     assert_equal "bla", AN_Codec.decode("bla")
@@ -109,7 +109,7 @@ class FieldTest < Test::Unit::TestCase
 
   def test_AN_Codec
     assert_raise(ISO8583Exception) {
-      dt = AN_Codec.encode "!!!"
+      AN_Codec.encode "!!!"
     }
     assert_equal "bla", AN_Codec.encode("bla")
     assert_equal "bla", AN_Codec.decode("bla")
@@ -117,10 +117,10 @@ class FieldTest < Test::Unit::TestCase
 
   def test_Track2_Codec
     assert_raise(ISO8583Exception) {
-      dt = Track2.encode "!!!"
+      Track2.encode "!!!"
     }
     assert_raise(ISO8583Exception) {
-      dt = Track2.encode ";12312312=123?5"
+      Track2.encode ";12312312=123?5"
     }
     assert_equal ";123123123=123?5", Track2.encode(";123123123=123?5")
     assert_equal ";123123123=123?5", Track2.decode(";123123123=123?5")
@@ -133,10 +133,10 @@ class FieldTest < Test::Unit::TestCase
     assert_equal "\x02", Packed_Number.encode(2)
     assert_equal "\x02\x55", Packed_Number.encode(0xff)
     assert_raise(ISO8583Exception) {
-      dt = Packed_Number.encode ";12312312=123?5"
+      Packed_Number.encode ";12312312=123?5"
     }
     assert_raise(ISO8583Exception) {
-      dt = Packed_Number.encode "F"
+      Packed_Number.encode "F"
     }
   end
 
@@ -145,7 +145,7 @@ class FieldTest < Test::Unit::TestCase
       BE_U16.encode 2**16
     }
     assert_raise(ISO8583Exception) {
-      BE_U16.encode -1
+      BE_U16.encode(-1)
     }
     assert_equal "\0\0", BE_U16.encode(0)
     expected = "\xff\xff".force_encoding('ASCII-8BIT')
@@ -164,7 +164,7 @@ class FieldTest < Test::Unit::TestCase
       BE_U32.encode 2**32
     }
     assert_raise(ISO8583Exception) {
-      BE_U32.encode -1
+      BE_U32.encode(-1)
     }
     assert_equal "\0\0\0\0", BE_U32.encode(0)
     expected = "\xff\xff\xff\xff".force_encoding('ASCII-8BIT')

data/test/test_fields.rb

@@ -10,7 +10,7 @@ class FieldTest < Test::Unit::TestCase
     assert_equal "456", rest
 
     assert_raise(ISO8583ParseException) {
-      l,rest = LLL.parse "12"
+      _,rest = LLL.parse "12"
     }
 
     enc = LLL.encode 123
@@ -50,10 +50,10 @@ class FieldTest < Test::Unit::TestCase
     assert_equal "123ABC", value
     assert_equal "", rest
     assert_raise(ISO8583ParseException) {
-      l,rest = LLLVAR_AN.parse "12"
+      _,rest = LLLVAR_AN.parse "12"
     }
     assert_raise(ISO8583ParseException) {
-      l,rest = LLVAR_AN.parse "12123"
+      _,rest = LLVAR_AN.parse "12123"
     }
 
     enc = LLVAR_AN.encode "123A"
@@ -83,10 +83,10 @@ class FieldTest < Test::Unit::TestCase
     assert_equal 1234, value
     assert_equal "", rest
     assert_raise(ISO8583ParseException) {
-      l,rest = LLLVAR_N.parse "12"
+      _,rest = LLLVAR_N.parse "12"
     }
     assert_raise(ISO8583ParseException) {
-      l,rest = LLVAR_N.parse "12123"
+      _,rest = LLVAR_N.parse "12123"
     }
 
     enc = LLVAR_N.encode 1234
@@ -116,10 +116,10 @@ class FieldTest < Test::Unit::TestCase
     assert_equal ";123123123=123?5", value
     assert_equal "", rest
     assert_raise(ISO8583ParseException) {
-      l,rest = LLVAR_Z.parse "12"
+      _,rest = LLVAR_Z.parse "12"
     }
     assert_raise(ISO8583ParseException) {
-      l,rest = LLVAR_Z.parse "17;123123123=123?5"
+      _,rest = LLVAR_Z.parse "17;123123123=123?5"
     }
 
     enc = LLVAR_Z.encode ";123123123=123?5"
@@ -213,6 +213,7 @@ class FieldTest < Test::Unit::TestCase
     fld.length=3
     value, rest = fld.parse "\x01\x23\x45"
     assert_equal 123, value
+    assert_equal "\x45", rest
 
     assert_equal "\x01\x23", fld.encode(123)
     assert_equal "\x01\x23", fld.encode("123")
@@ -241,6 +242,7 @@ class FieldTest < Test::Unit::TestCase
     assert_equal 12, dt.hour
     assert_equal 34, dt.min
     assert_equal 56, dt.sec
+    assert_equal "", rest
     
     assert_raise(ISO8583Exception) {
       fld.encode 1234567

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: iso8583
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Tim Becker
@@ -9,10 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-15 00:00:00.000000000 Z
+date: 2021-07-04 00:00:00.000000000 Z
 dependencies: []
-description: |
-  Ruby implementation of ISO 8583 financial messaging
+description: 'Ruby implementation of ISO 8583 financial messaging
+
+  '
 email:
 - tim.becker@kuriositaet.de
 - cordawyn@gmail.com
@@ -20,6 +21,13 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- AUTHORS
+- CHANGELOG
+- Gemfile
+- LICENSE
+- README.md
+- Rakefile
+- TODO
 - lib/8583.rb
 - lib/iso8583.rb
 - lib/iso8583/berlin.rb
@@ -31,14 +39,6 @@ files:
 - lib/iso8583/message.rb
 - lib/iso8583/util.rb
 - lib/iso8583/version.rb
-- AUTHORS
-- CHANGELOG
-- Gemfile
-- Gemfile.lock
-- LICENSE
-- README.md
-- Rakefile
-- TODO
 - test/BitmapTests.rb
 - test/message_test.rb
 - test/test_codec.rb
@@ -55,18 +55,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements:
 - none
-rubyforge_project: iso8583
-rubygems_version: 2.0.14.1
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: 'iso8583: Ruby implementation of ISO 8583 financial messaging'

data/Gemfile.lock

@@ -1,38 +0,0 @@
-PATH
-  remote: .
-  specs:
-    iso8583 (0.3.0)
-      test-unit (~> 3.0.0)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    diff-lcs (1.2.5)
-    power_assert (0.2.4)
-    rake (10.4.2)
-    rspec (3.3.0)
-      rspec-core (~> 3.3.0)
-      rspec-expectations (~> 3.3.0)
-      rspec-mocks (~> 3.3.0)
-    rspec-core (3.3.2)
-      rspec-support (~> 3.3.0)
-    rspec-expectations (3.3.1)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.3.0)
-    rspec-mocks (3.3.2)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.3.0)
-    rspec-support (3.3.0)
-    test-unit (3.0.9)
-      power_assert
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  iso8583!
-  rake
-  rspec (~> 3.3.0)
-
-BUNDLED WITH
-   1.10.6