iso-iban 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0620d303ad9521d970f78c7d9241b70aff7513a4
-  data.tar.gz: 79bef52b6e60f17fe955bf0c0bad877d27e3e758
+  metadata.gz: 1331caf363e5c9959e34a85b95c69a112e9b9e52
+  data.tar.gz: 86451b8eeb5fd428501f250cf442ba49aacc3e65
 SHA512:
-  metadata.gz: cd61b440ccdaa0d25992b712bfb417fbfc4aadf03d66964552c0bf9e282704df8e490689aa8e1d9dbc468c877063eb437cb5e2c1bd2216aebe84d0ef075c10a7
-  data.tar.gz: 0c159932573521ad658ac6db7d00c3fcb71b7cd607286b1064357e8216ad7c7e472536b2372d86e4266a0b287fa72ce21dc1923cd0354f2a81040181b71986c4
+  metadata.gz: b84ad4b9a52ffb2b1c644237f3ef462f0003746ef9ce1503039df28f46a1c52518e741f8d6335f5439503821b9d3ffeca951e0b42a13077fdf0ca07eab727a88
+  data.tar.gz: abc912af4577970c0708822751d206ba0b097d744290a6c13972f90e2b8837f47ae37655020db96ea93270a49bdcc199249e14a9b7f30cbf40018be075d4f8c9

data/iso-iban.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name                      = "iso-iban"
-  s.version                   = "0.0.1"
+  s.version                   = "0.0.2"
   s.authors                   = "Stefan Rusterholz"
   s.email                     = "stefan.rusterholz@gmail.com"
   s.homepage                  = "https://github.com/apeiros/iso-iban"

data/lib/iso/iban.rb

@@ -37,7 +37,7 @@ module ISO
   #   Bank identifier: The identifier that uniquely identifies the financial
   #   institution and, when appropriate, the branch of that financial institution
   #   servicing an account
-  #   
+  #
   #   `In this registry, the branch identifier format is shown specifically, when
   #   present.`
   #
@@ -84,11 +84,17 @@ module ISO
       elsif ENV['IBAN_SPECIFICATIONS'] then
         spec_file = ENV['IBAN_SPECIFICATIONS']
       else
-        spec_file = File.expand_path('../../../../data/iso-iban/specs.yaml', __FILE__)
-        spec_file = Gem.datadir('iso-iban')+'/specs.yaml' if defined?(Gem) && !File.file?(spec_file)
+        spec_file = File.expand_path('../../../data/iso-iban/specs.yaml', __FILE__)
+        if !File.file?(spec_file) && defined?(Gem) && Gem.datadir('iso-iban')
+          spec_file = Gem.datadir('iso-iban')+'/specs.yaml'
+        end
       end
 
-      @specifications = ISO::IBAN::Specification.load_yaml(spec_file)
+      if spec_file && File.file?(spec_file)
+        @specifications = ISO::IBAN::Specification.load_yaml(spec_file)
+      else
+        raise "Could not load IBAN specifications, no specs file found."
+      end
 
       self
     end

data/lib/iso/iban/specification.rb

@@ -105,7 +105,25 @@ module ISO
 
       # @return [Array<Integer>] An array with the lengths of all components.
       def component_lengths
-        @bban_structure.scan(/\d+/).map(&:to_i)
+        [bank_code_length, branch_code_length, account_code_lenght].tap { |lengths| lengths.delete(0) }
+      end
+
+      # @return [Fixnum]
+      #   The length of the bank code in the IBAN, 0 if the IBAN has no bank code.
+      def bank_code_length
+        @bank_position_from && @bank_position_to ? @bank_position_to-@bank_position_from+1 : 0
+      end
+
+      # @return [Fixnum]
+      #   The length of the bank code in the IBAN, 0 if the IBAN has no branch code.
+      def branch_code_length
+        @branch_position_from && @branch_position_to ? @branch_position_to-@branch_position_from+1 : 0
+      end
+
+      # @return [Fixnum]
+      #   The length of the account code in the IBAN.
+      def account_code_lenght
+        bban_length-bank_code_length-branch_code_length
       end
 
       # @return [Array] An array with the Specification properties. Used for serialization.

data/lib/iso/iban/version.rb

@@ -13,6 +13,6 @@ module ISO
     # @note
     #   require 'iso/iban' loads the version.
     #
-    Version = Gem::Version.new("0.0.1")
+    Version = Gem::Version.new("0.0.2")
   end
 end

data/test/unit/lib/iso/iban.rb

@@ -7,6 +7,12 @@ suite "ISO::IBAN" do
     ISO::IBAN.instance_variable_set(:@specifications, {'CH' => ISO::IBAN::Specification.new("Switzerland", "CH", "CH2!n5!n12!c", 21, "5!n12!c", 17, 4, 8, nil, nil)})
   end
 
+  test 'ISO::IBAN::generate problem, TODO' do
+    ISO::IBAN.instance_variable_set(:@specifications, {'BG' => ISO::IBAN::Specification.new("Bulgaria", "BG", "BG2!n4!a4!n2!n8!c", 22, "4!a4!n2!n8!c", 18, 4, 7, 8, 11)})
+    assert ISO::IBAN.generate('BG', 'AAAA', '2', 'C').valid? # this works now
+    assert ISO::IBAN.generate('BG', 'A', '2', 'C').valid? # this still fails, because ISO::IBAN::generate can't pad 'a' format fields
+  end
+
   test 'ISO::IBAN::load_specifications' do
     reset_test_files
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iso-iban
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Stefan Rusterholz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-07 00:00:00.000000000 Z
+date: 2013-07-09 00:00:00.000000000 Z
 dependencies: []
 description: |-
   ISO::IBAN implements IBAN (International Bank Account Number) specification as per ISO 13616-1.