isbndb 1.5.4 → 1.5.5

data/Gemfile

@@ -2,12 +2,14 @@ source "http://rubygems.org"
 
 gem 'activesupport'
 gem 'i18n'
+gem 'rake'
+gem 'rdoc'
 gem 'libxml-ruby', '>= 1.1.4'
 
 # Include everything needed to run rake, tests, features, etc.
 group :development do
-  gem "shoulda", ">= 0"
-  gem "bundler"
-  gem "jeweler"
-  gem "rcov", ">= 0"
+  gem 'shoulda', '>= 0'
+  gem 'bundler'
+  gem 'jeweler'
+  gem 'rcov', '>= 0'
 end

data/Gemfile.lock

@@ -1,16 +1,17 @@
 GEM
   remote: http://rubygems.org/
   specs:
-    activesupport (3.0.5)
+    activesupport (3.0.9)
     git (1.2.5)
-    i18n (0.5.0)
-    jeweler (1.5.2)
-      bundler (~> 1.0.0)
+    i18n (0.6.0)
+    jeweler (1.6.2)
+      bundler (~> 1.0)
       git (>= 1.2.5)
       rake
-    libxml-ruby (1.1.4)
-    rake (0.8.7)
+    libxml-ruby (2.0.6)
+    rake (0.9.2)
     rcov (0.9.9)
+    rdoc (3.6.1)
     shoulda (2.11.3)
 
 PLATFORMS
@@ -22,5 +23,7 @@ DEPENDENCIES
   i18n
   jeweler
   libxml-ruby (>= 1.1.4)
+  rake
   rcov
+  rdoc
   shoulda

data/README.markdown

@@ -170,6 +170,10 @@ Here is a real-life example of how to use Ruby ISBNdb. Imagine a Rails applicati
         <p><strong>authors</strong>: <%= book.authors_text %></p>
       </div>
     <% end %>
+    
+Testing
+-------
+[![Build Status](http://travis-ci.org/sethvargo/isbndb.png)](http://travis-ci.org/sethvargo/isbndb)
 
 Know Bugs and Limitations
 -------------------------

data/Rakefile

@@ -38,8 +38,8 @@ end
 
 task :default => :test
 
-require 'rake/rdoctask'
-Rake::RDocTask.new do |rdoc|
+require 'rdoc/task'
+RDoc::Task.new do |rdoc|
   version = File.exist?('VERSION') ? File.read('VERSION') : ""
 
   rdoc.rdoc_dir = 'rdoc'

data/VERSION

@@ -1 +1 @@
-1.5.4
+1.5.5

data/isbndb.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{isbndb}
-  s.version = "1.5.4"
+  s.version = "1.5.5"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.authors = ["Seth Vargo"]
-  s.date = %q{2011-04-21}
+  s.authors = [%q{Seth Vargo}]
+  s.date = %q{2011-06-23}
   s.description = %q{Ruby ISBNdb is a amazingly fast and accurate gem that reads ISBNdb.com's XML API and gives you incredible flexibilty with the results! The gem uses libxml-ruby, the fastest XML parser for Ruby, so you get blazing fast results every time. Additionally, the newest version of the gem also features caching, so developers minimize API-key usage.}
   s.email = %q{seth.vargo@gmail.com}
   s.extra_rdoc_files = [
@@ -35,14 +35,10 @@ Gem::Specification.new do |s|
     "test/test_isbndb.rb"
   ]
   s.homepage = %q{https://github.com/sethvargo/isbndb}
-  s.licenses = ["MIT"]
-  s.require_paths = ["lib"]
-  s.rubygems_version = %q{1.7.2}
+  s.licenses = [%q{MIT}]
+  s.require_paths = [%q{lib}]
+  s.rubygems_version = %q{1.8.5}
   s.summary = %q{This gem provides an easy solution for connecting to ISBNdb.com's API}
-  s.test_files = [
-    "test/helper.rb",
-    "test/test_isbndb.rb"
-  ]
 
   if s.respond_to? :specification_version then
     s.specification_version = 3
@@ -50,6 +46,8 @@ Gem::Specification.new do |s|
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_runtime_dependency(%q<activesupport>, [">= 0"])
       s.add_runtime_dependency(%q<i18n>, [">= 0"])
+      s.add_runtime_dependency(%q<rake>, [">= 0"])
+      s.add_runtime_dependency(%q<rdoc>, [">= 0"])
       s.add_runtime_dependency(%q<libxml-ruby>, [">= 1.1.4"])
       s.add_development_dependency(%q<shoulda>, [">= 0"])
       s.add_development_dependency(%q<bundler>, [">= 0"])
@@ -58,6 +56,8 @@ Gem::Specification.new do |s|
     else
       s.add_dependency(%q<activesupport>, [">= 0"])
       s.add_dependency(%q<i18n>, [">= 0"])
+      s.add_dependency(%q<rake>, [">= 0"])
+      s.add_dependency(%q<rdoc>, [">= 0"])
       s.add_dependency(%q<libxml-ruby>, [">= 1.1.4"])
       s.add_dependency(%q<shoulda>, [">= 0"])
       s.add_dependency(%q<bundler>, [">= 0"])
@@ -67,6 +67,8 @@ Gem::Specification.new do |s|
   else
     s.add_dependency(%q<activesupport>, [">= 0"])
     s.add_dependency(%q<i18n>, [">= 0"])
+    s.add_dependency(%q<rake>, [">= 0"])
+    s.add_dependency(%q<rdoc>, [">= 0"])
     s.add_dependency(%q<libxml-ruby>, [">= 1.1.4"])
     s.add_dependency(%q<shoulda>, [">= 0"])
     s.add_dependency(%q<bundler>, [">= 0"])

data/lib/isbndb/result_set.rb

@@ -73,7 +73,10 @@ module ISBNdb
     # each child. This method works because the API always returns #{@collection}List followed by a subset
     # of #{@collection}Data. These results are all pushed into the @results array for accessing.
     def build_results
-      @xml.find("#{@collection}List/#{@collection}Data").collect { |node| (@results ||= []) << Result.new(node) }
+      @results = []
+      list =  @xml.find("#{@collection}List/#{@collection}Data")
+      return [nil] if list.empty?
+      list.collect { |node| @results << Result.new(node) }
     end
     
     # This helper method is mainly designed for use with the go_to_page(page) method. It parses the XML

data/test/test_isbndb.rb

@@ -6,66 +6,72 @@ class TestISBNdb < Test::Unit::TestCase
       @query = ISBNdb::Query.new('KXWFXJIK')
     end    
     
-    # should "fetch a book by ISBN" do
-    #   @book = @query.find_book_by_isbn('1934356549').first
-    #   assert_equal '1934356549', @book.isbn
-    # end
-    #   
-    # should "fetch a book by ISBN13" do
-    #   @book = @query.find_book_by_isbn('9781934356548').first
-    #   assert_equal '9781934356548', @book.isbn13
-    # end
-    #   
-    # should 'fetch books by title' do
-    #   @books = @query.find_books_by_title('ruby')
-    #   @books.each do |book|
-    #     assert (book.title || "").downcase.include?('ruby') || (book.title_long || "").downcase.include?('ruby'), "#{book.title} did not contain 'ruby'"
-    #   end
-    # end
-    #   
-    # should 'get next_page and prev_page' do
-    #   @books = @query.find_books_by_title('ruby')
-    #   next_page = @books.next_page
-    #   assert_equal @books.first.title, next_page.prev_page.first.title, 'Failed to get next_page'
-    # end
-    #   
-    # should 'get keystats' do
-    #   assert @query.keystats.is_a?(Hash), "#{@query.keystats} was not a Hash"
-    #   assert @query.keystats[:requests] >= @query.keystats[:granted], "Number of requests (#{@query.keystats[:requests]}) was not greater than number of granted requests (#{@query.keystats[:granted]})"
-    #   assert @query.keystats[:requests] > 0 && @query.keystats[:requests] < 500, 'Requests were not between 0 and 500'
-    # end
-    #   
-    # should 'test access_key_set' do
-    #   @query = ISBNdb::Query.new(['API-KEY-1', 'API-KEY-2', 'API-KEY-3'])
-    #   @access_key_set = @query.access_key_set
-    #   assert_equal 'API-KEY-1', @access_key_set.current_key
-    #   assert_equal 'API-KEY-2', @access_key_set.next_key
-    #   @access_key_set.next_key!
-    #   assert_equal 'API-KEY-1', @access_key_set.prev_key
-    #   @access_key_set.use_key('A-NEW-KEY')
-    #   assert_equal 'A-NEW-KEY', @access_key_set.current_key
-    #   @access_key_set.use_key('API-KEY-3')
-    #   assert_equal 'API-KEY-3', @access_key_set.current_key
-    # end
-    #   
-    # should 'raise exception for an invalid access key' do
-    #   @invalid = ISBNdb::Query.new(['abc123foobar', '123anotherinvalidkey'])
-    #   assert_raise ISBNdb::AccessKeyError, "#{@invalid} did not raise AccessKeyError" do
-    #     @invalid.find_book_by_isbn('1934356549')
-    #   end
-    # end
-    #   
-    # should 'raise exception for an invalid uri' do
-    #   assert_raise ISBNdb::InvalidURIError, "@query.find_invalid_by_unknown did not raise InvalidURIError" do
-    #     @query.find_invalid_by_unknown('foobar')
-    #   end
-    # end
+    should "fetch a book by ISBN" do
+      @book = @query.find_book_by_isbn('1934356549').first
+      assert_equal '1934356549', @book.isbn
+    end
+      
+    should "fetch a book by ISBN13" do
+      @book = @query.find_book_by_isbn('9781934356548').first
+      assert_equal '9781934356548', @book.isbn13
+    end
     
-    should 'make sub-result sets' do
-      @books = @query.find(:collection => 'books', :where => { :title => 'vargo' }, :results => 'prices')
-      @books.each do |book|
-        #puts book
-      end
+    should 'fail nicely on a bad ISBN' do
+      @book = @query.find_book_by_isbn('9780141033013').first
+      assert_nil @book
     end
-  end
+
+     should 'fetch books by title' do
+       @books = @query.find_books_by_title('ruby')
+       @books.each do |book|
+         assert (book.title || "").downcase.include?('ruby') || (book.title_long || "").downcase.include?('ruby'), "#{book.title} did not contain 'ruby'"
+       end
+     end
+       
+     should 'get next_page and prev_page' do
+       @books = @query.find_books_by_title('ruby')
+       next_page = @books.next_page
+       assert_equal @books.first.title, next_page.prev_page.first.title, 'Failed to get next_page'
+     end
+       
+     should 'get keystats' do
+       assert @query.keystats.is_a?(Hash), "#{@query.keystats} was not a Hash"
+       assert @query.keystats[:requests].to_i >= @query.keystats[:granted].to_i, "Number of requests (#{@query.keystats[:requests]}) was not greater than number of granted requests (#{@query.keystats[:granted]})"
+       assert @query.keystats[:requests].to_i > 0 && @query.keystats[:requests].to_i < 500, 'Requests were not between 0 and 500'
+     end
+       
+     should 'test access_key_set' do
+       @query = ISBNdb::Query.new(['API-KEY-1', 'API-KEY-2', 'API-KEY-3'])
+       @access_key_set = @query.access_key_set
+       assert_equal 'API-KEY-1', @access_key_set.current_key
+       assert_equal 'API-KEY-2', @access_key_set.next_key
+       @access_key_set.next_key!
+       assert_equal 'API-KEY-1', @access_key_set.prev_key
+       @access_key_set.use_key('A-NEW-KEY')
+       assert_equal 'A-NEW-KEY', @access_key_set.current_key
+       @access_key_set.use_key('API-KEY-3')
+       assert_equal 'API-KEY-3', @access_key_set.current_key
+     end
+       
+     should 'raise exception for an invalid access key' do
+       @invalid = ISBNdb::Query.new(['abc123foobar', '123anotherinvalidkey'])
+       assert_raise ISBNdb::AccessKeyError, "#{@invalid} did not raise AccessKeyError" do
+         @invalid.find_book_by_isbn('1934356549')
+       end
+     end
+       
+     should 'raise exception for an invalid uri' do
+       assert_raise ISBNdb::InvalidURIError, "@query.find_invalid_by_unknown did not raise InvalidURIError" do
+         @query.find_invalid_by_unknown('foobar')
+       end
+     end
+     
+     # This isn't done yet...
+     should 'make sub-result sets' do
+       @books = @query.find(:collection => 'books', :where => { :title => 'vargo' }, :results => 'prices')
+       @books.each do |book|
+         #puts book
+       end
+     end
+   end
 end

metadata

@@ -1,104 +1,127 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: isbndb
-version: !ruby/object:Gem::Version 
+version: !ruby/object:Gem::Version
+  version: 1.5.5
   prerelease: 
-  version: 1.5.4
 platform: ruby
-authors: 
+authors:
 - Seth Vargo
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-04-21 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2011-06-23 00:00:00.000000000Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: &2154230480 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
+  version_requirements: *2154230480
+- !ruby/object:Gem::Dependency
   name: i18n
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  requirement: &2154229980 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
+  version_requirements: *2154229980
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: &2154229200 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: *2154229200
+- !ruby/object:Gem::Dependency
+  name: rdoc
+  requirement: &2154228380 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: *2154228380
+- !ruby/object:Gem::Dependency
   name: libxml-ruby
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  requirement: &2154227540 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
         version: 1.1.4
   type: :runtime
   prerelease: false
-  version_requirements: *id003
-- !ruby/object:Gem::Dependency 
+  version_requirements: *2154227540
+- !ruby/object:Gem::Dependency
   name: shoulda
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  requirement: &2154226720 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
   prerelease: false
-  version_requirements: *id004
-- !ruby/object:Gem::Dependency 
+  version_requirements: *2154226720
+- !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &id005 !ruby/object:Gem::Requirement 
+  requirement: &2154226020 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
   prerelease: false
-  version_requirements: *id005
-- !ruby/object:Gem::Dependency 
+  version_requirements: *2154226020
+- !ruby/object:Gem::Dependency
   name: jeweler
-  requirement: &id006 !ruby/object:Gem::Requirement 
+  requirement: &2154225440 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
   prerelease: false
-  version_requirements: *id006
-- !ruby/object:Gem::Dependency 
+  version_requirements: *2154225440
+- !ruby/object:Gem::Dependency
   name: rcov
-  requirement: &id007 !ruby/object:Gem::Requirement 
+  requirement: &2154224760 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
   prerelease: false
-  version_requirements: *id007
-description: Ruby ISBNdb is a amazingly fast and accurate gem that reads ISBNdb.com's XML API and gives you incredible flexibilty with the results! The gem uses libxml-ruby, the fastest XML parser for Ruby, so you get blazing fast results every time. Additionally, the newest version of the gem also features caching, so developers minimize API-key usage.
+  version_requirements: *2154224760
+description: Ruby ISBNdb is a amazingly fast and accurate gem that reads ISBNdb.com's
+  XML API and gives you incredible flexibilty with the results! The gem uses libxml-ruby,
+  the fastest XML parser for Ruby, so you get blazing fast results every time. Additionally,
+  the newest version of the gem also features caching, so developers minimize API-key
+  usage.
 email: seth.vargo@gmail.com
 executables: []
-
 extensions: []
-
-extra_rdoc_files: 
+extra_rdoc_files:
 - LICENSE.txt
 - README.markdown
-files: 
+files:
 - .document
 - ACKNOWLEDGEMENTS
 - Gemfile
@@ -116,35 +139,31 @@ files:
 - test/helper.rb
 - test/test_isbndb.rb
 homepage: https://github.com/sethvargo/isbndb
-licenses: 
+licenses:
 - MIT
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 4519594731805575555
-      segments: 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+      segments:
       - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+      hash: 3725550696331158843
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.7.2
+rubygems_version: 1.8.5
 signing_key: 
 specification_version: 3
 summary: This gem provides an easy solution for connecting to ISBNdb.com's API
-test_files: 
-- test/helper.rb
-- test/test_isbndb.rb
+test_files: []