is_unique 0.0.4 → 0.1.0

data/README

@@ -1,7 +1,7 @@
 Is Unique
 =========
 
-This is a simple ActiveRecord extension that makes sure that no duplicate records are added to the database. When you create a new model instance that already exists, it won't create a new record, but return the existing one instead. The extension generates a hash off the model attributes and use it to check for existing records. Of course, it ignores primary key, created_at, updated_at and other columns that you ask it to.
+This is a simple ActiveRecord extension that makes sure that no duplicate records are added to the database. When you create a new model instance that already exists, it won't create a new record, but will return the existing one instead. The extension generates a hash off the model attributes and use it to check for existing records. Of course, it ignores primary key, created_at, updated_at and other columns that you ask it to.
 
 Here's an example. Say you have a Location model and you want all your locations to be unique. When you add a new location you'd like to check whether it already exists and if it does, you don't want to create a new record.
 
@@ -21,14 +21,14 @@ class Location < ActiveRecord::Base
   is_unique
 end
 
-Then fire up console and try it:
+Then fire up the console and try it:
 
 >> l = Location.create(:name => 'London', :lat => '51.5', :lng => '-0.13', :alias => 'Londinium')
-  Location Load (0.4ms)   SELECT * FROM "locations" WHERE ("locations"."unique_hash" = 189338025) LIMIT 1
+  Location Load (0.4ms)   SELECT * FROM `locations` WHERE (`locations`.`unique_hash` = '...') LIMIT 1
   Location Create (0.6ms)   INSERT INTO "locations" ...
 => #<Location id: ...>
 >> l.clone.save
-  Location Load (0.7ms)   SELECT * FROM "locations" WHERE ("locations"."unique_hash" = 189338025) LIMIT 1
+  Location Load (0.7ms)   SELECT * FROM "locations" WHERE ("locations"."unique_hash" = '...') LIMIT 1
   Location Load (0.6ms)   SELECT * FROM "locations" WHERE ("locations"."id" = 1)
 => true
 
@@ -46,7 +46,7 @@ end
 >> n.alias = 'Something different'
 => "Something different"
 >> n.save
-  Location Load (0.7ms)   SELECT * FROM "locations" WHERE ("locations"."unique_hash" = 189338025) LIMIT 1
+  Location Load (0.7ms)   SELECT * FROM "locations" WHERE ("locations"."unique_hash" = '...') LIMIT 1
   Location Load (0.6ms)   SELECT * FROM "locations" WHERE ("locations"."id" = 2) 
 => true
 >> n == l

data/VERSION

@@ -1 +1 @@
-0.0.4
+0.1.0

data/generators/is_unique/templates/is_unique_migration.rb

@@ -1,6 +1,6 @@
 class <%= file_name.camelcase %> < ActiveRecord::Migration
   def self.up
-    add_column :<%= table_name %>, :<%= unique_hash_column %>, :integer
+    add_column :<%= table_name %>, :<%= unique_hash_column %>, :string, :limit => 20
     add_index :<%= table_name %>, :<%= unique_hash_column %>
     # Generate hashes for existing records
     <%= class_name %>.find_each { |r| r.save(false) }

data/is_unique.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{is_unique}
-  s.version = "0.0.4"
+  s.version = "0.1.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Eugene Bolshakov"]
-  s.date = %q{2010-03-26}
+  s.date = %q{2010-05-18}
   s.description = %q{Makes ActiveRecord return existing records instead of creating duplicates}
   s.email = %q{eugene.bolshakov@gmail.com}
   s.extra_rdoc_files = [

data/lib/is_unique.rb

@@ -1,3 +1,5 @@
+require 'digest/sha1'
+
 module IsUnique
   def self.included(base)
     base.extend IsUnique::ClassMethods
@@ -49,11 +51,15 @@ module IsUnique
       end
 
       def calculate_unique_hash
-        self.is_unique_hash = unique_attributes.sort_by{ |pair| pair.hash }.hash
+        self.is_unique_hash = Digest::SHA1.digest(
+          unique_attribute_names.inject('') do |r, e|
+            r + "#{e}#{read_attribute_before_type_cast(e)}"
+          end
+        )
       end
 
-      def unique_attributes
-        attributes.except(*self.class.read_inheritable_attribute(:is_unique_ignore))
+      def unique_attribute_names
+        attribute_names - self.class.read_inheritable_attribute(:is_unique_ignore)
       end
   end
 end

data/spec/support/db.rb

@@ -14,7 +14,7 @@ def setup_db
       t.string     :name
       t.float      :lat, :lng
       t.string     :alias
-      t.integer    :unique_hash
+      t.string     :unique_hash, :length => 20
       t.timestamps
     end
   end

data/spec/unique_model_spec.rb

@@ -16,8 +16,8 @@ class PopulatedPlace < Location
 end
 
 describe "A unique model" do
-  before(:each) do
-    @it = Location.create(
+  subject do
+    Location.create(
       :name  => 'London',
       :lat   => '51.5084152563931',
       :lng   => '-0.125532746315002',
@@ -25,44 +25,44 @@ describe "A unique model" do
     )
   end
 
+  it 'should have a 20 characters long unique hash' do
+    subject.unique_hash.length.should == 20
+  end
+
   it "should not create a new record with the same attributes" do
-    new_record = @it.clone
-    lambda { new_record.save! }.
-      should_not change(Location, :count)
+    new_record = subject.clone
+    expect { new_record.save! }.to_not change(Location, :count)
   end
 
   it "should not create a new record with a different ignored attribute" do
-    new_record = @it.clone
+    new_record = subject.clone
     new_record.alias = 'Greater London'
-    lambda { new_record.save! }.
-      should_not change(Location, :count)
+    expect { new_record.save! }.to_not change(Location, :count)
   end
 
   it "should return the existing record on creation" do
-    new_record = @it.clone
+    new_record = subject.clone
     new_record.save!
-    new_record.should == @it
+    new_record.should == subject
   end
 
   it "should allow to create a record with different attributes" do
-    new_record = @it.clone
+    new_record = subject.clone
     new_record.name = 'Greater London'
-    lambda { new_record.save! }.
-      should change(Location, :count).by(1)
-    new_record.should_not == @it
+    expect { new_record.save! }.to change(Location, :count).by(1)
+    new_record.should_not == subject
   end
 
   it "should allow to create a record with original attributes when an existing record is updated" do
-    new_record = @it.clone
-    @it.update_attribute(:name, 'Greater London')
-    lambda { new_record.save! }.
-      should change(Location, :count).by(1)
-    new_record.should_not == @it
+    new_record = subject.clone
+    subject.update_attribute(:name, 'Greater London')
+    expect { new_record.save! }.to change(Location, :count).by(1)
+    new_record.should_not == subject
   end
 
   context "that is a subclass of another model" do
-    before(:each) do
-      @it = PopulatedPlace.create(
+    subject do
+      PopulatedPlace.create(
         :name  => 'London',
         :lat   => '51.5084152563931',
         :lng   => '-0.125532746315002',
@@ -71,16 +71,15 @@ describe "A unique model" do
     end
 
     it "should be able to override columns that should be ignored" do
-      new_record = @it.clone
+      new_record = subject.clone
       new_record.name = 'Greater London'
       new_record.alias = 'London, UK'
-      lambda { new_record.save! }.
-        should_not change(PopulatedPlace, :count)
+      expect { new_record.save! }.to_not change(PopulatedPlace, :count)
     end
 
     it "should run callbacks just once" do
-      @it.should_receive(:calculate_unique_hash).once
-      @it.save
+      subject.should_receive(:calculate_unique_hash).once
+      subject.save
     end
   end
 end

metadata

@@ -4,9 +4,9 @@ version: !ruby/object:Gem::Version
   prerelease: false
   segments: 
   - 0
+  - 1
   - 0
-  - 4
-  version: 0.0.4
+  version: 0.1.0
 platform: ruby
 authors: 
 - Eugene Bolshakov
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-26 00:00:00 +03:00
+date: 2010-05-18 00:00:00 +04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency