is_a_collection 0.0.5 → 0.1.0

data/lib/is_a_collection.rb

@@ -1,21 +1,50 @@
+require 'set'
+
+class Object # http://whytheluckystiff.net/articles/seeingMetaclassesClearly.html
+  def meta_def name, &blk
+    (class << self; self; end).instance_eval { define_method name, &blk }
+  end
+end
+
 class Class
   
-  def is_a_collection(id_method=:id)
+  def is_a_collection(id_method=:id, opts={})
     id_method = id_method.to_sym
+    indices = [opts[:index], opts[:indices]].flatten.compact
     
     include IsACollection::InstanceMethods
     extend IsACollection::ClassMethods
     
     define_method :add_to_collection do
-      self.class.__collection[__send__ id_method] = self
+      primary_key = __send__(id_method)
+      raise IsACollection::DuplicateKey if self.class.__collection[primary_key]
+      self.class.__collection[primary_key] = self
+      
+      indices.each do |index|
+        self.class.__indices[index][__send__ index].add(self)
+      end
     end
+    
     define_method :remove_from_collection do
       self.class.__collection.delete(__send__ id_method)
+      
+      indices.each do |index|
+        self.class.__indices[index][__send__ index].delete(self)
+      end
+    end
+    
+    indices.each do |index|
+      meta_def :"find_by_#{index}" do |genre|
+        __indices[index][genre]
+      end
     end
+    
   end
 end
 
 module IsACollection
+  class DuplicateKey < StandardError; end
+  
   module InstanceMethods
     def initialize(*args, &block)
       super
@@ -37,6 +66,12 @@ module IsACollection
     def find(identifier)
       __collection[identifier]
     end
+    def clear_collection_indices
+      @__collection = {}
+      @__indices = Hash.new{ |hash,key| hash[key] = Hash.new{ |hash1,key1| hash1[key1] = Set.new } }
+    end
+    def __indices
+      @__indices ||= Hash.new{ |hash,key| hash[key] = Hash.new{ |hash1,key1| hash1[key1] = Set.new } }
+    end
   end
 end
-

data/spec/is_a_collection_spec.rb

@@ -28,6 +28,19 @@ class C
   is_a_collection
 end
 
+class Song
+  attr_reader :title, :genre
+  is_a_collection :title, :index => :genre
+  
+  def initialize(title, genre)
+    @title, @genre = title, genre
+    add_to_collection
+  end
+  def destroy
+    remove_from_collection
+  end
+end
+
 describe "is_a_collection" do
   describe "#all" do
     describe "without any instances" do
@@ -43,6 +56,12 @@ describe "is_a_collection" do
       end
     end
   end
+  describe "on primary key collision" do
+    it "raise an error" do
+      b1 = B.new('a key')
+      lambda{ B.new('a key') }.should raise_error(IsACollection::DuplicateKey)
+    end
+  end
   describe "#find" do
     it "should return the instance by default identifier (#object_id)" do
       a = A.new
@@ -65,4 +84,30 @@ describe "is_a_collection" do
       B.find('doomed').should be_nil
     end
   end
+  describe "indices" do
+    after(:each) do
+      Song.clear_collection_indices
+    end
+    describe "on instance creation" do
+      it "adds instances to the index" do
+        s1 = Song.new 'some title', 'Rock'
+        s2 = Song.new 'some other title', 'Rock'
+        Song.find_by_genre('Rock').should include(s1)
+        Song.find_by_genre('Rock').should include(s2)
+      end
+      it "doesn't add instances to other indices" do
+        s1 = Song.new 'some title', 'Rock'
+        s2 = Song.new 'some other title', 'Pop'
+        Song.find_by_genre('Rock').should_not include(s2)
+      end
+    end
+    describe "on instance destruction" do
+      it "removes the instance from the index" do
+        s = Song.new 'some other title', 'Rock'
+        Song.find_by_genre('Rock').should include(s)
+        s.destroy
+        Song.find_by_genre('Rock').should_not include(s)
+      end
+    end
+  end
 end

metadata

@@ -1,12 +1,8 @@
 --- !ruby/object:Gem::Specification 
 name: is_a_collection
 version: !ruby/object:Gem::Version 
-  prerelease: false
-  segments: 
-  - 0
-  - 0
-  - 5
-  version: 0.0.5
+  prerelease: 
+  version: 0.1.0
 platform: ruby
 authors: 
 - Niko Dittmann
@@ -14,8 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-12-14 00:00:00 +01:00
-default_executable: 
+date: 2011-07-01 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rspec
@@ -25,8 +20,6 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        segments: 
-        - 0
         version: "0"
   type: :development
   version_requirements: *id001
@@ -41,7 +34,6 @@ extra_rdoc_files: []
 files: 
 - lib/is_a_collection.rb
 - spec/is_a_collection_spec.rb
-has_rdoc: true
 homepage: http://github.com/niko/is_a_collection
 licenses: []
 
@@ -55,21 +47,17 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      segments: 
-      - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      segments: 
-      - 0
       version: "0"
 requirements: []
 
 rubyforge_project: nowarning
-rubygems_version: 1.3.7
+rubygems_version: 1.7.2
 signing_key: 
 specification_version: 3
 summary: "A small gem that adds #find, #all and #destroy to a class to keep track of its instances."