iron_fixture_extractor 1.1.0 → 1.1.1

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 1.1.0 -> 1.1.0
+* Deprecation warning for fe_manifest.yml's extracted from 1.0.0 or earlier.
+
+* Fix for Oracle reset pk seq (didn't work on 1.1.0)
+
 ## 1.0.0 -> 1.1.0
 * Shouldn't be any breaking changes, mostly a switch to rspec for
 testing.

data/README.md

@@ -172,6 +172,34 @@ In a nutshell:
 See spec/README_FOR_DEVELOPERS.md for more details.
 
 
+
+#### TODO: JOE REPLACE THE ABOVE CONTENT WITH THIS METHOD
+Alternatively, another way to lower the barrier to contributing is to submodule the Gem into your project
+and hack in the features you need to support your app specific, then add
+a test case to the Gem itself that illustrates your change...
+
+#### TODO: Write a "For Rspec users", include an initializer:
+
+    # config/initializers/iron_fixture_extractor.rb
+    Fe.fixtures_root = 'spec/fe_fixtures' if defined?(Fe)
+
+#### TODO: Write something up about bug with has_many :through
+* If you have a query that utilizes a has_many :through.  Make sure to
+put the table that facilitates the :through AFTER the one that uses it.
+ie.
+
+    # NOT WORKING
+    query='Etl::Receipt.includes(:audits, :instcd_to_jobid_mappings, :dars_job_queue_lists  => {:job_queue_runs => [:job_queue_outs, {:job_queue_reqs => {:job_queue_subreqs  => :job_queue_courses}}]})'
+    t=Fe.extract(query,:name => 'poo')
+
+    # WORKING
+    query='Etl::Receipt.includes(:audits, {:dars_job_queue_lists  => {:job_queue_runs => [:job_queue_outs, {:job_queue_reqs => {:job_queue_subreqs  => :job_queue_courses}}]}}, :instcd_to_jobid_mappings)'
+    t=Fe.extract(query,:name => 'poo')
+
+* Beers, kudos, praise, and glory for a developer who can find the
+reason for this and a fix...I tried, but couldn't figure it out, hence
+the work around.
+
 ## Footnotes
 I used various ideas from the following blog posts, gists, and existing
 ruby gems, thanks to the authors of these pages:

data/lib/fe/extractor.rb

@@ -57,10 +57,15 @@ module Fe
       raise "No models to load, relax your :only or :except filters (or don't bother calling this method)" if the_tables.empty?
 
       the_tables.each do |table_name|
+        class_name = if self.table_name_to_model_name_hash.kind_of?(Hash)
+          self.table_name_to_model_name_hash[table_name]
+        else
+          ActiveSupport::Deprecation.warn "your fe_manifest.yml does not contain a table_name_to_model_name_hash (as found in 1.0.0 or earlier). Version 2.0.0 will require this. See test cases for how to manually jigger your fe_manifest.ymls to function."
+          nil
+        end
         if options[:map].nil?
           # Vanilla create_fixtures will work fine when no mapping is being used
           ActiveRecord::Fixtures.create_fixtures(self.target_path, table_name)
-          next
         else
           # Map table_name via a function (great for prefixing)
           new_table_name = if options[:map].kind_of?(Proc)
@@ -71,7 +76,6 @@ module Fe
           else
             table_name # No mapping for this table name
           end
-          class_name = self.table_name_to_model_name_hash[table_name]
           fixtures = ActiveRecord::Fixtures.new( ActiveRecord::Base.connection,
               new_table_name,
               class_name,
@@ -87,6 +91,7 @@ module Fe
         # calls.  aka this code should be eliminated/live elsewhere.
         case ActiveRecord::Base.connection.adapter_name
         when /oracle/i
+          model = class_name.constantize
           if model.column_names.include? "id"
             sequence_name = model.sequence_name.to_s
             max_id = model.maximum(:id)
@@ -212,18 +217,14 @@ module Fe
       raise "This gem only knows how to extract stuff w ActiveRecord" unless record.kind_of? ActiveRecord::Base
       key = record.class.base_class.to_s # the base_class is key for correctly handling STI
       @output_hash[key] ||= Set.new # Set ensures no duplicates
-      @output_hash[key].add record
-      record.association_cache.each do |assoc_cache|
-        assoc_name = assoc_cache.first
-        assoc_value = assoc_cache.last.target
-        unless assoc_value.kind_of? Array
-          assoc_value = Array(assoc_value)
-        end
-        assoc_value.each do |a|
+      @output_hash[key].add(record)
+      record.association_cache.each_pair do |assoc_name,association_def|
+        Array(association_def.target).each do |a|
           self.recurse(a)
         end
       end
     end
+
     def write_model_fixtures
       FileUtils.mkdir_p(self.target_path)
       self.output_hash.each_pair do |key,records|

data/lib/fe/version.rb

@@ -1,3 +1,3 @@
 module Fe
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: iron_fixture_extractor
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -143,7 +143,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 553662890390521503
+      hash: -3292280525626444386
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -152,7 +152,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 553662890390521503
+      hash: -3292280525626444386
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23