iron_bank 3.3.4 → 3.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4dcbe1d65189ca5901e083f5865448fd02a7867d079a476897ed66253838fe48
-  data.tar.gz: 4bddf6e7bb277eb398b41b643b95c2786c53479e211c6148c7212afae3e9c900
+  metadata.gz: 195ba10f5c39626868e1d281972ff45e4618f1e72b0d87684aa9c65d1ed1fa10
+  data.tar.gz: acd56eae404df5027aceeb8081b542da811178a71ff56924531b4d2280fa045d
 SHA512:
-  metadata.gz: 45f9a859f8981a3f5ff823d9baa458a525fbc01faa93d5e36c065839fa5fcf12ae9cbfe20aa5bf3b840015580c8d124e7aaea480a9ca53910eab84f6829ee591
-  data.tar.gz: a087ba2703630d7524a7e642f9f6467926d7f9a4d29b115d8e0aa7ad555984ee8f1aaad5dba16de48ac04290b6d022c06cde16a09ae0f3949ef05a18f5aec638
+  metadata.gz: 4db1e53ef118e2b496a1ae41ea0f880458386767e57a562de235f0e734416df59f441c7f1928aca06cfa3904c49623985a794f5b3bf72121391488c2dc1a1da4
+  data.tar.gz: 25c9457c4716177d3a21d0f6b993a433558a323a6ba8f63e4cca881660ddca92408a16226d6ae4e42f05f6d280c6340c42c2667a8a2c131afc0a3adee9acd05d

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    iron_bank (3.3.4)
+    iron_bank (3.4.0)
       faraday (~> 0)
       faraday_middleware (~> 0)
       nokogiri (~> 1)
@@ -30,8 +30,8 @@ GEM
     descendants_tracker (0.0.4)
       thread_safe (~> 0.3, >= 0.3.1)
     diff-lcs (1.3)
-    docile (1.3.1)
-    dotenv (2.7.2)
+    docile (1.3.2)
+    dotenv (2.7.5)
     equalizer (0.0.11)
     factory_bot (5.0.2)
       activesupport (>= 4.2.0)
@@ -42,7 +42,7 @@ GEM
     i18n (1.6.0)
       concurrent-ruby (~> 1.0)
     ice_nine (0.11.2)
-    jaro_winkler (1.5.2)
+    jaro_winkler (1.5.3)
     json (2.2.0)
     kwalify (0.7.2)
     method_source (0.9.2)
@@ -52,7 +52,7 @@ GEM
     nokogiri (1.10.4)
       mini_portile2 (~> 2.4.0)
     parallel (1.17.0)
-    parser (2.6.2.1)
+    parser (2.6.3.0)
       ast (~> 2.4.0)
     pry (0.12.2)
       coderay (~> 1.1.0)
@@ -62,8 +62,8 @@ GEM
       pry (~> 0.10)
     psych (3.1.0)
     rainbow (3.0.0)
-    rake (12.3.2)
-    reek (5.3.2)
+    rake (12.3.3)
+    reek (5.4.0)
       codeclimate-engine-rb (~> 0.4.0)
       kwalify (~> 0.7.0)
       parser (>= 2.5.0.0, < 2.7, != 2.5.1.1)
@@ -73,29 +73,28 @@ GEM
       rspec-core (~> 3.8.0)
       rspec-expectations (~> 3.8.0)
       rspec-mocks (~> 3.8.0)
-    rspec-core (3.8.0)
+    rspec-core (3.8.2)
       rspec-support (~> 3.8.0)
-    rspec-expectations (3.8.2)
+    rspec-expectations (3.8.4)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.8.0)
-    rspec-mocks (3.8.0)
+    rspec-mocks (3.8.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.8.0)
-    rspec-support (3.8.0)
-    rubocop (0.67.2)
+    rspec-support (3.8.2)
+    rubocop (0.74.0)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
-      parser (>= 2.5, != 2.5.1.1)
-      psych (>= 3.1.0)
+      parser (>= 2.6)
       rainbow (>= 2.2.2, < 4.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 1.6)
-    rubocop-performance (1.0.0)
-      rubocop (>= 0.58.0)
-    ruby-progressbar (1.10.0)
-    shoulda-matchers (4.0.1)
+      unicode-display_width (>= 1.4.0, < 1.7)
+    rubocop-performance (1.4.1)
+      rubocop (>= 0.71.0)
+    ruby-progressbar (1.10.1)
+    shoulda-matchers (4.1.2)
       activesupport (>= 4.2.0)
-    simplecov (0.16.1)
+    simplecov (0.17.0)
       docile (~> 1.1)
       json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
@@ -104,7 +103,7 @@ GEM
     timecop (0.9.1)
     tzinfo (1.2.5)
       thread_safe (~> 0.1)
-    unicode-display_width (1.5.0)
+    unicode-display_width (1.6.0)
     virtus (1.0.5)
       axiom-types (~> 0.1)
       coercible (~> 1.0)
@@ -128,7 +127,7 @@ DEPENDENCIES
   rubocop-performance (~> 1.0)
   shoulda-matchers (~> 4.0)
   simplecov (~> 0.15)
-  timecop (~> 0.9.0)
+  timecop (~> 0.9)
 
 BUNDLED WITH
    2.0.2

data/iron_bank.gemspec

@@ -41,7 +41,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rubocop-performance", "~> 1.0"
   spec.add_development_dependency "shoulda-matchers",    "~> 4.0"
   spec.add_development_dependency "simplecov",           "~> 0.15"
-  spec.add_development_dependency "timecop",             "~> 0.9.0"
+  spec.add_development_dependency "timecop",             "~> 0.9"
 
   spec.add_runtime_dependency "faraday",            "~> 0"
   spec.add_runtime_dependency "faraday_middleware", "~> 0"

data/lib/iron_bank/actions/query.rb

@@ -6,7 +6,14 @@ module IronBank
     # https://knowledgecenter.zuora.com/DC_Developers/K_Zuora_Object_Query_Language
     #
     class Query < Action
-      def self.call(zoql, limit: 0)
+      # Zuora's default is 2,000 records, but we simply use `0` here to not pass
+      # the parameter to Zuora APIs during the query call.
+      #
+      # See https://knowledgecenter.zuora.com/DC_Developers/BC_ZOQL#Limits
+      #
+      DEFAULT_ZUORA_LIMIT = 0
+
+      def self.call(zoql, limit: DEFAULT_ZUORA_LIMIT)
         new(zoql, limit).call
       end
 

data/lib/iron_bank/cacheable.rb

@@ -32,7 +32,8 @@ module IronBank
         cache.fetch(id, force: force) { super(id) }
       end
 
-      def where(conditions)
+      def where(conditions,
+                limit: IronBank::Actions::Query::DEFAULT_ZUORA_LIMIT)
         # Conditions can be empty when called from #all, it does not make sense
         # to try to cache all records returned then.
         return super if conditions.empty?

data/lib/iron_bank/local.rb

@@ -19,7 +19,11 @@ module IronBank
       store.any? ? store.values : super
     end
 
-    def where(conditions)
+    def first
+      store.any? ? store.values.first : super
+    end
+
+    def where(conditions, limit: IronBank::Actions::Query::DEFAULT_ZUORA_LIMIT)
       records = store.values.select do |record|
         conditions.all? { |field, value| record.public_send(field) == value }
       end

data/lib/iron_bank/queryable.rb

@@ -17,6 +17,9 @@ module IronBank
 
     # This methods leverages the fact that Zuora only returns 2,000 records at a
     # time, hance providing a default batch size
+    #
+    # See https://knowledgecenter.zuora.com/DC_Developers/BC_ZOQL#Limits
+    #
     def find_each
       return enum_for(:find_each) unless block_given?
 
@@ -36,17 +39,17 @@ module IronBank
       where({})
     end
 
-    def where(conditions)
-      query_string = IronBank::QueryBuilder.zoql(
-        object_name,
-        query_fields,
-        conditions
-      )
+    def first
+      where({}, limit: 1).first
+    end
+
+    def where(conditions, limit: IronBank::Actions::Query::DEFAULT_ZUORA_LIMIT)
+      query_string = IronBank::QueryBuilder.
+                     zoql(object_name, query_fields, conditions)
 
-      # FIXME: need to use logger instance instead
-      # puts "query: #{query_string}"
+      IronBank.logger.info "query: #{query_string}"
 
-      records = IronBank::Query.call(query_string)[:records]
+      records = IronBank::Query.call(query_string, limit: limit)[:records]
       return [] unless records
 
       records.each.with_object([]) do |data, result|

data/lib/iron_bank/utils.rb

@@ -8,7 +8,7 @@ module IronBank
 
     # Inspired from ActiveSupport
     def underscore(camel_cased_word)
-      return camel_cased_word unless camel_cased_word =~ /[A-Z-]|::/
+      return camel_cased_word unless /[A-Z-]|::/.match?(camel_cased_word)
 
       word = camel_cased_word.to_s.gsub(/::/, "/")
       word.gsub!(/([A-Z\d]+)([A-Z][a-z])/, '\1_\2')

data/lib/iron_bank/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module IronBank
-  VERSION     = "3.3.4"
+  VERSION     = "3.4.0"
   API_VERSION = "v1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: iron_bank
 version: !ruby/object:Gem::Version
-  version: 3.3.4
+  version: 3.4.0
 platform: ruby
 authors:
 - Mickael Pham
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-08-22 00:00:00.000000000 Z
+date: 2019-09-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bump
@@ -187,14 +187,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: '0.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: '0.9'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
@@ -349,7 +349,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: An opinionated Ruby interface to the Zuora API.