iron_bank 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 7b44c23ef147468febcaa424fc386905e956383b
-  data.tar.gz: c75b2d1b28b9b46ade61e3b3a2500c9908fefab3
+SHA256:
+  metadata.gz: 8234b3d722f4748c284fd3d3e0a1e813e9f41835156937971cb8777e6fb3df94
+  data.tar.gz: 3009116645a7c107b0d046993d4b75df937f04c0ef68e6547fb5aebcff3ce873
 SHA512:
-  metadata.gz: a79828f6152c630e86f4e56b25d95cb533d4e66ce348ac623c486c962944165b8d0b0d388beea9a116b04997a02d0b4692c7ce7ac7c9c36b5be82abcb3eaab41
-  data.tar.gz: d323fbda75c7d13afe62b8a2f02ef363bd7268cea1427b5016442fb077e08de23feb27366d6dab0b11a7f4a12f7039b2333e8958d7823dd250b868319ba6033b
+  metadata.gz: e327dc8139567cec93b02a5dce35bce8f83031f6481b78d6f021a4556415b3a1e2a04aeb789e49eca4e32c70efabb0759396ec276b5bba5337d99115b8c78adc
+  data.tar.gz: caaf42d97da52409e99c1f777a1b2b2f200a49728ad9aa3a4b0bf892ca6f1fac17ce67dbf29f109d4fb129161d1c116b36fb5d30a2a8bc09161f184e30e5c733

data/.reek.yml

@@ -60,6 +60,7 @@ detectors:
       - IronBank::Schema#self.import
       - IronBank::Local#where
       - IronBank::Local#load_records
+      - IronBank::LocalRecords#export
       - IronBank::Resources::ProductRatePlanChargeTier#self.load_records
 
   NilCheck:

data/lib/iron_bank/local.rb

@@ -43,18 +43,25 @@ module IronBank
         # this line, delete the other one, since `Hash#compact` is available in
         # 2.4.x and we can remove two smells from `.reek` while we are at it
         #
-        # store[row['Id']] = new(row.to_h.compact)
-        store[row['Id']] = new(row.to_h.reject { |_, value| value.nil? })
+        # store[row[:id]] = new(row.to_h.compact)
+        store[row[:id]] = new(row.to_h.reject { |_, value| value.nil? })
       end
     end
 
     def csv_options
       {
-        headers:    true,
-        converters: csv_converters
+        headers:           true,
+        header_converters: header_converters,
+        converters:        csv_converters
       }
     end
 
+    def header_converters
+      %i[
+        symbol
+      ]
+    end
+
     def csv_converters
       %i[
         decimal_integer

data/lib/iron_bank/local_records.rb

@@ -24,7 +24,8 @@ module IronBank
 
     def export
       CSV.open(file_path, 'w') do |csv|
-        csv << klass.fields # headers
+        # first row = CSV headers
+        csv << klass.fields.map { |field| IronBank::Utils.underscore(field) }
         write_records(csv)
       end
     end

data/lib/iron_bank/metadata.rb

@@ -28,8 +28,8 @@ module IronBank
 
     def with_schema
       fields.each do |field|
-        method_name = IronBank::Utils.underscore(field)
-        define_method(:"#{method_name}") { remote[field] }
+        field_name = IronBank::Utils.underscore(field).to_sym
+        define_method(:"#{field_name}") { remote[field_name] }
       end
     end
   end

data/lib/iron_bank/queryable.rb

@@ -8,9 +8,11 @@ module IronBank
     def find(id)
       raise IronBank::NotFound unless id
 
-      new(
-        IronBank.client.connection.get("v1/object/#{object_name}/#{id}").body
+      response = IronBank.client.connection.get(
+        "v1/object/#{object_name}/#{id}"
       )
+
+      new(IronBank::Object.new(response.body).deep_underscore)
     end
 
     # This methods leverages the fact that Zuora only returns 2,000 records at a
@@ -23,10 +25,10 @@ module IronBank
       query_result = client.query(query_string) # up to 2k records from Zuora
 
       loop do
-        query_result['records'].each { |data| yield new(data) }
-        break if query_result['done']
+        query_result[:records].each { |data| yield new(data) }
+        break if query_result[:done]
 
-        query_result = client.query_more(query_result['queryLocator'])
+        query_result = client.query_more(query_result[:queryLocator])
       end
     end
 
@@ -44,7 +46,7 @@ module IronBank
       # FIXME: need to use logger instance instead
       # puts "query: #{query_string}"
 
-      records = IronBank::Query.call(query_string)['records']
+      records = IronBank::Query.call(query_string)[:records]
       return [] unless records
 
       records.each.with_object([]) do |data, result|

data/lib/iron_bank/resource.rb

@@ -31,7 +31,7 @@ module IronBank
     # Every Zuora object has an ID, so we can safely declare it for each
     # resource
     def id
-      remote['Id']
+      remote[:id]
     end
 
     def inspect
@@ -56,7 +56,7 @@ module IronBank
 
     def to_csv_row
       self.class.fields.each.with_object([]) do |field, row|
-        row << remote[field]
+        row << remote[IronBank::Utils.underscore(field).to_sym]
       end
     end
 

data/lib/iron_bank/resources/invoice.rb

@@ -30,7 +30,7 @@ module IronBank
       # We can only retrieve one invoice body at a time, hence Body is excluded
       # from the query fields, but is populated using the `find` class method
       def body
-        remote['Body'] || reload['Body']
+        remote[:body] || reload[:body]
       end
     end
   end

data/lib/iron_bank/resources/product_rate_plan_charge_tier.rb

@@ -36,7 +36,7 @@ module IronBank
       # discount-fixed amount and regular pricing).
       def to_csv_row
         ProductRatePlanChargeTier.fields.each.with_object([]) do |field, row|
-          row << remote[field]
+          row << remote[IronBank::Utils.underscore(field).to_sym]
         end
       end
 
@@ -44,15 +44,15 @@ module IronBank
         CSV.foreach(file_path, csv_options).with_object({}) do |row, store|
           remote = row.to_h.reject { |_, value| value.nil? }
 
-          record = if remote['DiscountAmount']
+          record = if remote[:discount_amount]
                      CatalogTiers::DiscountAmount.new(remote)
-                   elsif remote['DiscountPercentage']
+                   elsif remote[:discount_percentage]
                      CatalogTiers::DiscountPercentage.new(remote)
                    else
                      CatalogTiers::Price.new(remote)
                    end
 
-          store[row['Id']] = record
+          store[row[:id]] = record
         end
       end
     end

data/lib/iron_bank/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module IronBank
-  VERSION     = '2.0.0'
+  VERSION     = '2.0.1'
   API_VERSION = 'v1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: iron_bank
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Mickael Pham
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-12-08 00:00:00.000000000 Z
+date: 2018-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bump
@@ -380,7 +380,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2.3
+rubygems_version: 2.7.8
 signing_key: 
 specification_version: 4
 summary: An opinionated Ruby interface to the Zuora API.