ircinch 2.4.1 → 2.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3e646f4e5f8d8281a86ddab9727f02ba9ee5c5ebcd874d12aa814a0691d63c9f
-  data.tar.gz: d1a798b6518cbabdfe928a6f56969a5fe1a70cd56ab00ae167da25ccacdae226
+  metadata.gz: de7e4e085fee1303e2bcca842721d58d57748d597b392c2f914a25bd2e6a30ef
+  data.tar.gz: 8aae2cfb9b253be5bb25aed45f05f1bb26de5b0acad85f732dbde1d9b7a54268
 SHA512:
-  metadata.gz: c75cb5184abbe64e61277332f9d1e64c7c143a5767d7732455e608ba1c2d1f73eeaefbc4da64f27d252b4c755e591fc49ad024fb3524e0624b03ebd852bb2488
-  data.tar.gz: a7cfa92fcfd22caf28ee5d211db38a04533b7b845a8ffc562ae87ed34864d2a439294b76bd8018eeabdeded96d719a8b0ae91bf690a43a30c43f6851b9e7966b
+  metadata.gz: 3a6fa7c8ab22c8afaf2426e2ac39321587b490a7a9cd186f7b025a10758286879d77e945dbc45089ffc23564725f74bad9c77b2bdd9f4223b8ee5a7373197627
+  data.tar.gz: 7ee970b4665d0e682d8e1382330d6b36809d967f485997717f2d37a96d2c9f14a244d96de00d4fd45bd0f8c57682160439b980f697b18c6044ffc44fcadacd3c

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+* IRCinch 2.4.2, 3 April 2025
+  - Improve Gemspec metadata
+  - Performance and linting improvements
+
 * IRCinch 2.4.1, 1 April 2025
   - Gemspec updates for compatibility with Ruby >= 3.4.0
   - Minor readme and documentation updates

data/ircinch.gemspec

@@ -14,9 +14,14 @@ Gem::Specification.new do |spec|
   spec.license = "MIT"
   spec.required_ruby_version = ">= 3.2.0"
 
-  spec.metadata["homepage_uri"] = spec.homepage
-  spec.metadata["source_code_uri"] = "https://github.com/ircinchrb/ircinch"
-  spec.metadata["changelog_uri"] = "https://github.com/ircinchrb/ircinch/blob/main/CHANGELOG.md"
+  spec.metadata = {
+    "bug_tracker_uri" => "https://github.com/ircinchrb/ircinch/issues",
+    "changelog_uri" => "https://github.com/ircinchrb/ircinch/blob/main/CHANGELOG.md",
+    "documentation_uri" => "https://rubydoc.info/gems/ircinch",
+    "homepage_uri" => spec.homepage,
+    "source_code_uri" => "https://github.com/ircinchrb/ircinch",
+    "rubygems_mfa_required" => "true"
+  }
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.

data/lib/cinch/channel.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require "set"
-
 require_relative "target"
 
 module Cinch
@@ -418,7 +416,7 @@ module Cinch
         # allow colors.
         text = Cinch::Formatting.unformat(text)
       end
-      super(text, notice)
+      super
     end
     alias_method :msg, :send # deprecated
     alias_method :privmsg, :send # deprecated

data/lib/cinch/configuration.rb

@@ -14,7 +14,7 @@ module Cinch
 
     def initialize(base = nil)
       base ||= self.class.default_config
-      super(base)
+      super
     end
 
     # @return [Hash]

data/lib/cinch/exceptions.rb

@@ -32,7 +32,7 @@ module Cinch
     # doesn't support yet.
     class UnsupportedMode < Generic
       def initialize(mode)
-        super "Cinch does not support the mode '#{mode}' yet."
+        super("Cinch does not support the mode '#{mode}' yet.")
       end
     end
 

data/lib/cinch/handler_list.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require "set"
-
 require_relative "cached_list"
 
 module Cinch

data/lib/cinch/irc.rb

@@ -504,7 +504,7 @@ module Cinch
           end
         elsif direction == :add
           # channel options
-          msg.channel.modes_unsynced[mode] = param.nil? ? true : param
+          msg.channel.modes_unsynced[mode] = param.nil? || param
         else
           msg.channel.modes_unsynced.delete(mode)
         end

data/lib/cinch/logger.rb

@@ -133,7 +133,7 @@ module Cinch
     private
 
     def format_message(message, level)
-      __send__ "format_#{level}", message
+      __send__ :"format_#{level}", message
     end
 
     def format_general(message)

data/lib/cinch/message.rb

@@ -357,7 +357,7 @@ module Cinch
     end
 
     def parse_error
-      return @command.to_i if numeric_reply? && @command[/[45]\d\d/]
+      @command.to_i if numeric_reply? && @command[/[45]\d\d/]
     end
 
     def parse_message

data/lib/cinch/network.rb

@@ -41,13 +41,13 @@ module Cinch
     # @return [String, nil] The mode used for getting the list of
     #   channel owners, if any
     def owner_list_mode
-      return "q" if @ircd == :unreal || @ircd == :inspircd
+      "q" if @ircd == :unreal || @ircd == :inspircd
     end
 
     # @return [String, nil] The mode used for getting the list of
     #   channel quiets, if any
     def quiet_list_mode
-      return "q" if @ircd == :"ircd-seven"
+      "q" if @ircd == :"ircd-seven"
     end
 
     # @return [Boolean] Does WHOIS only support one argument?

data/lib/cinch/plugin.rb

@@ -163,11 +163,11 @@ module Cinch
         when 1
           # {:key => value, ...}
           args.first.each do |key, value|
-            send("#{key}=", value)
+            send(:"#{key}=", value)
           end
         when 2
           # key, value
-          send("#{args.first}=", args.last)
+          send(:"#{args.first}=", args.last)
         else
           raise ArgumentError # TODO proper error message
         end
@@ -367,7 +367,7 @@ module Cinch
         @bot.loggers.debug "[plugin] #{self.class.plugin_name}: Registering CTCP `#{ctcp}`"
         new_handler = Handler.new(@bot, :ctcp, Pattern.generate(:ctcp, ctcp)) do |message, *args|
           if self.class.call_hooks(:pre, :ctcp, nil, self, [message])
-            __send__("ctcp_#{ctcp.downcase}", message, *args)
+            __send__(:"ctcp_#{ctcp.downcase}", message, *args)
             self.class.call_hooks(:post, :ctcp, nil, self, [message])
           else
             @bot.loggers.debug "[plugin] #{self.class.plugin_name}: Dropping message due to hook"

data/lib/cinch/rubyext/module.rb

@@ -12,7 +12,7 @@ class Module
       attr(attribute)
     end
 
-    define_method("#{attribute}_unsynced") do
+    define_method(:"#{attribute}_unsynced") do
       attr(attribute, false, true)
     end
   end

data/lib/cinch/sasl/diffie_hellman.rb

@@ -40,7 +40,7 @@ module Cinch
         result = 1
         while e > 0
           result = (result * b) % m if e[0] == 1
-          e = e >> 1
+          e >>= 1
           b = (b * b) % m
         end
         result

data/lib/cinch/syncable.rb

@@ -33,7 +33,7 @@ module Cinch
       if data
         @data[attribute] = value
       else
-        instance_variable_set("@#{attribute}", value)
+        instance_variable_set(:"@#{attribute}", value)
       end
       @synced_attributes << attribute
     end
@@ -70,7 +70,7 @@ module Cinch
       if data
         @data[attribute]
       else
-        instance_variable_get("@#{attribute}")
+        instance_variable_get(:"@#{attribute}")
       end
     end
 

data/lib/cinch/target.rb

@@ -138,7 +138,7 @@ module Cinch
     # @param [#to_s] message the ctcp message
     # @return [void]
     def ctcp(message)
-      send "\001#{message}\001"
+      send :"\001#{message}\001"
     end
 
     def concretize

data/lib/cinch/user.rb

@@ -135,13 +135,13 @@ module Cinch
     def unknown_unsynced
       attr(:unknown?, true, true)
     end
-    alias_method :"unknown?_unsynced", "unknown_unsynced"
+    alias_method :"unknown?_unsynced", :unknown_unsynced
 
     # @private
     def online_unsynced
       attr(:online?, true, true)
     end
-    alias_method :"online?_unsynced", "online_unsynced"
+    alias_method :"online?_unsynced", :online_unsynced
 
     # @private
     def channels_unsynced
@@ -152,14 +152,14 @@ module Cinch
     def secure_unsynced
       attr(:secure?, true, true)
     end
-    alias_method :"secure?_unsynced", "secure_unsynced"
+    alias_method :"secure?_unsynced", :secure_unsynced
 
     # @private
     # @since 2.1.0
     def oper_unsynced
       attr(:oper?, true, true)
     end
-    alias_method :"oper?_unsynced", "oper_unsynced"
+    alias_method :"oper?_unsynced", :oper_unsynced
 
     # By default, you can use methods like {#user}, {#host} and
     # alike – If you however fear that another thread might change

data/lib/cinch/version.rb

@@ -2,5 +2,5 @@
 
 module Cinch
   # Version of the library
-  VERSION = "2.4.1"
+  VERSION = "2.4.2"
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ircinch
 version: !ruby/object:Gem::Version
-  version: 2.4.1
+  version: 2.4.2
 platform: ruby
 authors:
 - Matt Sias
 bindir: exe
 cert_chain: []
-date: 2025-04-02 00:00:00.000000000 Z
+date: 2025-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ostruct
@@ -235,9 +235,12 @@ homepage: https://github.com/ircinchrb/ircinch
 licenses:
 - MIT
 metadata:
+  bug_tracker_uri: https://github.com/ircinchrb/ircinch/issues
+  changelog_uri: https://github.com/ircinchrb/ircinch/blob/main/CHANGELOG.md
+  documentation_uri: https://rubydoc.info/gems/ircinch
   homepage_uri: https://github.com/ircinchrb/ircinch
   source_code_uri: https://github.com/ircinchrb/ircinch
-  changelog_uri: https://github.com/ircinchrb/ircinch/blob/main/CHANGELOG.md
+  rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths:
 - lib