ips_validator 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 84e2a867d99b29d8b972d5d647814596c7c096873428a9292184e8eb87c0d940
-  data.tar.gz: 1a6fa284f4c0a9c00be098d425c054a19492ed08930c2692a4eb12d9bb05b2d5
+  metadata.gz: d00c478e2dd921147cda18b9ab576f51ff1b0c1ca2047f1d51289bd409cb33d1
+  data.tar.gz: 01f40ecedc1e9a4e6a5c5d412d1f81bf2371b60c70771ea03411ffab36a9d074
 SHA512:
-  metadata.gz: b910e881c9dc2e09c73ea3bc7973b41ca81a2069ec36a4bd27e87ce7a6018fb3c73c19cbd0b0668aefb3feb5ee816faa39f2e63dc567c0da5425bcd332d4690c
-  data.tar.gz: 3d266d33519c082db2d0456f62bed9a3fdd1b98604b4eb7da0b7da0991855ffef064e55c0b3e11806bd9b01cd868fd1b9d326e2945a740747146dd590855a458
+  metadata.gz: 3d87e7f9cc904c1194853d0442f14b7511ac8d017292777d1511be8728a19b09edbbd760535e12b5a6bc095eda6ac06890a76dd27673a4a21a6e4e091e0fa0fa
+  data.tar.gz: 167730fd7124f681077d2736efb3bedfca3c8ca64974d778e155790f8e929830ed706b81f997037b2142f81a0627957a5222eda2b740b79162d759ec7a8b8684

data/ips_validator.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.email         = ["@bakaoh"]
 
   spec.summary       = "Small library to check if Improvement Proposals(IPs) have valid front matter"
-  spec.homepage      = "https://github.com/thefortube"
+  spec.homepage      = "https://github.com/thefortube/ips_validator"
   spec.license       = "MIT"
 
   # Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'

data/lib/ips_validator.rb

@@ -5,7 +5,7 @@ require 'ips_validator/validator'
 module IpsValidator
   class Runner
     class << self  
-      def run(file_names)
+      def run(args)
         num_valid = 0
         num_invalid = 0
         num_error = 0
@@ -15,11 +15,15 @@ module IpsValidator
         types = []
         categories = []
         layers = []
+        xip = args[0].to_sym
+        file_names = args[1..-1]
+        
         file_names.map do |file_name|
           attributes = Loader.load(file_name)
           total+=1
           begin 
-            v = Validator.new(attributes)
+            validator = ValidatorFactory.make(xip)
+            v = validator.new(attributes)
             if v.valid?
               num_valid+=1      
             else

data/lib/ips_validator/validator.rb

@@ -1,28 +1,56 @@
 require 'active_model'
 
 module IpsValidator
-  class Validator
-    def initialize(opts = {})
-      # ruby does not allow method with -
-      # replaces - with _
-      opts.keys.each do |key|
-        raise("#{key} incude _ which is not allowed") if key.to_s.match(/_/)
-        if key.to_s.match(/-/)
-          new_key = opts.keys.last.to_s.gsub('-','_')
-          opts[new_key] = opts.delete key
+  class ValidatorFactory
+    def self.make(name)
+      Class.new do
+        def initialize(opts = {})
+          # ruby does not allow method with -
+          # replaces - with _
+          opts.keys.each do |key|
+            raise("#{key} incude _ which is not allowed") if key.to_s.match(/_/)
+            if key.to_s.match(/-/)
+              new_key = opts.keys.last.to_s.gsub('-','_')
+              opts[new_key] = opts.delete key
+            end
+          end
+          super(opts)
         end
+    
+        include ActiveModel::Model
+        attr_accessor name, :title, :author, :status, :created, :updated, :implementation
+        attr_accessor :replaces, :requires, :layer, :resolution
+        # replace - with _
+        attr_accessor :discussions_to, :superseded_by, :review_period_end
+        validates_presence_of :title, :author, :status, :created
+        validates name, presence: true
+        validates_inclusion_of :status, in: ['WIP', 'Proposed', 'Approved', 'Implemented', 'Rejected']
       end
-      super(opts)
     end
-
-    include ActiveModel::Model
-    attr_accessor :fip, :title, :author, :status, :created, :updated
-    attr_accessor :replaces, :requires, :layer, :resolution
-    # replace - with _
-    attr_accessor :discussions_to, :superseded_by, :review_period_end
-    validates_presence_of :title, :author, :status, :created
-    validates :fip, presence: true
-    validates_inclusion_of :status, in: ['WIP', 'Proposed', 'Approved', 'Implemented', 'Rejected']
   end
+
+  # class Validator
+  #   def initialize(opts = {})
+  #     # ruby does not allow method with -
+  #     # replaces - with _
+  #     opts.keys.each do |key|
+  #       raise("#{key} incude _ which is not allowed") if key.to_s.match(/_/)
+  #       if key.to_s.match(/-/)
+  #         new_key = opts.keys.last.to_s.gsub('-','_')
+  #         opts[new_key] = opts.delete key
+  #       end
+  #     end
+  #     super(opts)
+  #   end
+
+  #   include ActiveModel::Model
+  #   attr_accessor :fip, :title, :author, :status, :created, :updated
+  #   attr_accessor :replaces, :requires, :layer, :resolution
+  #   # replace - with _
+  #   attr_accessor :discussions_to, :superseded_by, :review_period_end
+  #   validates_presence_of :title, :author, :status, :created
+  #   validates :fip, presence: true
+  #   validates_inclusion_of :status, in: ['WIP', 'Proposed', 'Approved', 'Implemented', 'Rejected']
+  # end
 end
 

data/lib/ips_validator/version.rb

@@ -1,3 +1,3 @@
 module IpsValidator
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ips_validator
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Bakaoh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-10-13 00:00:00.000000000 Z
+date: 2020-10-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -102,7 +102,7 @@ files:
 - lib/ips_validator/loader.rb
 - lib/ips_validator/validator.rb
 - lib/ips_validator/version.rb
-homepage: https://github.com/thefortube
+homepage: https://github.com/thefortube/ips_validator
 licenses:
 - MIT
 metadata: {}