iodine 0.7.28 → 0.7.29

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b76690963cd5e669bee41bd2859f60164c3a9ce4dbcc56706864fe05ce5db049
-  data.tar.gz: cebe9da9b5206d2229e1ecefac594c26ffb548e0ff25aefba5429f0724e8a97f
+  metadata.gz: e99acc46ab75628917f405a1ef7aa08c38434f03b0210b2fd1300ddbf4cf5874
+  data.tar.gz: 05a8b2b8bcddebcb85f61257e9ab9aa762a72afba0f7b4dc569e32d1a97ebeb6
 SHA512:
-  metadata.gz: d9799ff98973047f253fafedcb3f5dc70b2e7f04409c0eb415093e1d984eea3996f6b2cd7ee2dc87fbdacd94653a95299857f4bae5146188c91e9a656add6b36
-  data.tar.gz: f422ac357af80a1a60a5ffe4940cf25afce4132aae41aae9f94048f8e6250e43b1d0aca09bedf4f9dbc1e7f733f5b7c6c3fab12d5fe4ef6cbaa48d4923196554
+  metadata.gz: bb038db0614b5c2bbda474c3c5ce25ba14ec0e70990ef799532754340842cec8aec44e52c8b3d93eec76a5d10e055948c0f3d8a5ee9eee92bf18449b8ef49f60
+  data.tar.gz: d5c078cf9d5a30d2f35c34935bb24a556c65680642c269544730cc420971de12eb90b8497303b4dfd6d971e8d9b22399a37bb21b85d804fecdf49f922b123772

data/CHANGELOG.md

@@ -6,6 +6,10 @@ Please notice that this change log contains changes for upcoming releases as wel
 
 ## Changes:
 
+#### Change log v.0.7.29
+
+**Fix**: fixed an issue where `env['rack.input'].read(nil, nil)` would return `nil` instead of `""` on zero-content requests (i.e., an empty POST request). Credit to @thexa4 (Max Maton) for exposing this issue and providing a POC for debugging (issue #71).
+
 #### Change log v.0.7.28
 
 **Fix**: fixed an issue where iodine would crush (or hang) if unprotected exceptions were raised within a response body's `each` loop. This also fixes Fiber support when streaming with Roda (note: iodine will concat the body in a buffer before sending it). Credit to @adam12 (Adam Daniels) both for exposing the issue (#70) and testing possible solutions.

data/ext/iodine/fio.c

@@ -5101,17 +5101,21 @@ typedef enum fio_cluster_message_type_e {
 
 typedef struct fio_collection_s fio_collection_s;
 
-#pragma pack(1)
+#ifndef __clang__ /* clang might misbehave by assumming non-alignment */
+#pragma pack(1)   /* https://gitter.im/halide/Halide/archives/2018/07/24 */
+#endif
 typedef struct {
   size_t name_len;
   char *name;
-  size_t ref;
+  volatile size_t ref;
   fio_ls_embd_s subscriptions;
   fio_collection_s *parent;
   fio_match_fn match;
   fio_lock_i lock;
 } channel_s;
+#ifndef __clang__
 #pragma pack()
+#endif
 
 struct subscription_s {
   fio_ls_embd_s node;

data/ext/iodine/iodine_rack_io.c

@@ -111,12 +111,13 @@ static VALUE rio_gets(VALUE self) {
 // Reads data from the IO, according to the Rack specifications for `#read`.
 static VALUE rio_read(int argc, VALUE *argv, VALUE self) {
   FIOBJ io = get_data(self);
-  if (!FIOBJ_TYPE_IS(io, FIOBJ_T_DATA))
-    return Qnil;
-
   VALUE buffer = Qnil;
-  char ret_nil = 0;
+  uint8_t ret_nil = 0;
   ssize_t len = 0;
+  if (!FIOBJ_TYPE_IS(io, FIOBJ_T_DATA)) {
+    return (argc > 0 && argv[0] != Qnil) ? Qnil : rb_str_buf_new(0);
+  }
+
   // get the buffer object if given
   if (argc == 2) {
     Check_Type(argv[1], T_STRING);
@@ -149,10 +150,7 @@ static VALUE rio_read(int argc, VALUE *argv, VALUE self) {
     }
     return buffer;
   }
-  if (ret_nil)
-    return Qnil;
-  else
-    return rb_str_buf_new(0);
+  return ret_nil ? Qnil : rb_str_buf_new(0);
 }
 
 // Does nothing - this is controlled by the server.

data/lib/iodine/version.rb

@@ -1,3 +1,3 @@
 module Iodine
-  VERSION = '0.7.28'.freeze
+  VERSION = '0.7.29'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iodine
 version: !ruby/object:Gem::Version
-  version: 0.7.28
+  version: 0.7.29
 platform: ruby
 authors:
 - Boaz Segev
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-03-30 00:00:00.000000000 Z
+date: 2019-04-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -202,7 +202,7 @@ licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-post_install_message: 'Thank you for installing Iodine 0.7.28.
+post_install_message: 'Thank you for installing Iodine 0.7.29.
 
 '
 rdoc_options: []