iodine 0.7.25 → 0.7.26

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 78a87730fe356cbad1e97b0f8b236aa0d11922a5f4d9a2bc0dcd0b2d78ed76b9
-  data.tar.gz: 78867a8cb0fa36d09a642e1bde58226e7bc1db8286890d2fa393021607e05319
+  metadata.gz: cef74e69c89b287a19db0fdfe5dfe4d54df7e33026d786832aebb6e431457efa
+  data.tar.gz: 86a85ce79660e0df9bcd56b66a6ebd5d1274e29f83bffc1f004acf7bd99bbfe4
 SHA512:
-  metadata.gz: c300c420d934e36214360481db13975971934d34566c172e301b3f9432263bdbb1a8fe3fec0002dab56485749cc49519d940735ef21d545b0b83fa5bd5cd024e
-  data.tar.gz: d38221c36a4a2c889d68e0992b8e1da0f62ad93a5114b4dc74953f72d5dd959bb71b82b3a28b2b2913b0251f983e8d30b5e0c7d4f9fb4b3e930f272e7424d9db
+  metadata.gz: b0d9c2b9730b802c9c085f820243ee20621ec845cde85411927a38661f903cf75792d143d163498bd5597c4301df38a881c123b604edee0bdfbe72b71bc2aab8
+  data.tar.gz: 16fd00d1387cf1aab22c58091abded717aca527b912dbdd7dc358eaec9d18a16b16919ad77177dc50d358c465c96af77dfa35433c95e1ad6ff67e585feb7b341

data/CHANGELOG.md

@@ -6,6 +6,14 @@ Please notice that this change log contains changes for upcoming releases as wel
 
 ## Changes:
 
+#### Change log v.0.7.26
+
+**Fix**: (`http`) fixed HTTP date format to force the day of the month to use two digits. Credit to @ianks (Ian Ker-Seymer) for exposing this issue (issue #64).
+
+**Fix**: (`iodine`) fixed static file service without an application (when using iodine as a stand-alone static file server).
+
+**Fix**: (`fio`) miscellaneous compatibility updates.
+
 #### Change log v.0.7.25
 
 **Fix**: (`iodine`) fixed host name binding when running `iodine` using `rackup` or through `Rack`. Credit to @adam12 (Adam Daniels) for PR #60.

data/exe/iodine

@@ -37,6 +37,7 @@ module Iodine
           if Iodine::DEFAULT_SETTINGS[:public]
             puts "         Running only static file service."
             opt = ::Rack::Server::Options.new.parse!([])
+            app = Proc.new { [404, {}, "Not Found!"] }
           else
             puts "\nERROR: Couldn't run Ruby application, check command line arguments."
             ARGV << "-?"

data/ext/iodine/fio.c

@@ -52,14 +52,6 @@ Feel free to copy, use and enjoy according to the license provided.
 #endif
 #endif
 
-#if FIO_ENGINE_EPOLL
-#include <sys/epoll.h>
-
-#elif FIO_ENGINE_KQUEUE
-
-#include <sys/event.h>
-#endif
-
 /* for kqueue and epoll only */
 #ifndef FIO_POLL_MAX_EVENTS
 #define FIO_POLL_MAX_EVENTS 64
@@ -90,6 +82,15 @@ Feel free to copy, use and enjoy according to the license provided.
 #define FIO_TLS_WEAK __attribute__((weak))
 #endif
 
+/* Mitigates MAP_ANONYMOUS not being defined on older versions of MacOS */
+#if !defined(MAP_ANONYMOUS)
+#if defined(MAP_ANON)
+#define MAP_ANONYMOUS MAP_ANON
+#else
+#define MAP_ANONYMOUS 0
+#endif
+#endif
+
 /* *****************************************************************************
 Event deferring (declarations)
 ***************************************************************************** */
@@ -1619,6 +1620,7 @@ Section Start Marker
 
 ***************************************************************************** */
 #if FIO_ENGINE_EPOLL
+#include <sys/epoll.h>
 
 /**
  * Returns a C string detailing the IO engine selected during compilation.
@@ -1779,6 +1781,7 @@ Section Start Marker
 
 ***************************************************************************** */
 #if FIO_ENGINE_KQUEUE
+#include <sys/event.h>
 
 /**
  * Returns a C string detailing the IO engine selected during compilation.
@@ -2318,8 +2321,11 @@ int fio_set_non_block(int fd) {
   int flags;
   if (-1 == (flags = fcntl(fd, F_GETFL, 0)))
     flags = 0;
-  // printf("flags initial value was %d\n", flags);
+#ifdef O_CLOEXEC
   return fcntl(fd, F_SETFL, flags | O_NONBLOCK | O_CLOEXEC);
+#else
+  return fcntl(fd, F_SETFL, flags | O_NONBLOCK);
+#endif
 #elif defined(FIONBIO)
   /* Otherwise, use the old way of doing it */
   static int flags = 1;
@@ -2591,13 +2597,10 @@ Internal socket flushing related functions
 #if !defined(USE_SENDFILE) && !defined(USE_SENDFILE_LINUX) &&                  \
     !defined(USE_SENDFILE_BSD) && !defined(USE_SENDFILE_APPLE)
 #if defined(__linux__) /* linux sendfile works  */
-#include <sys/sendfile.h>
 #define USE_SENDFILE_LINUX 1
 #elif defined(__FreeBSD__) /* FreeBSD sendfile should work - not tested */
-#include <sys/uio.h>
 #define USE_SENDFILE_BSD 1
 #elif defined(__APPLE__) /* Is the apple sendfile still broken? */
-#include <sys/uio.h>
 #define USE_SENDFILE_APPLE 2
 #else /* sendfile might not be available - always set to 0 */
 #define USE_SENDFILE 0
@@ -2675,6 +2678,7 @@ read_error:
 }
 
 #if USE_SENDFILE_LINUX /* linux sendfile API */
+#include <sys/sendfile.h>
 
 static int fio_sock_sendfile_from_fd(int fd, fio_packet_s *packet) {
   ssize_t sent;
@@ -2688,7 +2692,8 @@ static int fio_sock_sendfile_from_fd(int fd, fio_packet_s *packet) {
   return sent;
 }
 
-#elif USE_SENDFILE_LINUX_BSD || USE_SENDFILE_APPLE /* FreeBSD / Apple API */
+#elif USE_SENDFILE_BSD || USE_SENDFILE_APPLE /* FreeBSD / Apple API */
+#include <sys/uio.h>
 
 static int fio_sock_sendfile_from_fd(int fd, fio_packet_s *packet) {
   off_t act_sent = 0;
@@ -2717,7 +2722,7 @@ error:
 }
 
 #else
-static int (*fio_sock_sendfile_from_fd)(int fd, struct packet_s *packet) =
+static int (*fio_sock_sendfile_from_fd)(int fd, fio_packet_s *packet) =
     fio_sock_write_from_fd;
 
 #endif
@@ -3533,7 +3538,8 @@ static void __attribute__((destructor)) fio_lib_destroy(void) {
   fio_free(fio_data);
   /* memory library destruction must be last */
   fio_mem_destroy();
-  FIO_LOG_DEBUG("(%d) facil.io resources released, exit complete.", getpid());
+  FIO_LOG_DEBUG("(%d) facil.io resources released, exit complete.",
+                (int)getpid());
   if (add_eol)
     fprintf(stderr, "\n"); /* add EOL to logs (logging adds EOL before text */
 }
@@ -3762,7 +3768,7 @@ static void fio_worker_startup(void) {
     fio_data->is_worker = 1;
   } else if (fio_data->is_worker) {
     /* Worker Process */
-    FIO_LOG_INFO("%d is running.", getpid());
+    FIO_LOG_INFO("%d is running.", (int)getpid());
   } else {
     /* Root Process should run in single thread mode */
     fio_data->threads = 1;
@@ -3786,7 +3792,7 @@ static void fio_worker_startup(void) {
 static void fio_worker_cleanup(void) {
   /* switch to winding down */
   if (fio_data->is_worker)
-    FIO_LOG_INFO("(%d) detected exit signal.", getpid());
+    FIO_LOG_INFO("(%d) detected exit signal.", (int)getpid());
   else
     FIO_LOG_INFO("Server Detected exit signal.");
   fio_state_callback_force(FIO_CALL_ON_SHUTDOWN);
@@ -3815,7 +3821,7 @@ static void fio_worker_cleanup(void) {
   if (fio_data->parent == getpid()) {
     FIO_LOG_INFO("   ---  Shutdown Complete  ---\n");
   } else {
-    FIO_LOG_INFO("(%d) cleanup complete.", getpid());
+    FIO_LOG_INFO("(%d) cleanup complete.", (int)getpid());
   }
 }
 
@@ -3849,11 +3855,12 @@ static void *fio_sentinel_worker_thread(void *arg) {
       /* don't call any functions while forking. */
       fio_lock(&fio_fork_lock);
       if (!WIFEXITED(status) || WEXITSTATUS(status)) {
-        FIO_LOG_ERROR("Child worker (%d) crashed. Respawning worker.", child);
+        FIO_LOG_ERROR("Child worker (%d) crashed. Respawning worker.",
+                      (int)child);
         fio_state_callback_force(FIO_CALL_ON_CHILD_CRUSH);
       } else {
         FIO_LOG_WARNING("Child worker (%d) shutdown. Respawning worker.",
-                        child);
+                        (int)child);
       }
       fio_defer_push_task(fio_sentinel_task, NULL, NULL);
       fio_unlock(&fio_fork_lock);
@@ -3917,7 +3924,7 @@ void fio_start FIO_IGNORE_MACRO(struct fio_start_args args) {
       "* Press ^C to stop\n",
       fio_data->workers, fio_data->workers > 1 ? "workers" : "worker",
       fio_data->threads, fio_data->threads > 1 ? "threads" : "thread",
-      fio_engine(), fio_data->capa, fio_data->parent);
+      fio_engine(), fio_data->capa, (int)fio_data->parent);
 
   if (args.workers > 1) {
     for (int i = 0; i < args.workers && fio_data->active; ++i) {
@@ -4496,9 +4503,9 @@ static void fio_listen_on_startup(void *pr_) {
   fio_listen_protocol_s *pr = pr_;
   fio_attach(pr->uuid, &pr->pr);
   if (pr->port_len)
-    FIO_LOG_DEBUG("(%d) started listening on port %s", getpid(), pr->port);
+    FIO_LOG_DEBUG("(%d) started listening on port %s", (int)getpid(), pr->port);
   else
-    FIO_LOG_DEBUG("(%d) started listening on Unix Socket at %s", getpid(),
+    FIO_LOG_DEBUG("(%d) started listening on Unix Socket at %s", (int)getpid(),
                   pr->addr);
 }
 
@@ -5837,7 +5844,7 @@ static struct cluster_data_s {
 static void fio_cluster_data_cleanup(int delete_file) {
   if (delete_file && cluster_data.name[0]) {
 #if DEBUG
-    FIO_LOG_DEBUG("(%d) unlinking cluster's Unix socket.", getpid());
+    FIO_LOG_DEBUG("(%d) unlinking cluster's Unix socket.", (int)getpid());
 #endif
     unlink(cluster_data.name);
   }
@@ -5886,7 +5893,7 @@ static void fio_cluster_init(void) {
   tmp_folder_len += 14;
   tmp_folder_len +=
       snprintf(cluster_data.name + tmp_folder_len,
-               FIO_CLUSTER_NAME_LIMIT - tmp_folder_len, "%d", getpid());
+               FIO_CLUSTER_NAME_LIMIT - tmp_folder_len, "%d", (int)getpid());
   cluster_data.name[tmp_folder_len] = 0;
 
   /* remove if existing */
@@ -5931,7 +5938,7 @@ static void fio_cluster_on_data(intptr_t uuid, fio_protocol_s *pr_) {
       if (c->exp_channel) {
         if (c->exp_channel >= (1024 * 1024 * 16) + 1) {
           FIO_LOG_FATAL("(%d) cluster message name too long (16Mb limit): %u\n",
-                        getpid(), (unsigned int)c->exp_channel);
+                        (int)getpid(), (unsigned int)c->exp_channel);
           exit(1);
           return;
         }
@@ -5939,7 +5946,7 @@ static void fio_cluster_on_data(intptr_t uuid, fio_protocol_s *pr_) {
       if (c->exp_msg) {
         if (c->exp_msg >= (1024 * 1024 * 64) + 1) {
           FIO_LOG_FATAL("(%d) cluster message data too long (64Mb limit): %u\n",
-                        getpid(), (unsigned int)c->exp_msg);
+                        (int)getpid(), (unsigned int)c->exp_msg);
           exit(1);
           return;
         }
@@ -6021,7 +6028,7 @@ static void fio_cluster_on_close(intptr_t uuid, fio_protocol_s *pr_) {
   } else if (fio_data->active) {
     /* no shutdown message received - parent crashed. */
     if (c->type != FIO_CLUSTER_MSG_SHUTDOWN && fio_is_running()) {
-      FIO_LOG_FATAL("(%d) Parent Process crash detected!", getpid());
+      FIO_LOG_FATAL("(%d) Parent Process crash detected!", (int)getpid());
       fio_state_callback_force(FIO_CALL_ON_PARENT_CRUSH);
       fio_state_callback_clear(FIO_CALL_ON_PARENT_CRUSH);
       fio_cluster_data_cleanup(1);
@@ -6184,7 +6191,8 @@ static void fio_cluster_listen_on_close(intptr_t uuid,
   cluster_data.uuid = -1;
   if (fio_parent_pid() == getpid()) {
 #if DEBUG
-    FIO_LOG_DEBUG("(%d) stopped listening for cluster connections", getpid());
+    FIO_LOG_DEBUG("(%d) stopped listening for cluster connections",
+                  (int)getpid());
 #endif
     if (fio_data->active)
       kill(0, SIGINT);
@@ -6210,7 +6218,8 @@ static void fio_listen2cluster(void *ignore) {
       .ping = mock_ping_eternal,
       .on_close = fio_cluster_listen_on_close,
   };
-  FIO_LOG_DEBUG("(%d) Listening to cluster: %s", getpid(), cluster_data.name);
+  FIO_LOG_DEBUG("(%d) Listening to cluster: %s", (int)getpid(),
+                cluster_data.name);
   fio_attach(cluster_data.uuid, p);
   (void)ignore;
 }
@@ -6342,8 +6351,8 @@ static inline void fio_cluster_inform_root_about_channel(channel_s *ch,
   fio_str_info_s ch_name = {.data = ch->name, .len = ch->name_len};
   fio_str_info_s msg = {.data = NULL, .len = 0};
 #if DEBUG
-  FIO_LOG_DEBUG("(%d) informing root about: %s (%zu) msg type %d", getpid(),
-                ch_name.data, ch_name.len,
+  FIO_LOG_DEBUG("(%d) informing root about: %s (%zu) msg type %d",
+                (int)getpid(), ch_name.data, ch_name.len,
                 (ch->match ? (add ? FIO_CLUSTER_MSG_PATTERN_SUB
                                   : FIO_CLUSTER_MSG_PATTERN_UNSUB)
                            : (add ? FIO_CLUSTER_MSG_PUBSUB_SUB
@@ -7143,8 +7152,10 @@ static inline block_s *block_new(void) {
   }
   /* collect memory from the system */
   blk = sys_alloc(FIO_MEMORY_BLOCK_SIZE * FIO_MEMORY_BLOCKS_PER_ALLOCATION, 0);
-  if (!blk)
+  if (!blk) {
+    fio_unlock(&memory.lock);
     return NULL;
+  }
   FIO_LOG_DEBUG("memory allocator allocated %p from the system", (void *)blk);
   FIO_MEMORY_ON_BLOCK_ALLOC();
   block_init_root(blk, blk);
@@ -9418,7 +9429,7 @@ FIO_FUNC void fio_socket_test(void) {
 #else
   fio_str_write(&sock_name, "/tmp", 4);
 #endif
-  fio_str_printf(&sock_name, "/fio_test_sock-%d.sock", getpid());
+  fio_str_printf(&sock_name, "/fio_test_sock-%d.sock", (int)getpid());
 
   fprintf(stderr, "=== Testing facil.io listening socket creation (partial "
                   "testing only).\n");

data/ext/iodine/fio.h

@@ -110,7 +110,7 @@ Version and helper macros
 #define FIO_VERSION_MAJOR 0
 #define FIO_VERSION_MINOR 7
 #define FIO_VERSION_PATCH 0
-#define FIO_VERSION_BETA 8
+#define FIO_VERSION_BETA 9
 
 /* Automatically convert version data to a string constant - ignore these two */
 #define FIO_MACRO2STR_STEP2(macro) #macro
@@ -224,10 +224,16 @@ Version and helper macros
 #define __has_builtin(...) 0
 #define FIO_GNUC_BYPASS 1
 #elif !defined(__clang__) && !defined(__has_builtin)
+/* E.g: GCC < 6.0 doesn't support __has_builtin */
 #define __has_builtin(...) 0
 #define FIO_GNUC_BYPASS 1
 #endif
 
+#if defined(__GNUC__) && (__GNUC__ < 4 || (__GNUC__ == 4 && __GNUC_MINOR__ < 5))
+/* GCC < 4.5 doesn't support deprecation reason string */
+#define deprecated(reason) deprecated
+#endif
+
 #ifndef FIO_FUNC
 #define FIO_FUNC static __attribute__((unused))
 #endif
@@ -2022,7 +2028,8 @@ int fio_pubsub_is_attached(fio_pubsub_engine_s *engine);
 /* Select the correct compiler builtin method. */
 #elif __has_builtin(__sync_add_and_fetch)
 /** An atomic exchange operation, ruturns previous value */
-#define fio_atomic_xchange(p_obj, value) __sync_fetch_and_or((p_obj), (value))
+#define fio_atomic_xchange(p_obj, value)                                       \
+  __sync_val_compare_and_swap((p_obj), *(p_obj), (value))
 /** An atomic addition operation */
 #define fio_atomic_add(p_obj, value) __sync_add_and_fetch((p_obj), (value))
 /** An atomic subtraction operation */
@@ -2030,7 +2037,8 @@ int fio_pubsub_is_attached(fio_pubsub_engine_s *engine);
 
 #elif __GNUC__ > 3
 /** An atomic exchange operation, ruturns previous value */
-#define fio_atomic_xchange(p_obj, value) __sync_fetch_and_or((p_obj), (value))
+#define fio_atomic_xchange(p_obj, value)                                       \
+  __sync_val_compare_and_swap((p_obj), *(p_obj), (value))
 /** An atomic addition operation */
 #define fio_atomic_add(p_obj, value) __sync_add_and_fetch((p_obj), (value))
 /** An atomic subtraction operation */

data/ext/iodine/fiobject.h

@@ -378,7 +378,7 @@ Atomic reference counting
   __atomic_sub_fetch(&FIOBJECT2HEAD(o)->ref, 1, __ATOMIC_SEQ_CST)
 
 /* Select the correct compiler builtin method. */
-#elif defined(__has_builtin)
+#elif defined(__has_builtin) && !FIO_GNUC_BYPASS
 
 #if __has_builtin(__sync_fetch_and_or)
 /** An atomic addition operation */

data/ext/iodine/hpack.h

@@ -786,7 +786,7 @@ void hpack_test(void) {
         tmp = hpack_string_pack(buffer + buf_pos, limit - buf_pos, str1, 56,
                                 (i & 1) == 1);
         if (tmp == -1)
-          fprintf(stderr, "* HPACK STRING PACKING FAIL AT %lu\n", i);
+          fprintf(stderr, "* HPACK STRING PACKING FAIL AT %zu\n", i);
         else if ((size_t)tmp > limit - buf_pos)
           break;
         buf_pos += tmp;
@@ -799,7 +799,7 @@ void hpack_test(void) {
         --i;
         tmp = hpack_string_unpack(result, 56, buffer, limit, &buf_pos);
         if (tmp == -1) {
-          fprintf(stderr, "* HPACK STRING UNPACKING FAIL AT %lu\n",
+          fprintf(stderr, "* HPACK STRING UNPACKING FAIL AT %zu\n",
                   (repeats - 1) - i);
           exit(-1);
         } else if (tmp != 56) {
@@ -811,13 +811,13 @@ void hpack_test(void) {
         }
         if (memcmp(str1, result, 56)) {
           fprintf(stderr,
-                  "* HPACK STRING UNPACKING ERROR AT %lu. Got (%u) %.*s\n",
+                  "* HPACK STRING UNPACKING ERROR AT %zu. Got (%u) %.*s\n",
                   (repeats - 1) - i, tmp, tmp, result);
           exit(-1);
         }
       }
       fprintf(stderr,
-              "* HPACK string primitive test complete (buffer used %u/%zu "
+              "* HPACK string primitive test complete (buffer used %d/%zu "
               "strings)\n",
               count, repeats);
     }

data/ext/iodine/http.c

@@ -18,6 +18,21 @@ Feel free to copy, use and enjoy according to the license provided.
 #include <sys/types.h>
 #include <unistd.h>
 
+#ifndef HAVE_TM_TM_ZONE
+#if defined(__FreeBSD__) || defined(__NetBSD__) || defined(__OpenBSD__) ||     \
+    defined(__DragonFly__) || defined(__bsdi__) || defined(__ultrix) ||        \
+    (defined(__APPLE__) && defined(__MACH__)) ||                               \
+    (defined(__sun) && !defined(__SVR4))
+/* Known BSD systems */
+#define HAVE_TM_TM_ZONE 1
+#elif defined(__GLIBC__) && defined(_BSD_SOURCE)
+/* GNU systems with _BSD_SOURCE */
+#define HAVE_TM_TM_ZONE 1
+#else
+#define HAVE_TM_TM_ZONE 0
+#endif
+#endif
+
 /* *****************************************************************************
 SSL/TLS patch
 ***************************************************************************** */
@@ -2073,11 +2088,20 @@ struct tm *http_gmtime(time_t timer, struct tm *tmbuf) {
   if (timer < 0)
     return gmtime_r(&timer, tmbuf);
   ssize_t a, b;
-  tmbuf->tm_gmtoff = 0;
-  tmbuf->tm_zone = "UTC";
-  tmbuf->tm_isdst = 0;
-  tmbuf->tm_year = 70; // tm_year == The number of years since 1900
-  tmbuf->tm_mon = 0;
+#if HAVE_TM_TM_ZONE
+  *tmbuf = (struct tm){
+      .tm_isdst = 0,
+      .tm_year = 70, // tm_year == The number of years since 1900
+      .tm_mon = 0,
+      .tm_zone = "UTC",
+  };
+#else
+  *tmbuf = (struct tm){
+      .tm_isdst = 0,
+      .tm_year = 70, // tm_year == The number of years since 1900
+      .tm_mon = 0,
+  };
+#endif
   // for seconds up to weekdays, we build up, as small values clean up
   // larger values.
   a = (ssize_t)timer;
@@ -2168,6 +2192,7 @@ static const char *MONTH_NAMES[] = {"Jan ", "Feb ", "Mar ", "Apr ",
 static const char *GMT_STR = "GMT";
 
 size_t http_date2str(char *target, struct tm *tmbuf) {
+  /* note: day of month is always 2 digits */
   char *pos = target;
   uint16_t tmp;
   pos[0] = DAY_NAMES[tmbuf->tm_wday][0];
@@ -2176,15 +2201,10 @@ size_t http_date2str(char *target, struct tm *tmbuf) {
   pos[3] = ',';
   pos[4] = ' ';
   pos += 5;
-  if (tmbuf->tm_mday < 10) {
-    *pos = '0' + tmbuf->tm_mday;
-    ++pos;
-  } else {
-    tmp = tmbuf->tm_mday / 10;
-    pos[0] = '0' + tmp;
-    pos[1] = '0' + (tmbuf->tm_mday - (tmp * 10));
-    pos += 2;
-  }
+  tmp = tmbuf->tm_mday / 10;
+  pos[0] = '0' + tmp;
+  pos[1] = '0' + (tmbuf->tm_mday - (tmp * 10));
+  pos += 2;
   *(pos++) = ' ';
   pos[0] = MONTH_NAMES[tmbuf->tm_mon][0];
   pos[1] = MONTH_NAMES[tmbuf->tm_mon][1];
@@ -2216,6 +2236,7 @@ size_t http_date2str(char *target, struct tm *tmbuf) {
 }
 
 size_t http_date2rfc2822(char *target, struct tm *tmbuf) {
+  /* note: day of month is either 1 or 2 digits */
   char *pos = target;
   uint16_t tmp;
   pos[0] = DAY_NAMES[tmbuf->tm_wday][0];
@@ -2263,7 +2284,9 @@ size_t http_date2rfc2822(char *target, struct tm *tmbuf) {
   return pos - target;
 }
 
+/* HTTP header format for Cookie ages */
 size_t http_date2rfc2109(char *target, struct tm *tmbuf) {
+  /* note: day of month is always 2 digits */
   char *pos = target;
   uint16_t tmp;
   pos[0] = DAY_NAMES[tmbuf->tm_wday][0];
@@ -2272,15 +2295,10 @@ size_t http_date2rfc2109(char *target, struct tm *tmbuf) {
   pos[3] = ',';
   pos[4] = ' ';
   pos += 5;
-  if (tmbuf->tm_mday < 10) {
-    *pos = '0' + tmbuf->tm_mday;
-    ++pos;
-  } else {
-    tmp = tmbuf->tm_mday / 10;
-    pos[0] = '0' + tmp;
-    pos[1] = '0' + (tmbuf->tm_mday - (tmp * 10));
-    pos += 2;
-  }
+  tmp = tmbuf->tm_mday / 10;
+  pos[0] = '0' + tmp;
+  pos[1] = '0' + (tmbuf->tm_mday - (tmp * 10));
+  pos += 2;
   *(pos++) = ' ';
   pos[0] = MONTH_NAMES[tmbuf->tm_mon][0];
   pos[1] = MONTH_NAMES[tmbuf->tm_mon][1];

data/ext/iodine/redis_engine.c

@@ -320,7 +320,7 @@ static void redis_send_next_command_unsafe(redis_engine_s *r) {
         FIO_LS_EMBD_OBJ(redis_commands_s, node, r->queue.next);
     fio_write2(r->pub_data.uuid, .data.buffer = cmd->cmd,
                .length = cmd->cmd_len, .after.dealloc = FIO_DEALLOC_NOOP);
-    FIO_LOG_DEBUG("(redis %d) Sending (%zu bytes):\n%s\n", getpid(),
+    FIO_LOG_DEBUG("(redis %d) Sending (%zu bytes):\n%s\n", (int)getpid(),
                   cmd->cmd_len, cmd->cmd);
   }
 }
@@ -352,7 +352,7 @@ static void resp_on_pub_message(struct redis_engine_internal_s *i, FIOBJ msg) {
   if (!node) {
     /* TODO: possible ping? from server?! not likely... */
     FIO_LOG_WARNING("(redis %d) received a reply when no command was sent.",
-                    getpid());
+                    (int)getpid());
     return;
   }
   node->next = (void *)fiobj_dup(msg);
@@ -657,7 +657,7 @@ static void redis_on_publish_root(const fio_pubsub_engine_s *eng,
   *buf++ = '\r';
   *buf++ = '\n';
   *buf = 0;
-  FIO_LOG_DEBUG("(%d) Publishing:\n%s", getpid(), cmd->cmd);
+  FIO_LOG_DEBUG("(%d) Publishing:\n%s", (int)getpid(), cmd->cmd);
   cmd->cmd_len = (uintptr_t)buf - (uintptr_t)(cmd + 1);
   redis_attach_cmd(r, cmd);
   return;

data/lib/iodine.rb

@@ -130,7 +130,7 @@ module Iodine
       end
     end
 
-    ### trap some signals to avoid exception reports
+    ### trap some signals to avoid excessive exception reports
     begin
       old_sigint = Signal.trap("SIGINT") { old_sigint.call if old_sigint.respond_to?(:call) }
     rescue Exception

data/lib/iodine/version.rb

@@ -1,3 +1,3 @@
 module Iodine
-  VERSION = '0.7.25'.freeze
+  VERSION = '0.7.26'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iodine
 version: !ruby/object:Gem::Version
-  version: 0.7.25
+  version: 0.7.26
 platform: ruby
 authors:
 - Boaz Segev
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-02-22 00:00:00.000000000 Z
+date: 2019-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -201,7 +201,7 @@ licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-post_install_message: 'Thank you for installing Iodine 0.7.25.
+post_install_message: 'Thank you for installing Iodine 0.7.26.
 
 '
 rdoc_options: []