iodine 0.4.15 → 0.4.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 8fae6d0a20c82608a04c0a8845ccc4992810ac6c
-  data.tar.gz: eec0b8600e70903a2433022c7d236c8a315f08d9
+SHA256:
+  metadata.gz: '05830f6522c10a7287f298b6e4b7036ae90c958e28764f485f3e1b231fe8e953'
+  data.tar.gz: 41cfef0ab58ccdcb11f7d9437e6cc9a8454580073c89ad98701dfe9604abba74
 SHA512:
-  metadata.gz: c455f2313d471371eefacf262855f01c5efcffff54e46e06f966eee46cc3de1ea482a9e8547d40d7c04aa631cfd8889070fbd532d6372ea6a70f0b5b8f18d56b
-  data.tar.gz: bbf799a3051dac65311d12dbf287530b36ab873f53b256181a087235ee6f3fbe35fe52528d16364ca169105c3d3b076f3e17bedc960d238889f0395f6df4fbf0
+  metadata.gz: e3ff1d96d782bbf698ea13bd23a57972abcc94e2ce155f4863395efc67a91694997d9f44e1d2dd35e4ec5fd181064242e1ff6fb9f08e3208694b2e582a440b23
+  data.tar.gz: c4a014449954157add87616fa7ffe376499204c02b10d313a44b7edba5ccf1a2e865e98ed883e4b9fbf0be8c00f16d0a7def400f30cb84cc4b391f882d2582b4

data/CHANGELOG.md

@@ -6,52 +6,52 @@ Please notice that this change log contains changes for upcoming releases as wel
 
 ## Changes:
 
-#### Change log v.0.4.15
-
-**Update**: (`facil.io`) updating the facil.io library version to use the 0.5.8 released version.
+---
 
-This includes the following changes (as well as other minor changes), as detailed in facil.io's CHANGELOG:
+#### Change log v.0.4.16
 
-**Fix**: (`defer`, `fiobj`) fix Linux compatibility concerns (when using GCC). Credit goes to @kotocom.
+**Fix**: (`websocket_parser`) The websocket parser had a memory offset and alignment handling issue in it's unmasking (XOR) logic and the new memory alignment protection code. The issue would impact the parser in rare occasions when multiple messages where pipelined in the internal buffer and their length produced an odd alignment (the issue would occur with very fast clients, or a very stressed server).
 
-**Fix**: (`defer`) fixes the non-debug version of the new defer, which didn't define some debug macros.
+#### Change log v.0.4.15
 
-**Updates**: minor updates to the boilerplate documentation and the "new application" creation process.
+**Update**: (`facil.io`) updating the facil.io library version to use the 0.5.8 released version.
 
-**Fix**: Added `cmake_minimum_required` and related CMake fixes to the CMake file and generator. Credit to David Morán (@david-moran) for [PR #22](https://github.com/boazsegev/facil.io/pull/22) fixing the CMakelist.txt.
+This includes the following changes (as well as other minor changes), as detailed in facil.io's CHANGELOG:
 
 **Compatibility**: (`websocket_parser`) removed unaligned memory access from the XOR logic in the parser, making it more compatible with older CPU systems that don't support unaligned memory access or 64 bit word lengths.
 
 **Optimization**: (`defer`) rewrote the data structure to use a hybrid cyclic buffer and linked list for the task queue (instead of a simple linked list), optimizing locality and minimizing memory allocations.
 
-**Misc**: minor updates and tweaks, such as adding the `fiobj_ary2prt` function for operations such as quick sort, updating some documentation etc'.
-
-**Fix**: (`fiobj`) fixed an where `gcc` would complain about overwriting the `fio_cstr_s` struct due to `const` members. Credit to @vit1251 for exposing this issue.
-
-**Fix**: (`fiobj`) fixed NULL pointer testing for `fiobj_free(NULL)`.
-
 **Compatibility**: (`gcc-6`) Fix some compatibility concerns with `gcc` version 6, as well as some warnings that were exposed when testing with `gcc`.
 
-**Optimization**: (`fiobj`) optimized the JSON parsing memory allocations as well as fixed some of the function declarations to add the `const` keyword where relevant.
+---
 
 #### Change log v.0.4.14
 
 **Fix**: (`facil.io`) fixes an issue where timer monitoring would report failure when the timer exists and is being monitored.
 
+---
+
 #### Change log v.0.4.12
 
 **Fix**: (`facil.io`) fixes some lingering issues with the new Websocket parser, namely an issue where certain network packet lengths would cause the parser to fail. Credit to Tom Lahti (@uidzip) for exposing the issue.
 
+---
+
 #### Change log v.0.4.11
 
 **Fix**: (`iodine`) use Ruby `fork` instead of system `fork`, allowing Ruby hooks to run before and after forking. This also fixes an issue where the Ruby timer thread isn't (re)initialized.
 
+---
+
 #### Change log v.0.4.10
 
 **Portability**: (`mac OS High Sierra`) iodine will load the Objective C library on macOS machines before starting up the server - this will prevent `fork` from crashing the server on macOS High Sierra, see [discussion here](https://github.com/puma/puma/issues/1421).
 
 **Fix**: (`facil.io`) fixes an error with the new Websocket parser (introduced in v. 0.4.9) that caused medium sized messages (127 Bytes - 64Kib) to be parsed incorrectly. Apologies. The test program I used seems to have validated messages using length comparison (instead of data comparison). Credit to Tom Lahti (@uidzip) for exposing the issue.
 
+---
+
 #### Change log v.0.4.9
 
 **Change**: (`facil.io`) the internal Websocket parser was replaced with something easier to read, for maintainability reasons. Performance seems to be mostly unaffected (sometimes it's faster and sometimes it's slower, common case is slightly optimized).
@@ -64,7 +64,7 @@ This includes the following changes (as well as other minor changes), as detaile
 
 **Fix**: (`facil.io`) timer timeout review is now correctly ignored, preventing the timer from being shut down prematurely.
 
-***
+---
 
 #### Change log v.0.4.8
 
@@ -74,7 +74,7 @@ This includes the following changes (as well as other minor changes), as detaile
 
 **Performance**: The `now` HTTP Date string is now cached for up to 2 seconds, improving performance for `Date`, `Last-Modified` and Iodine logging messages that relate to the current time. However, it's likely that Rack will write it's own date string, masking this feature.
 
-***
+---
 
 #### Change log v.0.4.7
 
@@ -88,7 +88,7 @@ This includes the following changes (as well as other minor changes), as detaile
 
 **Fix**: (`defer`) a shutdown issue in `defer_perform_in_fork` was detected by @cdkrot and his fix was implemented.
 
-***
+---
 
 #### Change log v.0.4.6
 
@@ -96,25 +96,25 @@ This includes the following changes (as well as other minor changes), as detaile
 
 **Fix**: (from `facil.io`) fix `SIGTERM` handling, make sure sibling processes exit when a sibling dies.
 
-***
+---
 
 #### Change log v.0.4.5
 
 **Fix**: fix static file service for `X-Sendfile` as well as static error file fallback pages (404.html etc').
 
-***
+---
 
 #### Change log v.0.4.4
 
 **Fix**: fixed an issue related to Ruby 2.3 optimizations of String management (an issue that didn't seem to effect Ruby 2.4). This fix disables the recyclable buffer implemented for the `on_message` Websocket callback. The callback will now receive a copy of the buffer (not the buffer itself), so there is no risk of collisions between the network buffer (managed in C) and the `on_message(data)` String (managed by Ruby).
 
-***
+---
 
 #### Change log v.0.4.3
 
 **Fix**: fixed a possible issue in fragmented pipelined Websocket messages.
 
-***
+---
 
 #### Change log v.0.4.2
 
@@ -122,7 +122,7 @@ This includes the following changes (as well as other minor changes), as detaile
 
 **Fix**: fixed a possible issue with high-jacking which might cause the server to hang.
 
-***
+---
 
 #### Change log v.0.4.1
 
@@ -130,7 +130,7 @@ This includes the following changes (as well as other minor changes), as detaile
 
 **Fix** move the `rake-compiler` dependency to "development" instead of "runtime". Credit to Luis Lavena (@luislavena) for exposing the issue (#19).
 
-***
+---
 
 #### Change log v.0.4.0
 
@@ -176,13 +176,13 @@ Iodine::HTTP.listen port: 3000, app: my_app2, public: "./www"
 Iodine.start
 ```
 
-***
+---
 
 #### Change log v.0.3.6
 
 **Update**: Now using `facil.io` v.0.4.3. This fixes some delays in websocket packet flushing (latency), as well as other internal polishes. It also promises some possible future feature extensions that could add a major performance boost.
 
-***
+---
 
 #### Change log v.0.3.5
 
@@ -190,13 +190,13 @@ Iodine.start
 
 **Minor changes**: This release incorporates some more minor changes from the [`facil.io` 0.4.2 update](https://github.com/boazsegev/facil.io/releases/tag/v.0.4.2).
 
-***
+---
 
 #### Change log v.0.3.4
 
 **Fix**: (`sock`, `facil`, bscrypt) Add missing `static` keywords to prevent state collisions with other libraries.
 
-***
+---
 
 #### Change log v.0.3.3
 
@@ -208,7 +208,7 @@ Iodine.start
 
 **Compatibility**: (from `facil.io`) Added spaces after header names (`:` => `: `), since some parsers don't seem to read the RFC.
 
-***
+---
 
 #### Change log v.0.3.2
 
@@ -216,12 +216,12 @@ Iodine.start
 
 **Fix**: (from `facil.io`) fixed stream response logging.
 
-***
+---
 
 #### Change log v.0.3.1
 
 **Update**: Follow `facil.io`'s update for healthier thread throttling and energy consumption.
-***
+---
 
 #### Change log v.0.3.1
 
@@ -229,31 +229,31 @@ Iodine.start
 
 **Gem Specification update**: We updated the gem specification to allow for Rack 1.x users and to update the gem description.
 
-***
+---
 
 #### Change log v.0.3.0
 
 **`facil.io` C Core Update**: The C library core that drives Iodine [`facil.io`](http://facil.io) was updated to version 0.4.0 and Iodine follows closely on the heels of this update. The transition was easy enough and the API remains unchanged... but because the performance gain was so big and because it's a new code base, we opted to bump the minor release version.
 
-***
+---
 
 #### Change log v.0.2.17
 
 **Performance**: Enhanced Performance for single threaded / blocking applications by adding a dedicated IO thread. This is related to issue #14.
 
-***
+---
 
 #### Change log v.0.2.16
 
 **Update**: iodine can now run as a basic HTTP static file server without a Ruby application (no `config.ru`) when the `-www` option is used from the command line.
 
-***
+---
 
 #### Change log v.0.2.15
 
 **Fix**: Fixed typo in logging and code comments, credit to @jmoriau in PR #13.
 
-***
+---
 
 #### Change log v.0.2.14
 
@@ -263,7 +263,7 @@ Iodine.start
 
 **Deprecation**: In version 0.2.1 we have notified that the the Websocket method `uuid` was deprecated in favor of `conn_id`, as suggested by the [Rack Websocket Draft](https://github.com/rack/rack/pull/1107). This deprecation is now enforced.
 
-***
+---
 
 #### Change log v.0.2.13
 
@@ -271,13 +271,13 @@ Iodine.start
 
 **Credit**: credit to Elia Schito (@elia) and Augusts Bautra (@Epigene) for fixing parts of the documentation (PR #11 , #12).
 
-***
+---
 
 #### Change log v.0.2.12
 
 **Fix**: removed `mempool` after it failed some stress and concurrency tests.
 
-***
+---
 
 #### Change log v.0.2.11
 
@@ -287,7 +287,7 @@ Iodine.start
 
 **Update**: lessons learned from `facil.io` have been implemented for better compatibility of Iodine's core C layer.
 
-***
+---
 
 #### Change log v.0.2.10
 
@@ -314,13 +314,13 @@ Iodine.start
 * `bscrypt` random generator (where `dev/random` is unavailable) should now provide more entropy.
 
 
-***
+---
 
 #### Change log v.0.2.9
 
 **Fix**: fixed a gcc-4.8 compatibility issue that prevented iodine 0.2.8 from compiling on Heroku's cedar-14 stack. This was related to missing system include files in gcc-4.8. It should be noted that Heroku's stack and compiler (which utilizes Ubuntu 14) has known issues and / or limited support for some of it's published features... but I should have remembered that before releasing version 0.2.8... sorry about that.
 
-***
+---
 
 #### Change log v.0.2.8
 
@@ -328,7 +328,7 @@ Iodine.start
 
 **Housekeeping**: Cleaned up some code, removed old files, copied over the latest [`facil.io`](http://facil.io) library. There's probably some more housekeeping left to perform, especially anywhere where documentation is concerned. I welcome help with documentation.
 
-***
+---
 
 #### Change log v.0.2.7
 
@@ -336,13 +336,13 @@ Iodine.start
 
 **Update**: Automated the number of processes (forks) and threads used when these are not explicitly specified. These follow the number of cores / 2.
 
-***
+---
 
 #### Change log v.0.2.6
 
 **Update**: The IO reactor review will now be delayed until all events scheduled are done. This means that is events schedule future events, no IO data will be reviewed until all scheduled data is done. Foolish use might cause infinite loops that skip the IO reactor, but otherwise performance is improved (since the IO reactor might cause a thread to "sleep", delaying event execution).
 
-***
+---
 
 #### Change log v.0.2.5
 
@@ -350,7 +350,7 @@ Iodine.start
 
 **Minor Fix**: Fix Iodine::Rack's startup message's `fprintf` call to fit correct argument sizes (Linux warnings).
 
-***
+---
 
 #### Change log v.0.2.4
 
@@ -362,7 +362,7 @@ Iodine.start
 
 **Update**: Iodine::Rack startup messages now include details regarding open file limits imposed by the OS (open file limits control the maximum allowed concurrent connections and other resource limits).
 
-***
+---
 
 #### Change log v.0.2.3
 
@@ -370,7 +370,7 @@ Iodine.start
 
 **Update**: The global socket `write` buffer was increased to ~16Mb (from ~4Mb), allowing for more concurrent `write` operations. However, the `write` buffer is still limited and `write` might block while the buffer is full. Blocking and "hanging" the server until there's enough room in the buffer for the requested `write` will slow the server down while keeping it healthy and more secure. IMHO, it is the lesser of two evils.
 
-***
+---
 
 #### Change log v.0.2.2
 
@@ -378,7 +378,7 @@ Iodine.start
 
 **Update**: A performance warning now shows if the CPUs are significantly under-utilized (less than half are used) of if too many are utilized (more than double the amount of CPUs), warning against under-utilization or excessive context switching (respectively).
 
-***
+---
 
 #### Change log v.0.2.1
 
@@ -390,7 +390,7 @@ Iodine.start
 
 **Fix**: fixed an issue were the server would crash when attempting to send a long enough websocket message.
 
-***
+---
 
 #### Change log v.0.2.0
 
@@ -398,7 +398,7 @@ This version is a total rewrite. The API is totally changed, nothing stayed.
 
 Iodine is now written in C, as a C extension for Ruby. The little, if any, ruby code written is just the fluff and feathers.
 
-***
+---
 
 ### deprecation of the 0.1.x version line
 
@@ -410,7 +410,7 @@ Iodine is now written in C, as a C extension for Ruby. The little, if any, ruby
 
 **Logs**: Log the number of threads utilized when starting up the server.
 
-***
+---
 
 #### Change log v.0.1.20
 
@@ -420,19 +420,19 @@ Iodine is now written in C, as a C extension for Ruby. The little, if any, ruby
 
 **API Changes**: `Iodine::HTTP.max_http_buffer` was replaced with `Iodine::HTTP.max_body_size`, for a better understanding of the method's result.
 
-***
+---
 
 #### Change log v.0.1.19
 
 **Update**: added the `go_away` method to the HTTP/1 protocol, for seamless connection closeing across HTTP/2, HTTP/1 and Websockets.
 
-***
+---
 
 #### Change log v.0.1.18
 
 **Update**: The request now has the shortcut method `Request#host_name` for accessing the host's name (without the port part of the string).
 
-***
+---
 
 #### Change log v.0.1.17
 
@@ -446,13 +446,13 @@ Iodine is now written in C, as a C extension for Ruby. The little, if any, ruby
 
 * Remember that sessions are never really safe, no matter how much we guard them. Session hijacking is far too easy. This is why Iodine stores the session data locally and not within the session cookie. This is also why you should review any authentication before performing sensitive tasks based on session stored authentication data.
 
-***
+---
 
 #### Change log v.0.1.16
 
 **Performance**: HTTP/1 and HTTP/2 connections now share and recycle their write buffer when while reading the response body and writing it to the IO. This (hopefully) prevents excess `malloc` calls by the interpreter.
 
-***
+---
 
 #### Change log v.0.1.15
 
@@ -460,7 +460,7 @@ Iodine is now written in C, as a C extension for Ruby. The little, if any, ruby
 
 **Update**: Websockets now support the `on_ping` callback, which will be called whenever a ping was sent without error.
 
-***
+---
 
 #### Change log v.0.1.14
 
@@ -468,7 +468,7 @@ Iodine is now written in C, as a C extension for Ruby. The little, if any, ruby
 
 **Performance**: the Protocol class now recycles the data string as a thread global socket buffer (different threads have different buffer strings), preventing excessive `malloc` calls by the Ruby interpreter. To keep the `data` (in `on_message(data)`) past the `on_message` method's scope, be sure to duplicate it using `data.dup`, or the string's buffer will be recycled.
 
-***
+---
 
 #### Change log v.0.1.13
 
@@ -480,7 +480,7 @@ Iodine is now written in C, as a C extension for Ruby. The little, if any, ruby
 
 **Compatibility**: minor fixes and changes in preparation for Ruby 2.3.0. These may affect performance due to slower String initialization times.
 
-***
+---
 
 #### Change log v.0.1.12
 
@@ -488,13 +488,13 @@ Iodine is now written in C, as a C extension for Ruby. The little, if any, ruby
 
 **Security**: set the HTTPOnly flag for session id cookies.
 
-***
+---
 
 #### Change log v.0.1.11
 
 **Fix**: fixed the Rack server Handler, which was broken in version 0.1.10.
 
-***
+---
 
 #### Change log v.0.1.10
 
@@ -502,7 +502,7 @@ Iodine is now written in C, as a C extension for Ruby. The little, if any, ruby
 
 **Performance**: faster TimedEvent clearing when manually stopped. Minor improvements to direct big-file sending (recycle buffer to avoid `malloc`).
 
-***
+---
 
 #### Change log v.0.1.9
 
@@ -512,7 +512,7 @@ Iodine is now written in C, as a C extension for Ruby. The little, if any, ruby
 
 **Update**: repeatedly calling `Iodine.force_start!` will now be ignored, as might have been expected. Once Iodine had started, `force_start!` cannot be called until Iodine had finished (and even than, Iodine might never be as fresh nor as young as it was).
 
-***
+---
 
 #### Change log v.0.1.8
 
@@ -528,13 +528,13 @@ Iodine is now written in C, as a C extension for Ruby. The little, if any, ruby
 
 **Fix** fixed an issue where HTTP streaming would disconnect while still processing. Streaming timeout now extended to 15 seconds between response writes.
 
-***
+---
 
 #### Change log v.0.1.7
 
 Removed a deprecation notice for blocking API. Client API will remain blocking due to use-case requirements.
 
-***
+---
 
 #### Change log v.0.1.6
 
@@ -548,7 +548,7 @@ Removed a deprecation notice for blocking API. Client API will remain blocking d
 
 (removed after reviewing use-cases).
 
-***
+---
 
 #### Change log v.0.1.5
 
@@ -556,7 +556,7 @@ Removed a deprecation notice for blocking API. Client API will remain blocking d
 
 **Fix**: Fixed an issue where Iodine might take a long time to shut down after a Fatal Error during the server initialization.
 
-***
+---
 
 #### Change log v.0.1.4
 
@@ -566,19 +566,19 @@ Removed a deprecation notice for blocking API. Client API will remain blocking d
 
 **Fix**: fixed an issue where HTTP2 header size limit condition was not recognized by the Ruby parser (a double space issue, might be an issue with the 2.2.3 Ruby parser).
 
-***
+---
 
 #### Change log v.0.1.3
 
 **Fix**: fixed an issue with the new form/multipart parser, where the '+' sign would be converted to spaces on form fields (not uploaded files), causing in-advert potential change to the original POSTed data.
 
-***
+---
 
 #### Change log v.0.1.2
 
 **Fix**: fixed an issue where the default implementation of `ping` did not reset the timeout if the connection wasn't being closed (the default implementation checks if the Protocol is working on existing data and either resets the timer allowing the work to complete or closes the connection if no work is being done).
 
-***
+---
 
 #### Change log v.0.1.1
 
@@ -592,7 +592,7 @@ Removed a deprecation notice for blocking API. Client API will remain blocking d
 
 **Logging**: Better HTTP error logging and recognition.
 
-***
+---
 
 #### Change log v.0.1.0
 

data/ext/iodine/websocket_parser.h

@@ -143,21 +143,40 @@ Message masking
 /** used internally to mask and unmask client messages. */
 void websocket_xmask(void *msg, uint64_t len, uint32_t mask) {
   if (len > 7) {
-    /* XOR any unaligned memory (4 byte alignment) */
-    const uintptr_t offset = 4 - ((uintptr_t)msg & 3);
-    switch (offset) {
-    case 3:
-      ((uint8_t *)msg)[2] ^= ((uint8_t *)(&mask))[2];
-    /* fallthrough */
-    case 2:
-      ((uint8_t *)msg)[1] ^= ((uint8_t *)(&mask))[1];
-    /* fallthrough */
-    case 1:
-      ((uint8_t *)msg)[0] ^= ((uint8_t *)(&mask))[0];
-      /* rotate mask and move pointer to first 4 byte alignment */
-      mask = (mask << (offset << 3)) | (mask >> ((4 - offset) << 3));
-      msg = (void *)((uintptr_t)msg + offset);
-      len -= offset;
+    { /* XOR any unaligned memory (4 byte alignment) */
+      const uintptr_t offset = 4 - ((uintptr_t)msg & 3);
+      // switch (offset) {
+      // case 3:
+      //   ((uint8_t *)msg)[2] ^= ((uint8_t *)(&mask))[2];
+      // /* fallthrough */
+      // case 2:
+      //   ((uint8_t *)msg)[1] ^= ((uint8_t *)(&mask))[1];
+      // /* fallthrough */
+      // case 1:
+      //   ((uint8_t *)msg)[0] ^= ((uint8_t *)(&mask))[0];
+      //   /* rotate mask and move pointer to first 4 byte alignment */
+      //   mask = (mask << (offset << 3)) | (mask >> ((4 - offset) << 3));
+      //   msg = (void *)((uintptr_t)msg + offset);
+      //   len -= offset;
+      // }
+      switch (offset) {
+      case 3:
+        ((uint8_t *)msg)[2] ^= ((uint8_t *)(&mask))[2];
+      /* fallthrough */
+      case 2:
+        ((uint8_t *)msg)[1] ^= ((uint8_t *)(&mask))[1];
+      /* fallthrough */
+      case 1:
+        ((uint8_t *)msg)[0] ^= ((uint8_t *)(&mask))[0];
+        /* rotate mask and move pointer to first 4 byte alignment */
+        uint64_t comb = mask | ((uint64_t)mask << 32);
+        ((uint8_t *)(&mask))[0] = ((uint8_t *)(&comb))[0 + offset];
+        ((uint8_t *)(&mask))[1] = ((uint8_t *)(&comb))[1 + offset];
+        ((uint8_t *)(&mask))[2] = ((uint8_t *)(&comb))[2 + offset];
+        ((uint8_t *)(&mask))[3] = ((uint8_t *)(&comb))[3 + offset];
+        msg = (void *)((uintptr_t)msg + offset);
+        len -= offset;
+      }
     }
 #if UINTPTR_MAX <= 0xFFFFFFFF
     /* handle  4 byte XOR alignment in 32 bit mnachine*/
@@ -182,6 +201,7 @@ void websocket_xmask(void *msg, uint64_t len, uint32_t mask) {
     }
 #endif
   }
+
   /* XOR any leftover bytes (might be non aligned)  */
   switch (len) {
   case 7:
@@ -471,7 +491,8 @@ websocket_buffer_peek(void *buffer, uint64_t len) {
  */
 static uint64_t websocket_consume(void *buffer, uint64_t len, void *udata,
                                   uint8_t require_masking) {
-  struct websocket_packet_info_s info = websocket_buffer_peek(buffer, len);
+  volatile struct websocket_packet_info_s info =
+      websocket_buffer_peek(buffer, len);
   if (info.head_length + info.packet_length > len)
     return len;
   uint64_t reminder = len;
@@ -482,7 +503,11 @@ static uint64_t websocket_consume(void *buffer, uint64_t len, void *udata,
     /* unmask? */
     if (info.masked) {
       /* masked */
-      const uint32_t mask = ((uint32_t *)payload)[-1];
+      const uint32_t mask; // = ((uint32_t *)payload)[-1];
+      ((uint8_t *)(&mask))[0] = ((uint8_t *)(payload))[-4];
+      ((uint8_t *)(&mask))[1] = ((uint8_t *)(payload))[-3];
+      ((uint8_t *)(&mask))[2] = ((uint8_t *)(payload))[-2];
+      ((uint8_t *)(&mask))[3] = ((uint8_t *)(payload))[-1];
       websocket_xmask(payload, info.packet_length, mask);
     } else if (require_masking) {
       /* error */

data/lib/iodine/version.rb

@@ -1,3 +1,3 @@
 module Iodine
-  VERSION = '0.4.15'.freeze
+  VERSION = '0.4.16'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iodine
 version: !ruby/object:Gem::Version
-  version: 0.4.15
+  version: 0.4.16
 platform: ruby
 authors:
 - Boaz Segev
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-12-13 00:00:00.000000000 Z
+date: 2017-12-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -292,7 +292,7 @@ requirements:
 - Ruby >= 2.2.2 required for Rack 2.
 - Ruby >= 2.4.0 recommended.
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: iodine - a fast HTTP / Websocket Server with Pub/Sub support, optimized for