invisiblehand 0.1.1 → 0.1.2

data/lib/invisiblehand/api.rb

@@ -71,11 +71,23 @@ module InvisibleHand
       query = url_params_from opts
       url   = "#{@config[:protocol]}#{@config[:endpoint]}#{path}?#{query}"
 
-      api_raw_request method, url
+      if opts[:debug]
+        debug { api_raw_request method, url }
+      else
+        api_raw_request method, url
+      end
     end
 
     private
 
+    def debug &block
+      old_log_level = logger.level
+      logger.level  = ::Logger::DEBUG
+      result        = block.call
+      logger.level  = old_log_level
+      result
+    end
+
     def api_raw_request method, url
       logger.debug "API call URL: #{url}"
 
@@ -91,15 +103,21 @@ module InvisibleHand
       logger.debug "API call took #{elapsed.round(3)} seconds."
       logger.debug "API json response: #{json.inspect}"
 
-      raise Error::APIError.new(json["error"], url) if json["error"]
+      raise Error::APIError.new(json["error"], url, response) if json["error"]
 
       json
     end
 
     def url_params_from hash
-      hash.map do |key, value|
+      params = hash.map do |key, value|
+        # There are some parameters that will be passed to an API call that we
+        # don't want to include in the query string. Filter them out here.
+        next if [:debug].include? key.to_sym
+
         "#{CGI.escape(key.to_s)}=#{CGI.escape(value.to_s)}"
-      end.join("&")
+      end
+
+      params.compact.join('&')
     end
 
     def valid_config?

data/lib/invisiblehand/errors.rb

@@ -11,12 +11,13 @@ module InvisibleHand
     end
 
     class APIError < StandardError
-      attr_accessor :url
+      attr_accessor :url, :raw_response
 
-      def initialize message, url
+      def initialize message, url, raw_response
         super message
 
-        @url = url
+        @url          = url
+        @raw_response = raw_response
       end
     end
   end

data/lib/invisiblehand/version.rb

@@ -1,5 +1,5 @@
 module InvisibleHand
   unless const_defined? :VERSION
-    VERSION = "0.1.1"
+    VERSION = "0.1.2"
   end
 end

data/spec/api_spec.rb

@@ -34,6 +34,14 @@ describe InvisibleHand::API do
     end
   end
 
+  describe "ad-hoc debug flag" do
+    specify "the debug option to a single call should not break things" do
+      expect do
+        api.live_price(page["original_url"], :debug => true)
+      end.to_not raise_error
+    end
+  end
+
   describe "invalid config" do
     specify "no app_id or api_key should throw error" do
       expect do
@@ -59,4 +67,24 @@ describe InvisibleHand::API do
       end
     end
   end
+
+  describe "errors" do
+    describe InvisibleHand::Error::APIError do
+      subject do
+        error = nil
+
+        begin
+          api.live_price "not a real url"
+        rescue InvisibleHand::Error::APIError => e
+          error = e
+        end
+
+        error
+      end
+
+      its(:url)          { should be_a String }
+      its(:raw_response) { should be_a String }
+      its(:message)      { should be_a String }
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: invisiblehand
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -110,7 +110,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1889337055537833862
+      hash: -3726614589269803000
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -119,7 +119,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1889337055537833862
+      hash: -3726614589269803000
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24