inventory_refresh 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6ade3208f2b15b5f3ddd1eb2ba062bc011ba4ce8fbd4bbc838ba9ccef62fb19f
-  data.tar.gz: 6aecb2c6ea69ba72b48819eb8a4af6cbffa9f3c9d475bcca8c88e6e5f5fa0cf1
+  metadata.gz: 2795b6d1400c002ec2943be86f275bd456771a8090135420fdeaa085592be302
+  data.tar.gz: e16e6285f5f7a623c6452c3a4559c36e0f6d402ebb17822425e15181fc44b084
 SHA512:
-  metadata.gz: e2d87b6841db8fd728269e4234ae05ca0c80a5612980ee08b83815d626b2945bca34644a972133eedb8f76bce19c627cc93a3d812a41c13edd8d74c9ff5d7175
-  data.tar.gz: c811d7fad848a207228595ede6cdb251a7096192ae5984bf3be0af667956553035c22c45ece7b7962807339b9e45cf06ed4f823561a7c3ccd40fa9a631db1c50
+  metadata.gz: 78755d1c33a17c1f3f9793b3e16576a4981cea708f878f1fcad3643540d6511077d6bd8fe0b01d17279e8056ce0f7df0c871ecf5dec982a2ff4d8be62124cab9
+  data.tar.gz: 80c8475497a20a67a3b7915d50f2072ed1b2a2e44ec74c6a744aa87d5f83b5a968eef4cceabd0ab6971dc701aaa5a0b97a0da03db169c2d235071168c7af1dcf

data/lib/inventory_refresh/inventory_collection/index/proxy.rb

@@ -195,7 +195,7 @@ module InventoryRefresh
           # TODO(lsmola) do we need some production logging too? Maybe the refresh log level could drive this
           # Let' do this really slick development and test env, but disable for production, since the checks are pretty
           # slow.
-          # TODO: return if Rails.env.production?
+          return unless inventory_collection.assert_graph_integrity
 
           if manager_uuid.kind_of?(InventoryRefresh::InventoryCollection::Reference)
             # InventoryRefresh::InventoryCollection::Reference has been already asserted, skip

data/lib/inventory_refresh/inventory_collection.rb

@@ -87,7 +87,8 @@ module InventoryRefresh
                 :inventory_object_attributes, :name, :saver_strategy, :targeted_scope, :default_values,
                 :targeted_arel, :targeted, :manager_ref_allowed_nil, :use_ar_object,
                 :created_records, :updated_records, :deleted_records,
-                :custom_reconnect_block, :batch_extra_attributes, :references_storage
+                :custom_reconnect_block, :batch_extra_attributes, :references_storage,
+                :assert_graph_integrity
 
     delegate :<<,
              :build,
@@ -409,6 +410,8 @@ module InventoryRefresh
     #        db. These extra attributes might be a product of :use_ar_object assignment and we need to specify them
     #        manually, if we want to use a batch saving strategy and we have models that populate attributes as a side
     #        effect.
+    # @param assert_graph_integrity [Boolean] Default false.  If true then extra checks for graph integrity will be
+    #        performed and an exception will be raised if an error is found.
     def initialize(model_class: nil, manager_ref: nil, association: nil, parent: nil, strategy: nil,
                    custom_save_block: nil, delete_method: nil, dependency_attributes: nil,
                    attributes_blacklist: nil, attributes_whitelist: nil, complete: nil, update_only: nil,
@@ -416,7 +419,7 @@ module InventoryRefresh
                    inventory_object_attributes: nil, name: nil, saver_strategy: nil,
                    parent_inventory_collections: nil, manager_uuids: [], all_manager_uuids: nil, targeted_arel: nil,
                    targeted: nil, manager_ref_allowed_nil: nil, secondary_refs: {}, use_ar_object: nil,
-                   custom_reconnect_block: nil, batch_extra_attributes: [])
+                   custom_reconnect_block: nil, batch_extra_attributes: [], assert_graph_integrity: nil)
       @model_class            = model_class
       @manager_ref            = manager_ref || [:ems_ref]
       @secondary_refs         = secondary_refs
@@ -438,6 +441,7 @@ module InventoryRefresh
       @saver_strategy         = process_saver_strategy(saver_strategy)
       @use_ar_object          = use_ar_object || false
       @batch_extra_attributes = batch_extra_attributes
+      @assert_graph_integrity = assert_graph_integrity.nil? ? false : assert_graph_integrity
 
       @manager_ref_allowed_nil = manager_ref_allowed_nil || []
 

data/lib/inventory_refresh/save_collection/saver/base.rb

@@ -247,7 +247,7 @@ module InventoryRefresh::SaveCollection
           # Change the InventoryCollection's :association or :arel parameter to return distinct results. The :through
           # relations can return the same record multiple times. We don't want to do SELECT DISTINCT by default, since
           # it can be very slow.
-          if false # TODO: Rails.env.production?
+          unless inventory_collection.assert_graph_integrity
             logger.warn("Please update :association or :arel for #{inventory_collection} to return a DISTINCT result. "\
                         " The duplicate value is being ignored.")
             return false
@@ -273,7 +273,7 @@ module InventoryRefresh::SaveCollection
           subject = "#{hash} of #{inventory_collection} because of missing foreign key #{x} for "\
                     "#{inventory_collection.parent.class.name}:"\
                     "#{inventory_collection.parent.try(:id)}"
-          if false # TODO: Rails.env.production?
+          unless inventory_collection.assert_graph_integrity
             logger.warn("Referential integrity check violated, ignoring #{subject}")
             return false
           else

data/lib/inventory_refresh/version.rb

@@ -1,3 +1,3 @@
 module InventoryRefresh
-  VERSION = "0.1.1".freeze
+  VERSION = "0.1.2".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: inventory_refresh
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - ManageIQ Developers
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-09-13 00:00:00.000000000 Z
+date: 2019-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord