intransient_capybara 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 947b6ccc4687c7a53e50287635750f38f1954248
-  data.tar.gz: e9f78842a8d76789c4529a0f35fa199f5cdc5da9
+  metadata.gz: 83593a8ec8648d2aaad1258458fa0d9960e7d464
+  data.tar.gz: 51a353e91f335e71206b1aff35b7147bb20f7cd4
 SHA512:
-  metadata.gz: 8410c434c7901645473afe4a79f8423063ea8578d65afbfa2434e155a34f0af89dbe8c5b759e4381cc56dee2e62556bd928702208510d4844d748e942eca8753
-  data.tar.gz: 0069d6bbebeb99905ba1d31a4c8807100eb787654d278dd99b07a96f5c157492106a05a0cdba9a3a9ac2d12bae0238b08dedec925cab8b3d0cbad8ec286e9d53
+  metadata.gz: 6c44f04d8a0e4978d48d0239c00bc3260cb9fa407b131487283f0695de28dcd95957d2b7678f1b8e3123e0ab57ccce68493feb3761b8452a6cd40f5f647a3e09
+  data.tar.gz: c68d4e09e88ad7678019619d36fc94742bbb018335657989328989456a91819658f0929eeca46c37fed0c228cbb89f2fdfc4c65fdfaa5e6c14310ed306e62268

data/README.md

@@ -91,21 +91,21 @@ Register the driver
 
 ```
 
-###Debuggability
+### Debuggability
 
-1. When an element is not found, we output what the current path is and the page's entire HTML, to debug what is going on.  A common case is getting redirected somewhere else, and another is the wrong template is rendering or your partial is not rendering at all.  Sometimes you look at the HTML and your element is there and knowing that will help figure out why the selector isn't working.
+1. When an element is not found, we output what the current path is and the page's entire HTML (unless environment variable DEBUG_HIDE_PAGE_HTML is 'true'), to debug what is going on.  A common case is getting redirected somewhere else, and another is the wrong template is rendering or your partial is not rendering at all.  Sometimes you look at the HTML and your element is there and knowing that will help figure out why the selector isn't working.
 
 2. When environment variable DEBUG_TEST_TRAFFIC is 'true', we output a summary of network traffic from each test.  If you are downloading a lot of stuff or making inordinant amounts of calls it will be insightful to you to know this - it might be reducable, or you may need to preload stuff, etc.  You can also set DEBUG_TEST_TRAFFIC_RAISE_EXTERNAL to 'true' and we will throw an exception if you make a network call to an external service.  This is super common and you should either stub out all of these or add them to the blacklist.  jQuery is a common one if you are loading that JS from a CDN, and you may need to load it from the asset pipeline during tests instead.
 
 3. When environment variable TRACE_TEST_FRAMEWORK is 'true', we output some traces of blocking rack requests and the calling of test setup and teardown.  This can help you make sure your ordering is correct and could help you see if things are happening concurrently or not.
 
-###Correct configuration
+### Correct configuration
 
 1. Capybara.default_max_wait_time is a very important decision.  This gem defaults that to 10 seconds.  More than that and you're probably failing anyways and you're just extending your test run for no reason.  Much less and you get transient.  Time is less important than stability and 10 seconds is a good balance on the stabiltiy side of the world.  You can override this by setting Capybara.default_max_wait_time again in your inherited class.
 
 2. Set phantomjs_options when you set up Poltergeist.  Not loading images and ignoring SSL errors are the common suggestions to improve stability in PhantomJS.
 
-###Correct usage of Capybara/Poltergeist/PhantomJS
+### Correct usage of Capybara/Poltergeist/PhantomJS
 
 1. You need to setup and teardown consistently in your tests, so we will throw an exception if you override one of these and forget to call super (which is SUPER common).
 

data/lib/intransient_capybara/minitest_retry.rb

@@ -14,12 +14,15 @@ module Minitest
 
       retries = [ENV.fetch('MINITEST_RETRY_COUNT', 3).to_i, 1].max
 
-      retries.times do
+      test_executions = 0
+      while test_executions < retries do
+        test_executions += 1
+
         result = Minitest.run_one_method(klass, method_name)
 
         first_result ||= result
 
-        if result.passed?
+        if result.passed? || result.skipped?
           unless ENV.fetch('TRANSIENT_TESTS_REPORT_FAILURE', false) == 'true'
             report_result = result
           end
@@ -32,6 +35,7 @@ module Minitest
 
           if result.failure.exception.present? && result.failure.exception.class.to_s == 'Capybara::Poltergeist::DeadClient'
             puts "PhantomJS died!!!! - #{klass.to_s}##{method_name}"
+            test_executions -= 1
             next
           end
 

data/lib/intransient_capybara/patches.rb

@@ -37,8 +37,11 @@ module Capybara
           puts 'We failed to find an element :('
           puts
           puts 'We are on path: ' + session.current_path
-          puts
-          puts 'This is the page HTML: ' + session.body
+
+          unless ENV.fetch('DEBUG_HIDE_PAGE_HTML', false) == 'true'
+            puts
+            puts 'This is the page HTML: ' + session.body
+          end
           puts
           raise sad_day
 

data/lib/intransient_capybara/version.rb

@@ -1,3 +1,3 @@
 module IntransientCapybara
-  VERSION = "1.0.1"
+  VERSION = "1.0.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: intransient_capybara
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Seth Ringling
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-12-02 00:00:00.000000000 Z
+date: 2017-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -151,7 +151,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: A set of improvements to Capybara/Poltergeist/PhantomJS test stack that reduces