intown 0.1.4 → 0.1.5

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: d76054e6f04a413200acac85cd5d1efa1001fd3f
+  data.tar.gz: f465740a9d6886e767a98188fc7f35ebf41da2ef
+SHA512:
+  metadata.gz: 69d58ede22936397ae92900ed3997417176650beeef66830fac78d78f7113bf1f2ad6e67c7563520e399a53981a0af1aa7461a16bfd239af3a8807dbcbf1602e
+  data.tar.gz: 629e25cc1fe3fd3585c79d965f2214336f7b38e03f6925ac044582e52419d1f46d52d05773dd6af7afe977dfd0fad0fe01a064860308932ebb8e6c0b143ca41f

data/lib/intown/client.rb

@@ -20,7 +20,8 @@ module Intown
 
       def process_response(response)
         case response.code
-        when 500 then raise Intown::InvalidRequestError, response.body
+        when 500 then internal_server_error(response)
+        when 502 then bad_gateway(response)
         when 404 then process_not_found(response)
         when 406 then process_not_acceptable(response)
         else
@@ -48,6 +49,14 @@ module Intown
         nil
       end
 
+      def internal_server_error(response)
+        raise Intown::InternalServerError, "Bandsintown returned a 500 internal server error. Please retry this request later."
+      end
+
+      def bad_gateway(response)
+        raise Intown::BadGatewayError, "Bandsintown returned a 502 proxy error. Please retry this request later."
+      end
+
       def artist_identifier(params)
         return musicbrainz_identifier(params[:mbid]) if params[:mbid]
         return facebook_identifier(params[:fbid]) if params[:fbid]

data/lib/intown/errors.rb

@@ -1,4 +1,6 @@
 module Intown
   IntownError = Class.new(StandardError)
   InvalidRequestError = Class.new(IntownError)
+  InternalServerError = Class.new(IntownError)
+  BadGatewayError = Class.new(IntownError)
 end

data/lib/intown/version.rb

@@ -1,3 +1,3 @@
 module Intown
-  VERSION = "0.1.4"
+  VERSION = "0.1.5"
 end

data/spec/intown/artist_spec.rb

@@ -59,21 +59,35 @@ describe Intown::Artist do
   
   describe "invalid response" do
     let(:status_code) { nil }
-    let(:response_body) { nil }
+    let(:response_body) { '{"errors":["app_id param is required"]}' }
     let(:response) {
       stub(:body => response_body, 
            :code => status_code)
     }
+
     before do
       Intown::Artist.should_receive(:get).and_return(response)
     end
+
+    context "500 Internal Server Error" do
+      let(:status_code) { 500 }
+      it_behaves_like 'error', Intown::InternalServerError
+    end
+
+    context "502 Bad Gateway" do
+      let(:status_code) { 502 }
+      it_behaves_like 'error', Intown::BadGatewayError
+    end
+
+    context "404 Not Found" do
+      let(:status_code) { 404 }
+      it_behaves_like 'error', Intown::InvalidRequestError
+    end
+
     context "406 Not Acceptable" do
       let(:status_code) { 406 }
-      it "should raise an invalid request error" do
-        expect { Intown::Artist.fetch(:name => "Jr. Doc") }.to raise_error Intown::InvalidRequestError
-      end
+      it_behaves_like 'error', Intown::InvalidRequestError
     end
-    
   end
 
 end

data/spec/spec_helper.rb

@@ -12,3 +12,5 @@ VCR.configure do |c|
   c.hook_into :webmock
   c.allow_http_connections_when_no_cassette = true
 end
+
+Dir["./spec/support/**/*.rb"].sort.each {|f| require f}

data/spec/support/shared_examples.rb

@@ -0,0 +1,5 @@
+shared_examples 'error' do |e|
+  it "should raise #{e}" do
+    expect { Intown::Artist.fetch(:name => "Jr. Doc") }.to raise_error e
+  end
+end

metadata

@@ -1,112 +1,99 @@
 --- !ruby/object:Gem::Specification
 name: intown
 version: !ruby/object:Gem::Version
-  prerelease: 
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Ben Scheirman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-23 00:00:00.000000000 Z
+date: 2013-07-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 2.12.0
-    none: false
-  type: :development
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: 2.12.0
-    none: false
-- !ruby/object:Gem::Dependency
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.4.0
-    none: false
-  type: :development
+        version: 2.12.0
+- !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: 2.4.0
-    none: false
-- !ruby/object:Gem::Dependency
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.9.3
-    none: false
-  type: :development
+        version: 2.4.0
+- !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: 1.9.3
-    none: false
-- !ruby/object:Gem::Dependency
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
-    none: false
-  type: :development
+        version: 1.9.3
+- !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-    none: false
-- !ruby/object:Gem::Dependency
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 0.10.0
-    none: false
-  type: :runtime
+        version: '0'
+- !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: 0.10.0
-    none: false
-- !ruby/object:Gem::Dependency
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 1.2.0
-    none: false
-  type: :runtime
+        version: 0.10.0
+- !ruby/object:Gem::Dependency
   name: hashie
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: 1.2.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.2.0
-    none: false
 description: A client for the Bandsintown API.
 email:
 - ben@scheirman.com
@@ -144,29 +131,29 @@ files:
 - spec/intown/event_spec.rb
 - spec/intown/intown_spec.rb
 - spec/spec_helper.rb
+- spec/support/shared_examples.rb
 homepage: https://github.com/subdigital/intown
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-  none: false
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-  none: false
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.0.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Supports Bandsintown API version 1.1
 test_files:
 - spec/acceptance/fetch_artist_by_name_spec.rb
@@ -185,4 +172,4 @@ test_files:
 - spec/intown/event_spec.rb
 - spec/intown/intown_spec.rb
 - spec/spec_helper.rb
-has_rdoc: 
+- spec/support/shared_examples.rb