intercom 4.2.1 → 4.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8a680039a8ef799d52b227657866f60afa19bf4b292f9d70646c8f962eca11a0
-  data.tar.gz: 40317d4521715f294bec48805ed9edf6f83406260b5c74bde5e9cf96cdf9cb8c
+  metadata.gz: ea6de8ff389a01f714c1a0f5f42ffadf46b22f3636743fd58f76a9ad5c1ec458
+  data.tar.gz: 7e5da0a304fe4b90614fda3944d0f40089ab61db0e5aac0444235fde34186e49
 SHA512:
-  metadata.gz: df28a00dc009f9e7bd94fa497021312d4cbe005905eea6095d1efe1172f567d8f806a47750843e129cfae5af80db038aea355ba2f1a2b5122142893574d9d977
-  data.tar.gz: d57709458d73737890f1933264f10b23c486a08840bd3a561c8971dbfef3d2ad88b4ddb2d393154b4127cd78196a39a56c93c0f08c747c74bd303c729d01fc5f
+  metadata.gz: d1ab02970d6363d0b07424a2d9a09019ae69a29770d671045fb677332f4ce1621ee907d2e2ec0c6d29398374bc826c0ed197e6ff857813371f4d77d1c4b8692f
+  data.tar.gz: e821557df3b3eda19a519d0d51523b77434724a433e2e7ec651ebdb979b0e0847cab0576da9055e6e696b13987c3a66470edb21d4fca91d275b92b6ba0ac6337

data/README.md

@@ -170,7 +170,7 @@ contact.remove_company(id: company.id)
 contact.companies.each {|c| p c.name}
 
 # attach a subscription_types on a contact
-contact.create_subscription_types(id: subscription_type.id)
+contact.create_subscription_type(id: subscription_type.id)
 
 # List subscription_types for a contact
 contact.subscription_types.each {|n| p n.id}

data/changes.txt

@@ -1,3 +1,7 @@
+4.2.2
+- Fixed FlatStore to skip hash values when building API request payloads
+- Removed hash validation on FlatStore reads to allow for custom objects
+
 4.1.3
 - Updated ReadMe with more errors.
 - Fixed issue where paginated requests could only be iterated through once.

data/intercom.gemspec

@@ -21,7 +21,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'minitest', '~> 5.4'
   spec.add_development_dependency "m", "~> 1.5.0"
   spec.add_development_dependency 'rake', '~> 10.3'
-  spec.add_development_dependency 'mocha', '~> 1.0'
+  spec.add_development_dependency 'mocha', '~> 2.0'
   spec.add_development_dependency "fakeweb", ["~> 1.3"]
   spec.add_development_dependency "pry"
 

data/lib/intercom/lib/flat_store.rb

@@ -2,7 +2,7 @@ module Intercom
   module Lib
 
     # Sub-class of {Hash} for storing custom data attributes.
-    # Doesn't allow nested Hashes or Arrays. And requires {String} or {Symbol} keys.
+    # Doesn't allow Arrays. And requires {String} or {Symbol} keys.
     class FlatStore < Hash
 
       def initialize(attributes={})
@@ -21,9 +21,16 @@ module Intercom
         super(key.to_s)
       end
 
+      def to_submittable_hash
+        # Filter out Custom Object references when submitting to API
+        self.reject do |key, value|
+          value.is_a?(Hash)
+        end
+      end
+
       private
       def validate_key_and_value(key, value)
-        raise ArgumentError.new("This does not support nested data structures (key: #{key}, value: #{value}") if value.is_a?(Array) || value.is_a?(Hash)
+        raise ArgumentError.new("This does not support nested data structures (key: #{key}, value: #{value}") if value.is_a?(Array)
         raise ArgumentError.new("Key must be String or Symbol: #{key}") unless key.is_a?(String) || key.is_a?(Symbol)
       end
     end

data/lib/intercom/version.rb

@@ -1,3 +1,3 @@
 module Intercom #:nodoc:
-  VERSION = "4.2.1"
+  VERSION = "4.2.2"
 end

data/spec/spec_helper.rb

@@ -2,7 +2,7 @@
 
 require 'intercom'
 require 'minitest/autorun'
-require 'mocha/setup'
+require 'mocha/minitest'
 require 'webmock'
 require 'time'
 require 'pry'

data/spec/unit/intercom/contact_spec.rb

@@ -90,12 +90,10 @@ describe Intercom::Contact do
     _(contact.to_hash['custom_attributes']).must_equal 'mad' => 123, 'other' => now.to_i, 'thing' => 'yay'
   end
 
-  it 'rejects nested data structures in custom_attributes' do
+  it 'rejects lists in custom_attributes' do
     contact = Intercom::Contact.new
 
     _(proc { contact.custom_attributes['thing'] = [1] }).must_raise(ArgumentError)
-    _(proc { contact.custom_attributes['thing'] = { 1 => 2 } }).must_raise(ArgumentError)
-    _(proc { contact.custom_attributes['thing'] = { 1 => { 2 => 3 } } }).must_raise(ArgumentError)
 
     contact = Intercom::Contact.new(test_contact)
     _(proc { contact.custom_attributes['thing'] = [1] }).must_raise(ArgumentError)

data/spec/unit/intercom/lib/flat_store_spec.rb

@@ -3,11 +3,15 @@
 require 'spec_helper'
 
 describe Intercom::Lib::FlatStore do
-  it 'raises if you try to set or merge in nested hash structures' do
+  it 'raises if you try to set arrays but allows hashes' do
     data = Intercom::Lib::FlatStore.new
     _(proc { data['thing'] = [1] }).must_raise ArgumentError
-    _(proc { data['thing'] = { 1 => 2 } }).must_raise ArgumentError
-    _(proc { Intercom::Lib::FlatStore.new(1 => { 2 => 3 }) }).must_raise ArgumentError
+  
+    data['thing'] = { 'key' => 'value' }
+    _(data['thing']).must_equal({ 'key' => 'value' })
+    
+    flat_store = Intercom::Lib::FlatStore.new('custom_object' => { 'type' => 'Order.list', 'instances' => [{'id' => '123'}] })
+    _(flat_store['custom_object']).must_equal({ 'type' => 'Order.list', 'instances' => [{'id' => '123'}] })
   end
 
   it 'raises if you try to use a non string key' do
@@ -28,4 +32,30 @@ describe Intercom::Lib::FlatStore do
     _(data['b']).must_equal 2
     _(data[:b]).must_equal 2
   end
+
+  describe '#to_submittable_hash' do
+    it 'filters out all hash values' do
+      data = Intercom::Lib::FlatStore.new(
+        'regular_attr' => 'value',
+        'number_attr' => 42,
+        'custom_object' => {
+          'type' => 'Order.list',
+          'instances' => [
+            { 'id' => '31', 'external_id' => 'ext_123' }
+          ]
+        },
+        'regular_hash' => { 'key' => 'value' },
+        'metadata' => { 'source' => 'api', 'version' => 2 }
+      )
+      
+      submittable = data.to_submittable_hash
+      
+      _(submittable['regular_attr']).must_equal 'value'
+      _(submittable['number_attr']).must_equal 42
+      
+      _(submittable.key?('custom_object')).must_equal false
+      _(submittable.key?('regular_hash')).must_equal false
+      _(submittable.key?('metadata')).must_equal false
+    end
+  end
 end

data/spec/unit/intercom/user_spec.rb

@@ -106,12 +106,10 @@ describe 'Intercom::User' do
     _(user.to_hash['companies']).must_equal companies
   end
 
-  it 'rejects nested data structures in custom_attributes' do
+  it 'rejects lists in custom_attributes' do
     user = Intercom::User.new
 
     _(proc { user.custom_attributes['thing'] = [1] }).must_raise(ArgumentError)
-    _(proc { user.custom_attributes['thing'] = { 1 => 2 } }).must_raise(ArgumentError)
-    _(proc { user.custom_attributes['thing'] = { 1 => { 2 => 3 } } }).must_raise(ArgumentError)
 
     user = Intercom::User.from_api(test_user)
     _(proc { user.custom_attributes['thing'] = [1] }).must_raise(ArgumentError)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: intercom
 version: !ruby/object:Gem::Version
-  version: 4.2.1
+  version: 4.2.2
 platform: ruby
 authors:
 - Ben McRedmond
@@ -12,10 +12,10 @@ authors:
 - Declan McGrath
 - Jamie Osler
 - Bob Long
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-12-16 00:00:00.000000000 Z
+date: 2025-09-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -65,14 +65,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: fakeweb
   requirement: !ruby/object:Gem::Requirement
@@ -264,7 +264,7 @@ homepage: https://www.intercom.io
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -279,8 +279,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.16
-signing_key: 
+rubygems_version: 3.0.3.1
+signing_key:
 specification_version: 4
 summary: Ruby bindings for the Intercom API
 test_files: