intercom 3.5.10 → 3.5.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0f98bf7f9725ad035949ca88859ba807a6323a83
-  data.tar.gz: 97e46a4507500d311495e11114fb80d0715cb0a0
+  metadata.gz: 3017e9c7947af1ad08fba93c5d5cd16d4f491b5b
+  data.tar.gz: e34343229866f215a24a1888a5d10164934fe881
 SHA512:
-  metadata.gz: 8c83c5d9c5ad9d4844b5b8f7c3602e6bf76cbbb9e9836b264acbdcfdb5e3567310c1441e23c7cd0b2dac30f0200bbea46175fe9eea5c130aa49d16e9ca5cd2d4
-  data.tar.gz: b480c171fd98135e719c37be86b0d13f7288f65130583d863afad3dd32acdc42de3e66be8941620047ba57db9fc54548b10307cbed55bd5278563825e6728de0
+  metadata.gz: d54158812a58f552cf5bced5b3307d8a0297a9b31c007e29cb38503272813591787f220f613625ff2b01980243a12f5a49771e779a4e457ad4759d4e14e02c10
+  data.tar.gz: 912b3598890f7d1416045ca14fdb1c672cd5e46eba59f799ac09a3c5641498cea4704c826e536c630d867c3ecc377891aedeb6a4c67cf240365db65084b7fb11

data/README.md

@@ -22,7 +22,7 @@ This version of the gem is compatible with `Ruby 2.1` and above.
 
 Using bundler:
 
-    gem 'intercom', '~> 3.5.9'
+    gem 'intercom', '~> 3.5.10'
 
 ## Basic Usage
 

data/RELEASING.md

@@ -0,0 +1,9 @@
+# Releasing Intercom
+
+We use https://github.com/svenfuchs/gem-release to tag, bump, and release new versions
+
+Please add a line to changes.txt before you release a new version.
+
+```
+gem bump --tag --release
+```

data/changes.txt

@@ -1,3 +1,6 @@
+3.5.10
+  - Add Support for find_all events pagination (@jkeyes)
+
 3.5.9
  - Fix event create method
 

data/lib/intercom/api_operations/find_all.rb

@@ -16,7 +16,7 @@ module Intercom
           finder_details[:url] = "/#{collection_name}"
           finder_details[:params] = params
         end
-        ClientCollectionProxy.new(collection_name, finder_details: finder_details,  client: @client)
+        collection_proxy_class.new(collection_name, finder_details: finder_details,  client: @client)
       end
 
       private

data/lib/intercom/service/base_service.rb

@@ -1,3 +1,5 @@
+require 'intercom/client_collection_proxy'
+
 module Intercom
   module Service
     class BaseService
@@ -11,6 +13,10 @@ module Intercom
         raise NotImplementedError
       end
 
+      def collection_proxy_class
+        Intercom::ClientCollectionProxy
+      end
+
       def from_api(api_response)
         object = collection_class.new
         object.from_response(api_response)

data/lib/intercom/service/event.rb

@@ -1,8 +1,16 @@
+require 'intercom/client_collection_proxy'
 require 'intercom/service/base_service'
 require 'intercom/api_operations/save'
 require 'intercom/api_operations/bulk/submit'
 
 module Intercom
+  class EventCollectionProxy < ClientCollectionProxy
+
+    def paging_info_present?(response_hash)
+      !!(response_hash['pages'])
+    end
+  end
+
   module Service
     class Event < BaseService
       include ApiOperations::FindAll
@@ -12,6 +20,10 @@ module Intercom
       def collection_class
         Intercom::Event
       end
+
+      def collection_proxy_class
+        Intercom::EventCollectionProxy
+      end
     end
   end
 end

data/lib/intercom/version.rb

@@ -1,3 +1,3 @@
 module Intercom #:nodoc:
-  VERSION = "3.5.10"
+  VERSION = "3.5.11"
 end

data/spec/spec_helper.rb

@@ -568,11 +568,23 @@ def test_event_list
     "type" => "event.list",
     "events" => [ test_event ],
     "pages" => {
-      "next" => "https =>//api.intercom.io/events?type=user&intercom_user_id=55a3b&before=144474756550"
+      "next" => "https://api.intercom.io/events?type=user&intercom_user_id=55a3b&before=144474756550"
     }
   }
 end
 
+def page_of_events(include_next_link=false)
+  {
+     "type" => "event.list",
+     "events" => [ test_event ],
+     "pages" =>
+      {
+        "next" => (include_next_link ? "https://api.intercom.io/events?type=user&intercom_user_id=55a3b&before=144474756550" : nil),
+      }
+  }
+end
+
+
 def error_on_modify_frozen
   RUBY_VERSION =~ /1.8/ ? TypeError : RuntimeError
 end

data/spec/unit/intercom/event_spec.rb

@@ -11,6 +11,25 @@ describe "Intercom::Event" do
     client.events.find_all(type: 'user', email: 'joe@example.com').first
   end
 
+  it "has the correct collection proxy class" do
+    client.events.collection_proxy_class.must_equal Intercom::EventCollectionProxy
+  end
+
+  it "stops iterating if no next link" do
+    client.expects(:get).with("/events", type: 'user', email: 'joe@example.com').returns(page_of_events(false))
+    event_names = []
+    client.events.find_all(type: 'user', email: 'joe@example.com').each { |event| event_names << event.event_name }
+    event_names.must_equal %W(invited-friend)
+  end
+
+  it "keeps iterating if next link" do
+    client.expects(:get).with("/events", type: 'user', email: 'joe@example.com').returns(page_of_events(true))
+    client.expects(:get).with("https://api.intercom.io/events?type=user&intercom_user_id=55a3b&before=144474756550", {}).returns(page_of_events(false))
+    event_names = []
+    client.events.find_all(type: 'user', email: 'joe@example.com').each { |event| event_names << event.event_name }
+    event_names.must_equal %W(invited-friend invited-friend)
+  end
+
   it "creates an event with metadata" do
     client.expects(:post).with('/events', {'event_name' => 'Eventful 1', 'created_at' => created_time.to_i, 'email' => 'joe@example.com', 'metadata' => {'invitee_email' => 'pi@example.org', :invite_code => 'ADDAFRIEND', 'found_date' => 12909364407}}).returns(:status => 202)
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: intercom
 version: !ruby/object:Gem::Version
-  version: 3.5.10
+  version: 3.5.11
 platform: ruby
 authors:
 - Ben McRedmond
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-10 00:00:00.000000000 Z
+date: 2017-02-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -137,6 +137,7 @@ files:
 - Gemfile
 - MIT-LICENSE
 - README.md
+- RELEASING.md
 - Rakefile
 - changes.txt
 - intercom.gemspec
@@ -242,7 +243,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: intercom
-rubygems_version: 2.4.8
+rubygems_version: 2.6.1
 signing_key: 
 specification_version: 4
 summary: Ruby bindings for the Intercom API
@@ -269,4 +270,3 @@ test_files:
 - spec/unit/intercom/user_spec.rb
 - spec/unit/intercom/visitors_spec.rb
 - spec/unit/intercom_spec.rb
-has_rdoc: