intercom 2.1.1 → 2.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d9ed1775dc3cc5e1980a18e1419ce693ec689fb8
-  data.tar.gz: 0dc43ebffc28d82a5ac234718d2f5825145b1285
+  metadata.gz: bfa7fdd97efe351ed92aaeb329120fa12544523c
+  data.tar.gz: 2fdd8a519b9f5f27cf25706467671dfd34c760ab
 SHA512:
-  metadata.gz: 522dba42daac4713dddace9c320278f93c56e1e12998054bfbfe865d84e8832d8108edff50624f913a28362f8c7f4a9577e340cf9810c31c0f4987d30330af1f
-  data.tar.gz: 0440645b457b10b1f59792ef6e742b8c96ca46a1a40b7b011ed910a27e777eb03324a0a8db99167f835d67e1f66e295568bb63d051f293048aca766c869ee729
+  metadata.gz: a7c1c1db29702c1b4dab017afbe3b80b4a67ab6cbb419e35e426b0d5ac3d73d72307b67f9dd171c45bde0365c6e4fae88d22d490643135cb2a61b179cbcf1dcf
+  data.tar.gz: c45e08a51fc9462b587ef2529e2752359b26edbe470d9d33d739c68bdbe975059d19ded0839ea928e099d0c28ac649876b1d187596f5708d6a3f3ec1f798a9ee

data/changes.txt

@@ -1,3 +1,7 @@
+2.2.2
+- Clean up some spec warnings
+- Fix incrementing of custom data
+
 2.1.1
 - Added User Agent header
 

data/lib/intercom/admin.rb

@@ -4,7 +4,6 @@ require 'intercom/traits/api_resource'
 module Intercom
   class Admin
     include ApiOperations::List
-    include Traits::IncrementableAttributes
     include Traits::ApiResource
   end
 end

data/lib/intercom/generic_handlers/count.rb

@@ -22,7 +22,7 @@ module Intercom
 
             def do_count
               entity.fetch_for_app.send(appwide_entity_to_count)['count']
-            rescue Intercom::AttributeNotSetError => ex
+            rescue Intercom::AttributeNotSetError
               # Indicates this this kind of counting is not supported
               raise_no_method_missing_handler
             end

data/lib/intercom/generic_handlers/tag.rb

@@ -41,7 +41,7 @@ module Intercom
             end
             
             def tag_object_list(args)
-              to_tag_object_list = args[1].map { |id| { :id => id } }
+              args[1].map { |id| { :id => id } }
             end
             
             def untag_object_list(args)

data/lib/intercom/traits/incrementable_attributes.rb

@@ -3,20 +3,9 @@ module Intercom
     module IncrementableAttributes
 
       def increment(key, value=1)
-        mark_field_as_changed!(:increments)
-        increments[key] ||= 0
-        increments[key] += value
-      end
-
-      private
-
-      def increments
-        @increments ||= {}
-      end
-
-      def increments=(hash)
-        mark_field_as_changed!(:increments)
-        @increments = hash
+        existing_value = self.custom_attributes[key]
+        existing_value ||= 0
+        self.custom_attributes[key] = existing_value + value
       end
     end
   end

data/lib/intercom/version.rb

@@ -1,3 +1,3 @@
 module Intercom #:nodoc:
-  VERSION = "2.1.1"
+  VERSION = "2.1.2"
 end

data/spec/spec_helper.rb

@@ -108,7 +108,6 @@ def test_message
 end
 
 def page_of_users(include_next_link: false)
-  all_user =
   {
      "type"=>"user.list",
      "pages"=>

data/spec/unit/intercom/traits/api_resource_spec.rb

@@ -18,7 +18,6 @@ describe Intercom::Traits::ApiResource do
   before(:each) { api_resource.from_response(object_json) }
 
   it "does not set type on parsing json" do
-    assert_nil api_resource.instance_variable_get(:@type)
     api_resource.wont_respond_to :type
   end
 

data/spec/unit/intercom/user_spec.rb

@@ -115,40 +115,28 @@ describe "Intercom::User" do
 
     it "increments up by 1 with no args" do
       @user.increment("mad")
-      @user.to_hash["increments"].must_equal "mad" => 1
+      @user.to_hash["custom_attributes"]["mad"].must_equal 124
     end
 
     it "increments up by given value" do
       @user.increment("mad", 4)
-      @user.to_hash["increments"].must_equal "mad" => 4
+      @user.to_hash["custom_attributes"]["mad"].must_equal 127
     end
 
     it "increments down by given value" do
       @user.increment("mad", -1)
-      @user.to_hash["increments"].must_equal "mad" => -1
-    end
-
-    it "doesn't allow direct access to increments hash" do
-      proc { @user.increments["mad"] = 1 }.must_raise Intercom::AttributeNotSetError
-      proc { @user.increments }.must_raise Intercom::AttributeNotSetError
-    end
-
-    it "can update the increments hash without losing previous changes" do
-      @user.increment("mad")
-      @user.to_hash["increments"].must_equal "mad" => 1
-      @user.increment("another", -2)
-      @user.to_hash["increments"].must_equal "mad" => 1, "another" => -2
+      @user.to_hash["custom_attributes"]["mad"].must_equal 122
     end
 
     it "can increment new custom data fields" do
       @user.increment("new_field", 3)
-      @user.to_hash["increments"].must_equal "new_field" => 3
+      @user.to_hash["custom_attributes"]["new_field"].must_equal 3
     end
 
     it "can call increment on the same key twice and increment by 2" do
       @user.increment("mad")
       @user.increment("mad")
-      @user.to_hash["increments"].must_equal "mad" => 2
+      @user.to_hash["custom_attributes"]["mad"].must_equal 125
     end
   end
 

data/spec/unit/intercom_spec.rb

@@ -40,6 +40,7 @@ describe Intercom do
       after do
         Intercom.protocol = @protocol
         Intercom.hostname = @hostname
+        Intercom.endpoints = ["https://api.intercom.io"]
       end
 
       it "allows overriding of the endpoint and protocol" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: intercom
 version: !ruby/object:Gem::Version
-  version: 2.1.1
+  version: 2.1.2
 platform: ruby
 authors:
 - Ben McRedmond
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-27 00:00:00.000000000 Z
+date: 2014-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest