intercom 0.1.8 → 0.1.9

data/changes.txt

@@ -1,3 +1,6 @@
+0.1.9
+ - better response object for tags
+
 0.1.8
  - change tag response to match the new api response. add support to query users that are tagged with a specific tag
 

data/lib/intercom/hashable_object.rb

@@ -2,8 +2,7 @@ module Intercom
   module HashableObject
     def from_hash(hash)
       hash.each do |key,value|
-        setter_method = "#{key.to_s}="
-        self.send(setter_method, value) if self.respond_to?(setter_method)
+        instance_variable_set("@#{key}".to_sym, value)
       end
     end
 
@@ -13,5 +12,9 @@ module Intercom
         hash
       end
     end
+
+    def displayable_attributes
+      to_hash.delete_if {|k, v| !self.respond_to?(k) }
+    end
   end
 end

data/lib/intercom/tag.rb

@@ -24,7 +24,7 @@ module Intercom
   #  Or update a tag and save it like this:
   #  tag = Intercom::Tag.find_by_name "Super Tag"
   #  tag.color = "green"
-  #  tag.user_ids << 'abc123'
+  #  tag.user_ids = ['abc123']
   #  tag.tag_or_untag = "untag"
   #  tag.save
 
@@ -32,7 +32,7 @@ module Intercom
     extend RequiresParameters
     include HashableObject
 
-    attr_accessor :name, :color, :user_ids, :emails, :tag_or_untag, :segment, :tagged_user_count, :id
+    attr_reader :name, :color, :segment, :tagged_user_count, :id
 
     def initialize(attributes={})
       from_hash(attributes)
@@ -48,7 +48,7 @@ module Intercom
     def self.from_api(api_response)
       tag = Tag.new
       tag.from_hash(api_response)
-      tag
+      tag.displayable_self
     end
 
     ##
@@ -70,7 +70,13 @@ module Intercom
     def save
       response = Intercom.post("/v1/tags", to_hash)
       self.from_hash(response)
-      self
+      displayable_self
+    end
+
+    ##
+    # Create a new clean instance to return (only showing the readable attributes)
+    def displayable_self
+      Tag.new(self.displayable_attributes)
     end
   end
 end

data/lib/intercom/version.rb

@@ -1,3 +1,3 @@
 module Intercom #:nodoc:
-  VERSION = "0.1.8"
+  VERSION = "0.1.9"
 end

data/spec/spec_helper.rb

@@ -1,6 +1,6 @@
 require 'intercom'
 require 'minitest/autorun'
-require 'mocha'
+require 'mocha/setup'
 
 def test_user(email="bob@example.com")
   {

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: intercom
 version: !ruby/object:Gem::Version
-  version: 0.1.8
+  version: 0.1.9
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-09 00:00:00.000000000 Z
+date: 2013-04-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest