intercom-rails 0.3.8 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 2c8c86341c15d5e3d7620a1a737c2a2eb62744b3
-  data.tar.gz: bccf57bc964ba2aa3daa7dee8b7e569e21d28d4f
+SHA256:
+  metadata.gz: 253fda3b6f83f376ead3c83360c0961be21060cab192d6d6ca49b0f3308fc607
+  data.tar.gz: 2cd892059becff0f29dc82d6aa9e85979ba2bb1da03feec6257972342e893169
 SHA512:
-  metadata.gz: 923ca98ea86eee4d13dbfc68691f706883fe08929e6d147888522e2aa1f93f95f6720e5ce033671e29531d4811fff9e13a73ec6bc7c26f23f805b085d3617f63
-  data.tar.gz: 396f0c39720971cd3afc59869e015c076cc4ba5e608b41069a0406902ad70e9b70c784a7f41ee7983739e04feaca4d619a832d8f1b2c9d704c5fb5ee7b14a747
+  metadata.gz: 87baa5f81d73eac5cec417df64b1d3884e75e4fcb98a7397be636409479f12dab4b5ea6d601db335a6012820d05c503892c275014194cf763fa3ebcde9d4f687
+  data.tar.gz: bfa0536a645fa87c1af4720465aad50279c44b2edaaf245236a12efe9270406f9dd6d9ff6021f77df8d33b2b2156b788a243d5da59d326cf665fad5cf6a33b64

data/README.md

@@ -62,12 +62,13 @@ Feel free to mail us: team@intercom.io, if you're still having trouble.
 ## Configuration
 
 ### API Secret
-If you want to use Identity Verification, ensure you set your API secret in `config/initializers/intercom.rb`:
+It is possible to enable Identity Verification for the Intercom Messenger and you can find the documentation in how to [here](https://developers.intercom.com/docs/enable-secure-mode-on-your-web-product). If you want to use this feature, ensure you set your Identity Verification Secret as the API secret in `config/initializers/intercom.rb`:
 
 ```ruby
   config.api_secret = '123456'
 ```
-**Note: This example is just for the sake of simplicity, you should never include your api secret in source control. Instead, you should use the Rails [secret config](http://guides.rubyonrails.org/4_1_release_notes.html#config-secrets-yml) feature.**
+**Note: This example is just for the sake of simplicity, you should never include this secret in source control. Instead, you should use the Rails [secret config](http://guides.rubyonrails.org/4_1_release_notes.html#config-secrets-yml) feature.**
+
 ### Shutdown
 
 If you use Intercom Respond combined with another product like Engage, any user that uses a shared computer and browser with someone else will be able to see the most recently logged in user’s conversation history until the cookie expires.
@@ -115,7 +116,7 @@ class VisitorsController < ApplicationController
 
   protected
   def intercom_shutdown
-    IntercomRails::ShutdownHelper.intercom_shutdown(session, cookies)
+    IntercomRails::ShutdownHelper.intercom_shutdown(session, cookies, request.domain)
   end
 end
 ```
@@ -125,7 +126,7 @@ end
 If you use another service than Devise or if you implemented your own authentication service, you can call the following method in a controller to shutdown Intercom on logout.
 
 ```ruby
-IntercomRails::ShutdownHelper::intercom_shutdown_helper(cookies)
+IntercomRails::ShutdownHelper::intercom_shutdown_helper(cookies, domain)
 ```
 
 **Be aware that if you call this method before a 'redirect_to' (quite common on logout) it will have no impact** as it is impossible to update cookies when you use a redirection.

data/lib/intercom-rails/shutdown_helper.rb

@@ -3,13 +3,16 @@ module IntercomRails
     # This helper allows to erase cookies when a user log out of an application
     # It is recommanded to call this function every time a user log out of your application
     # Do not use before a redirect_to because it will not clear the cookies on a redirection
-    def self.intercom_shutdown_helper(cookies)
+    def self.intercom_shutdown_helper(cookies, domain = nil)
+      nil_session = { value: nil, expires: 1.day.ago }
+      nil_session = nil_session.merge(domain: domain) unless domain.nil? || domain == 'localhost'
+
       if (cookies.is_a?(ActionDispatch::Cookies::CookieJar))
-        cookies["intercom-session-#{IntercomRails.config.app_id}"] = { value: nil, expires: 1.day.ago}
+        cookies["intercom-session-#{IntercomRails.config.app_id}"] = nil_session
       else
         controller = cookies
         Rails.logger.info("Warning: IntercomRails::ShutdownHelper.intercom_shutdown_helper takes an instance of ActionDispatch::Cookies::CookieJar as an argument since v0.2.34. Passing a controller is depreciated. See https://github.com/intercom/intercom-rails#shutdown for more details.")
-        controller.response.delete_cookie("intercom-session-#{IntercomRails.config.app_id}", { value: nil, expires: 1.day.ago})
+        controller.response.delete_cookie("intercom-session-#{IntercomRails.config.app_id}", nil_session)
       end
     rescue
     end
@@ -18,10 +21,10 @@ module IntercomRails
       session[:perform_intercom_shutdown] = true
     end
 
-    def self.intercom_shutdown(session, cookies)
+    def self.intercom_shutdown(session, cookies, domain = nil)
       if session[:perform_intercom_shutdown]
         session.delete(:perform_intercom_shutdown)
-        intercom_shutdown_helper(cookies)
+        intercom_shutdown_helper(cookies, domain)
       end
     end
 

data/lib/intercom-rails/version.rb

@@ -1,3 +1,3 @@
 module IntercomRails
-  VERSION = "0.3.8"
+  VERSION = "0.4.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: intercom-rails
 version: !ruby/object:Gem::Version
-  version: 0.3.8
+  version: 0.4.0
 platform: ruby
 authors:
 - Ben McRedmond
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-23 00:00:00.000000000 Z
+date: 2018-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -203,7 +203,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: intercom-rails
-rubygems_version: 2.5.1
+rubygems_version: 2.7.4
 signing_key: 
 specification_version: 4
 summary: Rails helper for emitting javascript script tags for Intercom