intercom-rails 0.2.1 → 0.2.2

data/README.mdown

@@ -170,6 +170,7 @@ Any custom data defined in `config/initializers/intercom.rb` will also be sent.
 ## Contributors
 
 - Dr Nic Williams (@drnic) - provided a rails generator for adding the Intercom javascript tag into your layout.
+- Alexander Chaychuk (@sashich) - fixed bug in user detection when users not persisted (e.g. new session view with devise).
 
 ## License
 

data/lib/intercom-rails/proxy/user.rb

@@ -35,7 +35,7 @@ module IntercomRails
       end
 
       def valid?
-        return false if user.blank?
+        return false if user.blank? || user.respond_to?(:new_record?) && user.new_record?
         return true if user.respond_to?(:id) && user.id.present?
         return true if user.respond_to?(:email) && user.email.present?
         false

data/lib/intercom-rails/version.rb

@@ -1,3 +1,3 @@
 module IntercomRails
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
 end

data/test/intercom-rails/proxy/user_test.rb

@@ -74,6 +74,14 @@ class UserTest < MiniTest::Unit::TestCase
     assert_equal true, User.new(DUMMY_USER).valid?
   end
 
+  def test_not_valid_if_new_record?
+    new_record_user = dummy_user(:email => 'not-saved@intercom.io', :name => 'New Record')
+    def new_record_user.new_record?
+      true
+    end
+    assert_equal false, User.new(new_record_user).valid?
+  end
+
   def test_includes_custom_data_from_intercom_custom_data
     object_with_intercom_custom_data = Object.new
     object_with_intercom_custom_data.instance_eval do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: intercom-rails
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
   prerelease: 
 platform: ruby
 authors:
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-28 00:00:00.000000000 Z
+date: 2012-11-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -179,18 +179,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -3480669061587157733
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -3480669061587157733
 requirements: []
 rubyforge_project: intercom-rails
 rubygems_version: 1.8.23