inteltech_sms 0.1.4 → 1.0.0

data/.travis.yml

@@ -66,3 +66,11 @@ matrix:
       - RUBYGEMS_VERSION=1.8.25
       - TEST_GEM=true
       - secure: "D6Sd+bPmNb3P+98W1arc+SbaFV8oC+0NhnZX9fcoIqCHfnVpt6Vd54idUxJv\nhhFUFmySl17zCX/HRaVoscpCYPcJWRWIeXSD4qrHlObaTx+BDKlMAlWl/Y7d\nQy9c4g+QbDhz94l3DeNW7VbCYz/YYyRPBCcZK+K3H1KPmMtngRU="
+  allow_failures:
+    - rvm: rbx-19mode
+    - rvm: rbx-19mode
+      env:
+      - RUBYGEMS_VERSION=1.8.25
+      - TEST_GEM=true
+      - secure: "D6Sd+bPmNb3P+98W1arc+SbaFV8oC+0NhnZX9fcoIqCHfnVpt6Vd54idUxJv\nhhFUFmySl17zCX/HRaVoscpCYPcJWRWIeXSD4qrHlObaTx+BDKlMAlWl/Y7d\nQy9c4g+QbDhz94l3DeNW7VbCYz/YYyRPBCcZK+K3H1KPmMtngRU="
+

data/README.rdoc

@@ -50,6 +50,49 @@ Example ruby code:
     puts "send_multiple_sms (sending to mobiles should work, sending to a landline should fail):"
     puts res2.collect {|r| "sms to #{r.sms} #{r.success? ? 'was successfull' : "failed (#{r.class} with code #{r.response_code})"}."}.join("\n")
 
+=== Dummy for testing
+
+A Dummy class is also provided for use with tests. The dummy class will return a response based on the response code given.
+
+You can instantiate an instance of the DummyInteltechSms, passing the initial credit, and optionally the response code
+
+Example ruby code:
+
+    require 'rubygems'
+
+    require 'dummy_inteltech_sms'
+
+    test_sms = '123'
+
+    gateway = DummyInteltechSms.new(1)
+
+    credit = gateway.get_credit.inspect
+
+    puts "You have #{credit} Credit/s left"
+
+    res = gateway.send_sms(test_sms,'Test from Ruby')
+    puts "send_sms to #{res.sms} was successfull."
+
+    credit = gateway.get_credit.inspect
+    puts "You have #{credit} Credit/s left"
+
+    begin
+      # This will return no credit
+      res = gateway.send_sms(test_sms,'Test from Ruby')
+      puts "send_sms to #{res.sms} was successfull."
+    rescue ex => InteltechSms::Error
+      puts "send_sms to #{res.sms} failed. Gateway response #{ex.response.class} with code #{ex.response.response_code}."
+    end
+
+    res2 = gateway.send_multiple_sms([test_sms, test_sms2, landline_sms],'Test from Ruby to multiple numbers')
+
+    gateway.response_code = InteltechSms::UNAUTHORIZED_RESPONSE_CODE
+    # OR
+    gateway = DummyInteltechSms.new(1,InteltechSms::UNAUTHORIZED_RESPONSE_CODE)
+
+    puts "send_multiple_sms (sending to mobiles should work, sending to a landline should fail):"
+    puts res2.collect {|r| "sms to #{r.sms} #{r.success? ? 'was successfull' : "failed (#{r.class} with code #{r.response_code})"}."}.join("\n")
+
 === Optional arguments
 
 There are a few optional parameters that the gateway will accept.

data/VERSION

@@ -1 +1 @@
-0.1.4
+1.0.0

data/inteltech_sms.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "inteltech_sms"
-  s.version = "0.1.4"
+  s.version = "1.0.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Ian Heggie"]
-  s.date = "2013-10-29"
+  s.date = "2013-12-01"
   s.description = "Ruby gem that provides an InteltechSms class to check credit and send SMS text messages to single or multiple recipients"
   s.email = "ian@heggie.biz"
   s.extra_rdoc_files = [
@@ -27,8 +27,10 @@ Gem::Specification.new do |s|
     "Rakefile",
     "VERSION",
     "inteltech_sms.gemspec",
+    "lib/dummy_inteltech_sms.rb",
     "lib/inteltech_sms.rb",
     "test/helper.rb",
+    "test/test_dummy_inteltech_sms.rb",
     "test/test_inteltech_sms.rb"
   ]
   s.homepage = "http://github.com/ianheggie/inteltech_sms"

data/lib/dummy_inteltech_sms.rb

@@ -0,0 +1,61 @@
+
+require 'net/http'
+
+require 'inteltech_sms'
+
+# Dummy Class for testing
+
+class DummyInteltechSms < InteltechSms 
+
+
+  attr_accessor :credit, :response_code 
+
+  def initialize(credit, response_code = InteltechSms::SUCCESS_RESPONSE_CODE)
+    super('dummy_user', 'a_secret')
+    @credit = credit.to_i
+    @response_code = response_code
+    @last_sms = ''
+  end
+
+  def get_credit
+    res = InteltechSms::FakeHTTPSuccess.new(@response_code == InteltechSms::SUCCESS_RESPONSE_CODE ? "credit,#{@credit}" : @response_code)
+    process_get_credit_response(res)
+  end
+
+  def send_sms(sms, message, options = { })
+    this_response_code = response_code_for_sms(sms)
+    @credit -= 1 if this_response_code == InteltechSms::SUCCESS_RESPONSE_CODE
+    res = InteltechSms::FakeHTTPSuccess.new(this_response_code)
+    process_send_sms_response(res, sms)
+  end
+
+  def send_multiple_sms(sms, message, options = { })
+    this_response_code = response_code_for_sms(sms)
+    sms_array = (sms.respond_to?(:each) ? sms : sms.split(','))
+    @credit -= sms_array.size if this_response_code == InteltechSms::SUCCESS_RESPONSE_CODE
+
+    ret = [ ]
+    sms_array.each do |this_sms|
+      ret << Response.factory(this_sms.strip, this_response_code)
+    end
+    ret
+  end
+
+  private
+
+  def response_code_for_sms(sms)
+    ret = @response_code
+    if ret == InteltechSms::SUCCESS_RESPONSE_CODE
+      if @credit <= 0 
+        ret = InteltechSms::NO_CREDIT_RESPONSE_CODE
+      else
+        ret = @last_sms == sms ? InteltechSms::DUPLICATE_RESPONSE_CODE : @response_code
+        @last_sms = sms
+      end
+    end
+    ret
+  end
+
+end
+
+# vi:ai sw=2:

data/lib/inteltech_sms.rb

@@ -3,6 +3,28 @@ require "rexml/document"
 
 class InteltechSms
 
+  SUCCESS_RESPONSE_CODE = '0000'
+  UNAUTHORIZED_RESPONSE_CODE = '2006'
+  ACCOUNT_NOT_ACTIVATED_RESPONSE_CODE = '2007'
+  INVALID_NUMBER_RESPONSE_CODE = '2015'
+  DUPLICATE_RESPONSE_CODE = '2016'
+  NO_CREDIT_RESPONSE_CODE = '2018'
+  UNAUTHORIZED_KEY_RESPONSE_CODE = '2022'
+  EMPTY_MESSAGE_RESPONSE_CODE = '2051'
+  TOO_MANY_RECIPIENTS_RESPONSE_CODE = '2052'
+
+  # General failures
+  INVALID_SENDER_RESPONSE_CODE = '2017'
+
+  class FakeHTTPSuccess
+    attr_accessor :body
+
+    def initialize(body)
+      @body = body
+    end
+  end
+
+
   class Error < StandardError
     attr_reader :response
     def initialize(response)
@@ -22,20 +44,24 @@ class InteltechSms
 
     def self.factory(sms, response_code)
       case response_code.strip
-      when '0000'
+      when SUCCESS_RESPONSE_CODE
         Success.new(sms, response_code)
-      when '2006'
+      when UNAUTHORIZED_RESPONSE_CODE
         Unauthorized.new(sms, response_code)
-      when '2015'
+      when INVALID_NUMBER_RESPONSE_CODE
         BadRequest.new(sms, response_code)
-      when '2016'
+      when DUPLICATE_RESPONSE_CODE
         Duplicate.new(sms, response_code)
-      when '2018'
+      when NO_CREDIT_RESPONSE_CODE
         NoCredit.new(sms, response_code)
-      when '2022'
+      when UNAUTHORIZED_KEY_RESPONSE_CODE
         Unauthorized.new(sms, response_code)
-      when '2051'
+      when EMPTY_MESSAGE_RESPONSE_CODE
+        BadRequest.new(sms, response_code)
+      when TOO_MANY_RECIPIENTS_RESPONSE_CODE
         BadRequest.new(sms, response_code)
+      when ACCOUNT_NOT_ACTIVATED_RESPONSE_CODE
+        Unauthorized.new(sms, response_code)
       else 
         Failure.new(sms, response_code)
       end
@@ -86,8 +112,29 @@ class InteltechSms
   def get_credit
     uri = URI('http://inteltech.com.au/secure-api/credit.php')
     res = Net::HTTP.post_form(uri, 'username' => @username, 'key' => @secret_key, 'method' => 'ruby')
+    process_get_credit_response(res)
+  end
+
+  def send_sms(sms, message, options = { })
+    uri = URI('http://inteltech.com.au/secure-api/send.single.php')
+    args = { :username => @username, :key => @secret_key, :sms => sms, :message => message, :method => 'ruby' }.merge(options)
+    res = Net::HTTP.post_form(uri, args)
+    process_send_sms_response(res, sms)
+  end
+
+  def send_multiple_sms(sms, message, options = { })
+    uri = URI('http://inteltech.com.au/secure-api/send.php')
+    sms_string = sms.respond_to?(:join) ? sms.join(',') : sms.to_s
+    args = { :username => @username, :key => @secret_key, :sms => sms_string, :message => message, :method => 'ruby' }.merge(options)
+    res = Net::HTTP.post_form(uri, args)
+    process_send_multiple_sms_response(res)
+  end
+
+  protected
+
+  def process_get_credit_response(res)
     case res
-    when Net::HTTPSuccess, Net::HTTPRedirection
+    when Net::HTTPSuccess, Net::HTTPRedirection, InteltechSms::FakeHTTPSuccess
       if res.body =~ /credit,(\d*)/
         $1.to_i 
       elsif res.body =~ /\d\d\d\d/
@@ -100,13 +147,9 @@ class InteltechSms
     end
   end
 
-  def send_sms(sms, message, options = { })
-    uri = URI('http://inteltech.com.au/secure-api/send.single.php')
-    
-    args = { :username => @username, :key => @secret_key, :sms => sms, :message => message, :method => 'ruby' }.merge(options)
-    res = Net::HTTP.post_form(uri, args)
+  def process_send_sms_response(res, sms)
     case res
-    when Net::HTTPSuccess, Net::HTTPRedirection
+    when Net::HTTPSuccess, Net::HTTPRedirection, InteltechSms::FakeHTTPSuccess
       r= Response.factory(sms, res.body)
       raise InteltechSms::Error.new(r) unless r.success?
       r
@@ -115,11 +158,7 @@ class InteltechSms
     end
   end
 
-  def send_multiple_sms(sms, message, options = { })
-    uri = URI('http://inteltech.com.au/secure-api/send.php')
-    sms_string = sms.respond_to?(:join) ? sms.join(',') : sms.to_s
-    args = { :username => @username, :key => @secret_key, :sms => sms_string, :message => message, :method => 'ruby' }.merge(options)
-    res = Net::HTTP.post_form(uri, args)
+  def process_send_multiple_sms_response(res)
     case res
     when Net::HTTPSuccess, Net::HTTPRedirection
       doc = REXML::Document.new res.body

data/test/helper.rb

@@ -21,6 +21,7 @@ end
 #$LOAD_PATH.unshift(File.dirname(__FILE__))
 
 require 'inteltech_sms'
+require 'dummy_inteltech_sms'
 
 class Test::Unit::TestCase
 end

data/test/test_dummy_inteltech_sms.rb

@@ -0,0 +1,250 @@
+require 'helper'
+require 'net/http'
+
+class TestDummyInteltechSms < Test::Unit::TestCase
+
+  # ==================================================
+  # Useful constants
+
+  TEST_SMS = '04111'
+  TEST_SMS2 = '04222'
+  LANDLINE_SMS = '03123'
+
+  # ==================================================
+  # Tests
+
+  # Code 0000 Message added to queue OK.
+
+  context "with credit" do
+
+    setup do
+      @good_gateway = DummyInteltechSms.new(123)
+    end
+
+    should "get_credit should return non zero credit" do
+      assert_operator @good_gateway.get_credit, :>, 0
+    end
+
+    should "send a single test sms via send_sms" do
+      expected = InteltechSms::Success.new(TEST_SMS, InteltechSms::SUCCESS_RESPONSE_CODE)
+      assert_equal expected, @good_gateway.send_sms(TEST_SMS,'Test from Ruby - send a single test sms via send_sms')
+    end
+  end
+
+  context "#send_multiple_sms" do
+    should "return an array with a response for each sms sent" do
+      @good_gateway = DummyInteltechSms.new(123)
+      @res = @good_gateway.send_multiple_sms [TEST_SMS, TEST_SMS2],'Test from Ruby - return an array with a response for each sms sent'
+      assert_kind_of Array, @res
+      assert_equal 2, @res.length
+      assert_equal InteltechSms::Success.new(TEST_SMS, InteltechSms::SUCCESS_RESPONSE_CODE), @res[0], "send_multiple_sms returns success for 1st element"
+      assert_equal InteltechSms::Success.new(TEST_SMS2, InteltechSms::SUCCESS_RESPONSE_CODE), @res[1], "send_multiple_sms returns success for 2nd element"
+    end 
+
+    should "return an array with a response for each sms sent where a comma seperated string is provided" do
+      @good_gateway = DummyInteltechSms.new(123)
+      @res = @good_gateway.send_multiple_sms [TEST_SMS2, TEST_SMS].join(','),'Test from Ruby - return an array with a response for each sms sent where a comma seperated string is provided'
+      assert_kind_of Array, @res
+      assert_equal 2, @res.length
+      assert_equal InteltechSms::Success.new(TEST_SMS2, InteltechSms::SUCCESS_RESPONSE_CODE), @res[0], "send_multiple_sms returns success for 1st element"
+      assert_equal InteltechSms::Success.new(TEST_SMS, InteltechSms::SUCCESS_RESPONSE_CODE), @res[1], "send_multiple_sms returns success for 2nd element"
+    end 
+  end
+
+  # --------------------------------------------------
+  # Code 2006 Not enough information has been supplied for authentication. Please ensure that your Username and Unique Key are supplied in your request.
+
+  context "with blank username" do
+    setup do
+      @bad_gateway = DummyInteltechSms.new(0, InteltechSms::UNAUTHORIZED_RESPONSE_CODE)
+    end
+
+    should "raise an Unauthorized Error exception when get_credit is called" do
+      ex = assert_raises InteltechSms::Error do
+        @bad_gateway.get_credit
+      end
+      assert_equal InteltechSms::Unauthorized.new('', InteltechSms::UNAUTHORIZED_RESPONSE_CODE), ex.response
+    end
+
+    should "raise an Unauthorized Error exception when send_sms is called" do
+      ex = assert_raises InteltechSms::Error do
+        @bad_gateway.send_sms TEST_SMS, 'Tests from ruby - with blank username raise an Unauthorized Error exception when send_sms is called'
+      end
+      assert_equal InteltechSms::Unauthorized.new(TEST_SMS, InteltechSms::UNAUTHORIZED_RESPONSE_CODE), ex.response
+    end
+
+    should "return an array Unauthorized responses when send_multiple_sms is called" do
+      @res = @bad_gateway.send_multiple_sms [TEST_SMS, TEST_SMS2], 'Test from Ruby - with blank username return an array Unauthorized responses when send_multiple_sms is called'
+      assert_kind_of Array, @res
+      assert_equal 2, @res.length, "send_multiple_sms returns results for each sms sent"
+      assert_kind_of InteltechSms::Unauthorized, @res[0], "send_multiple_sms returns Unauthorized for 1st element"
+      assert_equal InteltechSms::Unauthorized.new(TEST_SMS, InteltechSms::UNAUTHORIZED_RESPONSE_CODE), @res[0]
+      assert_kind_of InteltechSms::Unauthorized, @res[1], "send_multiple_sms returns Unauthorized for 2nd element"
+      assert_equal InteltechSms::Unauthorized.new(TEST_SMS2, InteltechSms::UNAUTHORIZED_RESPONSE_CODE), @res[1]
+    end
+
+  end
+
+  # --------------------------------------------------
+  # Code 2015 The destination mobile number is invalid.
+
+  # --------------------------------------------------
+  # Code 2016  Identical message sent to this recipient. Please try again in a few seconds.
+
+  context "with a good username and secure_key" do
+
+    setup do
+      @good_gateway = DummyInteltechSms.new(123)
+    end
+
+    should "reject the second of a pair of indentical messages" do
+      expected = InteltechSms::BadRequest.new(TEST_SMS, InteltechSms::DUPLICATE_RESPONSE_CODE)
+      @good_gateway.send_sms(TEST_SMS,'Test from Ruby - send two copies of single test sms via send_sms')
+
+      @good_gateway.response_code = InteltechSms::DUPLICATE_RESPONSE_CODE
+
+      ex = assert_raises InteltechSms::Error do
+        @good_gateway.send_sms(TEST_SMS,'Test from Ruby - send two copies of single test sms via send_sms')
+      end
+      assert_equal InteltechSms::Duplicate.new(TEST_SMS, InteltechSms::DUPLICATE_RESPONSE_CODE), ex.response
+    end
+
+  end
+
+  # --------------------------------------------------
+  # Code 2018 You have reached the end of your message credits. You will need to purchase more messages.
+
+  context "With an account without credit" do
+    setup do
+      @nocredit_gateway = DummyInteltechSms.new(0)
+    end
+
+    should "have get_credit return zero credit" do
+      assert_equal 0, @nocredit_gateway.get_credit
+    end
+
+    should "raise an NoCredit Error exception when send_sms is called" do
+      @nocredit_gateway.response_code = InteltechSms::NO_CREDIT_RESPONSE_CODE
+      ex = assert_raises InteltechSms::Error do
+        @nocredit_gateway.send_sms TEST_SMS, 'Test from ruby - no credit on send_sms'
+      end
+      assert_equal InteltechSms::NoCredit.new(TEST_SMS, InteltechSms::NO_CREDIT_RESPONSE_CODE), ex.response
+    end
+
+    should "return an array NoCredit responses when send_multiple_sms is called" do
+      @res = @nocredit_gateway.send_multiple_sms [TEST_SMS, TEST_SMS2], 'Test from Ruby - return an array NoCredit responses when send_multiple_sms is called'
+      assert_kind_of Array, @res
+      assert_equal 2, @res.length, "send_multiple_sms returns results for each sms sent"
+      assert_kind_of InteltechSms::NoCredit, @res[0], "send_multiple_sms returns NoCredit for 1st element"
+      assert_equal InteltechSms::NoCredit.new(TEST_SMS, InteltechSms::NO_CREDIT_RESPONSE_CODE), @res[0]
+      assert_kind_of InteltechSms::NoCredit, @res[1], "send_multiple_sms returns NoCredit for 2nd element"
+      assert_equal InteltechSms::NoCredit.new(TEST_SMS2, InteltechSms::NO_CREDIT_RESPONSE_CODE), @res[1]
+    end
+
+  end
+
+  # --------------------------------------------------
+  # Code 2022 Your Unique Key is incorrect. This may be caused by a recent password change.
+
+  context "With an incorrect secure_key" do
+    setup do
+      @bad_gateway = DummyInteltechSms.new(0, InteltechSms::UNAUTHORIZED_KEY_RESPONSE_CODE)
+    end
+
+    should "raise an Unauthorized Error exception when get_credit is called" do
+      ex = assert_raises InteltechSms::Error do
+        @bad_gateway.get_credit
+      end
+      assert_equal InteltechSms::Unauthorized.new('', InteltechSms::UNAUTHORIZED_KEY_RESPONSE_CODE), ex.response
+    end
+
+    should "raise an Unauthorized Error exception when send_sms is called" do
+      ex = assert_raises InteltechSms::Error do
+        @bad_gateway.send_sms TEST_SMS, 'Test from ruby - incorrect secure key send_sms call'
+      end
+      assert_equal InteltechSms::Unauthorized.new(TEST_SMS, InteltechSms::UNAUTHORIZED_KEY_RESPONSE_CODE), ex.response
+    end
+
+    should "return an array Unauthorized responses when send_multiple_sms is called" do
+      @res = @bad_gateway.send_multiple_sms [TEST_SMS, TEST_SMS2], 'Test from Ruby - with incorrect key return an array Unauthorized responses when send_multiple_sms is called'
+      assert_kind_of Array, @res
+      assert_equal 2, @res.length, "send_multiple_sms returns results for each sms sent"
+      assert_kind_of InteltechSms::Unauthorized, @res[0], "send_multiple_sms returns Unauthorized for 1st element"
+      assert_equal InteltechSms::Unauthorized.new(TEST_SMS, InteltechSms::UNAUTHORIZED_KEY_RESPONSE_CODE), @res[0]
+      assert_kind_of InteltechSms::Unauthorized, @res[1], "send_multiple_sms returns Unauthorized for 2nd element"
+      assert_equal InteltechSms::Unauthorized.new(TEST_SMS2, InteltechSms::UNAUTHORIZED_KEY_RESPONSE_CODE), @res[1]
+    end
+
+  end
+
+  context "with blank secure_key" do
+    setup do
+      @bad_gateway = DummyInteltechSms.new(0, InteltechSms::UNAUTHORIZED_KEY_RESPONSE_CODE)
+    end
+
+    should "raise an Unauthorized Error exception when get_credit is called" do
+      ex = assert_raises InteltechSms::Error do
+        @bad_gateway.get_credit
+      end
+      assert_equal InteltechSms::Unauthorized.new('', InteltechSms::UNAUTHORIZED_KEY_RESPONSE_CODE), ex.response
+    end
+
+    should "raise an Unauthorized Error exception when send_sms is called" do
+      ex = assert_raises InteltechSms::Error do
+        @bad_gateway.send_sms TEST_SMS, 'Test from ruby - blank secure key send_sms call'
+      end
+      assert_equal InteltechSms::Unauthorized.new(TEST_SMS, InteltechSms::UNAUTHORIZED_KEY_RESPONSE_CODE), ex.response
+    end
+
+    should "return an array Unauthorized responses when send_multiple_sms is called" do
+      @res = @bad_gateway.send_multiple_sms [TEST_SMS, TEST_SMS2], 'Test from Ruby - with blank secure key return an array Unauthorized responses when send_multiple_sms is called'
+      assert_kind_of Array, @res
+      assert_equal 2, @res.length, "send_multiple_sms returns results for each sms sent"
+      assert_kind_of InteltechSms::Unauthorized, @res[0], "send_multiple_sms returns Unauthorized for 1st element"
+      assert_equal InteltechSms::Unauthorized.new(TEST_SMS, InteltechSms::UNAUTHORIZED_KEY_RESPONSE_CODE), @res[0]
+      assert_kind_of InteltechSms::Unauthorized, @res[1], "send_multiple_sms returns Unauthorized for 2nd element"
+      assert_equal InteltechSms::Unauthorized.new(TEST_SMS2, InteltechSms::UNAUTHORIZED_KEY_RESPONSE_CODE), @res[1]
+    end
+
+  end
+
+  # --------------------------------------------------
+  # Code 2051 Message is empty.
+
+  context "with an empty message" do
+
+    setup do
+      @good_gateway = DummyInteltechSms.new(0, InteltechSms::EMPTY_MESSAGE_RESPONSE_CODE)
+    end
+
+  should "raise an BadRequest Error exception when send_sms is called" do
+    ex = assert_raises InteltechSms::Error do
+      @good_gateway.send_sms TEST_SMS, ''
+    end
+    assert_equal InteltechSms::BadRequest.new(TEST_SMS, InteltechSms::EMPTY_MESSAGE_RESPONSE_CODE), ex.response
+  end
+
+    should "return an array BadRequest responses when send_multiple_sms is called" do
+      @res = @good_gateway.send_multiple_sms [TEST_SMS, TEST_SMS2, LANDLINE_SMS], ''
+      assert_kind_of Array, @res
+      assert_equal 3, @res.length, "send_multiple_sms returns results for each sms sent"
+      assert_kind_of InteltechSms::BadRequest, @res[0], "send_multiple_sms returns BadRequest for 1st element"
+      assert_equal InteltechSms::BadRequest.new(TEST_SMS, InteltechSms::EMPTY_MESSAGE_RESPONSE_CODE), @res[0]
+      assert_kind_of InteltechSms::BadRequest, @res[1], "send_multiple_sms returns BadRequest for 2nd element"
+      assert_equal InteltechSms::BadRequest.new(TEST_SMS2, InteltechSms::EMPTY_MESSAGE_RESPONSE_CODE), @res[1]
+      assert_kind_of InteltechSms::BadRequest, @res[2], "send_multiple_sms returns BadRequest for 2nd element"
+      assert_equal InteltechSms::BadRequest.new(LANDLINE_SMS, InteltechSms::EMPTY_MESSAGE_RESPONSE_CODE), @res[2]
+    end
+
+  end
+
+
+  # --------------------------------------------------
+  # Code 2100-2199 Internal error
+
+  # (Unable to trigger these errors to test them)
+
+end
+
+# vi: sw=2 sm ai:
+

data/test/test_inteltech_sms.rb

@@ -84,7 +84,7 @@ class TestInteltechSms < Test::Unit::TestCase
         assert_equal InteltechSms::Success.new(TEST_SMS2, "0000"), @res[0], "send_multiple_sms returns success for 1st element"
         assert_equal InteltechSms::Success.new(TEST_SMS, "0000"), @res[1], "send_multiple_sms returns success for 2nd element"
       end 
-   end
+    end
   end
 
   # --------------------------------------------------

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inteltech_sms
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 1.0.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-29 00:00:00.000000000 Z
+date: 2013-12-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rdoc
@@ -142,8 +142,10 @@ files:
 - Rakefile
 - VERSION
 - inteltech_sms.gemspec
+- lib/dummy_inteltech_sms.rb
 - lib/inteltech_sms.rb
 - test/helper.rb
+- test/test_dummy_inteltech_sms.rb
 - test/test_inteltech_sms.rb
 homepage: http://github.com/ianheggie/inteltech_sms
 licenses:
@@ -160,7 +162,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 206346697614286170
+      hash: -1430435096325391718
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: