intacctrb 0.8 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 25f611a980b22b7214b5a76a9ca1d0f8a9c0f1c6b4d485b3525b26b4985f4035
-  data.tar.gz: 0fcd8251ad8f2483ec63d403edb1afb6a72b848b864898518f8864de3389c1c2
+  metadata.gz: 85d2a0530dd2439819c4affc9d598cf27f95cef62460fc9e78f98327741635c3
+  data.tar.gz: a8dac39c1c61d8f8bdcef1fa47eae8245d0a248ec8fdb5c6e6ea8d19c529daae
 SHA512:
-  metadata.gz: 5de26eb17bc292f2dadd4d5e4b40eca204b3a0fc05eb7d8105c56d1437e43631a2ba04a20e2e8eb1d72721a2f899e6e1d1956a83ffaf4be801674f8a88253408
-  data.tar.gz: 909abda7efcf9de11a1605b35a199b4796e09531d051fd562aa7efb990c9f60845dbbd1671b1fc58384b754683770507aee82df5752dfdd4e47f95fdc6785935
+  metadata.gz: 1043d711e9945cd3d59132800c59997f9d3c6c47ced936a5039e002746cf85905b77f8e512ed903bc5a0cc7c569b9c272128599fbcfed0666bb02da3470d420b
+  data.tar.gz: 4b7ecbd39d2b8c037b102e4236a8b36b6fa2466e34dcd8caa5ca9c598f9946d0afe243003fc6e6412790b1f32db37a980d94a1355c394edbe9d2d22f2ba7b595

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    intacctrb (0.8)
+    intacctrb (0.8.1)
       hooks
       nokogiri
 

data/lib/intacctrb/base.rb

@@ -105,7 +105,7 @@ module IntacctRB
         data = OpenStruct.new({result: true, intacct_id: object.intacct_id,
           object: response, data: data})
       else
-        data = OpenStruct.new({result: false})
+        data = OpenStruct.new({result: false, intacct_id: object.intacct_id})
         data.errors = {}
         response.xpath("//result/errormessage/error").each do |error|
           data.errors << {

data/lib/intacctrb/journal_entry.rb

@@ -2,33 +2,37 @@ module IntacctRB
   class JournalEntry < IntacctRB::Base
 
     def create
-      return false if object.intacct_id.present?
-      send_xml('create') do |xml|
-        xml.function(controlid: "f1") {
-          xml.send("create") {
-            xml.glbatch {
-              je_xml xml
+      if object.intacct_id.present?
+        return_error('You tried to create an object that already had an intacct_id')
+      else
+        send_xml('create') do |xml|
+          xml.function(controlid: "f1") {
+            xml.send("create") {
+              xml.glbatch {
+                je_xml xml
+              }
             }
           }
-        }
+        end
+        return_result(response)
       end
-
-      return_result(response)
     end
 
     def update
-      return false unless object.intacct_id.present?
-      send_xml('update') do |xml|
-        xml.function(controlid: "f1") {
-          xml.send("update") {
-            xml.glbatch {
-              je_xml xml
+      unless object.intacct_id.present?
+        return_error('You tried to update an object without an intacct_id')
+      else
+        send_xml('update') do |xml|
+          xml.function(controlid: "f1") {
+            xml.send("update") {
+              xml.glbatch {
+                je_xml xml
+              }
             }
           }
-        }
+        end
+        return_result(response)
       end
-
-      return_result(response)
     end
 
     # def delete

data/lib/intacctrb/version.rb

@@ -1,3 +1,3 @@
 module IntacctRB
-  VERSION = "0.8"
+  VERSION = "0.8.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: intacctrb
 version: !ruby/object:Gem::Version
-  version: '0.8'
+  version: 0.8.1
 platform: ruby
 authors:
 - Matt Hale