intacctrb 0.6.5 → 0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fcb2eff5aa2bf248ac441bf1ea888e0db3f25fb343229e7c1d4599ed80e13d6a
-  data.tar.gz: 8f9a3617ec7ba7fb403a1579082e1458073bc3186afc2675bc727bfc6353dc9c
+  metadata.gz: 2d4e19d9f812d2398ecefc363dc47ec23f47c73032b8b1cefa0a6c1315eef6b0
+  data.tar.gz: 4633dc926482dc271c874c5c49605da4654924368a008a3a47f0ba80bd0d40cf
 SHA512:
-  metadata.gz: 45d4ccdc0f0396d3309b138794d19990fe7d6b4e7070acf4052fe4a286b8fda49147f5b8535b09429e561bd449856bf4a66bf4578839d4d5be55f1ef0359a4e6
-  data.tar.gz: 1489a77d89728c8d3f44a4349764960140264c372493b6f302aca7c965e79b1a3cdfdabed646b9e3430b04350e3189814e24e9980dc492956520f7b8d13e5f20
+  metadata.gz: 0eccba7d30ebcbbfd4952ff4d92f7ba5fbd10a23fc4bd3a2612ecb0431a47a3c81acde2ca8d942ce301f06db7777d33bf64b783932bbbf5ec46dc0c3f2c09262
+  data.tar.gz: d8bd2f6d5c721b810df42c2429a9e65389c8b68af23e1397ab8daceadb6e69cccacd4bbcef97ad6a955b794adfa565441ea6cb601d275e44bf1d53a2258148e9

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    intacctrb (0.6.5)
+    intacctrb (0.7)
       hooks
       nokogiri
 

data/lib/intacctrb/base.rb

@@ -100,9 +100,9 @@ module IntacctRB
       end
     end
 
-    def return_result(response)
+    def return_result(response, data = nil)
       if successful?
-        data = OpenStruct.new({result: true, object: response})
+        data = OpenStruct.new({result: true, object: response, data: data})
       else
         data = OpenStruct.new({result: false})
         response.xpath("//result/errormessage/error").each do |error|

data/lib/intacctrb/contact.rb

@@ -1,7 +1,7 @@
 module IntacctRB
   class Contact < IntacctRB::Base
     def create
-      send_xml('create') do |xml|
+      response = send_xml('create') do |xml|
         xml.function(controlid: "1") {
           xml.send("create") {
             contact_xml(xml)
@@ -12,6 +12,34 @@ module IntacctRB
       return_result(response)
     end
 
+    def get_by_name(options = {})
+      # return false unless object.intacct_id.present?
+
+      options[:fields] = [
+        :contactid,
+        :contactname
+      ] if options[:fields].nil?
+
+      response = send_xml('get') do |xml|
+        xml.function(controlid: "f4") {
+          xml.readByName {
+            xml.object 'contact'
+            xml.keys object.try(:name) || options[:name]
+            xml.fields '*'
+          }
+        }
+      end
+
+      if successful?
+        data = OpenStruct.new({
+          id: response.at("//contact/RECORDNO").try(:content),
+          name: response.at("//contact/CONTACTNAME").try(:content)
+        })
+      end
+
+      return_result(response, data)
+    end
+
     def get(options = {})
       # return false unless object.intacct_id.present?
 
@@ -20,7 +48,7 @@ module IntacctRB
         :contactname
       ] if options[:fields].nil?
 
-      send_xml('get') do |xml|
+      response = send_xml('get') do |xml|
         xml.function(controlid: "f4") {
           xml.read {
             xml.object 'contact'
@@ -31,13 +59,13 @@ module IntacctRB
       end
 
       if successful?
-        @data = OpenStruct.new({
+        data = OpenStruct.new({
           id: response.at("//contact/RECORDNO").content,
           name: response.at("//contact/CONTACTNAME").content
         })
       end
 
-      successful?
+      return_result(response, data)
     end
 
     def get_list *fields
@@ -49,7 +77,7 @@ module IntacctRB
         :termname
       ] if fields.empty?
 
-      send_xml('get_list') do |xml|
+      response = send_xml('get_list') do |xml|
         xml.function(controlid: "f4") {
           xml.get_list(object: "contact", maxitems: "10", showprivate:"false") {
             # xml.fields {
@@ -70,14 +98,14 @@ module IntacctRB
       # end
       #
       # successful?
-      puts response
+      return_result(response)
     end
 
     def update updated_contact = false
       @object = updated_contact if updated_contact
       return false unless object.intacct_id.present?
 
-      send_xml('update') do |xml|
+      response = send_xml('update') do |xml|
         xml.function(controlid: "1") {
           xml.update {
             contact_xml(xml, true)
@@ -91,7 +119,7 @@ module IntacctRB
     def delete
       return false unless object.intacct_id.present?
 
-      @response = send_xml('delete') do |xml|
+      response = send_xml('delete') do |xml|
         xml.function(controlid: "1") {
           xml.delete_contact(contactid: intacct_id)
         }
@@ -103,8 +131,8 @@ module IntacctRB
     def contact_xml(xml, is_update = false)
       xml.contact {
         xml.recordno object.intacct_id if object.intacct_id
-        xml.contactname object.name unless (is_update || object.intacct_id.nil?)
-        xml.printas object.name
+        xml.contactname object.name if object.name
+        xml.printas object.name if object.name
         # COMPANYNAME	Optional	string	Company name
         # TAXABLE	Optional	boolean	Taxable. Use false for No, true for Yes. (Default: true)
         # TAXGROUP	Optional	string	Contact tax group name

data/lib/intacctrb/employee.rb

@@ -1,7 +1,7 @@
 module IntacctRB
   class Employee < IntacctRB::Base
     def create
-      send_xml('create') do |xml|
+      response = send_xml('create') do |xml|
         xml.function(controlid: "1") {
           xml.send("create") {
             employee_xml(xml)
@@ -20,7 +20,7 @@ module IntacctRB
         :contactname
       ] if options[:fields].nil?
 
-      send_xml('get') do |xml|
+      response = send_xml('get') do |xml|
         xml.function(controlid: "f4") {
           xml.read {
             xml.object 'EMPLOYEE'
@@ -31,7 +31,7 @@ module IntacctRB
       end
 
       if successful?
-        @data = OpenStruct.new({
+        data = OpenStruct.new({
           id: response.at("//EMPLOYEE/RECORDNO").content,
           name: response.at("//EMPLOYEE/PERSONALINFO/CONTACTNAME").content,
           contact_id: response.at("//EMPLOYEE/CONTACTKEY").content,
@@ -39,7 +39,37 @@ module IntacctRB
         })
       end
 
-      successful?
+      return_result(response, data)
+    end
+
+    def get_by_employee_id(options = {})
+      # return false unless object.intacct_id.present?
+
+      # options[:fields] = [
+      #   :contactid,
+      #   :contactname
+      # ] if options[:fields].nil?
+
+      response = send_xml('get') do |xml|
+        xml.function(controlid: "f4") {
+          xml.readByName {
+            xml.object 'EMPLOYEE'
+            xml.keys object.try(:employee_id) || options[:employee_id]
+            xml.fields '*'
+          }
+        }
+      end
+
+      if successful?
+        data = OpenStruct.new({
+          id: response.at("//EMPLOYEE/RECORDNO").content,
+          name: response.at("//EMPLOYEE/PERSONALINFO/CONTACTNAME").content,
+          contact_id: response.at("//EMPLOYEE/CONTACTKEY").content,
+          employee_id: response.at("//EMPLOYEE/EMPLOYEEID").content
+        })
+      end
+
+      return_result(response, data)
     end
 
     def get_list *fields
@@ -51,7 +81,7 @@ module IntacctRB
         :termname
       ] if fields.empty?
 
-      send_xml('get_list') do |xml|
+      response = send_xml('get_list') do |xml|
         xml.function(controlid: "f4") {
           xml.get_list(object: "employee", maxitems: "10", showprivate:"false") {
             # xml.fields {
@@ -62,24 +92,13 @@ module IntacctRB
           }
         }
       end
-
-      # if successful?
-      #   @data = OpenStruct.new({
-      #     id: response.at("//customer//customerid").content,
-      #     name: response.at("//customer//name").content,
-      #     termname: response.at("//customer//termname").content
-      #   })
-      # end
-      #
-      # successful?
-      puts response
+      return_result(response)
     end
 
     def update updated_employee = false
       @object = updated_employee if updated_employee
       return false unless object.intacct_id.present?
-
-      send_xml('update') do |xml|
+      response = send_xml('update') do |xml|
         xml.function(controlid: "1") {
           xml.update {
             employee_xml(xml)
@@ -93,7 +112,7 @@ module IntacctRB
     def delete
       return false unless object.intacct_id.present?
 
-      @response = send_xml('delete') do |xml|
+      response = send_xml('delete') do |xml|
         xml.function(controlid: "1") {
           xml.delete_employee(employeeid: intacct_id)
         }
@@ -104,7 +123,7 @@ module IntacctRB
 
     def employee_xml xml
       xml.employee {
-        xml.recordno if object.intacct_id
+        xml.recordno object.intacct_id if object.intacct_id
         xml.title object.title if object.title
         xml.personalinfo {
           xml.contactname object.name

data/lib/intacctrb/version.rb

@@ -1,3 +1,3 @@
 module IntacctRB
-  VERSION = "0.6.5"
+  VERSION = "0.7"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: intacctrb
 version: !ruby/object:Gem::Version
-  version: 0.6.5
+  version: '0.7'
 platform: ruby
 authors:
 - Matt Hale
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-08 00:00:00.000000000 Z
+date: 2018-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri