instant_quote 1.7.33 → 1.7.34

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 961b0814c5895349859b111b9154e56582aade793a7e7623c68e53b142742b86
-  data.tar.gz: 7e88f40122d9bc7442618b3fc4aa3994f6b8f988887cfb240de853d47094bd95
+  metadata.gz: 97b97adb2fb250be1f7b7a46b44cbb082500cb0dae53cb350e31123d506a1efe
+  data.tar.gz: 66ca99708c03bfbea6587abf097196998d366c1842026f43ce02b04705a779ae
 SHA512:
-  metadata.gz: ccf3b9a9eb9d9e38c3c9ad2a9341432f683dd0dc6ca14e59b31b80b701563560c4796869f8202a84c45461798387419dbf90b1db943635ad6b513e417b6971f8
-  data.tar.gz: aaa6b9dcd4fc6dfebf247e443911af337f77a0cd0f1f713547fc2aa51840e73d6069f68b194b8504ae997598f26c7d9556dff0a665b72457f41d6723629b7947
+  metadata.gz: 9f94bf675fa6e919ece437296cad1684401ee435f9e2e54c1d86be65b94469f00d4e155187644c1e93ba75cc745a09554a9e988e45738d28d3b3ced25fa3b5a4
+  data.tar.gz: d095be67aa6e9b7f0d07d3bdebef1e89e95140b7435445b90287b8275814b071cceff5c657d8dd74bb97f7ac84c01cec156844fc8a6fb0a878daac1638ef279f

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    instant_quote (1.7.33)
+    instant_quote (1.7.34)
       activesupport
       capital_on_tap (~> 1.0.1)
       iwoca (~> 1.1.0)
@@ -22,6 +22,7 @@ GEM
     addressable (2.8.5)
       public_suffix (>= 2.0.2, < 6.0)
     ast (2.4.2)
+    base64 (0.1.1)
     byebug (11.1.3)
     capital_on_tap (1.0.1)
       addressable
@@ -35,7 +36,8 @@ GEM
     diff-lcs (1.5.0)
     docile (1.4.0)
     dotenv (2.8.1)
-    faraday (2.7.10)
+    faraday (2.7.11)
+      base64
       faraday-net_http (>= 2.0, < 3.1)
       ruby2_keywords (>= 0.0.4)
     faraday-net_http (3.0.2)
@@ -51,7 +53,7 @@ GEM
     json-schema (4.0.0)
       addressable (>= 2.8)
     method_source (1.0.0)
-    minitest (5.19.0)
+    minitest (5.20.0)
     money (6.16.0)
       i18n (>= 0.6.4, <= 2)
     multi_json (1.15.0)
@@ -123,7 +125,7 @@ GEM
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
-    youlend (1.1.4)
+    youlend (1.2.0)
       addressable
       faraday (~> 2.7)
       rainbow
@@ -146,4 +148,4 @@ DEPENDENCIES
   webmock
 
 BUNDLED WITH
-   2.4.7
+   2.3.10

data/lib/instant_quote/adapter.rb

@@ -40,6 +40,10 @@ module InstantQuote
       new.get_approval(application_id, connection)
     end
 
+    def self.accept_offer(application_id, connection, offer_id)
+      new.accept_offer(application_id, connection, offer_id)
+    end
+
     def get_link(_connection)
       raise NotImplementedError, "You must implement '#{self.class.name}#get_link'"
     end
@@ -61,5 +65,9 @@ module InstantQuote
     def get_approval(_application_id, _connection)
       OpenStruct.new(success?: true)
     end
+
+    def accept_offer(_application_id, _connection, _offer_id)
+      true
+    end
   end
 end

data/lib/instant_quote/adapter_finder.rb

@@ -59,6 +59,10 @@ module InstantQuote
       adapter.get_approval(connection.external_id, connection)
     end
 
+    def accept_offer(offer_id)
+      adapter.accept_offer(connection.external_id, connection, offer_id)
+    end
+
     def additional_fields
       adapter.additional_fields
     end

data/lib/instant_quote/adapters/youlend.rb

@@ -2,24 +2,12 @@
 
 require 'youlend'
 require 'instant_quote/decision_parsers/youlend'
+require 'instant_quote/connection_translators/youlend_persons'
 
 module InstantQuote
   module Adapters
     class Youlend < Adapter
       additional_fields [
-        {
-          name: 'monthly_card_revenue',
-          label: 'Avg. monthly card revenue',
-          required: true,
-          type: 'money',
-          minimum: 1_000
-        },
-        {
-          name: 'monthly_revenue_from_invoices',
-          label: 'Avg. monthly revenue from invoices',
-          required: true,
-          type: 'money'
-        },
         {
           name: 'applicant_consent',
           label: 'Yes, I give my consent for my data to be shared with YouLend',
@@ -28,48 +16,44 @@ module InstantQuote
         }
       ]
 
-      # For Youlend we first need to do the pre_qualification and then, if we get a positive
-      # response we can create the lead. We need to call both endpoints here, so it might take a
-      # while.
+      # For Youlend we first need to create a lead and then update lead
+      # since some of the fields are not available in create
       def get_quote(params, connection)
-        response = ::Youlend::Lead.create(params)
+        data = create_lead(params)
 
-        if response.success?
-          connection.update(link: response.data[:signUpURL])
+        update_lead(data[:leadId], params)
+        submit_persons(data[:leadId], connection)
 
-          return response.data[:leadId]
-        end
+        connection.update(link: data[:signUpURL])
 
-        raise_error(response)
+        return data[:leadId]
       end
 
-      def get_status(_lead_id, connection)
+      def get_status(lead_id, connection)
+        details = ::Youlend::Lead.details(lead_id)
+        raise_error(details) unless details.success?
+
+        offers = ::Youlend::Lead.offers(lead_id) if details.body[:onboardingState] == 'offersProvided'
+        raise_error(offers) if offers && !offers.success?
+
+        decision = connection.approval_decision_info.merge(details: details.body)
+        decision.merge!(offers: offers&.body) if offers
+
+        connection.update(approval_decision_info: decision)
         DecisionParsers::Youlend.new(connection.approval_decision_info)
       end
 
+      def accept_offer(application_id, _connection, offer_id)
+        response = ::Youlend::Lead.accept_offer(application_id, offer_id)
+
+        response.success?
+      end
+
       # Gets the URL for the given state key.
       def get_link(connection)
         connection.link
       end
 
-      # Checks if the application is eligible for a loan. If it is we need to update the
-      # connection's approval_decision_info right away, since it's the only place where we get it.
-      def get_preapproval(params, connection)
-        # The preapproval endpoint doesn't work with all params, we need to remove some
-        params.delete(:companyName)
-        params.delete(:monthsTrading)
-        params.delete(:keyContactName)
-        params.delete(:registeredAddress)
-        params.delete(:thirdPartyLeadId)
-        params.delete(:contactPhoneNumber)
-
-        response = ::Youlend::Prequalification.verify(params)
-
-        connection.update(approval_decision_info: response.data) if response.success?
-
-        response
-      end
-
       private
 
       def raise_error(response)
@@ -79,6 +63,26 @@ module InstantQuote
           error: response.errors.first || '[Youlend] API error'
         )
       end
+
+      def create_lead(params)
+        response = ::Youlend::Lead.create(params)
+        raise_error(response) unless response.success?
+
+        response.data
+      end
+
+      def update_lead(lead_id, params)
+        response = ::Youlend::Lead.update(lead_id, params)
+        raise_error(response) unless response.success?
+      end
+
+      def submit_persons(lead_id, connection)
+        people_translator = ConnectionTranslators::YoulendPersons.new(connection)
+        people_params = people_translator.translate
+
+        response = ::Youlend::SignificantPersons.create(lead_id, people_params)
+        raise_error(response) unless response.success?
+      end
     end
   end
 end

data/lib/instant_quote/connection_translators/youlend.rb

@@ -5,58 +5,31 @@ module InstantQuote
     CURRENCY = 'GBP'
 
     class Youlend < ConnectionTranslator
-      # rubocop:disable Metrics/AbcSize
-      def translate
+      def translate # rubocop:disable Metrics/AbcSize
         {
           companyName: company.name,
           companyType: company_type_translated,
+          companyNumber: company.company_number,
           monthsTrading: company.total_months_in_business,
           keyContactName: primary_user_name,
           thirdPartyLeadId: application.code,
-          financialData: financial_data,
           countryISOCode: 'GBR',
           loanCurrencyISOCode: CURRENCY,
-          thirdPartyMerchantId: company.id,
-          thirdPartyCustomerId: application&.primary_user&.id,
+          loanAmount: application.amount.to_f,
+          thirdPartyCustomerId: application&.primary_user&.id.to_s,
           registeredAddress: company_address,
           contactPhoneNumber: extra_info[:applicant_phone_number],
-          monthlyCardRevenue: extra_info[:monthly_card_revenue].to_i,
-          contactEmailAddress: application&.primary_user&.email # optional
+          contactEmailAddress: application&.primary_user&.email,
+          # we need country and description on update
+          # but they are ignored in create
+          country: 'GBR',
+          description: application.description,
+          confirmedCreditSearch: true
         }
       end
-      # rubocop:enable Metrics/AbcSize
 
       private
 
-      def financial_data
-        {
-          monthlyCardRevenue: extra_info[:monthly_card_revenue].to_i,
-          monthlyRevenueFromInvoices: extra_info[:monthly_revenue_from_invoices].to_i,
-          paymentData: payment_data
-        }
-      end
-
-      def payment_data
-        (1..12).to_a.map do |month|
-          formatted_month = format('%02<month>d', month: month)
-
-          {
-            paymentDate: "#{Date.today.year - 1}-#{formatted_month}-01",
-            amount: total_amount,
-            currencyISOCode: CURRENCY
-          }
-        end
-      end
-
-      def total_amount
-        @total_amount ||= begin
-          card = extra_info[:monthly_card_revenue].to_i || 0
-          invoices = extra_info[:monthly_revenue_from_invoices].to_i || 0
-
-          card + invoices
-        end
-      end
-
       def company_address
         address = company.address
 
@@ -81,13 +54,13 @@ module InstantQuote
       def company_type_translated
         case company.company_type.name
         when /LTD/
-          'ltd'
+          'Ltd'
         when /LLP/
-          'llp'
+          'Llp'
         when /PLC/
-          'plc'
+          'Plc'
         when 'Sole Trader'
-          'soleTrader'
+          'SoleTrader'
         else
           'other'
         end

data/lib/instant_quote/connection_translators/youlend_persons.rb

@@ -0,0 +1,73 @@
+# frozen_string_literal: true
+
+module InstantQuote
+  module ConnectionTranslators
+    class YoulendPersons < ConnectionTranslator
+      def translate
+        people = application.borrower_organisation.company_people.map do |person|
+          translate_person(person)
+        end
+
+        {
+          significantPersons: people.select { |p| valid?(p) }
+        }
+      end
+
+      private
+
+      def valid?(person_hash)
+        person_hash.values_at(:address, :typeOfPerson, :dateOfBirth, :firstName, :surname)
+                   .none?(&:nil?)
+      end
+
+      def translate_person(person)
+        {
+          address: address(person),
+          dateOfBirth: date_of_birth(person),
+          firstName: person.first_name || person.name,
+          surname: person.last_name || person.name,
+          typeOfPerson: type_of_person(person),
+          emailAddress: application.primary_user.email,
+          mobilePhoneNumber: extra_info[:applicant_phone_number],
+          percentageOwned: person.shares_percent || 0,
+          nationality: person.nationality
+        }
+      end
+
+      def address(person)
+        address = person.address
+        return unless address
+
+        {
+          line1: address.line_1,
+          line2: address.line_2,
+          city: address.town,
+          region: address.town,
+          areaCode: address.postcode,
+          country: address.country
+        }
+      end
+
+      def type_of_person(person)
+        if person.director? && person.shareholder?
+          'DirectorAndBeneficialOwner'
+        elsif person.director?
+          'Director'
+        elsif person.shareholder?
+          'BeneficialOwner'
+        end
+      end
+
+      def date_of_birth(person)
+        dob = person.birthdate || application.primary_user.birthdate
+        return unless dob
+
+        {
+          year: dob.year,
+          month: dob.month,
+          day: dob.day
+        }
+      end
+    end
+  end
+end

data/lib/instant_quote/decision_parsers/youlend.rb

@@ -6,71 +6,145 @@ module InstantQuote
   module DecisionParsers
     # Example response:
     #
+    # Details response merged with optional offers
     # {
-    #   thirdPartyMerchantId: "b97b0834-74e5-4da6-a3df-c8dbe017fe09",
-    #   mid: nil,
-    #   companyName: "Test Company",
-    #   overallCreditRiskScore: 3.5,
-    #   overrideCreditRiskScore: 1.0,
-    #   loanOptions: [
-    #     { fundedAmount: 0.0, fee: 0.0, loanAmount: 0.0, sweep: 0.0, currencyISOCode: "GBP" },
-    #     { fundedAmount: 0.0, fee: 0.0, loanAmount: 0.0, sweep: 0.0, currencyISOCode: "GBP" },
-    #     { fundedAmount: 0.0, fee: 0.0, loanAmount: 0.0, sweep: 0.0, currencyISOCode: "GBP" }
-    #   ]
+    #   "details": {
+    #     "leadSourceLendingPartnerId": "2487faad-24c3-40ed-8e63-f4551555116a",
+    #     "onboardingState": "offersProvided",
+    #     "onboardingStateReason": "",
+    #     "organisationDetailsStepComplete": true,
+    #     "paymentDataStepComplete": true,
+    #     "offerStepComplete": false,
+    #     "kycDocumentsStepComplete": true,
+    #     "companyName": "SATURDAY LTD",
+    #     "leadType": "Api",
+    #     "signingDetails": {
+    #       "eligibleForInstantSigning": false,
+    #       "instantSigningDetails": null
+    #     }
+    #   },
+    #   "offers": {
+    #     "leadId": "5c35a9f4-436e-47b9-a31c-b55f5881f8be",
+    #     "previousAcceptedOffer": null,
+    #     "providedOffers": [
+    #       {
+    #         "offerId": "12cfda2b-cfb6-4d79-bd16-2979ed6a069a",
+    #         "youWillGet": 6000,
+    #         "youWillRepay": 7020,
+    #         "currencyISOCode": "GBP",
+    #         "sweep": 20,
+    #         "minimumWeeklyRepayment": 150.28,
+    #         "daysUntilRepayment": 218,
+    #         "maturityDate": "2024-06-26T16:42:15.038Z"
+    #       },
+    #       {
+    #         "offerId": "2d93cb8b-7e3b-4c87-87cf-40e2f7e226e3",
+    #         "youWillGet": 6500,
+    #         "youWillRepay": 7735,
+    #         "currencyISOCode": "GBP",
+    #         "sweep": 20,
+    #         "minimumWeeklyRepayment": 150.4,
+    #         "daysUntilRepayment": 240,
+    #         "maturityDate": "2024-07-29T16:42:15.038Z"
+    #       },
+    #       {
+    #         "offerId": "f2ef06ef-0c29-418c-ad93-d7abdee5994e",
+    #         "youWillGet": 7000,
+    #         "youWillRepay": 8470,
+    #         "currencyISOCode": "GBP",
+    #         "sweep": 20,
+    #         "minimumWeeklyRepayment": 150.1,
+    #         "daysUntilRepayment": 263,
+    #         "maturityDate": "2024-09-02T16:42:15.038Z"
+    #       }
+    #     ],
+    #     "acceptedOffer": null,
+    #     "unsignedLoanDocument": null,
+    #     "unsignedLoanDocumentDownloaded": false,
+    #     "documentSigningId": "00000000-0000-0000-0000-000000000000",
+    #     "sortCode": null,
+    #     "accountNumber": null,
+    #     "swift": null,
+    #     "iban": null,
+    #     "bankName": null,
+    #     "confirmedCompanyAccount": false,
+    #     "minFundingAmount": 0,
+    #     "maxFundingAmount": 0
+    #   }
     # }
+    #
     class Youlend < DecisionParser
+      APPROVED_STATES = %w[offersProvided offerAccepted contractgenerated contractsigned]
+
       def approved?
-        status_hash[:loanOptions].any? && !funded_option.empty?
+        APPROVED_STATES.include?(status) && loan_offer.present?
       end
 
       def declined?
-        !approved?
+        !(approved? || incomplete? || submitted? || pending?)
+      end
+
+      def pending?
+        data.nil? || data.empty?
+      end
+
+      def submitted?
+        status == 'stage1submitted'
+      end
+
+      def incomplete?
+        status == 'stage1incomplete'
       end
 
       def sweep
         return '-' unless approved?
 
-        funded_option[:sweep]
+        loan_offer[:sweep]
       end
 
       def status
         approved? ? 'approved' : 'declined'
       end
 
-      def fee
-        fee = funded_option[:fee].to_f || 0
-
-        Money.new(fee * 100).format
-      end
-
       def loan_amount
-        amount = funded_option[:loanAmount].to_f || 0
-
-        Money.new(amount * 100).format
+        Money.new(raw_loan_amount * 100).format
       end
 
       def funded_amount
-        amount = funded_option[:fundedAmount].to_f || 0
+        Money.new(raw_funded_amount * 100).format
+      end
+
+      def fee
+        Money.new(raw_fee_amount * 100).format
+      end
 
-        Money.new(amount * 100).format
+      def offer_id
+        loan_offer[:offerId]
       end
 
       alias amount funded_amount
 
       private
 
-      def funded_option
-        @funded_option ||= status_hash[:loanOptions].find(-> { {} }) do |opt|
-          opt[:fundedAmount].positive?
-        end
+      # Ideally we want to give the borrower the highest amount on offer.
+      def loan_offer
+        @loan_offer ||= (data.dig(:offers, :providedOffers) || []).max_by { |offer| offer[:youWillGet].to_f }
       end
 
-      def status_hash
-        default = ActiveSupport::HashWithIndifferentAccess.new({ loanOptions: [] })
+      def raw_fee_amount
+        raw_loan_amount - raw_funded_amount
+      end
 
-        return default unless data && !data.empty? && !data[:error]
+      def raw_funded_amount
+        loan_offer&.dig(:youWillGet)&.to_f || 0
+      end
 
-        default.merge(data)
+      def raw_loan_amount
+        loan_offer&.dig(:youWillRepay)&.to_f || 0
+      end
+
+      def status
+        data.dig(:details, :onboardingState)
       end
     end
   end

data/lib/instant_quote/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module InstantQuote
-  VERSION = '1.7.33'
+  VERSION = '1.7.34'
 end

data/lib/instant_quote.rb

@@ -37,6 +37,10 @@ module InstantQuote
     end
   end
 
+  def accept_offer(connection, offer_id)
+    AdapterFinder.new(connection).accept_offer(offer_id)
+  end
+
   def available_adapters
     AdapterFinder.available_adapters
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: instant_quote
 version: !ruby/object:Gem::Version
-  version: 1.7.33
+  version: 1.7.34
 platform: ruby
 authors:
 - rikas
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-09-13 00:00:00.000000000 Z
+date: 2023-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -150,6 +150,7 @@ files:
 - lib/instant_quote/connection_translators/iwoca_revenue_based_loans.rb
 - lib/instant_quote/connection_translators/optimum.rb
 - lib/instant_quote/connection_translators/youlend.rb
+- lib/instant_quote/connection_translators/youlend_persons.rb
 - lib/instant_quote/decision_parser.rb
 - lib/instant_quote/decision_parsers/capital_on_tap.rb
 - lib/instant_quote/decision_parsers/fake.rb
@@ -183,7 +184,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.0.8
 signing_key: 
 specification_version: 4
 summary: Instant quote providers gem.