instant_quote 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dcc46ad5c55f3fcd548e18ae0ba8a853ce640c77a043762fec33a298cd2a9a2a
-  data.tar.gz: c17b2fbc98a6637395a757122b0a2d1367bb3b6a0abbce1b2f87416d36b39ff4
+  metadata.gz: 5ef7de39482768419b0f8fcceef1a519f9a6f59d806663f87855b112255fb901
+  data.tar.gz: 365472c89d076772550acd39988412d8fc6a7501b0684d6a694a88e151802010
 SHA512:
-  metadata.gz: bf272f35c66fd55538f199d0220abe1a02d715d852bfd5f0f8bd8013a9eb112f71921745070351ea80658cd4951af6ab7b300865bf9ef4e77ebbb1f42eaf32b4
-  data.tar.gz: e120faaad9ae5b884d37c1993ae6e79e1b912d4e622c5b2eb83c0b8d15cdd46c0f9b72b90c92806f72bb2aad9d6ea3bdda9bbc861711ee5da1db8aae8a542568
+  metadata.gz: 7ba1a1214b4eb23a89b69f90f60195bf7f50d2d45f17b1727571f506dbc033513ec127c56ba18a5061fd93abb6df30b5952cf57bcf0ada33bdda091962fd43b8
+  data.tar.gz: 655bec0c02d728f1e2f39ffa32decbad0754359ede1b60dcfa866b65509316cddc1d0e5ea3ded3b279b1e850b89f2b6d0508d26af472d18f1eececf730bf0a2d

data/Gemfile.lock

@@ -1,11 +1,12 @@
 PATH
   remote: .
   specs:
-    instant_quote (1.1.1)
+    instant_quote (1.1.2)
       activesupport
       capital_on_tap
       iwoca
       money
+      phonelib
 
 GEM
   remote: https://rubygems.org/
@@ -31,10 +32,10 @@ GEM
     diff-lcs (1.3)
     docile (1.3.2)
     dotenv (2.7.5)
-    faraday (1.0.0)
+    faraday (0.17.3)
       multipart-post (>= 1.2, < 3)
-    faraday_middleware (1.0.0.rc1)
-      faraday (~> 1.0)
+    faraday_middleware (0.14.0)
+      faraday (>= 0.7.4, < 1.0)
     i18n (1.8.2)
       concurrent-ruby (~> 1.0)
     iwoca (1.0.0)
@@ -53,6 +54,7 @@ GEM
     parallel (1.19.1)
     parser (2.7.0.2)
       ast (~> 2.4.0)
+    phonelib (0.6.42)
     pry (0.12.2)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)

data/instant_quote.gemspec

@@ -38,4 +38,5 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'capital_on_tap'
   spec.add_dependency 'iwoca'
   spec.add_dependency 'money'
+  spec.add_dependency 'phonelib'
 end

data/lib/instant_quote/connection_translators/capital_on_tap.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'phonelib'
+
 module InstantQuote
   module ConnectionTranslators
     class CapitalOnTap < ConnectionTranslator
@@ -12,24 +14,26 @@ module InstantQuote
           FirstName: app_user.first_name,
           LastName: app_user.last_name,
           DateOfBirth: extra_info['date_of_birth'],
-          MobilePhone: extra_info['applicant_phone_number'],
+          MobilePhone: format_phone(extra_info['applicant_phone_number']),
           EmailAddress: app_user.email,
           PersonalAddress: translate_address,
           TradingName: app_org.name,
           BusinessLegalName: app_org.name,
-          BusinessLandline: extra_info['business_landline'],
+          BusinessLandline: format_phone(extra_info['business_landline']),
           YearsTrading: app_org.years_in_business,
           MonthlyTurnOver: translate_turnover,
           BusinessType: translate_business_type,
           BusinessAddress: translate_address,
-          RegistrationNumber: app_org.company_number,
+          RegistrationNumber: app_org.company_number
         }
 
         # If the borrower organisation is Sole Trader we need to merge two additional fields.
-        fields.merge!(
-          MonthlyIncome: extra_info['monthly_income'],
-          MonthlyExpenditure: extra_info['monthly_expenditure']
-        ) if app_org.sole_trader?
+        if app_org.sole_trader?
+          fields.merge!(
+            MonthlyIncome: extra_info['monthly_income'],
+            MonthlyExpenditure: extra_info['monthly_expenditure']
+          )
+        end
 
         fields
       end
@@ -37,6 +41,13 @@ module InstantQuote
 
       private
 
+      # Converts phone numbers with country code to local phone numbers, because that's what Capital
+      # on Tap expects.
+      def format_phone(phone_number)
+        phone = Phonelib.parse(phone_number)
+        phone.national(false)
+      end
+
       def app_user
         application.primary_user
       end
@@ -48,7 +59,7 @@ module InstantQuote
       def translate_address
         addr = app_org.address
 
-        return '' unless addr.present?
+        return '' unless addr && addr != ''
 
         street_parts = [addr.line_1, addr.line_2, addr.line_3, addr.line_4]
 

data/lib/instant_quote/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module InstantQuote
-  VERSION = '1.1.1'
+  VERSION = '1.1.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: instant_quote
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - rikas
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-03-10 00:00:00.000000000 Z
+date: 2020-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -164,6 +164,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: phonelib
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Instant quote providers gem.
 email:
 - oterosantos@gmail.com