inst_statsd 2.2.0 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4be1145693a7188f19fe5b64206465eeece936dd9220f9185d1d87e5d895e91c
-  data.tar.gz: f9f61e0ceb159ff2dabc3b8bda50e9ab5edb299e94d5ab3fed4a664815137697
+  metadata.gz: 568ce7b0b1164ceb930ba4c27604d3600f3afc9faf9486fa55ed315c3e1b6e90
+  data.tar.gz: e8970517048f627c0449ba8fa241adaae49b9aa37b3a4faa5047aa64e67f07d6
 SHA512:
-  metadata.gz: c588cc8d11fc48e12808183efc310f98468b2c1e508e98864c8c796d60a22508fec115694dc56f03a311511e17cd221badff168bfaf77dc414581ca829f62a24
-  data.tar.gz: 7020ddd2f162501c846c280b7e93d4e037479edd7cea347267911607c3da3b578096cb2ef426f0fd86ddeac077b8ded803c7ebe50dd1c501704c9f537ce1e9af
+  metadata.gz: 92c65a63134c03d227481e0fca2cf23e438268dd8fa59a124ac95795c7e3ec304ac6d7052d7e9e0270cdfdb89ff7bba24543b4021fdfed3dc098fedb6951364a
+  data.tar.gz: 53087ac5aa2d2efe2af74d037ed18a0723774b38e17e3ddb34a8de2b5f67ec74620ef33c02737f3393a1faaf48c81ff5cd0cbfb217f408eb57b249f97ed312d4

data/lib/inst_statsd/request_stat.rb

@@ -20,6 +20,7 @@ module InstStatsd
         self.short_stat = "request"
         self.tags[:controller] = controller if controller
         self.tags[:action] = action if action
+        self.tags[:status] = status if status
       else
         self.common_key = "request.#{controller}.#{action}" if controller && action
       end
@@ -48,6 +49,17 @@ module InstStatsd
       @payload.fetch(:params, {})['action']
     end
 
+    def status
+      status = @payload.fetch(:status, 0)
+      # Only return status group to reduce the number of indexed custom metrics (and cost) of datadog
+      return '1XX' if status >= 100 and status < 200
+      return '2XX' if status >= 200 and status < 300
+      return '3XX' if status >= 300 and status < 400
+      return '4XX' if status >= 400 and status < 500
+      return '5XX' if status >= 500 and status < 600
+      nil
+    end
+
     def total
       if (!@finish || !@start)
         return 0

data/spec/inst_statsd/request_stat_spec.rb

@@ -70,6 +70,22 @@ describe InstStatsd::RequestStat do
     end
   end
 
+  describe '#status' do
+    it 'should return nil if status is not defined' do
+      rs = create_subject
+      expect(rs.status).to eq nil
+    end
+
+    it 'should return HTTP status group if present' do
+      expect(create_subject({status: 200}).status).to eq '2XX'
+      expect(create_subject({status: 201}).status).to eq '2XX'
+      expect(create_subject({status: 302}).status).to eq '3XX'
+      expect(create_subject({status: 400}).status).to eq '4XX'
+      expect(create_subject({status: 404}).status).to eq '4XX'
+      expect(create_subject({status: 503}).status).to eq '5XX'
+    end
+  end
+
   describe '#total' do
     it 'correctly calculates milliseconds from start, finish' do
       rs = create_subject({params: {}})
@@ -113,10 +129,11 @@ describe InstStatsd::RequestStat do
         params: {
           'controller' => 'foo',
           'action'     => 'index'
-        }
+        },
+        status: 200
       }
       rs = create_subject(payload, statsd)
-      expect(statsd).to receive(:timing).with('request.total', 1000, {short_stat: 'request.total', tags: {action: "index", controller: "foo"}} )
+      expect(statsd).to receive(:timing).with('request.total', 1000, {short_stat: 'request.total', tags: {action: "index", controller: "foo", status: '2XX'}} )
       rs.report
     end
 

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: inst_statsd
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.3.0
 platform: ruby
 authors:
 - Nick Cloward
 - Jason Madsen
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-07-29 00:00:00.000000000 Z
+date: 2022-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dogstatsd-ruby
@@ -123,7 +123,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description:
+description: 
 email:
 - ncloward@instructure.com
 - jmadsen@instructure.com
@@ -159,7 +159,7 @@ homepage: https://github.com/instructure/inst_statsd
 licenses:
 - MIT
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -174,8 +174,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.24
-signing_key:
+rubygems_version: 3.0.3
+signing_key: 
 specification_version: 4
 summary: Statsd for Instructure
 test_files: