inst-jobs 0.11.2 → 0.11.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0bc81cd3d15885fbfd0558a315efcabbd16f6701
-  data.tar.gz: 271cf7be1cde08c996559900465ab98086cf6a33
+  metadata.gz: 7711534eafbbf16017703429b63228d6736a4c76
+  data.tar.gz: 3fd4fa2edf53a8238f0e189bae5b561661288cd4
 SHA512:
-  metadata.gz: 92560308a67142a9b2ae4a3866c29860ed60871a4fac41a33893df04b829e33e71101af3fdbcde40f08897ca6bcfc3be87e867948f01faed06e469ff9c614da3
-  data.tar.gz: a2a293e69048a1be851da508d704eb2df2d000f4cce035e8a7e57c65b233e104227263c6abd82ca7b64b5a92210ee10cbaa8a451bcccd99e23ef99aedfcbc53d
+  metadata.gz: d7b4f7c661730403a943d967553b7e5426ba32f6d4f8750ea7550cb8d84d05a41e311638c4b5ca78fc541e630f7b8ae42a967f0cfeefe01d446f47badd265ffc
+  data.tar.gz: 70f3a55a6bcc33e1552a4a999b7595f7c64231857bc872da1c33bf662a3a2afe5e41b05c223f45890fdbea4dbeb6068633b731ea4f3b6e95da03153257148c5b

data/lib/delayed/backend/base.rb

@@ -180,7 +180,7 @@ module Delayed
           # notify the payload_object of a permanent failure
           obj = payload_object
           obj.on_permanent_failure(error) if obj && obj.respond_to?(:on_permanent_failure)
-        rescue DeserializationError
+        rescue
           # don't allow a failed deserialization to prevent destroying the job
         end
 

data/lib/delayed/version.rb

@@ -1,3 +1,3 @@
 module Delayed
-  VERSION = "0.11.2"
+  VERSION = "0.11.3"
 end

data/spec/sample_jobs.rb

@@ -26,3 +26,8 @@ module M
     def perform; @@runs += 1; end
   end
 end
+
+class DeserializeErrorJob < SimpleJob; end
+Psych.add_domain_type("ruby/object", "DeserializeErrorJob") do |_type, val|
+  raise "error deserializing"
+end

data/spec/shared/worker.rb

@@ -354,6 +354,22 @@ shared_examples_for 'Delayed::Worker' do
     end
   end
 
+  describe "custom deserialization errors" do
+    it "should reschedule with more attempts left" do
+      job = Delayed::Job.create({:payload_object => DeserializeErrorJob.new, max_attempts: 2})
+      job.instance_variable_set("@payload_object", nil)
+      worker = Delayed::Worker.new(:max_priority => nil, :min_priority => nil, :quiet => true)
+      expect { worker.perform(job) }.not_to raise_error
+    end
+
+    it "run permanent failure code on last attempt" do
+      job = Delayed::Job.create({:payload_object => DeserializeErrorJob.new, max_attempts: 1})
+      job.instance_variable_set("@payload_object", nil)
+      worker = Delayed::Worker.new(:max_priority => nil, :min_priority => nil, :quiet => true)
+      expect { worker.perform(job) }.not_to raise_error
+    end
+  end
+
   describe "#start" do
     it "fires off an execute callback on the processing jobs loop" do
       fired = false

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inst-jobs
 version: !ruby/object:Gem::Version
-  version: 0.11.2
+  version: 0.11.3
 platform: ruby
 authors:
 - Tobias Luetke
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-23 00:00:00.000000000 Z
+date: 2016-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: after_transaction_commit