inspecstyle 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bb076b244e5088e7e791398f5eb97c1e4605cfb1884f16926c77b950ff0227de
-  data.tar.gz: a5fa8c99dc4df14eb42e1af6af351e96cece0b8e3a38b06cad1b42cca7f9e124
+  metadata.gz: 9c05d8e13dc59b97ef50ee7e38f9e728dc3e52ade3e648c4dc73241d3f32d60f
+  data.tar.gz: be29a3ae8643a818ef62e7f0a491cc161940b9a675641ae34343cdc082470ec2
 SHA512:
-  metadata.gz: 0a2ff04f4194cae59aec606787a481529430883636c19d10324de5d45e579e842fe29ef5a8ecf2f67e6b61e2eb722d28bde84cc2c6ac073eebb8954fc16895ab
-  data.tar.gz: 3ced9b66232704943c40220b303ecefd7fd58d39b35c00d753d71f95e566ca9574dfff0bd8e7d60f3c2663503dafe1e88dc0d50bedec04555cb184960e30af90
+  metadata.gz: 460c48ff0252cbfff1fb0a1b0245366eba8ae3ed939c03dc418a0561ce9d8d31fc8d9beefaf941fe24ea93f52681057104e6ec8863b58b248399ea1072c7a3dd
+  data.tar.gz: e8bb21c13461a344f7ed3b75ef55634755adb454d0530672024ef8fb60d15fdfb3d0c06aedb60322ca864e7520f88cc65e4913979d5a76051467e3f44dafe49a

data/lib/rubocop/cop/inspecstyle/azure_generic_resource.rb

@@ -8,6 +8,7 @@ module RuboCop
       # @example EnforcedStyle: InSpecStyle (default)
       #   # azure_generic_resource has been deprecated
       #   # 'https://github.com/inspec/inspec/issues/3131'
+      #   # Since there are multiples replacements autocorrect is not supported.
       #
       #   # bad
       #   azure_generic_resource
@@ -26,7 +27,7 @@ module RuboCop
         def on_send(node)
           return unless azure_generic_resource?(node)
 
-          add_offense(node, location: node.loc.selector)
+          add_offense(node, location: :selector)
         end
       end
     end

data/lib/rubocop/cop/inspecstyle/deprecated_attributes.rb

@@ -18,7 +18,8 @@ module RuboCop
       class DeprecatedAttributes < Cop
         include RangeHelp
 
-        MSG = 'Use `#input` instead of `#attribute`.'
+        MSG = 'Use `#input` instead of `#attribute`. This will be removed in '\
+              'InSpec 5'
 
         def_node_matcher :attribute?, <<~PATTERN
           (send nil? :attribute ...)

data/lib/rubocop/cop/inspecstyle/oracle_db_session_pass.rb

@@ -14,7 +14,8 @@ module RuboCop
       #   sql = oracledb_session(user: 'my_user', password: 'password')
       class OracleDbSessionPass < Cop
         include MatchRange
-        MSG = 'Use `:password` instead of `:pass`.'
+        MSG = 'Use `:password` instead of `:pass`. This will be removed in '\
+              'InSpec 5'
 
         def_node_matcher :oracledb_session_pass?, <<~PATTERN
           (send _ :oracledb_session

data/lib/rubocop/cop/inspecstyle/shadow_properties.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
-# NOTE TO SELF - this one isn't currently working even though my pattern works in Rubocop's bin/console
+# NOTE TO SELF - this one works BUT not if other its statements are defined. Needs
+# to work in any arrangement. This is a powerful one to crack as this pattern
+# will be used in a LOT of other cops. 
 
 module RuboCop
   module Cop
@@ -27,8 +29,8 @@ module RuboCop
         # See https://github.com/rubocop-hq/rubocop-ast/blob/master/lib/rubocop/node_pattern.rb
         #
         # For example
-        MSG = 'Use `#users` instead of `#user`. This property will be removed '\
-              'in InSpec 5'
+        MSG = 'Use `:%<modifier>ss` instead of `:%<modifier>s` as a property ' \
+        'for the `shadow` resource. This property will be removed in InSpec 5'
 
         def_node_matcher :shadow_resource_user_property?, <<~PATTERN
           (block
@@ -41,17 +43,17 @@ module RuboCop
         PATTERN
 
         def on_block(node)
-          return unless shadow_resource_user_property?(node) do |result|
-            require 'pry'
-            # binding.pry
-            add_offense(node, message: message(result))
+          return unless shadow_resource_user_property?(node) do |modifier|
+            message = format(MSG, modifier: modifier)
+            range = locate_range(modifier, node)
+            add_offense(node, message: message, location: range)
           end
         end
 
         private
 
-        def message(result)
-          MSG #
+        def locate_range(modifier, node)
+          node.children.find { |child| child.type == :block }.children.first.children.find{|x| x == s(:str, modifier)}.source_range
         end
       end
     end

data/lib/rubocop/inspecstyle/version.rb

@@ -1,5 +1,5 @@
 module RuboCop
   module InSpecStyle
-    VERSION = "0.1.5"
+    VERSION = "0.1.6"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inspecstyle
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - Nick Schwaderer