inspec-chef 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 29c070e9e924069b6c2f7418bdfd8164b0c69f9ae3ad7447928b3cdb99ca6e30
-  data.tar.gz: 875794f04d148b86a41a401c481bc0fb53e6b398059668fc1d307820e4b285ff
+  metadata.gz: cf13aeb2415399d3c00d3bf0e03f64aa6d46161dbcaf028f7ce9d105476b46c8
+  data.tar.gz: 9e721f499a57caf6ba16babc18c4e638a269db8fa6aa25f03048a0b3ef4049be
 SHA512:
-  metadata.gz: e87dee841335d6e05a96cdb2d74bd8a77b7b975d9a54f73a0eae94766cb7def48adc20291ea821d0b3d51096b9cb4b5ad1419d8105f9f253a784d22f06b42f02
-  data.tar.gz: 47360a9eb493ddf659535f7f59b3810bd271a2ba49b3e84677e3cc4c6e936b7273eb764d211fc7d8d4ad6272cc2a027311f46c4690eb7aabd4cff03637a8fcd2
+  metadata.gz: 1edb515f0338855b9c6a3b266a70c808b48fcf01b12b0e88f750e4a530be9770a01fefea0c67ea4145f04836b93e5af6668dcfdad2f29f8ab0ca5f6b76cd299b
+  data.tar.gz: '087bcae728e94fd4d4ea1c9f0f2774fe04c82b093bd5ecc61ffed86c61f9aedd757ca892fbf20293ce72f35560389699ca546a50908b8edf42421d2ef1198e96'

data/README.md

@@ -51,6 +51,11 @@ This plugin supports the following options:
 | INSPEC_CHEF_CLIENT   | chef_api_client   | The name of the client of the Chef server to connect as |
 | INSPEC_CHEF_KEY      | chef_api_key      | Path to the private certificate identifying the node |
 
+Using this plugin with Windows instances is broken with `chef-api` versions up to 0.10.4 due
+to a dependency issue within the deprecated `logify` gem. Versions starting with 0.10.5 use Chef's
+native logging system and work on both Linux and Windows. Other versions will only work with Linux
+instances.
+
 ## Configuration for TestKitchen
 
 To allow for more dev/prod parity, this input plugin detects if it is called
@@ -69,9 +74,8 @@ suites:
         install_flavor: "oracle"
 ```
 
-Please note, that support for `load_plugins` is not available on versions 1.3.1
-and below of the `kitchen-inspec` verifier plugin. Please check
-[kitchen-inspec PR #247 on GitHub](https://github.com/inspec/kitchen-inspec/pull/247) for finding official versions supporting this feature.
+Please note, that support for `load_plugins` was introduced in version 1.3.2 of
+the `kitchen-inspec` verifier plugin. Earlier versions are unable to load InSpec V2 plugins.
 
 ## Usage
 
@@ -130,3 +134,6 @@ is __not__ done on the clients tested, but the workstation executing InSpec.
   `ipaddress`, `hostname` or `fqdn` fields. One case would be IPv6 target
   nodes. Trying to resolve will result in error "Unable too lookup remote Chef
   client name"
+- Using TestKitchen to run InSpec from a Chef cookbook on a remote machine will
+  fail. As InSpec is not invoked as a verifier from within Kitchen, but as a
+  standalone binary, it cannot access the passed kitchen attributes and databags.

data/lib/inspec-chef/input.rb

@@ -1,5 +1,6 @@
 require "chef-api"
 require "jmespath"
+require "json"
 require "resolv"
 require "uri"
 
@@ -31,8 +32,11 @@ module InspecPlugins
 
       # Fetch method used for Input plugins
       def fetch(_profile_name, input_uri)
+        logger.trace format("Inspec-Chef received query for input %<uri>s", uri: input_uri)
         return nil unless valid_plugin_input?(input_uri)
 
+        logger.debug format("Inspec-Chef input schema detected")
+
         connect_to_chef_server
 
         input = parse_input(input_uri)
@@ -40,15 +44,18 @@ module InspecPlugins
           data = get_databag_item(input[:object], input[:item])
         elsif input[:type] == :node && input[:item] == "attributes"
           # Search Chef node name, if no host given explicitly
-          input[:object] = get_clientname(scan_target) unless input[:object]
+          input[:object] = get_clientname(scan_target) unless input[:object] || inside_testkitchen?
 
           data = get_attributes(input[:object])
         end
 
-        result = JMESPath.search(input[:query].join("."), data)
+        # Quote components to allow "-" as part of search query.
+        # @see https://github.com/jmespath/jmespath.rb/issues/12
+        expression = input[:query].map { |component| '"' + component + '"' }.join(".")
+        result = JMESPath.search(expression, data)
         raise format("Could not resolve value for %s, check if databag/item or attribute exist", input_uri) unless result
 
-        result
+        stringify(result)
       end
 
       private
@@ -101,6 +108,11 @@ module InspecPlugins
         }
       end
 
+      # Deeply stringify keys of Array/Hash
+      def stringify(result)
+        JSON.parse(JSON.dump(result))
+      end
+
       # ========================================================================
       # Interfacing with Inspec and Chef
 

data/lib/inspec-chef/version.rb

@@ -5,6 +5,6 @@
 # to learn the current version.
 module InspecPlugins
   module Chef
-    VERSION = "0.3.2".freeze
+    VERSION = "0.3.3".freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: inspec-chef
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Thomas Heinen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-24 00:00:00.000000000 Z
+date: 2020-04-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chef-api