insert 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c1e66a0f320d2c6c5aeb91f10c762a49f86750d9
-  data.tar.gz: b5d769bffbaee74b058ee9e9e5faad47cc556503
+  metadata.gz: 92bec9125377341c85ceee3b89c29edd076b6b82
+  data.tar.gz: 8c745f57f99c37690466368555e073131e91c228
 SHA512:
-  metadata.gz: fb76886411cd1d164c7d1accd6529eb67fb129d5978f7bfd88bc1b5b6923a3ce12a71641e4037a9495ff8ae66207027886aabf80d68b81d7e4562af37eb45b3d
-  data.tar.gz: 1d52d0b6915fb21dc3175a799396843cc1b16c9a9ac4d088bfd9cfc73a24beb215d58d4713c859e193510da1b3f838702037db2d9fc3591375cacc12bfd7a66c
+  metadata.gz: 8da9ae6de532a4eeb65e39a37a1ccec5389481fa893452a667f58f60924ef09713c20794e8d72128647d58272afb5b9f09c85225786a500f1e408ea44a362189
+  data.tar.gz: f627a6badc37b5daa1fb79f34978b904ddfe8129f11d11019ea22d76dd0ae81bd21025dba802e101706af541ef8d4b8a415b3b7134ac702a9405400e0f953477

data/lib/insert.rb

@@ -35,7 +35,11 @@ class Insert
       quoted_cols = cols.map { |col| connection.quote_ident col }
       bind_params = cols.length.times.map { |i| "$#{i+1}" }
       statement = %{INSERT INTO #{quoted_table_name} (#{quoted_cols.join(',')}) VALUES (#{bind_params.join(',')})}
-      connection.prepare name, statement
+      begin
+        connection.prepare name, statement
+      rescue PG::DuplicatePstatement
+        # noop
+      end
       name
     end
   end

data/lib/insert/version.rb

@@ -1,3 +1,3 @@
 class Insert
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/insert_spec.rb

@@ -1,7 +1,11 @@
 require 'spec_helper'
 
 describe Insert do
-  let(:connection) { PG.connect dbname: 'test_insert' }
+  def new_connection
+    PG.connect dbname: 'test_insert'
+  end
+
+  let(:connection) { new_connection }
   let(:insert)     { Insert.new connection }
 
   before do
@@ -27,13 +31,6 @@ describe Insert do
     end.to change{Dog.where(age: 2, name: 'bill').count}
   end
 
-  it "blows up without deallocate" do
-    expect do
-      Insert.new(connection).insert :dogs, age: 7
-      Insert.new(connection).insert :dogs, age: 7
-    end.to raise_error(PG::DuplicatePstatement)
-  end
-
   it "can deallocate" do
     a = Insert.new(connection)
     b = Insert.new(connection)
@@ -54,4 +51,44 @@ describe Insert do
     expect{insert.deallocate}.to raise_error(/can't.*dealloc/i)
   end
 
+  describe 'possible collisions' do
+    it "doesn't blow up if used on diff connections" do
+      a = Insert.new new_connection
+      b = Insert.new new_connection
+      expect do
+        a.insert :dogs, age: 7
+        b.insert :dogs, age: 7
+      end.to change{Dog.count}.by(2)
+    end
+
+    it "doesn't blow up when threading" do
+      a = Insert.new new_connection
+      b = Insert.new new_connection
+      expect do
+        a.insert :dogs, age: 7
+        Thread.new do
+          b.insert :dogs, age: 7
+        end
+        sleep 2
+      end.to change{Dog.count}.by(2)
+    end
+
+    it "doesn't blow up on the same connection" do
+      same_connection = new_connection
+      a = Insert.new same_connection
+      b = Insert.new same_connection
+      expect do
+        a.insert :dogs, age: 7
+        b.insert :dogs, age: 7
+      end.to change{Dog.count}.by(2)
+    end
+
+    it "automatically re-uses prepared statements on the same connection" do
+      expect do
+        Insert.new(connection).insert :dogs, age: 7
+        Insert.new(connection).insert :dogs, age: 7
+      end.not_to raise_error
+    end
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: insert
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Seamus Abshere
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-03 00:00:00.000000000 Z
+date: 2014-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler