insane_hook 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 52087f990c211ae1507916fb8c05de5e34fa3cc4
-  data.tar.gz: ff9200db9a99ccf204e6282df0b8b23114267bad
+  metadata.gz: 0a61856275cac8c83baf51f5dbe739af495c2086
+  data.tar.gz: 04f39eb108182f93f346afbd2c164ec36a421fda
 SHA512:
-  metadata.gz: be0a31b1693bc8321e422ca159084f2c49ac90da847072ee578b9c499314e5adbceb0d55631a792e7204e27cc9f1e037574b311a4fc43fe1d787d890204a27e9
-  data.tar.gz: 4a81df5fa6fd250662cc7241469d0908717e5cef03b903e2df4d393a7ebd2b0b3612c791fd615a49889c77a672abdf8105a7d99211b7be207179197d91c5e75c
+  metadata.gz: 576f92cee691387c45cc6f06971ade6c8eb2c7113ae14a90e277d732266eae6b2a01656b3d24cc4805e67f7ee421b2e03f40825fbf657937c00206ce2f2a8933
+  data.tar.gz: 40c9e53c80c015a4cf4646449ac7dd41629205e5045ced29ab172ad8967f5139f267334ca2c83a2d9a87dd2faa054fcb86718e2bf0a0de7c9059c25a4217401b

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    insane_hook (0.1.0)
+    insane_hook (0.3.0)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -30,12 +30,36 @@ class YeOldeTaske
     # attr_readers are available for:
     # - some_required_arg
     # - some_optional_arg
-    result meaningful_value
+    result "meaningful value"
   end
 end
 
-task = YeOldeTaske.new(some_required_arg: 7).call # => task instance
-task.result # => meaningful_value
+YeOldeTaske.new # => InsaneHook::MissingArgumentError
+
+task = YeOldeTaske.new(some_required_arg: "input") # => YeOldeTaske instance
+task.result # => raises InsaneHook::CommandNotRunError
+task.call # => YeOldeTaske instance
+task.result # => "meaningful value"
+```
+
+```ruby
+class YeOldeTaske
+  include InsaneHook
+  need :some_required_arg
+  allow :some_optional_arg
+
+  call do
+    # attr_readers are available for:
+    # - some_required_arg
+    # - some_optional_arg
+  end
+end
+
+task = YeOldeTaske.new(some_required_arg: 7).call
+task.result # => nil
+
+# Also
+task = YeOldeTaske.call(some_required_arg: 7)
 ```
 
 ## Development

data/lib/insane_hook.rb

@@ -1,61 +1,72 @@
 require "insane_hook/version"
 
 module InsaneHook
-
+  ARGS_VAR = :@@_command
+  REQUIRED_ARGS = :required
+  OPTIONAL_ARGS = :optional
+  RESULT_VAR = :@_result
+  NO_ARG = :_no_value
   class CommandNotRunError < StandardError ; end
+  class MissingArgumentError < StandardError ; end
 
   def self.included(mod)
-    mod.class_variable_set(:@@_command, {required: [], optional: []})
+    mod.class_variable_set(::InsaneHook::ARGS_VAR, {REQUIRED_ARGS => [], OPTIONAL_ARGS => []})
     mod.extend(ClassMethods)
     mod.define_singleton_method(:need, mod.instance_method(:_need))
     mod.define_singleton_method(:allow, mod.instance_method(:_allow))
     mod.define_singleton_method(:call, mod.instance_method(:_call))
-    #mod.define_method(:result, mod.instance_method(:_result))
   end
 
-  def result(value=:_no_value)
-    if value == :_no_value
-      if instance_variable_defined?(:@_result)
-        instance_variable_get(:@_result)
+  def result(value=NO_ARG)
+    if value == NO_ARG
+      if instance_variable_defined?(::InsaneHook::RESULT_VAR)
+        instance_variable_get(::InsaneHook::RESULT_VAR)
       else
         raise CommandNotRunError
       end
     else
-      instance_variable_set(:@_result, value)
+      instance_variable_set(::InsaneHook::RESULT_VAR, value)
     end
   end
 
   def _need(key)
     fail "#{key} is not a symbol" unless key.is_a? Symbol
-    args = self.class_variable_get(:@@_command)
-    args[:required] << key
-    self.class_variable_set(:@@_command, args)
+    args = self.class_variable_get(::InsaneHook::ARGS_VAR)
+    args[REQUIRED_ARGS] << key
+    self.class_variable_set(::InsaneHook::ARGS_VAR, args)
   end
 
   def _allow(key)
     fail "#{key} is not a symbol" unless key.is_a? Symbol
-    args = self.class_variable_get(:@@_command)
-    args[:optional] << key
-    self.class_variable_set(:@@_command, args)
+    args = self.class_variable_get(::InsaneHook::ARGS_VAR)
+    args[OPTIONAL_ARGS] << key
+    self.class_variable_set(::InsaneHook::ARGS_VAR, args)
   end
 
-  def _call(&block)
-    define_method(:call) do
-      result(nil)
-      instance_eval(&block)
-      self
+  def _call(**args, &block)
+    if block_given?
+      raise "Block cannot take arguments" if block.arity > 0
+      raise "call method already defined" if self.instance_methods.include?(:call)
+      define_method(:call) do
+        result(nil)
+        instance_eval(&block)
+        self
+      end
+    else
+      new(**args).call
     end
+
   end
 
   module ClassMethods
-    def new(**args, &block)
+    def new(**args)
       obj = self.allocate
-      self.class_variable_get(:@@_command)[:required].each do |var|
-        value = args.fetch(var) { raise "#{var} not provided in #{self.class}" }
+      self.class_variable_get(::InsaneHook::ARGS_VAR)[REQUIRED_ARGS].each do |var|
+        value = args.fetch(var) { raise(::InsaneHook::MissingArgumentError, "#{var} not provided in #{self.class}") }
         obj.instance_variable_set("@#{var}", value)
         obj.class.class_eval{attr_reader var}
       end
-      self.class_variable_get(:@@_command)[:optional].each do |var|
+      self.class_variable_get(::InsaneHook::ARGS_VAR)[OPTIONAL_ARGS].each do |var|
         value = args.fetch(var, nil)
         obj.instance_variable_set("@#{var}", value)
         obj.class.class_eval{attr_reader var}

data/lib/insane_hook/version.rb

@@ -1,3 +1,3 @@
 module InsaneHook
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: insane_hook
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Aldric Giacomoni, Ahmad Ragab