inline_forms 8.1.66 → 8.1.67

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7d798e9e7a6d981b422009a82073f77675148cfcd17263b501067d7d6e0a3b57
-  data.tar.gz: 76876893fbad74dd364b02c21f927bc414cb86b2b6e7a89b1caa5a3a941bab4d
+  metadata.gz: faafc3188dc88f06ee65cc379452eb7dde62753fe63b488b0250841c4cdb641d
+  data.tar.gz: 880f68f083664c8bf6de77fb522577365c43069523da92ca42a01bdd2fa7378a
 SHA512:
-  metadata.gz: d1c4624d5315833d86d2578112d2f494b8f7cd32219698de060afbc7570a638fb98c5bf07fd376de87854b264c85521033da2c88920093c3552b5925c5062c8b
-  data.tar.gz: dab2278a87d37e9005baafc360503a0a767cbd95ce1e20ad0484463098d65763547daac3f25c6e16ca1707ca8ee92ef7e9f922ffdfce996c74670af849f028bc
+  metadata.gz: e378f136a965b95f21f0e09e55776b1019eb3fa8a3ada7c1117ab101f2f2a117d654ebfe1b3cbf2c02b01cfd01c7e2096de3cf3d00ffa1d73b6c5474b0b81c3d
+  data.tar.gz: 86d6a6d5553a2b98227a3367b0f8cbdc703646bfa01b5a5f55a59dcf798a1c9bf029a0dfcfe7506d2a18e0eaf960155743266e146e4b9ab62d5678ac45b1bf51

data/CHANGELOG.md

@@ -8,6 +8,36 @@ All notable changes to this project are documented in this file.
 
 - Known issues, parked (local note `stuff/2026-10-31-dropdown-rule-3-parked.md`) with dropdown order rule 3: `includes`, `group` or `select` in `inline_forms_list` make `dropdown` and `dropdown_with_other` raise while `/index` works, so 8.1.65's fix for a list order on a joined table holds only for `joins`, `left_joins` and `eager_load`; a has_many join gives duplicate options. Present since 8.1.60. No host's list scope has these today. Parked; not changed.
 
+## [8.1.67] - 2026-11-06
+
+Fixes from a code review of 8.1.66.
+
+### Fixed
+
+- **Version and file trash pages no longer crash in a locale without `time.formats.inline_forms`.** 8.1.66 defined the format in en and nl only, and a bare `l(time, format: :inline_forms)` raises `I18n::MissingTranslationData` in any other locale when the host has no i18n fallbacks (rails-i18n's `:short`, used before, exists in every locale). The versions list, the file entries and the file trash now go through `inline_forms_time_text`, which passes the same format (`InlineForms::TIME_FORMAT`) as the default; the month names still come from the locale.
+- **No more document listeners piling up on Turbo visits.** 8.1.66's once-guard in `inline_forms.js` left the `turbo:frame-load` listener and the `.translation_missing` mouseover handler outside it, so a layout that re-runs the bundle added another of each per visit (after 10 visits every frame load rebuilt each tooltip 11 times). Both are inside the guard now (the mouseover handler is a plain DOM listener).
+- **Foundation and the widgets initialise once per page.** The first page ran `foundation()` and `initInlineFormsWidgets` from both the ready event and `turbo:load`, which destroyed and rebuilt every tooltip; one boot function now runs once per `<body>`.
+- **The submenu rule no longer hides drilldown submenus.** 8.1.66 hid every `.dropdown.menu` submenu without `is-dropdown-submenu`, which beats Foundation's own `.is-drilldown-submenu` rules for a `data-responsive-menu` on small screens. It now applies to `[data-dropdown-menu]` menus only.
+- **The title keys exist again, and say the application's name.** 8.1.66 removed `inline_forms.general.application_title`, `inline_forms.devise.title_for_devise` and `inline_forms.devise.welcome`, so a host view calling one bare (Papiamentu has several) showed "translation missing" in any locale it did not translate and that had no fallbacks. In en and nl they are now lambdas (`lib/locales/inline_forms_titles.rb`) that return `InlineForms.application_title`; a host's own translation still wins (its locale files load after the gem's; the example app checks the order).
+- **One source for the application's name.** `InlineForms.application_title` is the host's `application_name` translation, else its `ApplicationHelper#application_name` (8.1.66 skipped that and used the titleized module name, so an app could say "MyApp" in en and "My App" in nl), else the Rails module name. `inline_forms_application_title`, the admin layout's `<title>` and the Devise header use it.
+
+### Changed
+
+- **The admin layout loads Popper, Tippy and `inline_forms.js` in `<head>`.** In `<body>` Turbo Drive re-ran them on every visit with a fresh jQuery, the cause of 8.1.66's menu flash; Turbo runs head scripts once and appends missing ones in order on a visit from another layout. `no-js`, the once-guard and the submenu rule stay for host layouts that still load the bundle in `<body>`.
+- **Installer: the generated `config/locales/inline_forms_local.en.yml` has only `application_name`.** It also wrote the three title keys, in en only.
+- **`inline_forms_search_on` builds its clause once,** on the first search (`inline_forms_search_clause`), instead of on every search.
+
+### Tests
+
+- `turbo_menu_test`: the scripts in `<head>` in order, no document listener outside the guard, one boot per body, the `[data-dropdown-menu]` rule.
+- `locale_test`: the title keys resolve to the app's name in en and nl (translation, then the helper), a host translation wins, timestamps render in a locale without the gem's format.
+- `model_top_bar_test`: the search clause is built once.
+- Example app: `example_app_layout_title_test` checks the host's locale files load after the gem's title keys and that the keys say the app name in en and nl; `example_app_stylesheet_test` expects the scoped rule.
+
+### Lockstep
+
+- validation_hints 8.1.67, inline_forms_installer 8.1.67, inline_forms_schema_edit 8.1.67.
+
 ## [8.1.66] - 2026-11-06
 
 Requests from Papiamentu's move to the 8.1.65 admin (gem layout, engine model top bar, gem stylesheet); each was worked around in the apps.

data/app/assets/javascripts/inline_forms/inline_forms.js

@@ -14,28 +14,41 @@
 // dropdown_with_other combobox is an <input list> + <datalist>, and
 // slider_with_values is a native <input type="range">. jQuery itself stays
 // only because Foundation 6's JS requires it.
-// Once per page load. Turbo Drive re-runs this bundle on every visit (it sits
-// in <body>), and each run brings a fresh jQuery: without the guard each run
-// added another turbo:load listener, and a ready-handler `foundation()` from
-// the fresh copy (its own plugin data) would initialise the menus twice.
+// Listeners are added once per page load. The gem's layouts load this bundle
+// in <head>, which Turbo Drive keeps across visits, but a host layout may
+// still have it in <body>, which Turbo re-runs on every visit (each run with a
+// fresh jQuery): without the guard every run would add another set.
 if (!window.inlineFormsBooted) {
   window.inlineFormsBooted = true;
 
-  $(function(){
-    $(document).foundation();
-    initInlineFormsWidgets(document);
-  });
-
-  // Turbo Drive replaces <body> on a visit: the new top bar's DropdownMenu
-  // has to be initialised again, or its submenus show as plain lists.
-  // Foundation's reflow skips elements that already carry a plugin, so the
-  // call on the first page (turbo:load fires there too) is harmless. jQuery
-  // is looked up at call time.
-  document.addEventListener("turbo:load", function() {
+  // Foundation and the widgets, once per <body>. Turbo Drive replaces <body>
+  // on a visit, and the new top bar's DropdownMenu needs initialising or its
+  // submenus show as plain lists. The first page gets both the ready event
+  // and turbo:load (and a layout without Turbo only the first), so the body
+  // check keeps it to one init. jQuery is looked up at call time.
+  var inlineFormsBootedBody = null;
+  var bootInlineFormsPage = function() {
+    if (!document.body || document.body === inlineFormsBootedBody) { return; }
+    inlineFormsBootedBody = document.body;
     if (window.jQuery && window.jQuery.fn.foundation) {
       window.jQuery(document).foundation();
     }
     initInlineFormsWidgets(document);
+  };
+  $(bootInlineFormsPage);
+  document.addEventListener("turbo:load", bootInlineFormsPage);
+
+  // Re-bind widgets (tooltips) after Turbo Frame swaps.
+  document.addEventListener("turbo:frame-load", function(event) {
+    var root = event.target;
+    if (!root || !root.querySelectorAll) { return; }
+    initInlineFormsWidgets(root);
+  });
+
+  // get rid of translation_missing tooltips
+  document.addEventListener("mouseover", function(event) {
+    var el = event.target.closest && event.target.closest(".translation_missing");
+    if (el) { el.setAttribute("title", ""); }
   });
 }
 
@@ -104,17 +117,3 @@ function initValidationHintTooltips(root) {
     }
   });
 }
-
-// get rid of translation_missing tooltips
-$(document).ready(function() {
-  $(this).on('mouseover', '.translation_missing', function() {
-    $(this).attr('title', '');
-  });
-});
-
-// Re-bind widgets (tooltips) after Turbo Frame swaps.
-document.addEventListener("turbo:frame-load", function(event) {
-  var root = event.target;
-  if (!root || !root.querySelectorAll) { return; }
-  initInlineFormsWidgets(root);
-});

data/app/assets/stylesheets/inline_forms/inline_forms.scss

@@ -117,9 +117,12 @@
 // marks it `is-dropdown-submenu` (whose own rules then hide it). On the first
 // page `html.no-js` covers that gap (layouts/inline_forms.html.erb), but
 // Foundation removes the class and Turbo Drive never restores it, so after a
-// visit the new body's submenus flashed open until inline_forms.js
-// re-initialised them on turbo:load.
-.dropdown.menu > li > ul.menu:not(.is-dropdown-submenu) {
+// visit the new body's submenus could flash open until inline_forms.js
+// re-initialised them on turbo:load (most of all from a host layout that
+// still loads the bundle in <body>). Only for menus marked
+// `data-dropdown-menu`: a `data-responsive-menu` turns its submenus into
+// `is-drilldown-submenu` on small screens, which this rule would hide.
+.dropdown.menu[data-dropdown-menu] > li > ul.menu:not(.is-dropdown-submenu) {
   display: none;
 }
 

data/app/helpers/inline_forms_helper.rb

@@ -398,15 +398,21 @@ module InlineFormsHelper
   # (time.formats.inline_forms; rails-i18n's :short has none, so edits years
   # apart read the same), the exact ISO 8601 time on hover.
   def inline_forms_time(time)
-    tag.time(l(time, format: :inline_forms), datetime: time.iso8601, title: time.iso8601)
+    tag.time(inline_forms_time_text(time), datetime: time.iso8601, title: time.iso8601)
   end
 
-  # The application's name for the gem's titles and the Devise pages: the
-  # host's `application_name` translation, else its Rails module name. The
-  # gem used to ship "Application Title" / "Title for Devise" placeholders,
-  # shown in every locale the host did not override (nl, in all of them).
+  # The text alone. The gem defines time.formats.inline_forms only in en and
+  # nl; in another locale without it (and without i18n fallbacks) a bare
+  # l(format: :inline_forms) raises, so the same format is the default. The
+  # month names still come from that locale (rails-i18n).
+  def inline_forms_time_text(time)
+    l(time, format: :inline_forms, default: InlineForms::TIME_FORMAT)
+  end
+
+  # The application's name for the gem's titles and the Devise pages
+  # (InlineForms.application_title).
   def inline_forms_application_title
-    t("application_name", default: Rails.application.class.module_parent_name.titleize)
+    InlineForms.application_title
   end
 
   def version_modified_by(id)

data/app/views/devise/shared/_header_and_errors.html.erb

@@ -1,7 +1,7 @@
 <%# Unused by the gem's own devise views; kept for host apps that render it. %>
 <%# Same title source as layouts/inline_forms; Devise 5 dropped %>
 <%# devise_error_messages!, so errors use Devise's own error_messages partial. %>
-<div id="large_title"><%= t('application_name', default: application_name) %></div>
+<div id="large_title"><%= inline_forms_application_title %></div>
 <div id="flash_message">
   <% if resource.errors.any? %>
     <%= render "devise/shared/error_messages", resource: resource %>

data/app/views/inline_forms/file_trash/index.html.erb

@@ -14,7 +14,7 @@
       <% elsif @last_sweep.error.present? %>
         <%= t("inline_forms.files.global.sweep_failed", error: @last_sweep.error) %>
       <% else %>
-        <%= t("inline_forms.files.global.sweep_last", at: l(@last_sweep.ran_at, format: :inline_forms), count: @last_sweep.purged_count) %>
+        <%= t("inline_forms.files.global.sweep_last", at: inline_forms_time_text(@last_sweep.ran_at), count: @last_sweep.purged_count) %>
       <% end %>
     </p>
 
@@ -78,10 +78,10 @@
                   <span class="inline_forms-file-name"><%= inline_forms_file_entry_name(entry) %></span>
                   <span class="inline_forms-file-meta"><%= inline_forms_file_size(entry.byte_size) %> &middot; <%= t("inline_forms.files.reason.#{entry.reason}") %></span>
                 </td>
-                <td><%= t("inline_forms.files.by_on", user: inline_forms_file_user_name(entry.trashed_by_id), at: l(entry.trashed_at, format: :inline_forms)) %></td>
+                <td><%= t("inline_forms.files.by_on", user: inline_forms_file_user_name(entry.trashed_by_id), at: inline_forms_time_text(entry.trashed_at)) %></td>
                 <td>
-                  <% if entry.state == :restored %><%= t("inline_forms.files.state_restored", user: inline_forms_file_user_name(entry.restored_by_id), at: l(entry.restored_at, format: :inline_forms)) %>
-                  <% elsif entry.state == :purged %><%= t("inline_forms.files.state_purged", user: inline_forms_file_user_name(entry.purged_by_id), at: l(entry.purged_at, format: :inline_forms)) %>
+                  <% if entry.state == :restored %><%= t("inline_forms.files.state_restored", user: inline_forms_file_user_name(entry.restored_by_id), at: inline_forms_time_text(entry.restored_at)) %>
+                  <% elsif entry.state == :purged %><%= t("inline_forms.files.state_purged", user: inline_forms_file_user_name(entry.purged_by_id), at: inline_forms_time_text(entry.purged_at)) %>
                   <% elsif entry.state == :expired %><%= t("inline_forms.files.state_expired") %>
                   <% else %>
                     <% if entry.purge_after %><%= t("inline_forms.files.expires_in", count: ((entry.purge_after - Time.current) / 1.day).ceil, date: l(entry.purge_after.to_date)) %><% else %><%= t("inline_forms.files.global.states.trashed") %><% end %>

data/app/views/inline_forms/file_trash_panel.html.erb

@@ -41,13 +41,13 @@
           <span class="inline_forms-file-meta">
             <%= inline_forms_file_size(entry.byte_size) %> &middot;
             <%= t("inline_forms.files.reason.#{entry.reason}") %>
-            <%= t("inline_forms.files.by_on", user: inline_forms_file_user_name(entry.trashed_by_id), at: l(entry.trashed_at, format: :inline_forms)) %>
+            <%= t("inline_forms.files.by_on", user: inline_forms_file_user_name(entry.trashed_by_id), at: inline_forms_time_text(entry.trashed_at)) %>
           </span>
           <span class="inline_forms-file-meta">
             <% if entry.state == :restored %>
-              <%= t("inline_forms.files.state_restored", user: inline_forms_file_user_name(entry.restored_by_id), at: l(entry.restored_at, format: :inline_forms)) %>
+              <%= t("inline_forms.files.state_restored", user: inline_forms_file_user_name(entry.restored_by_id), at: inline_forms_time_text(entry.restored_at)) %>
             <% elsif entry.state == :purged %>
-              <%= t("inline_forms.files.state_purged", user: inline_forms_file_user_name(entry.purged_by_id), at: l(entry.purged_at, format: :inline_forms)) %>
+              <%= t("inline_forms.files.state_purged", user: inline_forms_file_user_name(entry.purged_by_id), at: inline_forms_time_text(entry.purged_at)) %>
             <% elsif entry.state == :expired %>
               <%= t("inline_forms.files.state_expired") %>
             <% else %>

data/app/views/layouts/inline_forms.html.erb

@@ -1,18 +1,17 @@
 <!DOCTYPE html>
 <%# class="no-js": Foundation's CSS hides the top-bar submenus while it is set %>
 <%# and its JS removes it on the first init, so the submenus do not show as %>
-<%# plain lists before then. Turbo Drive never puts it back, so later visits %>
-<%# rely on the `ul.menu:not(.is-dropdown-submenu)` rule in inline_forms.scss %>
-<%# and on the turbo:load handler in inline_forms.js. %>
+<%# plain lists before then. Turbo Drive never puts it back; after a visit %>
+<%# inline_forms.js initialises the new body on turbo:load, and the %>
+<%# `[data-dropdown-menu]` rule in inline_forms.scss covers any gap. %>
 <html lang="<%= I18n.locale %>" class="no-js">
   <head>
     <meta charset="utf-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <%# A missing translation must not reach <title>: a bare t() returns an %>
     <%# html_safe <span class="translation_missing"> that shows up as markup. %>
-    <%# The `default:` (the host's ApplicationHelper#application_name, which %>
-    <%# the header partial needs anyway) makes t() return plain, escaped text. %>
-    <title><%= t('application_name', default: application_name) %> v<%= InlineForms::VERSION %></title>
+    <%# inline_forms_application_title always has a plain-text fallback. %>
+    <title><%= inline_forms_application_title %> v<%= InlineForms::VERSION %></title>
     <%= stylesheet_link_tag "application" %>
     <%= stylesheet_link_tag "inline_forms_fonts" %>
     <%= stylesheet_link_tag "inline_forms/inline_forms" %>
@@ -22,6 +21,16 @@
     <%# Publishes the CSP nonce (nothing without a nonce generator) for the %>
     <%# scripts Turbo inserts. %>
     <%= csp_meta_tag %>
+    <%# In <head>, so Turbo Drive runs them once: it keeps head scripts across %>
+    <%# visits (a body script runs again on every visit, with a fresh jQuery), %>
+    <%# and appends them, in order, on a visit from a page that lacks them. %>
+    <%# Tippy.js (v6) needs Popper.js as a global before its UMD factory runs %>
+    <%# (`tippy-bundle.umd.min` only bundles default themes, not Popper itself). %>
+    <%# inline_forms.js initialises Foundation on the ready event and on %>
+    <%# turbo:load, once per <body>. %>
+    <%= javascript_include_tag 'popper.min' %>
+    <%= javascript_include_tag 'tippy-bundle.umd.min' %>
+    <%= javascript_include_tag 'inline_forms/inline_forms' %>
   </head>
 
   <body class="<%= inline_forms_body_theme_class %>">
@@ -40,14 +49,6 @@
     <div id="outer_container">
       <%= yield %>
     </div>
-    <%# Tippy.js (v6) needs Popper.js as a global before its UMD factory runs %>
-    <%# (`tippy-bundle.umd.min` only bundles default themes, not Popper itself). %>
-    <%# Turbo Drive re-runs these on every visit (no data-turbo-eval="false": %>
-    <%# a visit from a page whose layout lacks them must still load them). %>
-    <%# inline_forms.js boots once and re-initialises Foundation on turbo:load. %>
-    <%= javascript_include_tag 'popper.min' %>
-    <%= javascript_include_tag 'tippy-bundle.umd.min' %>
-    <%= javascript_include_tag 'inline_forms/inline_forms' %>
     <%# Turbo (Hotwire) is loaded as an ES module so it does not collide with %>
     <%# the classic-script Sprockets bundle above. Drive stays at the default %>
     <%# (enabled); inline interactions use `<turbo-frame>` + HTML responses. %>

data/lib/inline_forms/searchable.rb

@@ -19,16 +19,21 @@ module InlineForms
         end
 
         @inline_forms_searchable = true
-        # The clause is built when the scope runs, not here: quoting needs a
-        # database connection, and the class body runs whenever the model
-        # loads (eager loading, assets:precompile without a database).
+        @inline_forms_search_columns = cols
+        model = self
         scope :inline_forms_search, ->(q) {
-          clause = cols.map { |c|
-            "#{connection.quote_table_name(table_name)}.#{connection.quote_column_name(c)} LIKE :q"
-          }.join(" OR ")
-          where(clause, q: "%#{sanitize_sql_like(q.to_s)}%")
+          where(model.inline_forms_search_clause, q: "%#{sanitize_sql_like(q.to_s)}%")
         }
       end
+
+      # Built on the first search, not in inline_forms_search_on: quoting
+      # needs a database connection, and the class body runs whenever the
+      # model loads (eager loading, assets:precompile without a database).
+      def inline_forms_search_clause
+        @inline_forms_search_clause ||= @inline_forms_search_columns.map { |c|
+          "#{connection.quote_table_name(table_name)}.#{connection.quote_column_name(c)} LIKE :q"
+        }.join(" OR ")
+      end
     end
   end
 end

data/lib/inline_forms/version.rb

@@ -1,5 +1,5 @@
 # -*- encoding : utf-8 -*-
 
 module InlineForms
-  VERSION = "8.1.66"
+  VERSION = "8.1.67"
 end

data/lib/inline_forms.rb

@@ -187,6 +187,28 @@ module InlineForms
   # programmatically (generator / GUI); the user edits it to real values after.
   PLACEHOLDER_VALUES = { 1 => "one", 2 => "two" }.freeze
 
+  # Version and file timestamps: time.formats.inline_forms in the gem's en
+  # and nl locales, and the default where a locale lacks it.
+  TIME_FORMAT = "%d %b %Y %H:%M"
+
+  # The application's name for the gem's titles and the Devise pages: the
+  # host's `application_name` translation, else its
+  # ApplicationHelper#application_name (the installer writes both, and the
+  # gem's header partial uses the helper), else its Rails module name. The
+  # gem's title keys (inline_forms.general.application_title,
+  # inline_forms.devise.title_for_devise and .welcome) resolve to this in en
+  # and nl unless the host translates them (lib/locales/inline_forms_titles.rb).
+  def self.application_title
+    I18n.t("application_name", default: application_name_from_helper || Rails.application.class.module_parent_name)
+  end
+
+  def self.application_name_from_helper
+    return unless defined?(::ApplicationController)
+
+    helpers = ::ApplicationController.helpers
+    helpers.application_name if helpers.respond_to?(:application_name)
+  end
+
   def self.plain_text_form_element?(form_element)
     PLAIN_TEXT_FORM_ELEMENTS.include?(form_element.to_sym)
   rescue NoMethodError
@@ -408,7 +430,8 @@ module InlineForms
       end
     end
 
-    I18n.load_path << Dir[File.join(File.expand_path(File.dirname(__FILE__) + "/locales"), "*.yml")]
+    # .rb too: inline_forms_titles.rb holds the title keys as lambdas.
+    I18n.load_path << Dir[File.join(File.expand_path(File.dirname(__FILE__) + "/locales"), "*.{yml,rb}")]
     I18n.load_path.flatten!
   end
 end

data/lib/locales/inline_forms_titles.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+# The gem's title keys, resolved to the application's name
+# (InlineForms.application_title) instead of a placeholder. Lambdas, so a
+# host view that calls a key bare gets the real name too. A host translation
+# of the same key still wins: the host's locale files load after the gem's.
+title = ->(_key, **_options) { InlineForms.application_title }
+welcome = ->(_key, **_options) { I18n.t("inline_forms.devise.welcome_to", name: InlineForms.application_title) }
+keys = {
+  inline_forms: {
+    general: { application_title: title },
+    devise: { title_for_devise: title, welcome: welcome }
+  }
+}
+
+{ en: keys, nl: keys }

data/test/integration/locale_test.rb

@@ -143,26 +143,56 @@ class LocaleTest < InlineFormsIntegrationTestCase
 
   # The gem shipped "Application Title" / "Title for Devise" / "Welcome for
   # Devise" in en and nl; any locale the host did not override showed them.
-  test "no placeholder titles: the gem's titles use the host's application name" do
-    %i[en nl].each do |locale|
-      %w[inline_forms.general.application_title inline_forms.devise.title_for_devise inline_forms.devise.welcome].each do |key|
-        refute I18n.exists?(key, locale), "#{locale}.#{key} is a placeholder; the views fall back to application_name"
-      end
-    end
-
+  # The keys now resolve to the application's name, also when a host view
+  # calls them bare.
+  test "the gem's title keys resolve to the application's name" do
     get widgets_path
     I18n.backend.store_translations(:nl, application_name: "Werkplaats")
     strictly(:nl) do
+      assert_equal "Werkplaats", I18n.t("inline_forms.general.application_title")
+      assert_equal "Werkplaats", I18n.t("inline_forms.devise.title_for_devise")
+      assert_equal "Welkom bij Werkplaats!", I18n.t("inline_forms.devise.welcome")
       devise = controller.render_to_string(template: "stats/show", layout: "devise")
       assert_includes devise, "Werkplaats v#{InlineForms::VERSION}"
       top_bar = controller.render_to_string(partial: "devise/sessions/top-bar")
       assert_includes top_bar, "Werkplaats #{InlineForms::VERSION}"
-      assert_equal "Welkom bij Werkplaats!",
-        I18n.t("inline_forms.devise.welcome", default: I18n.t("inline_forms.devise.welcome_to", name: "Werkplaats"))
     end
     I18n.with_locale(:en) do
+      # No en application_name translation here: the host's
+      # ApplicationHelper#application_name.
+      assert_equal "Dummy", I18n.t("inline_forms.general.application_title")
+      assert_equal "Welcome to Dummy!", I18n.t("inline_forms.devise.welcome")
       assert_includes controller.render_to_string(template: "stats/show", layout: "application"), "Dummy v#{InlineForms::VERSION}"
     end
+  ensure
+    I18n.backend.reload!
+  end
+
+  test "a host translation of a title key wins" do
+    I18n.t("inline_forms.general.application_title") # loads the gem's files first, as a host app does
+    I18n.backend.store_translations(:nl, inline_forms: { general: { application_title: "Banko" } })
+
+    assert_equal "Banko", I18n.t("inline_forms.general.application_title", locale: :nl)
+  ensure
+    I18n.backend.reload!
+  end
+
+  # time.formats.inline_forms is defined in en and nl only; a bare
+  # l(format: :inline_forms) raises in any other locale without fallbacks.
+  test "version and trash timestamps render in a locale without the gem's format" do
+    original = I18n.available_locales
+    I18n.available_locales = original + [ :de ]
+    months = %w[Jan Feb Mär Apr Mai Jun Jul Aug Sep Okt Nov Dez]
+    I18n.backend.store_translations(:de, date: { abbr_month_names: [ nil, *months ] })
+    time = Time.zone.local(2019, 3, 5, 14, 7)
+
+    I18n.with_locale(:de) do
+      assert_raises(I18n::MissingTranslationData) { I18n.l(time, format: :inline_forms, raise: true) }
+      assert_equal "05 Mär 2019 14:07", ApplicationController.helpers.send(:inline_forms_time_text, time)
+    end
+  ensure
+    I18n.available_locales = original
+    I18n.backend.reload!
   end
 
   test "the versions list in en keeps its English labels" do

data/test/integration/model_top_bar_test.rb

@@ -79,5 +79,7 @@ class ModelTopBarTest < InlineFormsIntegrationTestCase
     %i[connection lease_connection with_connection].each { |m| model.singleton_class.remove_method(m) }
     Widget.create!(name: "Gamma")
     assert_equal [ "Gamma" ], model.inline_forms_search("amm").pluck(:name)
+    # Built once, on the first search.
+    assert_same model.inline_forms_search_clause, model.inline_forms_search_clause
   end
 end

data/test/integration/turbo_menu_test.rb

@@ -2,38 +2,52 @@
 
 require_relative "../integration_test_helper"
 
-# Top-bar submenus after a Turbo Drive visit. Turbo replaced <body> and re-ran
-# the inline_forms bundle (a fresh jQuery, its own Foundation plugin data),
-# and until that finished the new body's submenus showed as plain lists;
-# StProject, Scouting and Papiamentu each carried the same layout copy to
-# hide them (html.no-js, a turbo:load re-init, a CSS rule). Now the gem does.
+# Top-bar submenus after a Turbo Drive visit. The bundle sat in <body>, so
+# Turbo re-ran it on every visit (a fresh jQuery, its own Foundation plugin
+# data), and until that finished the new body's submenus showed as plain
+# lists; StProject, Scouting and Papiamentu each carried the same layout copy
+# to hide them (html.no-js, a turbo:load re-init, a CSS rule). Now the gem
+# loads the bundle in <head>, which Turbo runs once.
 class TurboMenuTest < InlineFormsIntegrationTestCase
   ROOT = File.expand_path("../..", __dir__)
 
-  test "the layout starts as no-js" do
+  def boot_block
+    js = File.read(File.join(ROOT, "app/assets/javascripts/inline_forms/inline_forms.js"))
+    js[/^if \(!window\.inlineFormsBooted\) \{.*?\n\}\n/m]
+  end
+
+  test "the layout starts as no-js and loads the bundle in head" do
     get widgets_path
 
     assert_response :success
     assert_match %r{<html lang="en" class="no-js">}, response.body
-    # Not data-turbo-eval="false": a Turbo visit from a page whose layout
-    # lacks the bundle has to run it.
-    assert_match %r{<script src="[^"]*/inline_forms/inline_forms[^"]*\.js"></script>}, response.body
+    head = response.body[%r{<head>.*</head>}m]
+    scripts = %w[popper.min tippy-bundle.umd.min inline_forms/inline_forms].map { |name|
+      head.index(%r{<script src="[^"]*/#{Regexp.escape(name)}[^"]*\.js"></script>})
+    }
+    assert scripts.all?, "popper, tippy and inline_forms.js are in <head>"
+    assert_equal scripts.sort, scripts, "in that order"
+    refute_match %r{<body.*inline_forms/inline_forms[^"]*\.js}m, response.body
   end
 
-  test "inline_forms.js boots once and re-initialises Foundation on turbo:load" do
-    js = File.read(File.join(ROOT, "app/assets/javascripts/inline_forms/inline_forms.js"))
-    boot = js[/if \(!window\.inlineFormsBooted\) \{.*?\n\}\n/m]
-
-    assert boot, "the DOM-ready and turbo:load wiring sits behind the once-guard"
-    turbo_load = boot[/addEventListener\("turbo:load".*?\n  \}\);/m]
-    assert_includes turbo_load, "window.jQuery(document).foundation();"
-    assert_includes turbo_load, "initInlineFormsWidgets(document);"
+  test "inline_forms.js wires every document listener once, and boots once per body" do
+    boot = boot_block
+
+    assert boot, "the listeners sit behind the once-guard"
+    rest = File.read(File.join(ROOT, "app/assets/javascripts/inline_forms/inline_forms.js")).sub(boot, "")
+    refute_match(/addEventListener|\$\(document\)|\.ready\(/, rest.gsub(%r{^\s*//.*$}, "").gsub(/el\.addEventListener\("input"/, ""),
+      "no document listener outside the guard: a host layout with the bundle in <body> re-runs it on every visit")
+    %w[turbo:load turbo:frame-load mouseover].each do |event|
+      assert_includes boot, "document.addEventListener(\"#{event}\""
+    end
+    assert_includes boot, "document.body === inlineFormsBootedBody"
+    assert_includes boot, "window.jQuery(document).foundation();"
   end
 
-  test "uninitialised submenus stay hidden after a visit" do
+  test "uninitialised dropdown submenus stay hidden, drilldown menus are left alone" do
     scss = File.read(File.join(ROOT, "app/assets/stylesheets/inline_forms/inline_forms.scss"))
 
-    assert_match(/^\.dropdown\.menu > li > ul\.menu:not\(\.is-dropdown-submenu\) \{\n  display: none;\n\}/, scss)
+    assert_match(/^\.dropdown\.menu\[data-dropdown-menu\] > li > ul\.menu:not\(\.is-dropdown-submenu\) \{\n  display: none;\n\}/, scss)
   end
 
   # Compiled CSS is checked in the example app (example_app_stylesheet_test).

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms
 version: !ruby/object:Gem::Version
-  version: 8.1.66
+  version: 8.1.67
 platform: ruby
 authors:
 - Ace Suares
@@ -273,6 +273,7 @@ files:
 - lib/inline_forms/version.rb
 - lib/locales/inline_forms.en.yml
 - lib/locales/inline_forms.nl.yml
+- lib/locales/inline_forms_titles.rb
 - lib/otherstuff/add_roles.sql
 - lib/otherstuff/mkrole
 - lib/otherstuff/roles_users.sql