inline_forms 8.1.18 → 8.1.19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ecefaa077ab62a564bbe19f49b650f9c2468329809110c80658b3016f6257b3c
-  data.tar.gz: 3fa4eed9d358f8c49b88438575c2c32b5732da40759afebeef41be464cc604df
+  metadata.gz: fb00bfea980d5563c8c6efdccfec5f570bf143487d0d25ddb790d38e8bb1e5a6
+  data.tar.gz: d843e74f5c4677993a8bc82454adb48db73477f3182dffe56dd0b9a389263258
 SHA512:
-  metadata.gz: 12844d6e2d41fed8e75a5ab4c5e5ef666ddac0b206285b8062b51185d648058f072b3db9ea0635b7b68d5b0f1450f495f45260f661dc53676be32f37826c70f9
-  data.tar.gz: 259eae56e0c02f5e52261601ea63dcb458e7a599faf8d3867fbb970e138f9c9f58623fe5146a312afdbe0cdea5e680d8f412cf9b625f62e1c0924dbff5622031
+  metadata.gz: b3864e91f61f48eeb3d6914c2f5651dec600ab4de3aeff91ee3bcbc4fa685603cfce59429d4baa7169d761d9e052891e03b8f6b070e693929a7c2638ecd1b70f
+  data.tar.gz: d279266cd6030c0464f2db416b4d50da554b539fc8382e77e78c75633d159057b42b7c7d81e671bfe884f598b1180816fca4af79d4e7d69bd6aa0e899ec41794

data/CHANGELOG.md

@@ -4,6 +4,17 @@ All notable changes to this project are documented in this file.
 
 ## [Unreleased]
 
+## [8.1.19] - 2026-05-28
+
+### Fixed
+
+- **Inline attribute `update` no longer renders a fake success on a failed save.** `InlineFormsController#update` called `@object.save` but ignored its return value, then unconditionally re-rendered `field_show` from the in-memory `@object`. When the save failed validation the user saw a "show" of the unsaved in-memory value while the DB row kept its old value — re-opening the edit surprised the user with the old value. `update` now branches on `@object.save`: on success it renders the show as before; on failure it re-renders the **edit** field (mirroring how `create` handles a failed save) with the validation errors in `flash.now[:error]`, so the user stays in the editor and can correct the input. This is a general fix affecting every form element, not just `money_field`.
+- **`money_field` malformed input regression.** money-rails rejects an unparseable amount such as `"99.ace99"` (the monetized validator fails, so `save` returns false and `amount_cents` is never written). Previously the inline edit showed a "saved" `$99.99` show that did not reflect the database. Now the edit field is re-rendered, and `money_field_edit` prefers the raw submitted `params[attribute]` over `object.send(attribute)` so the rejected input stays visible and editable instead of silently reverting.
+
+### Added
+
+- **Regression test:** `example_app_showcase_money_update_test.rb` POSTs a malformed `amount: "99.ace99"` inline update for the seeded `$99.95` "Full demo" `FormElementShowcase` and asserts the DB value is unchanged (`amount_cents == 9995`) and the response is the edit/error state (not a fake `$99.99` show), plus a positive path asserting a valid `"12.34"` persists (`amount_cents == 1234`) and renders the show.
+
 ## [8.1.18] - 2026-05-28
 
 ### Fixed

data/app/controllers/inline_forms_controller.rb

@@ -181,9 +181,25 @@ class InlineFormsController < ApplicationController
     @update_span = params[:update]
     InlineForms.assert_plain_text_column!(object: @object, attribute: @attribute, form_element: @form_element)
     send("#{@form_element.to_s}_update", @object, @attribute)
-    @object.save
-    respond_to do |format|
-      format.html { render_turbo_field(:field_show, turbo_field_show: true) }
+    # Branch on the actual save result. Previously the return value of
+    # `@object.save` was ignored and `field_show` was rendered
+    # unconditionally from the in-memory `@object`. When a save failed
+    # validation (e.g. money-rails rejecting an unparseable amount, or any
+    # `validates` failure) the user saw a "show" of the unsaved in-memory
+    # value -- a fake success -- while the DB row kept its old value. A
+    # subsequent edit then re-read the old value, surprising the user.
+    #
+    # On failure we keep the user in the edit field with their rejected
+    # input visible and surface the validation errors (mirrors `create`).
+    if @object.save
+      respond_to do |format|
+        format.html { render_turbo_field(:field_show, turbo_field_show: true) }
+      end
+    else
+      flash.now[:error] = @object.errors.to_a
+      respond_to do |format|
+        format.html { render_turbo_field(:field_edit) }
+      end
     end
   end
 

data/lib/inline_forms/form_elements/money_field_helper.rb

@@ -27,7 +27,15 @@ module InlineForms
     end
 
     def money_field_edit(object, attribute)
-      text_field_tag attribute, (object.send attribute), :class => 'input_money_field'
+      # On a fresh edit there is no submitted value, so fall back to the
+      # current Money value. On a re-render after a *failed* update
+      # (money-rails could not parse the input) `object.send(attribute)`
+      # no longer reflects what the user typed -- it returns the old/last
+      # parsed value -- so the user would silently lose their rejected
+      # input. Prefer the raw submitted `params[attribute]` so the bad
+      # value stays visible and editable.
+      value = params[attribute].presence || (object.send attribute)
+      text_field_tag attribute, value, :class => 'input_money_field'
     end
 
     def money_field_update(object, attribute)

data/lib/inline_forms/version.rb

@@ -1,4 +1,4 @@
 # -*- encoding : utf-8 -*-
 module InlineForms
-  VERSION = "8.1.18"
+  VERSION = "8.1.19"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms
 version: !ruby/object:Gem::Version
-  version: 8.1.18
+  version: 8.1.19
 platform: ruby
 authors:
 - Ace Suares