inline_forms 7.13.3 → 7.13.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ec05aa4e1a1a1f21dcd041e8022943ec84af7c9b1ad4ccd90a6f57721f1732cd
-  data.tar.gz: 05fac9919e1730afa9797d2b343a0c76484cf28c6ac0ca210daed96312699902
+  metadata.gz: 8a68d0c92e72d9f2a1adb026157f51097a12f77fa704be1c25c934178a540142
+  data.tar.gz: eeb3d95f3e6e1f988a3a5cad6a176ff4c503f8a6efab22f8ca9e03029457ae8e
 SHA512:
-  metadata.gz: 927830ff6c84fa2642f243df6956725584b990814ffc10a357983b253117cb2c1c99f3dc7b304438becd1a20e962cae72df6714f4b570cac4c1a54fe65dc3134
-  data.tar.gz: ad534d4e02d38e4dc6d607e18a92725cda21334a73b5a41bbea096dd5bb830fc23697a58928345ac32426fe5c3939a46106fb176068e1aa696637f2a7e7dcd6b
+  metadata.gz: b3411a60ef7e26d8994a47daf32ca10455ac6aee511f35b198afaa0ea53172cd009c5dd9632d069f05039ecd24ffca0508d2e3fbcd0b2ce93712e351a8f919d0
+  data.tar.gz: 01b8cff956c04ae458e1ea5b76534a5e741fb4845b518021cad5d6253693f54a8782ae802b504984ef3136a80fd3446a4db99e1584a3c0162e39ddec08f4c031

data/CHANGELOG.md

@@ -4,6 +4,31 @@ All notable changes to this project are documented in this file.
 
 ## [Unreleased]
 
+## [7.13.4] - 2026-05-19
+
+### Fixed
+
+- **Restore on a rich_text `create` version was asymmetric** depending on what the first save of the field happened to look like. If the field's first rich_text save was empty (e.g. opening the inline editor and saving without typing — common on top-level Apartments), the user later got a `create` (body: nil -> "") plus an `update` (body: "" -> "...") and could click Restore on the update to clear the field. If the first save already had content (more common on nested Photo descriptions), the field had only the `create` version and the 7.13.2 hide-Restore-on-create rule meant there was no Restore link at all — the user reported "I can restore the empty value on Apartments but not on the nested Photo".
+  - **`app/views/inline_forms/_versions_list.html.erb`**: show the Restore link on `:rich_text` `create` rows (still hide it on `:primary` `create` rows — those would mean destroying the parent record, which is the Destroy button's job).
+  - **`app/controllers/inline_forms_controller.rb#revert`**: when `reify` is nil and `@version.item` is an `ActionText::RichText`, treat the revert as "undo the creation" — destroy the rich_text row, `touch` the parent, and respond with the existing turbo-stream replacing the row + versions frames. Primary `create` reverts (only reachable via replayed URLs since the view hides the link) still no-op cleanly through the same handler.
+
+### Added
+
+- **`test/integration/example_app_apartment_versions_turbo_test.rb`** (installer template):
+  - `revert on rich_text create destroys the rich_text record so the field becomes empty` — pins the Apartment-side fix.
+  - `revert on nested Photo rich_text create destroys the rich_text record` — pins the originally reported nested-Photo case.
+  - `versions list shows Restore link on rich_text create rows` — pins the view-side link surfacing.
+  - `versions list hides Restore link on primary create rows but keeps it on update rows` — clarifies the asymmetry between `:primary` and `:rich_text` create rows (renames the earlier test).
+
+### Changed
+
+- **`InlineForms::VERSION`** and **`InlineFormsInstaller::VERSION`** -> `7.13.4`. Companion `validation_hints` release will follow in lockstep.
+
+### Verified
+
+- `gem build inline_forms.gemspec` -> `inline_forms-7.13.4.gem`; `gem build inline_forms_installer.gemspec` -> `inline_forms_installer-7.13.4.gem`.
+- `inline_forms create MyApp -d sqlite --example` -> `bundle exec rails test` -- **83 runs, 0 failures, 0 errors, 0 skips** (Ruby 4.0.4 / Rails 7.2.3.1).
+
 ## [7.13.3] - 2026-05-19
 
 ### Fixed

data/app/controllers/inline_forms_controller.rb

@@ -276,14 +276,27 @@ class InlineFormsController < ApplicationController
       # case a request was bookmarked or replayed: render close on the
       # current parent without mutating anything.
       if @object.nil?
+        # reify returns nil for `create` events (no prior state). For a
+        # rich_text create, reverting means "undo the creation" -> destroy
+        # the ActionText::RichText row so the parent's field reverts to
+        # empty (symmetric with reverting an update on a rich_text that
+        # was first saved empty). For a primary record we never offer
+        # Restore on `create` in the view; this branch only runs for
+        # replayed/bookmarked URLs and must remain a no-op response keyed
+        # off the parent.
         item = @version.item
-        @parent = if defined?(ActionText::RichText) && item.is_a?(ActionText::RichText)
-                    item.record
-                  else
-                    item
-                  end
-        return unless @parent
-        authorize!(:revert, @parent) if cancan_enabled?
+        if defined?(ActionText::RichText) && item.is_a?(ActionText::RichText)
+          @rich_text_record = item
+          @parent = @rich_text_record.record
+          return unless @parent
+          authorize!(:revert, @parent) if cancan_enabled?
+          @rich_text_record.destroy
+          @parent.touch if @parent.respond_to?(:touch)
+        else
+          @parent = item
+          return unless @parent
+          authorize!(:revert, @parent) if cancan_enabled?
+        end
         return unless row_html_turbo_allowed?
         respond_to do |format|
           format.turbo_stream { render_revert_turbo_streams }

data/app/views/inline_forms/_versions_list.html.erb

@@ -51,11 +51,18 @@
           parent's controller, so the same path works for both kinds.
 
           PaperTrail's `reify` returns nil for `create` versions (no prior
-          state to roll back to). Reverting a `create` would mean destroying
-          the record — primary records already have a dedicated Destroy
-          button (superadmin), and rich_text content can be cleared by
-          editing. Omitting the link here keeps the UI consistent and
-          avoids a NoMethodError in the controller's `save!`.
+          state to roll back to). Reverting a `create`:
+            * on a :rich_text entry  -> destroy the ActionText::RichText
+              record, i.e. clear the field. The Restore link is shown so
+              the user can symmetrically undo "I added content" the same
+              way they can undo "I edited content" — without this, a
+              field whose rich_text was first saved with non-empty content
+              had no Restore link at all (asymmetric with parents whose
+              first save happened to be empty).
+            * on a :primary entry  -> would mean destroying the parent
+              record itself. Primary records already have a dedicated
+              Destroy button (superadmin); the Restore link stays hidden
+              so the action is never offered ambiguously here.
 
           Empty-changeset update rows (e.g. PaperTrail `touch` events from
           `belongs_to ..., touch: true` on associated ActionText::RichText
@@ -64,7 +71,7 @@
           tracking (`has_paper_trail on: [:create, :update, :destroy]`),
           but legacy apps still have these rows in the audit trail; the
           link is hidden here so the action is never offered. -%>
-      <% if version.event == "create" %>
+      <% if version.event == "create" && entry[:kind] != :rich_text %>
         &nbsp;
       <% elsif version.changeset.nil? || version.changeset.except("updated_at").empty? %>
         &nbsp;

data/lib/inline_forms/version.rb

@@ -1,4 +1,4 @@
 # -*- encoding : utf-8 -*-
 module InlineForms
-  VERSION = "7.13.3"
+  VERSION = "7.13.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms
 version: !ruby/object:Gem::Version
-  version: 7.13.3
+  version: 7.13.4
 platform: ruby
 authors:
 - Ace Suares