inherited_resources 1.14.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 87f659e1b778d34e1c7f04ef7e8eba386a5acbbb4488d01cc2bf8779d80836ce
-  data.tar.gz: 5b28af6d8a16a8c8e35e0422fcd052be9d4ec4080fec78a755d23078e9e71c9e
+  metadata.gz: 9a09c7a051f4bb54bd49bdbf51a1a3c0c59d270f78d8fe30f678b3308c19d949
+  data.tar.gz: de365970fd390bd077e8cf91fd2793783c7df68b08c224a3ad775ad052606ab0
 SHA512:
-  metadata.gz: dd3e8c0db5001b1ea10cbeee5f001e1528ece1e664f1f7113c742d0dd8aff769484593190c471e277c1cbc95b6d5ebae2244bdec0c950ecdf997e302ed5877fc
-  data.tar.gz: 1e6c02bd2a5ca5a141dc632e5afdb2def6532f300e729a3d0a150974788bad1575ef71ae12a84d04c966f8756037cd6a18d0d62bb9438208a4aeaab513203050
+  metadata.gz: e3c2ce831127a24065c97cf8a3fb6857307dd216e27a45e341eb3d41d3d7bf4d8fe6b5d2eda5de913bfc34c52a35bb62cd785f6408298ff039fd5f791d00ca40
+  data.tar.gz: fc3908d187aac0c3b96b84a303ff450121f94c7fa8345f6f21650b531eab0be9f0fc20bbec3c0d237d2a416b172d0e43fe7345015bb12ef6651ede85399babfe

data/README.md

@@ -5,7 +5,7 @@ has been transferred to the ActiveAdmin organization for maintenance.  New featu
 requests are not encouraged.
 
 If you are not already using Inherited Resources we suggest instead using Rails'
-`respond_with` feature alongside the [responders gem](https://github.com/plataformatec/responders).
+`respond_with` feature alongside the [responders gem](https://github.com/heartcombo/responders).
 
 ## Inherited Resources
 
@@ -22,7 +22,7 @@ code by following fat models and skinny controllers convention. There are
 two screencasts available besides this README:
 
 * http://railscasts.com/episodes/230-inherited-resources
-* http://akitaonrails.com/2009/09/01/screencast-real-thin-restful-controllers-with-inherited-resources
+* https://www.akitaonrails.com/2009/09/01/screencast-real-thin-restful-controllers-with-inherited-resources
 
 ## Installation
 
@@ -49,7 +49,7 @@ $ gem install inherited_resources
 Since Inherited Resources 1.0, has_scope is not part of its core anymore but
 a gem dependency. Be sure to check the documentation to see how you can use it:
 
-- <http://github.com/plataformatec/has_scope>
+- <https://github.com/heartcombo/has_scope>
 
 And it can be installed as:
 
@@ -64,7 +64,7 @@ but is set as Inherited Resources dependency and it's used by default by
 InheritedResources controllers. Be sure to check the documentation to see
 how it will change your application:
 
-- <http://github.com/plataformatec/responders>
+- <https://github.com/heartcombo/responders>
 
 And it can be installed with:
 
@@ -737,7 +737,7 @@ MIT License. Copyright (c) 2009-2017 José Valim.
 Please use the Tidelift security contact to [report a security vulnerability][Tidelift security contact].
 Tidelift will coordinate the fix and disclosure.
 
-[rubygems_badge]: http://img.shields.io/gem/v/inherited_resources.svg
+[rubygems_badge]: https://img.shields.io/gem/v/inherited_resources.svg
 [rubygems]: https://rubygems.org/gems/inherited_resources
 [actions_badge]: https://github.com/activeadmin/inherited_resources/workflows/ci/badge.svg
 [actions]: https://github.com/activeadmin/inherited_resources/actions

data/app/controllers/inherited_resources/base.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module InheritedResources
   # = Base
   #

data/lib/generators/rails/inherited_resources_controller_generator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails/generators/rails/scaffold_controller/scaffold_controller_generator'
 
 module Rails

data/lib/inherited_resources/actions.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module InheritedResources
-  # Holds all default actions for InheritedResouces.
+  # Holds all default actions for InheritedResources.
   module Actions
 
     # GET /resources

data/lib/inherited_resources/base_helpers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Whenever base is required load the dumb responder since it's used inside actions.
 require 'inherited_resources/blank_slate'
 
@@ -54,7 +56,7 @@ module InheritedResources
 
       # Responsible for saving the resource on :create method. Overwriting this
       # allow you to control the way resource is saved. Let's say you have a
-      # PassworsController who is responsible for finding an user by email and
+      # PasswordsController who is responsible for finding an user by email and
       # sent password instructions for him. Instead of overwriting the entire
       # :create method, you could do something:
       #
@@ -133,7 +135,7 @@ module InheritedResources
       end
 
       # rubocop:disable Layout/CommentIndentation
-      # See https://github.com/rubocop-hq/rubocop/issues/6450
+      # See https://github.com/rubocop/rubocop/issues/6450
       #
       # Overwrite this method to provide other interpolation options when
       # the flash message is going to be set.
@@ -215,7 +217,7 @@ module InheritedResources
       #
       def get_resource_ivar #:nodoc:
         if instance_variable_defined?(:"@#{resource_instance_name}")
-          instance_variable_get("@#{resource_instance_name}")
+          instance_variable_get(:"@#{resource_instance_name}")
         else
           nil
         end
@@ -224,14 +226,14 @@ module InheritedResources
       # Set resource ivar based on the current resource controller.
       #
       def set_resource_ivar(resource) #:nodoc:
-        instance_variable_set("@#{resource_instance_name}", resource)
+        instance_variable_set(:"@#{resource_instance_name}", resource)
       end
 
       # Get collection ivar based on the current resource controller.
       #
       def get_collection_ivar #:nodoc:
         if instance_variable_defined?(:"@#{resource_collection_name}")
-          instance_variable_get("@#{resource_collection_name}")
+          instance_variable_get(:"@#{resource_collection_name}")
         else
           nil
         end
@@ -240,7 +242,7 @@ module InheritedResources
       # Set collection ivar based on the current resource controller.
       #
       def set_collection_ivar(collection) #:nodoc:
-        instance_variable_set("@#{resource_collection_name}", collection)
+        instance_variable_set(:"@#{resource_collection_name}", collection)
       end
 
       # Used to allow to specify success and failure within just one block:
@@ -368,7 +370,7 @@ module InheritedResources
         self.resources_configuration[:self][:role].present?
       end
 
-      # getting role for mass-asignment
+      # getting role for mass-assignment
       def as_role
         { as: self.resources_configuration[:self][:role] }
       end

data/lib/inherited_resources/belongs_to_helpers.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 module InheritedResources
 
   # = belongs_to
   #
   # Let's suppose that we have some tasks that belongs to projects. To specify
-  # this assoication in your controllers, just do:
+  # this association in your controllers, just do:
   #
   #    class TasksController < InheritedResources::Base
   #      belongs_to :project
@@ -77,7 +79,7 @@ module InheritedResources
 
       def get_parent_ivar(instance_name) #:nodoc:
         instance_variable_defined?(:"@#{instance_name}") &&
-          instance_variable_get("@#{instance_name}")
+          instance_variable_get(:"@#{instance_name}")
       end
 
       def set_parent_instance(parent_config, chain) #:nodoc:
@@ -97,7 +99,7 @@ module InheritedResources
           parent = parent.send(parent_config[:finder], params[parent_config[:param]])
         end
 
-        instance_variable_set("@#{parent_config[:instance_name]}", parent)
+        instance_variable_set(:"@#{parent_config[:instance_name]}", parent)
       end
 
       # Maps parents_symbols to build association chain. In this case, it

data/lib/inherited_resources/blank_slate.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module InheritedResources
   # An object from BlankSlate simply discards all messages sent to it.
   class BlankSlate
     instance_methods.each do |m|
-      undef_method m unless m =~ /^(__|object_id)/
+      undef_method m unless /^(__|object_id)/.match?(m)
     end
 
     def method_missing(*args)

data/lib/inherited_resources/class_methods.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module InheritedResources
   module ClassMethods
 
@@ -25,7 +27,7 @@ module InheritedResources
       #
       # * <tt>:route_instance_name</tt> - The name of the singular route. Defaults to :instance_name.
       #
-      # * <tt>:route_prefix</tt> - The route prefix which is automically set in namespaced
+      # * <tt>:route_prefix</tt> - The route prefix which is automatically set in namespaced
       #                            controllers. Default to :admin on Admin::ProjectsController.
       #
       # * <tt>:singleton</tt> - Tells if this controller is singleton or not.
@@ -53,7 +55,7 @@ module InheritedResources
           config[:request_name] = begin
             request_name = self.resource_class
             request_name = request_name.model_name.param_key if request_name.respond_to?(:model_name)
-            request_name.to_s.underscore.gsub('/', '_')
+            request_name.to_s.underscore.tr('/', '_')
           end
           options.delete(:resource_class) and options.delete(:class_name)
         end
@@ -65,7 +67,7 @@ module InheritedResources
         create_resources_url_helpers!
       end
 
-      # Defines wich actions will be inherited from the inherited controller.
+      # Defines which actions will be inherited from the inherited controller.
       # Syntax is borrowed from resource_controller.
       #
       #   actions :index, :show, :edit
@@ -215,7 +217,7 @@ module InheritedResources
           config[:finder]          = finder || :find
         end
 
-        if block_given?
+        if block
           class_eval(&block)
         else
           create_resources_url_helpers!
@@ -227,7 +229,7 @@ module InheritedResources
       #
       def polymorphic_belongs_to(*symbols, &block)
         options = symbols.extract_options!
-        options.merge!(polymorphic: true)
+        options[:polymorphic] = true
         belongs_to(*symbols, options, &block)
       end
 
@@ -235,7 +237,7 @@ module InheritedResources
       #
       def singleton_belongs_to(*symbols, &block)
         options = symbols.extract_options!
-        options.merge!(singleton: true)
+        options[:singleton] = true
         belongs_to(*symbols, options, &block)
       end
 
@@ -243,7 +245,7 @@ module InheritedResources
       #
       def optional_belongs_to(*symbols, &block)
         options = symbols.extract_options!
-        options.merge!(optional: true)
+        options[:optional] = true
         belongs_to(*symbols, options, &block)
       end
 
@@ -384,7 +386,7 @@ module InheritedResources
         # Forum::Thread#create will properly pick up the request parameter
         # which will be forum_thread, and not thread
         # Additionally make this work orthogonally with instance_name
-        config[:request_name] = self.resource_class.to_s.underscore.gsub('/', '_')
+        config[:request_name] = self.resource_class.to_s.underscore.tr('/', '_')
 
         # Initialize polymorphic, singleton, scopes and belongs_to parameters
         polymorphic = self.resources_configuration[:polymorphic] || { symbols: [], optional: false }

data/lib/inherited_resources/dsl.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module InheritedResources
   # Allows controllers to write actions using a class method DSL.
   #

data/lib/inherited_resources/engine.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module InheritedResources
   class Railtie < ::Rails::Engine
     config.inherited_resources = InheritedResources

data/lib/inherited_resources/polymorphic_helpers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module InheritedResources
 
   # = polymorphic associations
@@ -120,8 +122,8 @@ module InheritedResources
       #
       def parent
         if parent_type
-          p = instance_variable_defined?("@#{parent_type}") && instance_variable_get("@#{parent_type}")
-          p || instance_variable_set("@#{parent_type}", association_chain[-1])
+          p = instance_variable_defined?(:"@#{parent_type}") && instance_variable_get(:"@#{parent_type}")
+          p || instance_variable_set(:"@#{parent_type}", association_chain[-1])
         end
       end
 

data/lib/inherited_resources/responder.rb

@@ -1,5 +1,10 @@
+# frozen_string_literal: true
+
 module InheritedResources
   class Responder < ActionController::Responder
     include Responders::FlashResponder
+
+    self.error_status = :unprocessable_entity
+    self.redirect_status = :see_other
   end
 end

data/lib/inherited_resources/shallow_helpers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module InheritedResources
   # Shallow provides a functionality that goes on pair with Rails' shallow.
   # It is very similar to "optional" but it actually finds all the parents
@@ -33,7 +35,7 @@ module InheritedResources
       end
 
       def load_parents(instance, parent_symbols)
-        parent_symbols.reverse.each do |parent|
+        parent_symbols.reverse_each do |parent|
           instance = instance.send(parent)
           config   = resources_configuration[parent]
           params[config[:param]] = instance.to_param

data/lib/inherited_resources/singleton_helpers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module InheritedResources
 
   # = singleton

data/lib/inherited_resources/url_helpers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module InheritedResources
   # = URLHelpers
   #

data/lib/inherited_resources/version.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module InheritedResources
-  VERSION = '1.14.0'.freeze
+  VERSION = '2.0.0'.freeze
 end

data/lib/inherited_resources.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This is here because responders don't require it.
 require 'rails/engine'
 require 'responders'
@@ -28,7 +30,7 @@ end
 ActiveSupport.on_load(:action_controller_base) do
   # If you cannot inherit from InheritedResources::Base you can call
   # inherit_resources in your controller to have all the required modules and
-  # funcionality included.
+  # functionality included.
   def self.inherit_resources
     InheritedResources::Base.inherit_resources(self)
     initialize_resources_class_accessors!

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inherited_resources
 version: !ruby/object:Gem::Version
-  version: 1.14.0
+  version: 2.0.0
 platform: ruby
 authors:
 - José Valim
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-10-09 00:00:00.000000000 Z
+date: 2024-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: responders
@@ -115,7 +115,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.13
+rubygems_version: 3.5.18
 signing_key:
 specification_version: 4
 summary: Inherited Resources speeds up development by making your controllers inherit