infopark_reactor 1.20.0 → 1.20.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4565152e9620ee1549db9c630f29fc09963aca7c
-  data.tar.gz: 2f73a2ba9c91bf01bb6e976c5dc3f7c95ae69131
+  metadata.gz: 454dbe710b4633a4ed51766bbff6715c3fc61389
+  data.tar.gz: 9bfab36ff12db044a67d43bb2af6949064621d86
 SHA512:
-  metadata.gz: ea47b54ec12a7c0d158194e00af28291028d63a9873fb88b66cf881891ed1f55ea3ab26709aa7741f45eeaf79bf6aa16b255170a0b5e9ad39fc04e80639aff04
-  data.tar.gz: 666ca185f3ff1ecbbc9fc489c37c88e2cfa7be23c48e2fa4da3aa9de8408635f7641dad6fb308bc6d2c2e521a328cadf93766abc55310afb06d3237c05abed37
+  metadata.gz: 544e8f98979aa61bd01a1b67452c52f33fc46c4acd75ec3120266556b083aba990ba191244f9bc6fba7e43a3a2ea92471bfc8fde8b0dea4fbe129379e3e09d0d
+  data.tar.gz: 22bad39cdab60ca1d9ce6ab0dac9a4a0d67e788a189c22ab883e279689d60500fd066d525157d7466d51def0bc8a764cda7176ddad6ca89b3aa65b1428fdd690

data/lib/reactor/attributes.rb

@@ -103,8 +103,17 @@ module Reactor
             end
           EOC
         end
+
+        # active model dirty tracking
+        attribute_methods << <<-EOC
+        def #{attribute}_changed?
+          attribute_changed?(:#{attribute})
+        end
+        EOC
       end
 
+
+
       [:contentType].each do |attribute|
         writers << attribute.to_sym
         writers << attribute.to_s.underscore.to_sym
@@ -225,6 +234,18 @@ module Reactor
         self[:channels] || []
       end
 
+      def body_changed?
+        attribute_changed?(:body)
+      end
+
+      def title_changed?
+        attribute_changed?(:title)
+      end
+
+      def channels_changed?
+        attribute_changed?(:channels)
+      end
+
       # Sets given attribute, to given value. Converts values if neccessary
       # @see [Reactor::Attributes]
       # @note options are passed to underlying xml interface, but as of now have no effect
@@ -239,8 +260,7 @@ module Reactor
         formated_value = serialize_value(key, value)
         crul_set(attr, formated_value, options)
 
-        __send__(:attribute_will_change!, key)
-
+        __track_dirty_attribute(key)
         active_record_set(key, formated_value) if active_record_attr?(key)
         rails_connector_set(key, formated_value)
 
@@ -355,15 +375,30 @@ module Reactor
         attribute_type(attr) == :linklist
       end
 
-      def active_record_set(field, value)
-        if Reactor.rails4_2?
+      if Reactor.rails4_2?
+        def active_record_set(field, value)
           @attributes.write_from_user(field.to_s, value)
-        else
+        end
+      else
+        def active_record_set(field, value)
           @attributes_cache.delete(field.to_s)
           @attributes[field.to_s] = value
         end
       end
 
+      if Reactor.rails4_2? || Reactor.rails4_1?
+        def __track_dirty_attribute(key)
+          __send__(:attribute_will_change!, key.to_s)
+        end
+      else
+        def __track_dirty_attribute(key)
+          # in rails versions <= Rails 4.0 sometimes the first option
+          # and sometimes the second option is used
+          __send__(:attribute_will_change!, key.to_s)
+          __send__(:attribute_will_change!, key.to_sym)
+        end
+      end
+
       # Lazily sets values for crul interface. May be removed in later versions
       def crul_set(field, value, options)
         @__crul_attributes ||= {}

data/lib/reactor/cm/obj.rb

@@ -151,33 +151,55 @@ module Reactor
 
         skip_version_creation = @attrs.empty? && links_to_remove.empty? && links_to_set.empty? && !links_modified
 
-        # The save procedure consists of following steps:
-        # First request (assign attributes):
-        #  a. Execute take to assign the edited content to the current user
-        #  b. Execute edit to create an edited content if there is none present
-        #  c. Set object attributes (name, permalink, etc.)
-        #  d. Set content attributes (title, body etc. + custom attributes)
-        #  e. Resolve all links in *html* attributes
-        # Second request (overwrite linklists):
-        #  f. Remove superflous links
-        #  g. Overwrite existing links
-        #  h. Add missing links
+        # The save procedure consists of two multiplexed CM requests.
+        # Each request combines multiple operations for better performance.
         #
-        # Second request is optional and only happens if linklists
-        # have been changed.
+        # It is necessary to split the procedure into two request because
+        # of the linklist handling. For objects with only released content
+        # the edit operation copies all links (and generates new ids).
+        # Only the new links from the edited content can be manipulated.
+        # Thus it is neccessary after perform a read of links after the
+        # edit operation.
         #
-        # Steps a,b,d,e,f,g,h are optional and are skipped if only
-        # object attributes have been supplied.
+        # The second request may seem strange and redundant, but has very
+        # important reasons for being structured the way it is.
+        # The CM in all versions (as of this moment <= 7.0.1) contains
+        # multiple race conditions regarding slave workers and the CRUL
+        # interface.
         #
-        # It can happen that the second request is received by
-        # a different CM slave than the first request. If additionaly
-        # the slave has invalid cache (for example when the cache
-        # invalidate command has not yet been fully propagated among
-        # slaves), then race condition can occur.
-        # It is therefore extremely important for the second request
-        # to be resistant against invalid cache, otherwise then
-        # save operation aborts.
-
+        # It is possible that the two requests are processed by two different
+        # slave workers which have an invalid cache. Without careful
+        # programing it may lead to unexpected results and/or data loss.
+        # The reason behind it is simple: the cache invalidate requests
+        # are distributed asynchronously between workers.
+        #
+        # It is impossible to ensure that the two requests are processed
+        # by the same worker: a worker may get killed at any time, without
+        # warning (producing errors on keep-alive connections). Furthermore
+        # the workers regularly kill themselves (after X processed requests)
+        # to contain memory leaks.
+        #
+        # Following cases are especially important to handle correctly:
+        # Let Slave 1 be the worker receiving the first request and Slave 2
+        # be the worker receiving the second request. Let Object be the
+        # object on which the save operation is performed.
+        #
+        # 1. If the Object contains only released version, then Slave 2
+        # may be unaware of the newly created edited version by the time
+        # the second request is being processed. Thefore all operations
+        # involving indirect content references for example adding links
+        # (obj where ... editedContent addLinkTo) would get rejected
+        # by the Slave 2.
+        #
+        # 2. If the Object contains an edited version, then Slave 2 may
+        # be unaware of the changes perfomed on it, change of editor for
+        # example, and can reject valid requests. The more dramatic
+        # scenario involves Slave 2 persisting its invalid cached content
+        # which would result in a data loss.
+        #
+        # The requests have been thus crafted to deal with those problems.
+        # The solution is based on the precise source-code level knowledge
+        # of the CM internals.
         resp = MultiXmlRequest.execute do |reqs|
           reqs.optional  {|xml| SimpleCommandRequest.build(xml, @obj_id, 'take') } unless skip_version_creation
           reqs.optional  {|xml| SimpleCommandRequest.build(xml, @obj_id, 'edit') } unless skip_version_creation

data/lib/reactor/version.rb

@@ -1,4 +1,4 @@
 # -*- encoding : utf-8 -*-
 module Reactor
-  VERSION = "1.20.0"
+  VERSION = "1.20.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: infopark_reactor
 version: !ruby/object:Gem::Version
-  version: 1.20.0
+  version: 1.20.1
 platform: ruby
 authors:
 - Tomasz Przedmojski
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-08 00:00:00.000000000 Z
+date: 2016-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails