influxdb-rails 0.4.999 → 1.0.0.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d2ff414e8cae6402df105a81f2c74f85c4a54bbf891b8be50c1038c04e834700
-  data.tar.gz: b0487d28207ca60c4b25ef5db6c725c0aeca4d6cbf0c06d74f19ea5507b9da1e
+  metadata.gz: 68333c3962daf87c05e1ff1b221accc5854e4c7d671f0d0441a5c789b2322cee
+  data.tar.gz: 56017328de99c335fd4c590fe80c2d9de1b9132f39a7d3ac6d07b87b551597f9
 SHA512:
-  metadata.gz: 312c37ab1718fb18b54b322de99a298ed3adab60d6649052e73a0f48b9b3a8aabd9cef9edc9ab8d4ebd2741fddce111987db1cf831578b8dc86f82f1f8d431d2
-  data.tar.gz: 4ce0755f4b739c487f46e95d9140066fd693e9dd277f7a42b5b3d750d6749ffc4eafd502b23016fd4b27f9921f66937eb869416ccb531804c6f217e1c3622c09
+  metadata.gz: e6c6087522e487aaefabe377698d2275270070c0e9d70eb7110fd90000f2160fc03b127879e39481ca0ff7f1f6bc5010075c4d9fe64bd30ecebd9b04b7e98df6
+  data.tar.gz: baf2150e6140c85119da580cb89b06204a0372277c6adf7c57f15b89c214e41d80f05e0b47447df939eecc26dfb27115787750d92a22ae3ced38a047448f97bc

data/.gitignore

@@ -6,3 +6,4 @@ gemfiles/*.lock
 pkg/*
 spec/support/rails*/log/*
 .ruby-*
+vendor/bundle

data/.rubocop.yml

@@ -0,0 +1,77 @@
+AllCops:
+  Include:
+  - 'Rakefile'
+  - '*.gemspec'
+  - 'lib/**/*.rb'
+  - 'spec/**/*.rb'
+  Exclude:
+  - 'bin/**/*'
+  - 'smoke/**/*'
+  - 'Gemfile'
+  DisplayCopNames: true
+  StyleGuideCopsOnly: false
+  TargetRubyVersion: 2.3
+
+Rails:
+  Enabled: false
+
+Layout/EmptyLinesAroundArguments:
+  Enabled: false
+
+Layout/SpaceBeforeBlockBraces:
+  EnforcedStyleForEmptyBraces: space
+
+Layout/AlignHash:
+  EnforcedColonStyle: table
+  EnforcedHashRocketStyle: table
+
+Metrics/AbcSize:
+  Max: 20
+
+Metrics/BlockLength:
+  Exclude:
+  - 'spec/**/*.rb'
+
+Metrics/LineLength:
+  Max: 100
+  Exclude:
+  - 'spec/**/*.rb'
+
+Metrics/ModuleLength:
+  CountComments: false  # count full line comments?
+  Max: 120
+
+Metrics/ParameterLists:
+  Max: 6
+
+Naming/UncommunicativeMethodParamName:
+  AllowedNames: [io, id, db, ex]
+
+Naming/FileName:
+  Exclude:
+  - lib/influxdb-rails.rb
+
+Style/FormatStringToken:
+  Enabled: false
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Style/NumericPredicate:
+  Enabled: false
+
+Style/RescueModifier:
+  Enabled: false
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: comma
+  Exclude:
+  - "spec/**/*.rb"
+
+Style/TrailingCommaInHashLiteral:
+  EnforcedStyleForMultiline: comma
+  Exclude:
+  - "spec/**/*.rb"

data/.travis.yml

@@ -4,25 +4,32 @@ language: ruby
 before_install:
   - gem update --system --no-doc
   - gem install bundler --no-doc
+  - gem update bundler --no-doc
 rvm:
-  - 2.4.2
-  - 2.3.5
+  - ruby-head
+  - 2.5.3
+  - 2.4.5
+  - 2.3.8
 gemfile:
+  - gemfiles/Gemfile.rails-5.2.x
   - gemfiles/Gemfile.rails-5.1.x
   - gemfiles/Gemfile.rails-5.0.x
   - gemfiles/Gemfile.rails-4.2.x
-  - gemfiles/Gemfile.rails-4.1.x
-  - gemfiles/Gemfile.rails-4.0.x
+env:
+  - TEST_TASK=spec
 matrix:
+  allow_failures:
+    - rvm: ruby-head
+  include:
+    - { rvm: "2.5.3",   gemfile: "Gemfile", env: [TEST_TASK=rubocop] }
   exclude:
-    # Rails < 5 not on MRI 2.4
-    - { rvm: "2.4.2", gemfile: "gemfiles/Gemfile.rails-4.2.x" }
-    - { rvm: "2.4.2", gemfile: "gemfiles/Gemfile.rails-4.1.x" }
-    - { rvm: "2.4.2", gemfile: "gemfiles/Gemfile.rails-4.0.x" }
-
-notifications:
-  email:
-    - pilots@errplane.com
-  on_success: change
-  on_failure: always
+    # Rails < 5 not on MRI 2.4+
+    - { rvm: ruby-head, gemfile: "gemfiles/Gemfile.rails-4.2.x" }
+    - { rvm: "2.4.5",   gemfile: "gemfiles/Gemfile.rails-4.2.x" }
+    - { rvm: "2.5.3",   gemfile: "gemfiles/Gemfile.rails-4.2.x" }
+addons:
+  apt:
+    packages:
+      - haveged
+      - libgmp-dev
 script: bundle exec rake spec

data/CHANGELOG.md

@@ -3,14 +3,33 @@
 For the full commit log, [see here](https://github.com/influxdata/influxdb-rails/commits/master).
 
 
-## Unreleased changes
-
-- None.
-
-## v0.4.99, released 2017-12-12
-
-- No code changes, just inform people about 1.0 in the
-  gem post install message
+## v1.0.0.beta1, released 2018-11-22
+
+- Added app name to the measurement's tag sets (#44, @stefanhorning)
+- Added config parameters for additional series:
+  - `InfluxDB::Rails::Configuration#series_name_for_instrumentation`
+  - `InfluxDB::Rails::Configuration#series_name_for_exceptions`
+- Added method, status and format tags to metrics (#50, @ChrisBr)
+
+### Breaking changes
+
+- Support for Ruby <= 2.2.x has been removed
+- Support for Rails <= 4.1.x has been removed
+- Changed keys for exceptions (#43, @vassilevsky & @kkentzo)
+  - Exception message and backtrace are now InfluxDB values (changed from tags).
+  - The keys changed from `message` to `exception_message` and from
+    `backtrace` to `exception_backtrace`, since a single shard does not
+    allow for tags and values to share the same key
+  - To convert existing exception traces into the new format for
+    consistency, see [this gist][migrate].
+- Removed `time` key from InfluxDB::Rails::ExceptionPresenter#context`
+  - use `InfluxDB::Rails.current_timestamp` directly
+- Removed previously deprecated methods:
+  - `InfluxDB::Rails::Configuration#reraise_global_exceptions`
+  - `InfluxDB::Rails::Configuration#database_name`
+  - `InfluxDB::Rails::Configuration#application_id`
+
+[migrate]: https://gist.github.com/dmke/2d0f4ccf9f43faf82e732dc041e90ca2
 
 ## v0.4.3, released 2017-12-12
 

data/README.md

@@ -1,6 +1,6 @@
-> You are looking at the `README` for the 0.4.x releases of this gem
-> (`stable-04` branch). The current development version lives in the
-> `master` branch, [see here](https://github.com/influxdata/influxdb-rails#readme)
+> You are looking at the README for the master branch of this gem.
+> The latest released version lives in the stable-04 branch,
+> [see here](https://github.com/influxdata/influxdb-rails/tree/stable-04#readme)
 > for an online version.
 
 # influxdb-rails
@@ -9,7 +9,7 @@
 [![Build Status](https://travis-ci.org/influxdata/influxdb-rails.svg?branch=master)](https://travis-ci.org/influxdata/influxdb-rails)
 
 Automatically instrument your Ruby on Rails applications and write the
-metrics directly into [InfluxDB](https://www.influxdata.com/time-series-platform/influxdb/).
+metrics directly into [InfluxDB](http://influxdb.org/).
 
 This gem is designed for Rails 4.0+, Ruby 2.2+ and InfluxDB 0.9+.
 
@@ -27,7 +27,7 @@ To get things set up, just create an initializer:
 
 ```
 $ cd /to/you/rails/application
-$ touch config/initializers/influxdb-rails.rb
+$ touch config/initializers/influxdb_rails.rb
 ```
 
 In this file, you can configure the `InfluxDB::Rails` adapter. The default
@@ -51,9 +51,18 @@ InfluxDB::Rails.configure do |config|
   # config.series_name_for_controller_runtimes = "rails.controller"
   # config.series_name_for_view_runtimes       = "rails.view"
   # config.series_name_for_db_runtimes         = "rails.db"
+  # config.series_name_for_exceptions          = "rails.exceptions"
+  # config.series_name_for_instrumentation     = "instrumentation"
+
+  # Set the application name to something meaningful, by default we
+  # infer the app name from the Rails.application class name.
+  # config.application_name = Rails.application.class.parent_name
 end
 ```
 
+To see all default values, take a look into `InfluxDB::Rails::Configuration::DEFAULTS`,
+defined in `lib/influxdb/rails/configuration.rb`
+
 Out of the box, you'll automatically get reporting of your controller,
 view, and db runtimes for each request. You can also call through to the
 underlying `InfluxDB::Client` object to write arbitrary data like this:
@@ -81,10 +90,6 @@ To work around this limitation, set the `config.time_precision` to one
 of `"ms"` (milliseconds, 1·10<sup>-3</sup>s), `"us"` (microseconds,
 1·10<sup>-6</sup>s) or `"ns"` (nanoseconds, 1·10<sup>-9</sup>s).
 
-**Please note:** The default value for the time precision is going to
-change with version 1.0 of this gem, although the final value is not
-determined yet.
-
 [duplicate-points]: https://docs.influxdata.com/influxdb/v1.4/troubleshooting/frequently-asked-questions/#how-does-influxdb-handle-duplicate-points
 
 

data/Rakefile

@@ -1,14 +1,13 @@
-# encoding: utf-8
-
-require 'bundler'
-Bundler::GemHelper.install_tasks
+require "bundler/gem_tasks"
+require "rubocop/rake_task"
+RuboCop::RakeTask.new
 
 begin
   targeted_files = ARGV.drop(1)
-  file_pattern = targeted_files.empty? ? 'spec/**/*_spec.rb' : targeted_files
+  file_pattern = targeted_files.empty? ? "spec/**/*_spec.rb" : targeted_files
 
-  require 'rspec/core'
-  require 'rspec/core/rake_task'
+  require "rspec/core"
+  require "rspec/core/rake_task"
 
   RSpec::Core::RakeTask.new(:spec) do |t|
     t.pattern = FileList[file_pattern]
@@ -19,7 +18,7 @@ begin
     config.formatter = :documentation
   end
 rescue LoadError
-  require 'spec/rake/spectask'
+  require "spec/rake/spectask"
 
   puts file_pattern
 

data/gemfiles/Gemfile.rails-5.2.x

@@ -0,0 +1,7 @@
+source "https://rubygems.org"
+
+gem 'actionpack', '~> 5.2.0'
+gem 'activesupport', '~> 5.2.0'
+gem 'activemodel', '~> 5.2.0'
+
+gemspec :path => '../'

data/influxdb-rails.gemspec

@@ -1,44 +1,33 @@
-# -*- encoding: utf-8 -*-
-$:.push File.expand_path("../lib", __FILE__)
+lib = File.expand_path("lib", __dir__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "influxdb/rails/version"
 
-Gem::Specification.new do |s|
-  s.name        = "influxdb-rails"
-  s.summary     = %q{InfluxDB bindings for Ruby on Rails.}
-  s.description = %q{This gem automatically instruments your Ruby on Rails application using InfluxDB.}
-  s.version     = InfluxDB::Rails::VERSION
-  s.authors     = ['Christian Bruckmayer', 'Henne Vogelsang']
-  s.email       = ['christian@bruckmayer.net', 'hvogel@hennevogel.de']
-  s.licenses    = ['MIT']
-  s.homepage    = "http://influxdb.com"
-  s.metadata = {
-    "bug_tracker_uri"   => "https://github.com/influxdata/influxdb-rails/issues",
-    "changelog_uri"     => "https://github.com/influxdata/influxdb-rails/blob/master/CHANGELOG.md",
-    "documentation_uri" => "https://github.com/influxdata/influxdb-rails/blob/master/README.md",
-    "source_code_uri"   => "https://github.com/influxdata/influxdb-rails"
-  }
+Gem::Specification.new do |spec|
+  spec.name        = "influxdb-rails"
+  spec.version     = InfluxDB::Rails::VERSION
+  spec.authors     = ["Dominik Menke", "Todd Persen"]
+  spec.email       = ["dominik.menke@gmail.com", "todd@influxdb.com"]
+  spec.homepage    = "https://influxdata.com"
+  spec.summary     = "InfluxDB bindings for Ruby on Rails."
+  spec.description = "This gem automatically instruments your Ruby on Rails" \
+                     " 4.2/5.x applications using InfluxDB for storage."
+  spec.licenses    = ["MIT"]
 
-  s.files         = `git ls-files`.split($/)
-  s.test_files    = Dir.glob('test/**/*') + Dir.glob('spec/**/*') + Dir.glob('features/**/*')
-  s.executables   = Dir.glob('bin/**/*').map {|f| File.basename(f)}
-  s.require_paths = ["lib"]
+  spec.files         = `git ls-files`.split($/) # rubocop:disable Style/SpecialGlobalVars
+  spec.test_files    = spec.files.grep(%r{^(test|spec|features|smoke)/})
+  spec.require_paths = ["lib"]
 
-  s.add_runtime_dependency 'influxdb', '~> 0.5.0'
-  s.add_runtime_dependency 'railties', '> 3'
+  spec.required_ruby_version = ">= 2.3.0"
 
-  s.add_development_dependency 'bundler', ['>= 1.0.0']
-  s.add_development_dependency 'fakeweb', ['>= 0']
-  s.add_development_dependency 'rake', ['>= 0']
-  s.add_development_dependency 'rdoc', ['>= 0']
-  s.add_development_dependency 'rspec', ['>= 0']
-  s.add_development_dependency 'rspec-rails', ['>= 3.0.0']
-  s.add_development_dependency 'tzinfo', ['>= 0']
+  spec.add_runtime_dependency "influxdb", "~> 0.5.0"
+  spec.add_runtime_dependency "railties", "> 3"
 
-  s.post_install_message = %q{
-This is the last supported version of influxdb-rails in the 0.4 series. The
-next release will be 1.0 with quite a lot of breaking changes. For details:
-
-https://github.com/influxdata/influxdb-rails/wiki/1.0-Upgrade-Guide
-
-}
+  spec.add_development_dependency "bundler", ">= 1.0.0"
+  spec.add_development_dependency "fakeweb"
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "rdoc"
+  spec.add_development_dependency "rspec"
+  spec.add_development_dependency "rspec-rails", ">= 3.0.0"
+  spec.add_development_dependency "rubocop", "~> 0.60.0"
+  spec.add_development_dependency "tzinfo"
 end

data/lib/influxdb-rails.rb

@@ -2,8 +2,6 @@ require "net/http"
 require "net/https"
 require "rubygems"
 require "socket"
-require "thread"
-
 require "influxdb/rails/version"
 require "influxdb/rails/logger"
 require "influxdb/rails/exception_presenter"
@@ -14,6 +12,8 @@ require "influxdb/rails/rack"
 require "influxdb/rails/railtie" if defined?(Rails::Railtie)
 
 module InfluxDB
+  # InfluxDB::Rails contains the glue code needed to integrate with
+  # InfluxDB and Rails. This is a singleton class.
   module Rails
     class << self
       include InfluxDB::Rails::Logger
@@ -21,7 +21,7 @@ module InfluxDB
       attr_writer :configuration
       attr_writer :client
 
-      def configure(silent = false)
+      def configure(_silent = false)
         yield(configuration)
 
         # if we change configuration, reload the client
@@ -30,151 +30,126 @@ module InfluxDB
         InfluxDB::Logging.logger = configuration.logger unless configuration.logger.nil?
       end
 
+      # rubocop:disable Metrics/MethodLength
+      # rubocop:disable Metrics/AbcSize
+
       def client
-        @client ||= InfluxDB::Client.new configuration.influxdb_database,
-          :username => configuration.influxdb_username,
-          :password => configuration.influxdb_password,
-          :hosts => configuration.influxdb_hosts,
-          :port => configuration.influxdb_port,
-          :async => configuration.async,
-          :use_ssl => configuration.use_ssl,
-          :retry => configuration.retry,
-          :open_timeout => configuration.open_timeout,
-          :read_timeout => configuration.read_timeout,
-          :max_delay => configuration.max_delay,
-          :time_precision => configuration.time_precision
+        @client ||= InfluxDB::Client.new \
+          database:       configuration.influxdb_database,
+          username:       configuration.influxdb_username,
+          password:       configuration.influxdb_password,
+          hosts:          configuration.influxdb_hosts,
+          port:           configuration.influxdb_port,
+          async:          configuration.async,
+          use_ssl:        configuration.use_ssl,
+          retry:          configuration.retry,
+          open_timeout:   configuration.open_timeout,
+          read_timeout:   configuration.read_timeout,
+          max_delay:      configuration.max_delay,
+          time_precision: configuration.time_precision
       end
 
+      # rubocop:enable Metrics/MethodLength
+      # rubocop:enable Metrics/AbcSize
+
       def configuration
         @configuration ||= InfluxDB::Rails::Configuration.new
       end
 
-      def report_exception_unless_ignorable(e, env = {})
-        report_exception(e, env) unless ignorable_exception?(e)
+      def report_exception_unless_ignorable(ex, env = {})
+        report_exception(ex, env) unless ignorable_exception?(ex)
       end
-      alias_method :transmit_unless_ignorable, :report_exception_unless_ignorable
-
-      def report_exception(e, env = {})
-        begin
-          env = influxdb_request_data if env.empty? && defined? influxdb_request_data
-          exception_presenter = ExceptionPresenter.new(e, env)
-          log :info, "Exception: #{exception_presenter.to_json[0..512]}..."
-
-          ex_data = exception_presenter.context.merge(exception_presenter.dimensions)
-          timestamp = ex_data.delete(:time)
-
-          client.write_point "rails.exceptions", {
-            values: {
-              ts: timestamp,
-            },
-            tags: ex_data,
-            timestamp: timestamp,
-          }
-        rescue => e
-          log :info, "[InfluxDB::Rails] Something went terribly wrong. Exception failed to take off! #{e.class}: #{e.message}"
-        end
+      alias transmit_unless_ignorable report_exception_unless_ignorable
+
+      # rubocop:disable Metrics/MethodLength
+      # rubocop:disable Metrics/AbcSize
+
+      def report_exception(ex, env = {})
+        timestamp = InfluxDB::Rails.current_timestamp
+        env = influxdb_request_data if env.empty? && defined? influxdb_request_data
+        exception_presenter = ExceptionPresenter.new(ex, env)
+        log :info, "Exception: #{exception_presenter.to_json[0..512]}..."
+
+        client.write_point \
+          configuration.series_name_for_exceptions,
+          values:    exception_presenter.values.merge(ts: timestamp),
+          tags:      exception_presenter.context.merge(exception_presenter.dimensions),
+          timestamp: timestamp
+      rescue StandardError => ex
+        log :info, "[InfluxDB::Rails] Something went terribly wrong." \
+          " Exception failed to take off! #{ex.class}: #{ex.message}"
       end
-      alias_method :transmit, :report_exception
+      alias transmit report_exception
 
-      def handle_action_controller_metrics(name, start, finish, id, payload)
-        timestamp = convert_timestamp(finish.utc)
-        controller_runtime = ((finish - start)*1000).ceil
-        view_runtime = (payload[:view_runtime] || 0).ceil
-        db_runtime = (payload[:db_runtime] || 0).ceil
-        method = "#{payload[:controller]}##{payload[:action]}"
-        hostname = Socket.gethostname
+      def handle_action_controller_metrics(_name, start, finish, _id, payload)
+        tags = {
+          method:      "#{payload[:controller]}##{payload[:action]}",
+          status:      payload[:status],
+          format:      payload[:format],
+          http_method: payload[:method],
+          path:        payload[:path],
+          server:      Socket.gethostname,
+          app_name:    configuration.application_name,
+        }.reject { |_, value| value.nil? }
+
+        ts = convert_timestamp(finish.utc)
 
         begin
-          client.write_point configuration.series_name_for_controller_runtimes, {
-            values: {
-              value: controller_runtime,
-            },
-            tags: {
-              method: method,
-              server: hostname,
-            },
-            timestamp: timestamp,
-          }
-
-          client.write_point configuration.series_name_for_view_runtimes, {
-            values: {
-              value: view_runtime,
-            },
-            tags: {
-              method: method,
-              server: hostname,
-            },
-            timestamp: timestamp,
-          }
-
-          client.write_point configuration.series_name_for_db_runtimes, {
-            values: {
-              value: db_runtime,
-            },
-            tags: {
-              method: method,
-              server: hostname,
-            },
-            timestamp: timestamp,
-          }
-        rescue => e
+          {
+            configuration.series_name_for_controller_runtimes => ((finish - start) * 1000).ceil,
+            configuration.series_name_for_view_runtimes       => (payload[:view_runtime] || 0).ceil,
+            configuration.series_name_for_db_runtimes         => (payload[:db_runtime] || 0).ceil,
+          }.each do |series_name, value|
+            client.write_point series_name, values: { value: value }, tags: tags, timestamp: ts
+          end
+        rescue StandardError => e
           log :error, "[InfluxDB::Rails] Unable to write points: #{e.message}"
         end
       end
 
-      def convert_timestamp(ts)
-        case configuration.time_precision
-        when 'ns', nil
-          (ts.to_r * 1e9).to_i
-        when 'u'
-          (ts.to_r * 1e6).to_i
-        when 'ms'
-          (ts.to_r * 1e3).to_i
-        when 's'
-          ts.to_i
-        when 'm'
-          ts.to_i / 60
-        when 'h'
-          ts.to_i / 60 / 60
-        else
+      # rubocop:enable Metrics/MethodLength
+      # rubocop:enable Metrics/AbcSize
+
+      TIMESTAMP_CONVERSIONS = {
+        "ns" => 1e9.to_r,
+        nil  => 1e9.to_r,
+        "u"  => 1e6.to_r,
+        "ms" => 1e3.to_r,
+        "s"  => 1.to_r,
+        "m"  => 1.to_r / 60,
+        "h"  => 1.to_r / 60 / 60,
+      }.freeze
+      private_constant :TIMESTAMP_CONVERSIONS
+
+      def convert_timestamp(time)
+        conv = TIMESTAMP_CONVERSIONS.fetch(configuration.time_precision) do
           raise "Invalid time precision: #{configuration.time_precision}"
         end
+
+        (time.to_r * conv).to_i
       end
 
       def current_timestamp
         convert_timestamp(Time.now.utc)
       end
 
-      def ignorable_exception?(e)
-        configuration.ignore_current_environment? ||
-        !!configuration.ignored_exception_messages.find{ |msg| /.*#{msg}.*/ =~ e.message  } ||
-        configuration.ignored_exceptions.include?(e.class.to_s)
+      def ignorable_exception?(ex)
+        configuration.ignore_current_environment? || configuration.ignore_exception?(ex)
       end
 
-      def rescue(&block)
-        block.call
-      rescue StandardError => e
-        if configuration.ignore_current_environment?
-          raise(e)
-        else
-          transmit_unless_ignorable(e)
-        end
-      end
+      def rescue
+        yield
+      rescue StandardError => ex
+        raise ex if configuration.ignore_current_environment?
 
-      def rescue_and_reraise(&block)
-        block.call
-      rescue StandardError => e
-        transmit_unless_ignorable(e)
-        raise(e)
+        transmit_unless_ignorable(ex)
       end
 
-      def safely_prepend(module_name, opts = {})
-        return if opts[:to].nil? || opts[:from].nil?
-        if opts[:to].respond_to?(:prepend, true)
-          opts[:to].send(:prepend, opts[:from].const_get(module_name))
-        else
-          opts[:to].send(:include, opts[:from].const_get("Old" + module_name))
-        end
+      def rescue_and_reraise
+        yield
+      rescue StandardError => ex
+        transmit_unless_ignorable(ex)
+        raise ex
       end
     end
   end