inexact_equality_warning 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ae03455fe61747ac2eb8451499e8f16f416e11dd
-  data.tar.gz: 63bceb16e59cbd174328bbed7e065f7feff02e01
+  metadata.gz: ea8cdeed34206e0912c4358b86f589cb8e7ceb6a
+  data.tar.gz: bc341733ed61489d9306ae8edbd1578be2e1635c
 SHA512:
-  metadata.gz: 4a7921d82180fb2d5487e68ea37233dfa31ca5748b4403e18ae8795dfd0d3d9efdf600ffaa3688c4bf473416c018ff52e800faebf7250584b5863871fe354d24
-  data.tar.gz: 48e48d662db050e4b3ae8fef947d1aa4382c3d0a5a8979887d552b67df5cc851808e9e25d2e9a31c1ba38b931043a2ea3c65a50716375b5cc68926ece01e2796
+  metadata.gz: 486390cded551301cfd5ef1ef5aec45169a1dbc3849da13a28c0a0a11d5d4383077847a3e76439f30de15b0d29fae34273106f4c016949c96232a0ee5c901620
+  data.tar.gz: cb39f55449f5b519afa88f6abd43002a8d94a64593055abf7972a913ceae011b7210b2f91100418b1d759f2e4f61ac6f0e6045fb4b6fdf1ea8f080d18ae78bd6

data/README.md

@@ -4,3 +4,16 @@ x == 0.0
 # WARNING: Testing for equality between inexact floats is ill-advised, when comparing -2.7755575615628914e-17 and 0 (/path/to/file.rb:123)
 # => false
 ```
+
+
+### Installation and usage
+
+Gemfile:
+
+```ruby
+gem "inexact_equality_warning"
+```
+
+```ruby
+require "inexact_equality_warning"
+```

data/inexact_equality_warning.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name          = "inexact_equality_warning"
-  gem.version       = "0.0.1"
+  gem.version       = "0.0.2"
   gem.authors       = ["Adam Prescott"]
   gem.email         = ["adam@aprescott.com"]
   gem.description   = "Warn when comparing floats for equality."

data/lib/inexact_equality_warning.rb

@@ -1,7 +1,7 @@
 # it would be good to use #inexact? here -- https://bugs.ruby-lang.org/issues/5321
 module EqualityWarning
   def ==(other)
-    warn "WARNING: Testing for equality between inexact floats is ill-advised, when comparing #{self} and #{other} (#{caller.first})" if self.is_a?(Float) || other.is_a?(Float)
+    warn "WARNING: Testing for equality between inexact floats is ill-advised, when comparing #{self} and #{other} (#{caller.first})" if (self.is_a?(Numeric) && other.is_a?(Numeric)) && self.is_a?(Float) || other.is_a?(Float)
     super
   end
 end

data/spec/inexact_equality_warning_spec.rb

@@ -19,23 +19,41 @@ RSpec.describe EqualityWarning do
   end
 
   [
-    1.0, 1.0,
-    1.0, 1.0,
     1.0, 1,
+    1.0, 2**1000,
+    1.0, Rational(1, 2),
+    1.0, Complex(1, 2),
     1, 1.0,
-    1.0, Complex(1, 0),
-    1.0, Complex(0, 2),
-    1.0, 2**1000, # Bignum
+    Rational(1, 2), 1.0,
+    2**1000, 1.0,
+    Complex(1, 2), 1.0,
   ].each_slice(2) do |x, y|
     specify { expect_warning(x, y) }
   end
 
   [
+    1, 2**1000,
+    1, Rational(1, 2),
+    1, Complex(1, 2),
+    1, "anything",
+    2**1000, 1,
+    2**1000, Rational(1, 2),
+    2**1000, Complex(1, 2),
+    2**1000, "anything",
+    Rational(1, 2), 1,
+    Rational(1, 2), 2**1000,
+    Rational(1, 2), Complex(1, 2),
+    Rational(1, 2), "anything",
+    Complex(1, 2), 1,
+    Complex(1, 2), 2**1000,
+    Complex(1, 2), Rational(1, 2),
+    Complex(1, 2), "anything",
+    "anything", 1,
+    "anything", 2**1000,
+    "anything", Rational(1, 2),
+    "anything", Complex(1, 2),
+    1.0, "anything",
     "anything", 1.0,
-    1, 1,
-    Complex(1, 0), Complex(0, 2),
-    "anything", "anything",
-    2**1000, 2**1000, # Bignum
   ].each_slice(2) do |x, y|
     specify { expect_no_warning(x, y) }
   end
@@ -50,3 +68,21 @@ RSpec.describe EqualityWarning do
     expect(numeric_classes.reject { |klass| numeric_classes.any? { |other_class| other_class < klass } }).to eq(prepended_classes)
   end
 end
+
+=begin
+# test case permutations generation:
+
+test_values = {
+  Fixnum => "1",
+  Float => "1.0",
+  Bignum => "2**1000",
+  Rational => "Rational(1, 2)",
+  Complex => "Complex(1, 2)",
+  String => %~"anything"~
+}
+[Float, Fixnum, Bignum, Rational, Complex, String].permutation(2).to_a.map do |x, y|
+  [test_values[x], test_values[y]]
+end.each do |x, y|
+  puts "#{x}, #{y},"
+end
+=end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inexact_equality_warning
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Adam Prescott