indulgence 0.0.7 → 0.1.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZGQ4NWQwM2JlNzE1OTgwZmU5MzczOTQwY2JhODMyNGU1NDMwZjBlYg==
+    YTA1YTM4YmFhMGUzMTIxNzYwOWQ4YzYzZTM3NmRhNjc2YjY3NzdiZQ==
   data.tar.gz: !binary |-
-    OTMyYzI5MWYyNzkwZTFjOGI5NWMwMWQ1NTk5NzI5N2NmZGQ2Yzc4Zg==
+    OGNkZDE1ZDk0ZGE4ZjcyZTQzYjlhZGQxNTczOTVhMjY2ZTRlZTYyNg==
 SHA512:
   metadata.gz: !binary |-
-    ZjgxM2ZmOWNjMTkzNmEwMWZlNjY1MTUwYWViODcwMThjNjdjNzc0ODllMGQ5
-    YTU5YWY4NWJiYTQ1MWE3ZDI3ODg1YjA4NGI1ZTEyMzY0OGU3YjVjNDI4ZjU3
-    NzJkNjgwYTJmODZmMjUyMWI1Yjc4YjhiYjkxYTgyMmE1ZWM0MWM=
+    ZjNmNGMyZWEyNWIyNmRlYTJjMTcxODVkMGQ2ZWM0ODVmZGJhZTcyZWZmYzNi
+    ZTFlMTg2ODVmNzY4NDgzMzM1Y2NmN2Q0Mzc3NzM0NDBmMDEzNDYwZTc0ZGVk
+    YzY2ZWI2NzQ5ZDk3MjM3OWViNjNiYmQ0ZGNiNGM5NDA2OWNjMWU=
   data.tar.gz: !binary |-
-    NmFlMWUxMDgxYzI5MDBiMjY3ZGQ1NjVjZWJkZDI4MzU1ZDRmMzNmYmMwYzE0
-    ODg1NjUxNWZlYmQ5ZDRkNTYwOTMyY2FiZTVjOWIxOGQ2Njk0NDQ1MjJhOTY0
-    NWQxNDczNjBhMjA3YWJkMWQzMmU5ODc5MzlkYWQzY2VlODc2N2U=
+    NTg5ODNkMmJiYTllM2M5NjU5ODg3ODcxYzdmY2M1NTc2NTBiZGQ4YmI2NjY3
+    ZjM1YWY1OWZlMDY5NTdiMjE1NjBiMGFiYzcwYjA1MDBhNjZjNTI2MzMwYzdi
+    NGFiYzhkMWRiZDE0ZTYwMjZiMjhlYjE5ZWU0YWFlNDRmMGQ5NDA=

data/README.rdoc

@@ -373,6 +373,13 @@ With this used to define indulgence in Thing, we can do this:
     Thing.permitted(cicero, :create) == [thing]
     Thing.permitted(cicero, :read)   == Thing.all
 
+== Null entities
+
+Indulgence falls back to the *none* ability if _nil_ is passed as the entity.
+
+    thing.indule?(nil, :read) == false
+    Thing.indulgence(nil, :read) --> raises ActiveRecord::RecordNotFound
+
 == Examples
 
 For some examples, have a look at the tests. In particular, look at the object

data/lib/indulgence/permission.rb

@@ -13,7 +13,7 @@ module Indulgence
       {}
     end
     
-    def default
+    def null_entity
       {
         create: none,
         read: none,
@@ -21,6 +21,10 @@ module Indulgence
         delete: none
       }
     end
+
+    def default
+      null_entity
+    end
     
     def filter_many(things)
       ability.filter_many things, entity
@@ -80,6 +84,7 @@ module Indulgence
     end
     
     def abilities_for_role
+      return null_entity unless entity
       abilities[role_name] || default
     end
 

data/lib/indulgence/version.rb

@@ -1,10 +1,14 @@
 module Indulgence
-  VERSION = "0.0.7"
+  VERSION = "0.1.0"
 end
 
 # History
 # =======
 #
+# 0.1.0   Handles a nil entity being passed to either indulge? or indulgence.
+#         Code now tried and tested in a number of applications, so
+#         bumping up to 0.1.
+#
 # 0.0.7   Adds Thing.indulge? class method.
 #
 # 0.0.6   Specifies the default behaviour as assigning the none ability to

data/test/units/indulgence/permission_test.rb

@@ -25,5 +25,10 @@ module Indulgence
       assert_equal Ability, Permission.send(:ability_cache)[:test_ability].class
     end
 
+    def test_creation_with_null_entity
+      permission = Permission.new(nil, :read)
+      assert_equal Permission.none, permission.ability
+    end
+
   end
 end

data/test/units/role_permission_test.rb

@@ -20,6 +20,17 @@ class RolePermissionTest < Test::Unit::TestCase
       Role.indulgence(@user, :delete)
     end
   end
+
+  def test_null_entity_indulge
+    assert_equal(false, @role.indulge?(nil, :update))
+    assert_not_equal(@role.indulge?(@user, :update), @role.indulge?(nil, :update))
+  end
+
+  def test_null_entity_indulgence
+    assert_raise ActiveRecord::RecordNotFound do
+      assert_equal(0, Role.indulgence(nil, :update).count)
+    end
+  end
   
   def teardown
     User.delete_all

data/test/units/thing_permission_test.rb

@@ -29,6 +29,13 @@ class ThingPermissionTest < Test::Unit::TestCase
     assert_equal Permission.none, ThingPermission.new(@user, :update).ability
     assert_equal Permission.none, ThingPermission.new(@user, :delete).ability 
   end
+
+  def test_null_entity
+    assert_equal Permission.none, ThingPermission.new(nil, :create).ability
+    assert_equal Permission.none, ThingPermission.new(nil, :read).ability
+    assert_equal Permission.none, ThingPermission.new(nil, :update).ability
+    assert_equal Permission.none, ThingPermission.new(nil, :delete).ability
+  end
   
   def test_role_name
     assert_equal @super_user.role.name.to_sym, ThingPermission.new(@super_user, :read).role_name

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: indulgence
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.1.0
 platform: ruby
 authors:
 - Rob Nichols
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-04 00:00:00.000000000 Z
+date: 2014-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord