indulgence 0.0.6 → 0.0.7

checksums.yaml

@@ -0,0 +1,15 @@
+---
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    ZGQ4NWQwM2JlNzE1OTgwZmU5MzczOTQwY2JhODMyNGU1NDMwZjBlYg==
+  data.tar.gz: !binary |-
+    OTMyYzI5MWYyNzkwZTFjOGI5NWMwMWQ1NTk5NzI5N2NmZGQ2Yzc4Zg==
+SHA512:
+  metadata.gz: !binary |-
+    ZjgxM2ZmOWNjMTkzNmEwMWZlNjY1MTUwYWViODcwMThjNjdjNzc0ODllMGQ5
+    YTU5YWY4NWJiYTQ1MWE3ZDI3ODg1YjA4NGI1ZTEyMzY0OGU3YjVjNDI4ZjU3
+    NzJkNjgwYTJmODZmMjUyMWI1Yjc4YjhiYjkxYTgyMmE1ZWM0MWM=
+  data.tar.gz: !binary |-
+    NmFlMWUxMDgxYzI5MDBiMjY3ZGQ1NjVjZWJkZDI4MzU1ZDRmMzNmYmMwYzE0
+    ODg1NjUxNWZlYmQ5ZDRkNTYwOTMyY2FiZTVjOWIxOGQ2Njk0NDQ1MjJhOTY0
+    NWQxNDczNjBhMjA3YWJkMWQzMmU5ODc5MzlkYWQzY2VlODc2N2U=

data/README.rdoc

@@ -88,6 +88,13 @@ Simple true/false permission can be determined using the :indulge? method:
     thing.indulge?(user, :update) == false
     thing.indulge?(user, :delete) == false
 
+=== indulge? as a class method
+
+There is also a class :indulge? method. Calling this is the equivalent to
+calling :indulge? on a new object.
+
+    Thing.indulge?(user, :create) == Thing.new.indulge?(user, :create)
+
 == Filter many: indulgence
 
 The :indulgence method is used as a where filter:
@@ -251,6 +258,22 @@ With that done:
     Thing.indulgence(cicero, :update) == [thing]
     Thing.indulgence(cicero, :delete)  --> raises ActiveRecord::RecordNotFound
 
+Notice how Thing.indulge? behaves:
+
+    Thing.indulge?(cicero, :create) == false
+
+Thing.indulge? acts on a new instance of Thing where author_id will not be set.
+If this is not the behaviour expected, the permission may need to be checked
+at a stage after initialization, but before persisting:
+
+    thing = Thing.new(author: user)
+    if thing.indulge?(user, :create)
+      thing.save 
+    end
+
+In this example, the thing will be saved if the user is cicero, but not if
+the user has the role 'pleb'.
+
 === Defining your own actions
 
 The default actions on which indulgence is based are the CRUD operations: 
@@ -345,6 +368,8 @@ With this used to define indulgence in Thing, we can do this:
     thing.permit?(cicero, :update) == true
     thing.permit?(cicero, :delete) == false
 
+    Thing.permit?(cicero, :update) == false
+
     Thing.permitted(cicero, :create) == [thing]
     Thing.permitted(cicero, :read)   == Thing.all
 

data/lib/active_record/acts/indulgent.rb

@@ -13,6 +13,7 @@ module ActiveRecord
           
           alias_method args[:compare_single_method], :indulge? if args[:compare_single_method]
           singleton_class.send(:alias_method, args[:filter_many_method], :indulgence) if args[:filter_many_method]
+          singleton_class.send(:alias_method, args[:compare_single_method], :indulge?) if args[:compare_single_method]
           self.indulgent_permission_class = args[:using]
         end
         

data/lib/indulgence/indulgent.rb

@@ -8,6 +8,10 @@ module Indulgence
       rescue Indulgence::NotFoundError, Indulgence::AbilityNotFound
         raise_not_found
       end
+
+      def indulge?(entity, ability)
+        new.indulge?(entity, ability)
+      end
       
       private
       def raise_not_found

data/lib/indulgence/version.rb

@@ -1,10 +1,12 @@
 module Indulgence
-  VERSION = "0.0.6"
+  VERSION = "0.0.7"
 end
 
 # History
 # =======
 #
+# 0.0.7   Adds Thing.indulge? class method.
+#
 # 0.0.6   Specifies the default behaviour as assigning the none ability to
 #         all CRUD actions.
 # 

data/test/units/thing_test.rb

@@ -47,8 +47,8 @@ class ThingTest < Test::Unit::TestCase
     assert_equal(true, @thing.indulge?(@owner, :delete)) 
     assert_equal(false, @other_thing.indulge?(@owner, :delete))
   end
-  
-  def test_indule_via_entity_id
+
+  def test_indulge_via_entity_id
     make_second_thing
     @owner.update_attribute(:role, @thief)
     assert_equal(true, @thing.indulge?(@owner, :read))
@@ -56,13 +56,40 @@ class ThingTest < Test::Unit::TestCase
     assert_equal(false, @thing.indulge?(@owner, :delete))
   end
   
-  def test_indule_via_entity_association
+  def test_indulge_via_entity_association
     make_second_thing
     @owner.update_attribute(:role, @friend)
     assert_equal(true, @thing.indulge?(@owner, :read))
     assert_equal(true, @thing.indulge?(@owner, :update)) 
     assert_equal(false, @thing.indulge?(@owner, :delete))
   end
+
+  def test_indulge_on_new_object
+    @thing = Thing.new(:name => 'New', :owner => @owner)
+    @owner.update_attribute(:role, @demigod)
+    assert_equal(true, @thing.indulge?(@owner, :create))
+  end
+
+  def test_indulge_on_new_object_where_ability_defined_by_relationshop_name
+    @thing = Thing.new(:name => 'New', :owner => @owner)
+    @owner.update_attribute(:role, @friend)
+    assert_equal(true, @thing.indulge?(@owner, :update))
+  end
+
+  def test_indulge_as_class_method
+    assert_equal(false, Thing.indulge?(@owner, :read))
+    @owner.update_attribute(:role, @god)
+    assert_equal(true, Thing.indulge?(@owner, :read))
+  end
+
+  def test_indulge_as_class_method_with_custom_method
+    @owner.update_attribute(:role, @thief)
+    assert_equal(false, Thing.indulge?(@owner, :update))
+    @owner.update_attribute(:role, @friend)
+    assert_equal(false, Thing.indulge?(@owner, :update))
+    @owner.update_attribute(:role, @demigod)
+    assert_equal(false, Thing.indulge?(@owner, :update))
+  end
     
   def test_indulge_other_thing
     other_thing = OtherThing.create(:name => 'Other Stuff', :owner => @owner)
@@ -116,6 +143,12 @@ class ThingTest < Test::Unit::TestCase
     assert_equal(false, @thing.permit?(@owner, :delete))
     assert_equal(false, @other_thing.permit?(@owner, :delete))
   end
+
+  def test_aliased_class_compare_single_method
+    assert_equal(false, Thing.permit?(@owner, :read))
+    @owner.update_attribute(:role, @god)
+    assert_equal(true, Thing.permit?(@owner, :read))
+  end
   
   def test_aliased_filter_many_method
     make_second_thing

metadata

@@ -1,20 +1,18 @@
 --- !ruby/object:Gem::Specification
 name: indulgence
 version: !ruby/object:Gem::Version
-  version: 0.0.6
-  prerelease: 
+  version: 0.0.7
 platform: ruby
 authors:
 - Rob Nichols
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-19 00:00:00.000000000 Z
+date: 2014-02-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -22,7 +20,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -30,7 +27,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -38,7 +34,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -46,7 +41,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: standalone_migrations
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -54,7 +48,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -98,28 +91,28 @@ files:
 - test/db/schema.rb
 - test/test_helper.rb
 homepage: https://github.com/reggieb/indulgence
-licenses: []
+licenses:
+- MIT-LICENSE
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.1.10
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Yet another permissions gem
 test_files:
 - test/units/role_test.rb