inch 0.4.0.rc2 → 0.4.0.rc3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b68244a51e9f493211a0f8b1fda1773c74120d42
-  data.tar.gz: ffe7a9384808c79be81875ac1a6fdce2c832f8af
+  metadata.gz: be1d3023cb43e15c6a141ed20de1543d20a8be64
+  data.tar.gz: 5c7c5638b7998464f36dcbae6016c5742d17e8d7
 SHA512:
-  metadata.gz: fc0121c7348a0ad6daf269d1daf2ee570f95be5c5fec62c5647543d15e9aadd1eb9c8d5129c69caa1c81acda48d4878fde4a05a2ede1e538549bd2d36983da85
-  data.tar.gz: c1fa923fa045fd962426f938c2d6ce3fcf70a9638387dbfc2e292c45d11ad252273e500867f638c1dd0974f78f1f714049064aa8c5614b045064deed8bd5f98b
+  metadata.gz: 02501af74e5e84a9fbf0b25c69e9c319b46c2d35e8a9507ed97488917748bc3c98c9cecda89a1f704e0fd37633189d55ddfdb63e5877e1c34c8af4b65bbfc140
+  data.tar.gz: f9c15371028b15ae3cb630d55cf0eff00e008296ca93f6cce4af98361430466760e5024712abd975b0341172c37d24f969b7a78b123a5c3975c4664dee96f4fe

data/lib/inch/api/compare/code_objects.rb

@@ -29,11 +29,11 @@ module Inch
         end
 
         def degraded?
-          changed? && @before.score.to_i > @after.score.to_i
+          changed? && @before.score > @after.score
         end
 
         def improved?
-          changed? && @before.score.to_i < @after.score.to_i
+          changed? && @before.score < @after.score
         end
 
         def present?
@@ -45,11 +45,11 @@ module Inch
         end
 
         def unchanged?
-          present? && @before.score.to_i == @after.score.to_i
+          present? && @before.score == @after.score
         end
 
         def scores
-          [@before.score.to_i, @after.score.to_i]
+          [@before.score, @after.score]
         end
       end
     end

data/lib/inch/cli/command/diff.rb

@@ -6,6 +6,8 @@ module Inch
   module CLI
     module Command
       class Diff < Base
+        include Utils::ShellHelper
+
         register_command_as :diff
 
         def description
@@ -28,14 +30,6 @@ module Inch
 
         private
 
-        def git(dir, command)
-          old_pwd = Dir.pwd
-          Dir.chdir dir
-          out = `git #{command}`
-          Dir.chdir old_pwd
-          out
-        end
-
         # @return [Array<String>] the revisions passed in the command_line
         def revisions
           @revisions ||= @options.revisions.map do |rev|

data/lib/inch/cli/command/output/inspect.rb

@@ -40,7 +40,7 @@ module Inch
             min = o.evaluation.min_score
             max = o.evaluation.max_score
             echo "Score (min: #{min}, max: #{max})".ljust(40) +
-                  "#{o.score.to_i}".rjust(5) + "#{o.priority.to_i}".rjust(4)
+                  "#{o.score}".rjust(5) + "#{o.priority.to_i}".rjust(4)
             echo
           end
 
@@ -97,9 +97,9 @@ module Inch
 
           def colored_role_score(role)
             if role.potential_score
-              "(#{role.potential_score.to_i})".rjust(5).yellow.dark
+              "(#{role.potential_score})".rjust(5).yellow.dark
             else
-              value = role.score.to_i
+              value = role.score
               colored_score value, value.abs.to_s.rjust(4)
             end
           end

data/lib/inch/cli/command/output/list.rb

@@ -74,7 +74,7 @@ module Inch
           end
 
           def result_numbers(object, color)
-            score = object.score.to_i.to_s
+            score = object.score.to_s
             score = score.rjust(3).color(color)
             priority = object.priority
             "#{score}  #{priority}  #{object.fullname}"

data/lib/inch/cli/command/output/stats.rb

@@ -109,8 +109,8 @@ module Inch
           def __scores
             hash = {}
             @objects.sort_by(&:score).each do |o|
-              hash[o.score.to_i] ||= 0
-              hash[o.score.to_i] += 1
+              hash[o.score] ||= 0
+              hash[o.score] += 1
             end
             hash
           end

data/lib/inch/code_object/provider/yard/parser.rb

@@ -20,11 +20,10 @@ module Inch
           # @param config [Inch::Config::Codebase] configuration for codebase
           # @return [void]
           def parse(dir, config)
-            old_dir = Dir.pwd
-            Dir.chdir dir
-            parse_yard_objects(config.included_files, config.excluded_files)
-            inject_base_dir(dir)
-            Dir.chdir old_dir
+            Dir.chdir(dir) do
+              parse_yard_objects(config.included_files, config.excluded_files)
+              inject_base_dir(dir)
+            end
           end
 
           # @return [Array<YARD::Object::Base>]

data/lib/inch/config/codebase.rb

@@ -28,10 +28,9 @@ module Inch
 
       def update_via_yaml(dir)
         if yaml = self.class.yaml(dir)
-          old_dir = Dir.pwd
-          Dir.chdir dir
-          update_files yaml["files"]
-          Dir.chdir old_dir
+          Dir.chdir(dir) do
+            update_files yaml["files"]
+          end
         end
       end
 

data/lib/inch/evaluation/proxy/base.rb

@@ -56,7 +56,7 @@ module Inch
           @__min_score = __min_score
         end
 
-        # @return [Float] the final score for +object+
+        # @return [Fixnum] the final score for +object+
         def score
           @__score ||= __score
         end
@@ -144,7 +144,7 @@ module Inch
 
         # @return [Float]
         def __score
-          value = @roles.inject(0) { |sum,r| sum + r.score.to_f }
+          value = @roles.inject(0) { |sum,r| sum + r.score.to_f }.to_i
           if value < min_score
             min_score
           elsif value > max_score

data/lib/inch/evaluation/role/missing.rb

@@ -8,11 +8,11 @@ module Inch
           nil
         end
 
-        # @return [Float]
+        # @return [Fixnum]
         #  a score that can be achieved by adding the missing thing mentioned
         #  by the role
         def potential_score
-          @value.to_f
+          @value.to_i
         end
       end
     end

data/lib/inch/utils/shell_helper.rb

@@ -2,11 +2,9 @@ module Inch
   module Utils
     module ShellHelper
       def git(dir, command)
-        old_pwd = Dir.pwd
-        Dir.chdir dir
-        out = sh("git #{command}")
-        Dir.chdir old_pwd
-        out
+        Dir.chdir(dir) do
+          out = sh("git #{command}")
+        end
       end
 
       def sh(command)

data/lib/inch/version.rb

@@ -1,3 +1,3 @@
 module Inch
-  VERSION = "0.4.0.rc2"
+  VERSION = "0.4.0.rc3"
 end

data/test/unit/code_object/proxy/method_object_test.rb

@@ -278,7 +278,7 @@ describe ::Inch::CodeObject::Proxy::MethodObject do
     list << @objects.find("Overloading#mix")
     list << @objects.find("Overloading#hooks")
     list.each do |m|
-      assert_equal 100, m.score.to_i, "#{m.fullname} did not get 100"
+      assert_equal 100, m.score, "#{m.fullname} did not get 100"
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: inch
 version: !ruby/object:Gem::Version
-  version: 0.4.0.rc2
+  version: 0.4.0.rc3
 platform: ruby
 authors:
 - René Föhring
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-30 00:00:00.000000000 Z
+date: 2014-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler