in_time_scope 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 12b5f84b69262b47ea6936b0658151404805b938061fd0c91e080a1a4f435125
-  data.tar.gz: fe4cde1d907cb57e1562f551336db91ae43b30a22d2c3db6dd11e3a3eb3202e3
+  metadata.gz: c5ab9dff9b5a5abce4d0418d2a8ec3895126a910a0926f1a449fc55bad3cebd4
+  data.tar.gz: '082a9f889d860c0dc7f587fafb77baaa932ccc864e8dfe06b10b92ab9644308a'
 SHA512:
-  metadata.gz: 2f8766dad406ddfa8317afa597bf67fdbc2e2f1a4c7f437be46540f315f3359daf4cf8dfac317d4e36647597fe3aace454ad1549e50def596585503026305366
-  data.tar.gz: 0d53d1b56ebcd19b97e3a4af9f498a676ed31bd0d61b37d22ebf1d572ad7b591a86a670ea5e2adf40fd0122495362e7026dbd696b5631857edef447879a9350c
+  metadata.gz: 7df8620094c225af106a3ed909dfa3af5abd328630e1a571cbe0943ecf5a8f965bc1c56286493181305a44fc87a148b055247c12291ee9110b49ca700b45b1bc
+  data.tar.gz: 7dc373ec631d291cbdb9c73acaec4bc21d5271495a1131681a3a8aa6929480a28a886010eb3bcc209951825b5c92590a13730aae7ec119a09d96fb66d17f8218

data/README.md

@@ -277,16 +277,16 @@ The `earliest_in_time(:foreign_key)` scope uses a `NOT EXISTS` subquery to find
 
 ### Error Handling
 
-If you specify a scope name but the expected columns don't exist, an error is raised at class load time:
+If you specify a scope name but the expected columns don't exist, a `ColumnNotFoundError` is raised at class load time:
 
 ```ruby
 class Event < ActiveRecord::Base
   include InTimeScope
 
-  # This will raise NoMethodError if hoge_start_at or hoge_end_at columns don't exist
+  # This will raise ColumnNotFoundError if hoge_start_at or hoge_end_at columns don't exist
   in_time_scope :hoge
 end
-# => NoMethodError: undefined method `null' for nil:NilClass
+# => InTimeScope::ColumnNotFoundError: Column 'hoge_start_at' does not exist on table 'events'
 ```
 
 This helps catch configuration errors early during development.

data/lib/in_time_scope/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module InTimeScope
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

data/lib/in_time_scope.rb

@@ -5,6 +5,8 @@ require_relative "in_time_scope/version"
 
 module InTimeScope
   class Error < StandardError; end
+  class ColumnNotFoundError < Error; end
+  class ConfigurationError < Error; end
 
   def self.included(model)
     model.extend ClassMethods
@@ -18,8 +20,8 @@ module InTimeScope
       start_at_column = start_at.fetch(:column, :"#{time_column_prefix}start_at")
       end_at_column = end_at.fetch(:column, :"#{time_column_prefix}end_at")
 
-      start_at_null = start_at.fetch(:null, table_column_hash[start_at_column.to_s].null) unless start_at_column.nil?
-      end_at_null = end_at.fetch(:null, table_column_hash[end_at_column.to_s].null) unless end_at_column.nil?
+      start_at_null = fetch_null_option(start_at, start_at_column, table_column_hash)
+      end_at_null = fetch_null_option(end_at, end_at_column, table_column_hash)
 
       scope_method_name = method_name(scope_name, prefix)
 
@@ -28,6 +30,16 @@ module InTimeScope
 
     private
 
+    def fetch_null_option(config, column, table_column_hash)
+      return nil if column.nil?
+      return config[:null] if config.key?(:null)
+
+      column_info = table_column_hash[column.to_s]
+      raise ColumnNotFoundError, "Column '#{column}' does not exist on table '#{table_name}'" if column_info.nil?
+
+      column_info.null
+    end
+
     def method_name(scope_name, prefix)
       return :in_time if scope_name == :in_time
 
@@ -38,7 +50,7 @@ module InTimeScope
       # Define class-level scope
       if start_at_column.nil? && end_at_column.nil?
         # Both disabled - return all
-        scope scope_method_name, ->(_time = Time.current) { raise ArgumentError, "At least one of start_at or end_at must be specified." }
+        raise ConfigurationError, "At least one of start_at or end_at must be specified"
       elsif end_at_column.nil?
         # Start-only pattern (history tracking)
         define_start_only_scope(scope_method_name, start_at_column, start_at_null)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: in_time_scope
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - kyohah