in-parallel 0.1.16 → 0.1.17

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NGJlY2ZkMDkyMjM3MGE4NGIxNjljNDU1YTE1NGRkYWY2OWE2NjZkZA==
+    NWY0MDhlZmFhMGU4ZjNjY2U0YTAyYTJmOTJkYWExMWRhNTFiNTE2Mw==
   data.tar.gz: !binary |-
-    ZmQ4NmExZGJmYmZiNDM5NjM1MWQ1OGM5MTMwMGMwMjYzMDdjY2ViOQ==
+    NzQ4MzE5Yjk0NDc5NjY3YjUxOWM4ODY0NGE2NTk5ZWJiNmY0NWQwMA==
 SHA512:
   metadata.gz: !binary |-
-    MGFjZTBkNGUzYTEwYWFkMDY0YWVhNGIxNjc2MzhkOWUwNTg5Y2NjNmQxOTAy
-    ZjAwNTliZWJmZTU4NjU1ODg0OGExNmRkZTljMzk0OWQyZGU2ODFhOWQ3ZTUw
-    ZWQzNTRkMjY5YzM5MGYyZGViNGY4MjVhMjQwMDExYjE5MTQ3ZWY=
+    YzMwMWI3MGI2N2FiMDljMDUwM2JkNmVlNzI2ODRmOWM5NmJjYzU3NjBkMDdi
+    MTE5NDI0OGYzMzQ4MzNhNDdkOGYyZDBkYTBmOTgxNDQ2ZWU1Zjc1YmUzNDQy
+    OWU2NTJiODYzODE5NWUxODVlOTQ0MjMzZjM1ZWQ4NGE3YWJjMGE=
   data.tar.gz: !binary |-
-    OWEyOGQ2MWJiY2RiZTVhNTMxM2VhNDllM2MwNmM2ZTVjNWVhNjljMjcxZDU4
-    NWIxNTAxNzMyZDM1YWZlYjhhOWQ2Y2I0NzRmNGZmOWJlN2EzOTlhYTA5ZTk2
-    NDZlZGVhYmYyYzFkOTcwN2E0MWY4NjQ1NTEzOGZmMGE0OGE0MWM=
+    Y2UyNDhlZjFjNWQzZjNkMWMyOTVlNjljZjkzOWJhZWQ2ZDM1MmUwNTNlNTJm
+    NDY4MTBhYjVmMGJkMzAzMDU0OWE0NDMwZDA1ODc4MGFkZjNjZWQ5ZDBlOGZm
+    NTYxYjVlZGZkYTFjN2NlNTIxZGJmOGJlYjQ2NTVmNDFhNjc1MDk=

data/HISTORY.md

@@ -1,12 +1,43 @@
 # experimental_in-parallel_bump_and_tag_master - History
 ## Tags
-* [LATEST - 6 Feb, 2017 (27b497ea)](#LATEST)
+* [LATEST - 6 Feb, 2017 (8e97ff25)](#LATEST)
+* [0.1.16 - 6 Feb, 2017 (0d5030c3)](#0.1.16)
 * [0.1.15 - 3 Feb, 2017 (ff16929c)](#0.1.15)
 * [0.1.14 - 8 Aug, 2016 (ce331dbd)](#0.1.14)
 * [0.1.13 - 8 Aug, 2016 (26d19934)](#0.1.13)
 
 ## Details
-### <a name = "LATEST">LATEST - 6 Feb, 2017 (27b497ea)
+### <a name = "LATEST">LATEST - 6 Feb, 2017 (8e97ff25)
+
+* (GEM) update in-parallel version to 0.1.17 (8e97ff25)
+
+* Merge pull request #17 from nicklewis/handle-non-parallel-enumerables (dca0b0a5)
+
+
+```
+Merge pull request #17 from nicklewis/handle-non-parallel-enumerables
+
+(maint) Properly handle non-parallel enumerables
+```
+* (maint) Properly handle non-parallel enumerables (b041b864)
+
+
+```
+(maint) Properly handle non-parallel enumerables
+
+For Enumerables containing 0 or 1 items, the #each_in_parallel method
+was improperly calling the block without an argument, then calling it
+again properly but not returning the result of the block.
+
+The #each method returns the Enumerable that was it was called on,
+rather than the value of the block. This needs to be #map instead, to
+actually return an array of the one or zero values. The tests weren't
+catching this because they were effectively passing `identity` as the
+block, nullifying the distinction between #each and #map.
+```
+### <a name = "0.1.16">0.1.16 - 6 Feb, 2017 (0d5030c3)
+
+* (HISTORY) update in-parallel history for gem release 0.1.16 (0d5030c3)
 
 * (GEM) update in-parallel version to 0.1.16 (27b497ea)
 

data/lib/in-parallel/version.rb

@@ -1,3 +1,3 @@
 module InParallel
-  VERSION = '0.1.16'
+  VERSION = '0.1.17'
 end

data/lib/parallel_enumerable.rb

@@ -16,9 +16,9 @@ module Enumerable
       end
       # return the array of values, no need to look up from the map.
       return InParallel::InParallelExecutor.wait_for_processes(nil, block.binding, timeout, kill_all_on_error)
+    else
+      # If fork is not supported
+      map(&block)
     end
-    # If fork is not supported
-    block.call
-    each(&block)
   end
 end

data/spec/in-paralell_spec.rb

@@ -228,23 +228,36 @@ describe '.each_in_parallel' do
 
   it 'should return correct values' do
     start_time = Time.now
-    items      = ['foo', 'bar', 'baz', 'blah', 'foobar'].each_in_parallel do |item|
+    items      = [1,2,3,4,5].each_in_parallel do |item|
       sleep(Random.rand(1.0))
-      item
+      item * 2
     end
     # return values should be an array of the returned items in the last line of the block, in correct order
-    expect(['foo', 'bar', 'baz', 'blah', 'foobar']).to eq(items)
+    expect(items).to eq([2,4,6,8,10])
     # time should be less than combined delay in the 3 block calls
     expect(expect(Time.now - start_time).to be < 5)
   end
 
   it 'should run each iteration of a map in parallel' do
-    items = ['foo', 'bar', 'baz'].map.each_in_parallel do |item|
+    items = [1,2,3].map.each_in_parallel do |item|
       puts item
-      item
+      item * 2
     end
     # return values should be an array of the returned items in the last line of the block, in correct order
-    expect(items).to eq(['foo', 'bar', 'baz'])
+    expect(items).to eq([2,4,6])
+  end
+
+  it 'should return an empty array and do nothing with an empty enumerator' do
+    result = [].each_in_parallel do |item|
+      raise "Incorrectly called the block with an empty enumerator"
+    end
+    expect(result).to eq []
+  end
+
+  it 'should return the result of the block with only 1 item in the enumerator' do
+      expect([1].each_in_parallel do |item|
+        item * 2
+      end).to eq([2])
   end
 
   it 'should not run in parallel if there is only 1 item in the enumerator' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: in-parallel
 version: !ruby/object:Gem::Version
-  version: 0.1.16
+  version: 0.1.17
 platform: ruby
 authors:
 - samwoods1
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-06 00:00:00.000000000 Z
+date: 2017-02-07 00:00:00.000000000 Z
 dependencies: []
 description: Many other Ruby libraries that simplify parallel execution support one
   primary use case - crunching through a large queue of small, similar tasks as quickly