ims-lti 1.1.13 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 349045d52db72ab3885b106c5874f5e6c217fed2
-  data.tar.gz: 3dd49abc26a739d0c313f8bdb477317a79c2598d
+  metadata.gz: 3235b72aa7a7f01032b0e5a4e6f41291ef9fd8dc
+  data.tar.gz: 6fe9dd358c230756b798ede1317647fa0dfe5fe7
 SHA512:
-  metadata.gz: 14f47290fd89679b75b5e5b4957b08c9431e50b69632a313f89a194454b61126c8ee801b5329b246b8c64d7458698629bb289de1c66450498f20051be803506c
-  data.tar.gz: befc124ca8958e2912466f3a79dd8f20a9105cba6614a3bfe96d374d6dcffa2634493138a08727ef7ffc1d1a929624ee8d3b40e92cfe6f69b5d53f1f984172d0
+  metadata.gz: a533acf2b2051cc3ec55e9f2a1851ee008a64d2e595661f839d8e7528231d91d3e88aa4f313a1719adf9660c6a65df5515be1834cff1e2730dd0e48815f15dac
+  data.tar.gz: b6baa3a683f85d810bee49ccc79b07c9a535390e56eeec4fad4865fd35ca0f2c6c32283b159058e11c012b6f65681f359ed0cc351601850fa7ac336caed8f783

data/Changelog

@@ -1,3 +1,6 @@
+2017-03-08 Version 1.2.0
+    * Don't downcase roles
+
 2016-10-05 Version 1.1.13
     * Fix Oauth::Unauthorized initialization bug
     * Relax oauth dependency

data/README.md

@@ -52,7 +52,7 @@ and it will be signed with OAuth using a key/secret that both the TP and TC shar
 This is covered in the [LTI security model](http://www.imsglobal.org/LTI/v1p1/ltiIMGv1p1.html#_Toc319560466)
 
 Here is an example of a simple TP Sinatra app using this gem:
-[LTI Tool Provider](https://github.com/instructure/lti_tool_provider_example)
+[LTI Tool Provider](https://github.com/instructure/lti1_tool_provider_example)
 
 Once you find the `oauth_consumer_secret` based on the `oauth_consumer_key` in
 the request, you can initialize a `ToolProvider` object with them and the post parameters:

data/lib/ims/lti.rb

@@ -2,6 +2,7 @@ require 'oauth'
 require 'builder'
 require "rexml/document"
 require 'cgi'
+require 'securerandom'
 
 module IMS # :nodoc:
 
@@ -25,13 +26,16 @@ module IMS # :nodoc:
   #
   #    require 'ims/lti'
   module LTI
-    
+
     # The versions of LTI this library supports
     VERSIONS = %w{1.0 1.1}
-    
+
     class InvalidLTIConfigError < StandardError
     end
 
+    class XMLParseError < StandardError
+    end
+
     # POST a signed oauth request with the given key/secret/data
     def self.post_service_request(key, secret, url, content_type, body)
       raise IMS::LTI::InvalidLTIConfigError, "" unless key && secret

data/lib/ims/lti/deprecated_role_checks.rb

@@ -6,7 +6,7 @@ module DeprecatedRoleChecks
   # Check whether the Launch Parameters have a role
     def has_role?(role)
       role = role.downcase
-      @roles && @roles.any?{|r| r.index(role)}
+      @roles && @roles.any?{|r| r.downcase.index(role)}
     end
 
     # Convenience method for checking if the user has 'learner' or 'student' role

data/lib/ims/lti/launch_params.rb

@@ -96,7 +96,7 @@ module IMS::LTI
         if roles_list.is_a?(Array)
           @roles = roles_list
         else
-          @roles = roles_list.split(",").map(&:downcase)
+          @roles = roles_list.split(",")
         end
       else
         @roles = nil

data/lib/ims/lti/outcome_response.rb

@@ -46,7 +46,7 @@ module IMS::LTI
   #
   class OutcomeResponse
     include IMS::LTI::Extensions::Base
-    
+
     attr_accessor :request_type, :score, :message_identifier, :response_code,
             :post_response, :code_major, :severity, :description, :operation,
             :message_ref_identifier
@@ -70,7 +70,7 @@ module IMS::LTI
       response = OutcomeResponse.new
       response.process_post_response(post_response)
     end
-    
+
     def process_post_response(post_response)
       self.post_response = post_response
       self.response_code = post_response.code
@@ -105,7 +105,11 @@ module IMS::LTI
 
     # Parse Outcome Response data from XML
     def process_xml(xml)
-      doc = REXML::Document.new xml
+      begin
+        doc = REXML::Document.new xml
+      rescue => e
+        raise IMS::LTI::XMLParseError, "#{e}\nOriginal xml: '#{xml}'"
+      end
       @message_identifier = doc.text("//imsx_statusInfo/imsx_messageIdentifier").to_s
       @code_major = doc.text("//imsx_statusInfo/imsx_codeMajor")
       @code_major.downcase! if @code_major

data/lib/ims/lti/role_checks.rb

@@ -16,7 +16,7 @@ module IMS::LTI
     # Check whether the Launch Parameters have a given role
     def has_exact_role?(role)
       role = role.downcase
-      @roles && @roles.any? { |r| r == role }
+      @roles && @roles.any? { |r| r.downcase == role }
     end
 
     # Check whether the Launch Parameters have a given role ignoring
@@ -25,7 +25,7 @@ module IMS::LTI
     # will return true if the role is `urn:lti:role:ims/lis/Instructor/GuestInstructor`
     def has_base_role?(role)
       role = role.downcase
-      @roles && @roles.any? { |r| r.start_with?(role) }
+      @roles && @roles.any? { |r| r.downcase.start_with?(role) }
     end
 
     # Convenience method for checking if the user is the system administrator of the TC

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ims-lti
 version: !ruby/object:Gem::Version
-  version: 1.1.13
+  version: 1.2.0
 platform: ruby
 authors:
 - Instructure
@@ -28,22 +28,16 @@ dependencies:
   name: oauth
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
         version: 0.4.5
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '0.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
         version: 0.4.5
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -104,7 +98,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Ruby library for creating IMS LTI tool providers and consumers