impressionist 1.6.0 → 1.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2ba9ef405e0268bd6e6c4f49f5af548c64b99489
-  data.tar.gz: b23558b98793b625a57c55b14cbcded8c681f136
+  metadata.gz: ece53bd074111938c17d3cbd3b97949cdd87b94b
+  data.tar.gz: e3f6c58a7dee094cbd9f34414d455edbc64402ef
 SHA512:
-  metadata.gz: 20b79abe821d51b958b217d28b447476ccb0cf85bb7bf0edf8ede971f68981533c42469341507dd1131f5718ca7deb5239d4549ec0b372cf001605afe5ae1968
-  data.tar.gz: 2ecc6417699a4ad0059b15d685df29e9586ce8d6c5f158ccbaf770c84ceab5f06ac8bfb8b7e54ef02155f9a435e74db05e3189311cb95e335220a34cf0bfaff5
+  metadata.gz: b104697a66dc806f93d6da4666cf2fb39610f0a63641f276b7f9b2ca627d964aded1c995bc83ec0bfbae984111d60804f3bac714f2b344d1801a429c8d4170c6
+  data.tar.gz: d877a077d993b98d466b614c392325aad1123bd3894503c51ee95cb893a5b04d4303e637bc58d2189e41f42d320cf3649dffd573ff5aabf74883a6292838947e

data/CHANGELOG.rdoc

@@ -1,4 +1,11 @@
-== 1.6.0 (2016-09-16)
+== 1.6.1 (2018-04-16)
+* Add belongs_to optional true to setup_association (#264, @josephMG)
+* Add missing field for Mongoid (#254, @Fibrasek)
+* Implemented patch that will add the Rails major version to the migration file (#248, @jordanhudgens)
+* Add params filtering on new column (#246, @rposborne)
+* Add a DB migration to add params to schema. (#245, @rposborne)
+
+== 1.6.0 (2017-05-24)
 * Documentation example for counter_cache (#239, @fwolfst)
 * Green Travis CI builds (#238, @jgrau)
 * Rails 5.1 support (#241, @msimonborg)

data/README.md

@@ -247,7 +247,8 @@ Want to run the tests? Ok mummy
 Contributors
 ------------
 * [johnmcaliley - creator](https://github.com/johnmcaliley)
-* [Antonio C Nalesso - maintainer](https://github.com/acnalesso)
+* [jgrau - maintainer](https://github.com/jgrau)
+* [acnalesso](https://github.com/acnalesso)
 * [coryschires](https://github.com/coryschires)
 * [georgmittendorfer](https://github.com/georgmittendorfer)
 

data/UPGRADE_GUIDE.md

@@ -0,0 +1,13 @@
+# Upgrade guide
+
+## v1.5.1 -> v1.5.2
+
+Version 1.5.2 adds are new column to the `impressions` table. If you're on v1.5.1 you need to manually add the new column using
+
+```
+add_column :impressions, :params, :text
+
+add_index :impressions, [:impressionable_type, :impressionable_id, :params], :name => "poly_params_request_index", :unique => false
+```
+
+before upgrading.

data/app/controllers/impressionist_controller.rb

@@ -51,6 +51,7 @@ module ImpressionistController
 
     # creates a statment hash that contains default values for creating an impression via an AR relation.
     def associative_create_statement(query_params={})
+      filter = ActionDispatch::Http::ParameterFilter.new(Rails.application.config.filter_parameters)
       query_params.reverse_merge!(
         :controller_name => controller_name,
         :action_name => action_name,
@@ -59,7 +60,7 @@ module ImpressionistController
         :session_hash => session_hash,
         :ip_address => request.remote_ip,
         :referrer => request.referer,
-        :params => params_hash
+        :params => filter.filter(params_hash)
         )
     end
 

data/lib/generators/active_record/templates/create_impressions_table.rb

@@ -1,4 +1,4 @@
-class CreateImpressionsTable < ActiveRecord::Migration
+class CreateImpressionsTable < ActiveRecord::Migration<%= Rails::VERSION::MAJOR >= 5 ? "[#{Rails.version.to_f}]" : "" %>
   def self.up
     create_table :impressions, :force => true do |t|
       t.string :impressionable_type

data/lib/impressionist/models/mongoid/impression.rb

@@ -19,6 +19,7 @@ class Impression
   field :session_hash
   field :message
   field :referrer
+  field :params
 
   after_save :impressionable_counter_cache_updatable?
 

data/lib/impressionist/setup_association.rb

@@ -12,7 +12,11 @@ module Impressionist
     end
 
     def define_belongs_to
-      receiver.belongs_to(:impressionable, :polymorphic => true)
+      if ::Rails::VERSION::MAJOR.to_i >= 5
+        receiver.belongs_to(:impressionable, :polymorphic => true, :optional => true)	         
+      else
+        receiver.belongs_to(:impressionable, :polymorphic => true)
+      end
     end
 
     def set

data/lib/impressionist/version.rb

@@ -1,3 +1,3 @@
 module Impressionist
-  VERSION = "1.6.0"
+  VERSION = "1.6.1"
 end

data/tests/spec/minitest_helper.rb

@@ -1,4 +1,7 @@
 $:.unshift(File.dirname __FILE__)
 
+require 'rails/all'
+require 'rails/test_help'
 require "minitest/autorun"
 require "minitest/pride"
+require 'minitest/rails'

data/tests/test_app/spec/controllers/articles_controller_spec.rb

@@ -71,4 +71,20 @@ describe ArticlesController do
     Impression.last.session_hash.size.should eq 32
     Impression.last.referrer.should eq nil
   end
+
+  describe "when filtering params" do
+    before do
+      @_filtered_params = Rails.application.config.filter_parameters
+      Rails.application.config.filter_parameters = [:password]
+    end
+
+    it "values should not be recorded" do
+      get "index", password: "best-password-ever"
+      Impression.last.params.should eq("password" => "[FILTERED]")
+    end
+
+    after do
+      Rails.application.config.filter_parameters = @_filtered_params
+    end
+  end
 end

data/upgrade_migrations/version_1_5_2.rb

@@ -0,0 +1,12 @@
+class Version152UpdateImpressionsTable < ActiveRecord::Migration
+  def self.up
+    add_column :impressions, :params, :text
+
+    add_index :impressions, [:impressionable_type, :impressionable_id, :params], :name => "poly_params_request_index", :unique => false
+  end
+
+  def self.down
+    remove_index :impressions, [:impressionable_type, :impressionable_id, :params], :name => "poly_params_request_index"
+    remove_column :impressions, :params
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: impressionist
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.6.1
 platform: ruby
 authors:
 - johnmcaliley
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-24 00:00:00.000000000 Z
+date: 2018-04-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -52,6 +52,7 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- UPGRADE_GUIDE.md
 - app/controllers/impressionist_controller.rb
 - app/models/impression.rb
 - app/models/impressionist/bots.rb
@@ -187,6 +188,7 @@ files:
 - tests/test_app/spec/spec_helper.rb
 - upgrade_migrations/version_0_3_0.rb
 - upgrade_migrations/version_0_4_0.rb
+- upgrade_migrations/version_1_5_2.rb
 homepage: http://github.com/charlotte-ruby/impressionist
 licenses:
 - MIT
@@ -207,7 +209,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Easy way to log impressions